http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93566

Revision: 93566
Author:   kaldari
Date:     2011-07-31 02:55:59 +0000 (Sun, 31 Jul 2011)
Log Message:
-----------
fix for Bug 30139 - JS error in Chrome

Modified Paths:
--------------
    trunk/extensions/CentralNotice/special/SpecialBannerController.php

Modified: trunk/extensions/CentralNotice/special/SpecialBannerController.php
===================================================================
--- trunk/extensions/CentralNotice/special/SpecialBannerController.php  
2011-07-31 02:29:11 UTC (rev 93565)
+++ trunk/extensions/CentralNotice/special/SpecialBannerController.php  
2011-07-31 02:55:59 UTC (rev 93566)
@@ -166,7 +166,7 @@
        $script .= "\n\t\tvar url = '" . 
        Xml::escapeJsString( $wgNoticeFundraisingUrl ) . "';";
        $script .= <<<JAVASCRIPT
-               if ( bannerJson.landingPages.length ) {
+               if ( bannerJson.landingPages && bannerJson.landingPages.length 
) {
                        targets = String( bannerJson.landingPages ).split(',');
                        url += "?" + jQuery.param( {
                                'landing_page': targets[Math.floor( 
Math.random() * targets.length )].replace( /^\s+|\s+$/, '' )


_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to