http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94664
Revision: 94664
Author: demon
Date: 2011-08-16 17:30:21 +0000 (Tue, 16 Aug 2011)
Log Message:
-----------
MFT r94506
Modified Paths:
--------------
branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php
Property Changed:
----------------
branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php
Modified: branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php
===================================================================
--- branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php
2011-08-16 17:17:37 UTC (rev 94663)
+++ branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php
2011-08-16 17:30:21 UTC (rev 94664)
@@ -1241,10 +1241,11 @@
* @param string $commentId
* @return \type
*/
- public function getFullUrl( $commentId = '' ) {
+ public function getFullUrl( $commentId = 0 ) {
$title = SpecialPage::getTitleFor( 'Code',
$this->repo->getName() . '/' . $this->id );
- if ( $commentId !== '' ) {
+ # Append comment id if not null, empty string or zero
+ if ( $commentId ) {
$title->setFragment( "#c{$commentId}" );
}
Property changes on:
branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php
___________________________________________________________________
Added: svn:mergeinfo
+ /backend/CodeRevision.php:91549
/branches/REL1_15/phase3/extensions/CodeReview/backend/CodeRevision.php:51646
/branches/new-installer/phase3/extensions/CodeReview/backend/CodeRevision.php:43664-66004
/branches/sqlite/extensions/CodeReview/backend/CodeRevision.php:58211-58321
/branches/wmf/1.16wmf4/extensions/CodeReview/backend/CodeRevision.php:67177,69199,76243,77266
/branches/wmf-deployment/extensions/CodeReview/backend/CodeRevision.php:60970
/trunk/extensions/CodeReview/backend/CodeRevision.php:77974-93070,94506
/trunk/phase3/extensions/CodeReview/backend/CodeRevision.php:79828,79830,79848,79853,79950-79951,79954,79989,80006-80007,80013,80016,80080,80083,80124,80128,80238,81833,83212,83590
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
