http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99669

Revision: 99669
Author:   aaron
Date:     2011-10-13 05:38:44 +0000 (Thu, 13 Oct 2011)
Log Message:
-----------
fixed warnings for stats update (for flagged protection)

Modified Paths:
--------------
    
branches/wmf/1.18wmf1/extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php

Modified: 
branches/wmf/1.18wmf1/extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php
===================================================================
--- 
branches/wmf/1.18wmf1/extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php   
    2011-10-13 05:00:40 UTC (rev 99668)
+++ 
branches/wmf/1.18wmf1/extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php   
    2011-10-13 05:38:44 UTC (rev 99669)
@@ -197,11 +197,19 @@
        }
 
        private function getReviewTimesAnons( $dbCache ) {
+               $result = array(
+                       'average'       => 0,
+                       'median'        => 0,
+                       'percTable'     => array(),
+                       'sampleSize'    => 0,
+                       'sampleStartTS' => null,
+                       'sampleEndTS'   => null
+               );
+               if ( FlaggedRevs::useOnlyIfProtected() ) {
+                       return $result; // disabled
+               }
                $aveRT = $medianRT = 0;
                $rPerTable = array(); // review wait percentiles
-               if ( FlaggedRevs::useOnlyIfProtected() ) {
-                       return array( $aveRT, $medianRT, $rPerTable ); // 
disabled
-               }
                $nowUnix = wfTimestamp( TS_UNIX ); // current time in UNIX TS
                # Only go so far back...otherwise we will get garbage values 
due to 
                # the fact that FlaggedRevs wasn't enabled until after a while.
@@ -351,15 +359,14 @@
                                $rPerTable[$percentile] = $times[$rank];
                        }
                        #echo "(sampled ".count($times)." edits)...";
+                       $result['average']       = $aveRT;
+                       $result['median']        = $medianRT;
+                       $result['percTable']     = $rPerTable;
+                       $result['sampleSize']    = count( $times );
+                       $result['sampleStartTS'] = $minTSUnix;
+                       $result['sampleEndTS']   = $maxTSUnix;
                }
 
-               return array(
-                       'average'               => $aveRT,
-                       'median'                => $medianRT,
-                       'percTable'             => $rPerTable,
-                       'sampleSize'    => count( $times ),
-                       'sampleStartTS' => $minTSUnix,
-                       'sampleEndTS'   => $maxTSUnix
-               );
+               return $result;
        }
 }


_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to