Re: Issue 75 in memcached: Unnecessary stats locks around flushes.

2009-08-18 Thread Dustin
On Aug 18, 12:41 pm, Trond Norbye wrote: > Looks good to me Great, if both of these are looking good for you, can you cherry- pick the following: 117bf64b12fc845ff536fb4f160cdd21532a7bc1 785913b8674ccc20b62dd077060cffd2c13cdbda That's issue 71 and 75 respectively.

Re: Issue 75 in memcached: Unnecessary stats locks around flushes.

2009-08-18 Thread Trond Norbye
Looks good to me Cheers, Trond On 18. aug.. 2009, at 12.02, Dustin wrote: On Aug 18, 11:35 am, Trond Norbye wrote: You should lock the thread-local stat instead. Look at get/set etc.. Ah, of course. How's this? (currently my issue_75 branch on top of issue_71) commit 785913b8674ccc2

Re: Issue 75 in memcached: Unnecessary stats locks around flushes.

2009-08-18 Thread Dustin
On Aug 18, 11:35 am, Trond Norbye wrote: > You should lock the thread-local stat instead. Look at get/set etc.. Ah, of course. How's this? (currently my issue_75 branch on top of issue_71) commit 785913b8674ccc20b62dd077060cffd2c13cdbda Author: Dustin Sallings Date: Tue Aug 18 10:52:29 20

Re: Issue 75 in memcached: Unnecessary stats locks around flushes.

2009-08-18 Thread Trond Norbye
On 18. aug.. 2009, at 10.52, codesite-nore...@google.com wrote: Status: New Owner: dsallings Labels: Type-Defect Priority-Medium New issue 75 by dsallings: Unnecessary stats locks around flushes. http://code.google.com/p/memcached/issues/detail?id=75 Since stats are thread-local, there shou

Issue 75 in memcached: Unnecessary stats locks around flushes.

2009-08-18 Thread codesite-noreply
Updates: Status: Started Cc: trond.norbye dormando Comment #2 on issue 75 by dsallings: Unnecessary stats locks around flushes. http://code.google.com/p/memcached/issues/detail?id=75 Can someone take a look at this and tell me if I'm doing this wrong? -- You received this messa

Issue 74 in memcached: configure script incorrectly identifies sparc v9 as little endian, selecting incorrect hash function.

2009-08-18 Thread codesite-noreply
Updates: Status: Started Comment #1 on issue 74 by dsallings: configure script incorrectly identifies sparc v9 as little endian, selecting incorrect hash function. http://code.google.com/p/memcached/issues/detail?id=74 I've written a test for this bug against 1.4.0+ and I'm not findi

Issue 75 in memcached: Unnecessary stats locks around flushes.

2009-08-18 Thread codesite-noreply
Updates: Labels: -Priority-Medium Priority-Low Comment #1 on issue 75 by dsallings: Unnecessary stats locks around flushes. http://code.google.com/p/memcached/issues/detail?id=75 (No comment was entered for this change.) -- You received this message because you are listed in the owner

Issue 75 in memcached: Unnecessary stats locks around flushes.

2009-08-18 Thread codesite-noreply
Status: New Owner: dsallings Labels: Type-Defect Priority-Medium New issue 75 by dsallings: Unnecessary stats locks around flushes. http://code.google.com/p/memcached/issues/detail?id=75 Since stats are thread-local, there should be no reason to lock them. I've got a patch that updates them in

Issue 71 in memcached: Statistics not updated when flush is issued in binary mode

2009-08-18 Thread codesite-noreply
Updates: Status: Started Comment #1 on issue 71 by dsallings: Statistics not updated when flush is issued in binary mode http://code.google.com/p/memcached/issues/detail?id=71 I've got a fix for this in my issue_71 branch. -- You received this message because you are listed in the o

Re: Catch at least 1 connect error

2009-08-18 Thread johnny
>> This is nothing to do with memcache, but your PHP configuration. Ok, thanks. It got to be this. P.S. I'm sorry to post twice, yesterday I felt like this forum (I just found out it) was not working in updates.