Re: Question on item_chunk

2016-10-03 Thread dormando
> > > > I'll need to check more carefully. If that's true, the tests should show > data corruption (and they did a few times during development). Take a look > at the tests for the chunked item support? > > IE: If I allocate a new page to a slab class, the sequential bytes get > chopped up into a

Re: Question on item_chunk

2016-10-03 Thread yuantao peng
On Monday, October 3, 2016 at 9:17:00 PM UTC-4, Dormando wrote: > > > > On Mon, 3 Oct 2016, yuantao peng wrote: > > > Hi, --I am reading memcached source code and got a question on this > function: do_slabs_alloc_chunked, it is called by do_slabs_alloc if the > request size is larger

Re: Question on item_chunk

2016-10-03 Thread dormando
On Mon, 3 Oct 2016, yuantao peng wrote: > Hi,  --    I am reading memcached source code and got a question on this > function:  do_slabs_alloc_chunked,   it is called by do_slabs_alloc if the > request size is larger than > the slabclass size.  I am curious why we don't just move to a

Question on item_chunk

2016-10-03 Thread yuantao peng
Hi, -- I am reading memcached source code and got a question on this function: do_slabs_alloc_chunked, it is called by do_slabs_alloc if the request size is larger than the slabclass size. I am curious why we don't just move to a slabclass with larger size instead? Also, I am not sure