Re: Alternate hashing algorithm for higher performance?

2019-03-17 Thread dormando
Sounds good! fwiw binprot simply lacks a method for batching responses. I'll be fixing it this year but that's going to be a big refactor of the old frontend code. There's some use to it but there should be an option for batching anyway. VM's fine. I do most of my quick tests on a NUC, which is

Re: Alternate hashing algorithm for higher performance?

2019-03-17 Thread 'Eamonn Nugent' via memcached
Hi, I've been meaning to get myself dedicated test environments at one point, for my own stuff as well. Guess now is as good a time as any to try it out. I'll start using mc-crusher for benchmarks, and I'm going to throw it on at least a VM for now, run some long-term benchmarks, and likely try

Re: Alternate hashing algorithm for higher performance?

2019-03-17 Thread dormando
Yo, Fwiw, I use mc-crusher as the "official" benchmark: https://github.com/memcached/mc-crusher tho I need to update the README slightly. will do that in a bit. I also test on hardware uninterrupted by other things with turbo disabled :) testing on laptops can be really tough since you'll get

Re: Alternate hashing algorithm for higher performance?

2019-03-17 Thread 'Eamonn Nugent' via memcached
Reporting back with very preliminary benchmarks. Somehow, xxh64 is actually faster than xxh3 on my machine. One thing I forgot to mention before - I also looked at latencies with xxh32/64, and saw the 99th percentile latency lowered by about half compared to mmh3. So it could be beneficial in that

Re: Alternate hashing algorithm for higher performance?

2019-03-17 Thread 'Eamonn Nugent' via memcached
Hiya, Last night, I was running memtier_benchmark on my laptop (mid-2015 15" MBP, 2.5GHz 4c i7) and achieved about a 10-15% throughput improvement on both modern and non-modern settings on the 64 bit variant. 32 bit variant was about equal in performance (the results showed them to be within

Re: Alternate hashing algorithm for higher performance?

2019-03-17 Thread dormando
Hey, What exact test did you do? Well to be honest I've been wanting to swap in xxhash for a long time, but in my own profiling other things show up higher than murmur so I keep deprioritizing it :) One big problem with the hash algo is mc keys can be short and are hashed one at a time. xxhash