Re: [PATCH 2/2] Add a helper routine assoc_find_item() instead of repetitive code.

2017-12-29 Thread Manish Katiyar
Hi, Sorry for the late reply. I have opened a pull request on github. Thanks - Manish Thanks - Manish On Sat, Oct 14, 2017 at 3:56 PM, dormando wrote: > Hey, > > Any chance you could open your patches as PR's on github? It's a bit > easier for me to track there. I forgot to dig them out of my

Re: [PATCH 2/2] Add a helper routine assoc_find_item() instead of repetitive code.

2017-10-14 Thread dormando
Hey, Any chance you could open your patches as PR's on github? It's a bit easier for me to track there. I forgot to dig them out of my mailbox during the last few releases, sorry :( On Sat, 14 Oct 2017, Manish Katiyar wrote: > Hi, > Just curious if this patch is still under consideration. > > Th

Re: [PATCH 2/2] Add a helper routine assoc_find_item() instead of repetitive code.

2017-10-14 Thread Manish Katiyar
Hi, Just curious if this patch is still under consideration. Thanks - Manish On May 11, 2017 9:30 PM, "Manish Katiyar" wrote: > > > On May 11, 2017 7:27 PM, "dormando" wrote: > > They are, I'm just a bit slow, sorry! > > It's also easier to track as a PR on github, but this is fine. > > RE: y

Re: [PATCH 2/2] Add a helper routine assoc_find_item() instead of repetitive code.

2017-05-11 Thread Manish Katiyar
On May 11, 2017 7:27 PM, "dormando" wrote: They are, I'm just a bit slow, sorry! It's also easier to track as a PR on github, but this is fine. RE: you first patch (no objections), but since this one is in the core assoc code, I'd have to benchmark it to ensure no regression from adding the ext

Re: [PATCH 2/2] Add a helper routine assoc_find_item() instead of repetitive code.

2017-05-11 Thread dormando
They are, I'm just a bit slow, sorry! It's also easier to track as a PR on github, but this is fine. RE: you first patch (no objections), but since this one is in the core assoc code, I'd have to benchmark it to ensure no regression from adding the extra function calls. On Thu, 11 May 2017, Mani

Re: [PATCH 2/2] Add a helper routine assoc_find_item() instead of repetitive code.

2017-05-11 Thread Manish Katiyar
Hi, Are such trivial patches entertained ? On May 9, 2017 12:45 AM, "Manish Katiyar" wrote: > Signed-off-by: Manish Katiyar > --- > assoc.c | 42 +- > 1 file changed, 17 insertions(+), 25 deletions(-) > > diff --git a/assoc.c b/assoc.c > index 792c07a..

[PATCH 2/2] Add a helper routine assoc_find_item() instead of repetitive code.

2017-05-09 Thread Manish Katiyar
Signed-off-by: Manish Katiyar --- assoc.c | 42 +- 1 file changed, 17 insertions(+), 25 deletions(-) diff --git a/assoc.c b/assoc.c index 792c07a..e1bfa57 100644 --- a/assoc.c +++ b/assoc.c @@ -75,19 +75,26 @@ void assoc_init(const int hashtable_init) {