Re: news from the topic experiment

2016-10-12 Thread Erik van Zijst
Working on our Bitbucket spike I wondered if topics could perhaps benefit from a small simplification. Instead of adding the topic name as an additional field, what if we defined a topic commit by merely adding a boolean property to the meta dict; e.g. `is_topic: True`? Named branches would not

Re: [PATCH V2] py3: a second argument to open can't be bytes

2016-10-12 Thread Pierre-Yves David
On 10/13/2016 12:43 AM, Pierre-Yves David wrote: On 10/12/2016 11:23 PM, Martijn Pieters wrote: On 12 Oct 2016, at 14:00, Yuya Nishihara > wrote: FWIW, the current transformer will also rewrite open(f('foo')). This then also applies to

[PATCH 2 of 3 v2] tests: add more test coverage of phase changes when pushing

2016-10-12 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich # Date 1471734720 -7200 # Sun Aug 21 01:12:00 2016 +0200 # Node ID 6affe6ed5cc5b945961fb8f1fe2dc18e711089c2 # Parent 8db96226f748ff80003c0964bc4ece3b6c3e6d12 tests: add more test coverage of phase changes when pushing Prepare

[PATCH 1 of 3 v2] cmdutil: satisfy expections in dirstateguard.__del__, even if __init__ fails

2016-10-12 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich # Date 1476317981 -7200 # Thu Oct 13 02:19:41 2016 +0200 # Node ID 8db96226f748ff80003c0964bc4ece3b6c3e6d12 # Parent b85fa6bf298be07804a74d8fdec0d19fdbc6d740 cmdutil: satisfy expections in dirstateguard.__del__, even if __init__

[PATCH 3 of 3 v2] repos: introduce '-R readonly:PATH' for doing local operations "read only"

2016-10-12 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich # Date 1476319116 -7200 # Thu Oct 13 02:38:36 2016 +0200 # Node ID bc711933bb8cfacfe87d83fe945cf566d79439d8 # Parent 6affe6ed5cc5b945961fb8f1fe2dc18e711089c2 repos: introduce '-R readonly:PATH' for doing local operations "read

Re: [PATCH 2 of 7] copies: update _checkcopies to work in a rotated DAG

2016-10-12 Thread Pierre-Yves David
On 10/07/2016 05:41 PM, timeless wrote: Gábor Stefanik wrote: copies: update _checkcopies to work in a rotated DAG I'd argue this should be tagged (BC). I absolutely support this change, it should be changed, it is a bug. But the reason I'd argue that it's a change is that a repository

Re: [PATCH V2] py3: a second argument to open can't be bytes

2016-10-12 Thread Pierre-Yves David
On 10/12/2016 11:23 PM, Martijn Pieters wrote: On 12 Oct 2016, at 14:00, Yuya Nishihara > wrote: FWIW, the current transformer will also rewrite open(f('foo')). This then also applies to getattr(f('foo'), ...). We'll need to assert that the 3rd token is

Re: [PATCH V2] py3: a second argument to open can't be bytes

2016-10-12 Thread Martijn Pieters
On 12 Oct 2016, at 14:00, Yuya Nishihara wrote: > FWIW, the current transformer will also rewrite open(f('foo')). This then also applies to getattr(f('foo'), ...). We'll need to assert that the 3rd token is a comma, I think. signature.asc Description: Message signed with

Re: [PATCH 07 of 11 py3] dispatch: translate argv back to bytes on Python 3

2016-10-12 Thread Yuya Nishihara
On Tue, 11 Oct 2016 11:58:54 -0400, Augie Fackler wrote: > > On Oct 11, 2016, at 11:20 AM, Yuya Nishihara wrote: > > On Sun, 09 Oct 2016 10:16:49 -0400, Augie Fackler wrote: > >> # HG changeset patch > >> # User Augie Fackler > >> # Date 1476018603 14400 > >> #

Re: [PATCH 1 of 7] copies: don't record divergence for files needing no merge

2016-10-12 Thread Pierre-Yves David
On 10/08/2016 06:31 PM, Pierre-Yves David wrote: On 10/07/2016 02:31 PM, Gábor Stefanik wrote: # HG changeset patch # User Gábor Stefanik # Date 1475494199 -7200 # Mon Oct 03 13:29:59 2016 +0200 # Node ID 5b7cd65a9be6c82b3ad14096b41db44c198a6769 # Parent

Re: [PATCH] checkcopies: extract the '_related' closure

2016-10-12 Thread Yuya Nishihara
On Tue, 11 Oct 2016 02:20:46 +0200, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1476142148 -7200 > # Tue Oct 11 01:29:08 2016 +0200 > # Node ID 335c2c5695971db93149eb02d03835c0fca6faf8 > # Parent

Re: [PATCH 1 of 3] checkcopies: rename 'ca' to 'base'

2016-10-12 Thread Yuya Nishihara
On Sun, 09 Oct 2016 16:18:46 +0200, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1475944722 -7200 > # Sat Oct 08 18:38:42 2016 +0200 > # Node ID c06cb63082bf571fb6fc24bac2e23feefe00 > # Parent

Re: [PATCH V2] py3: a second argument to open can't be bytes

2016-10-12 Thread Yuya Nishihara
On Tue, 11 Oct 2016 18:19:23 +0100, Martijn Pieters wrote: > On 11 October 2016 at 17:50, Pierre-Yves David < > pierre-yves.da...@ens-lyon.org> wrote: > > > I'm trying to double review this (to have it move from hg-commited to > > public phase) and this is a bit too obscure for me (I assume

[PATCH 2 of 3] merge: only show "cannot merge flags for %s" warning if flags are different

2016-10-12 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich # Date 1476267738 -7200 # Wed Oct 12 12:22:18 2016 +0200 # Node ID 29bd20c4999865fc19ca3f0344c2c1231a318b1c # Parent bc7af83150d0137d35d2cd9bf715fc0e3658cf8a merge: only show "cannot merge flags for %s" warning if flags are

[PATCH 1 of 3] tests: add test coverage of merging x flag without ancestor

2016-10-12 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich # Date 1476267738 -7200 # Wed Oct 12 12:22:18 2016 +0200 # Node ID bc7af83150d0137d35d2cd9bf715fc0e3658cf8a # Parent b85fa6bf298be07804a74d8fdec0d19fdbc6d740 tests: add test coverage of merging x flag without ancestor It is

[PATCH 3 of 3] merge: clarify warning for (not) merging flags without ancestor

2016-10-12 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich # Date 1476267738 -7200 # Wed Oct 12 12:22:18 2016 +0200 # Node ID 9588752fc3a6d2b5b1f40ddfc48965997270892d # Parent 29bd20c4999865fc19ca3f0344c2c1231a318b1c merge: clarify warning for (not) merging flags without ancestor Give

[PATCH RFC] commands: introduce `hg display`

2016-10-12 Thread Gregory Szorc
# HG changeset patch # User Gregory Szorc # Date 1476260708 -7200 # Wed Oct 12 10:25:08 2016 +0200 # Node ID 5e9412f7dbc979f9b0f7c7a7e31c1315631d61da # Parent 30b9f29d5ec393e36d03f762faa323ba4cff7f68 commands: introduce `hg display` THIS PATCH IS CURRENTLY A WORK