Re: [PATCH 3 of 8 V2] internals: document compression negotiation

2016-12-28 Thread Sean Farley
Augie Fackler writes: >> On Dec 24, 2016, at 1:34 PM, Gregory Szorc wrote: >> >> Where do we stand with this series? I was waiting for feedback, but none >> arrived. > > I believe I had asked that others look at it, and hearing nothing, we should > conclude nobody else cares and move on and q

Re: [PATCH 3 of 3 website] donate: new page to route donations to conservancy

2016-12-28 Thread Sean Farley
David Soria Parra writes: > On Fri, Dec 23, 2016 at 11:08:12AM -0500, Augie Fackler wrote: >> # HG changeset patch >> # User Augie Fackler >> # Date 1482509162 18000 >> # Fri Dec 23 11:06:02 2016 -0500 >> # Node ID f48d84ce78aed4a3d063b08da0f7178028192501 >> # Parent 4d7de32b44efc1a385466e

Re: chg pager refactoring

2016-12-28 Thread Augie Fackler
On Tue, Dec 27, 2016 at 09:07:58PM +0900, Yuya Nishihara wrote: > On Mon, 26 Dec 2016 14:10:05 +, Jun Wu wrote: > > The goal is to move "pager" logic inside "runcommand" (both client and > > server side) and remove the "getpager" API. And I'd like to discuss some > > implementation details befo

Re: [PATCH 03 of 10] context: don't use mutable default argument value

2016-12-28 Thread Augie Fackler
On Tue, Dec 27, 2016 at 11:03:03AM +0100, Pierre-Yves David wrote: > > > On 12/27/2016 01:03 AM, Gregory Szorc wrote: > > # HG changeset patch > > # User Gregory Szorc > > # Date 1482796356 25200 > > # Mon Dec 26 16:52:36 2016 -0700 > > # Node ID 10645505563a162bb6d91a90e8b3ded769dcdbb1 > > #

Re: [PATCH 1 of 7] py3: have bytes version of os.getenv

2016-12-28 Thread Augie Fackler
> On Dec 28, 2016, at 4:54 PM, Pierre-Yves David > wrote: > > > > On 12/25/2016 09:01 AM, Yuya Nishihara wrote: >> On Thu, 22 Dec 2016 03:33:46 +0530, Pulkit Goyal wrote: >>> # HG changeset patch >>> # User Pulkit Goyal <7895pul...@gmail.com> >>> # Date 1482095138 -19800 >>> # Mon Dec 19

[PATCH] hgweb: link to raw-file on annotation page (BC)

2016-12-28 Thread Gregory Szorc
# HG changeset patch # User Gregory Szorc # Date 1482965297 25200 # Wed Dec 28 15:48:17 2016 -0700 # Node ID 4a560014d6d64edcefb1d431e882824771c5ae15 # Parent dc5b594f41e9be5820ce3f197d3817379b2d3af5 hgweb: link to raw-file on annotation page (BC) Every other template has the "raw" link loa

Re: [PATCH 3 of 3 V2] revset: add a changes(file, fromline, toline[, rev]) revset

2016-12-28 Thread Denis Laxalde
FUJIWARA Katsunori a écrit : At Mon, 26 Dec 2016 22:47:14 +0900, Yuya Nishihara wrote: On Sun, 25 Dec 2016 18:06:58 -0500, Augie Fackler wrote: On Dec 25, 2016, at 4:44 AM, Yuya Nishihara wrote: On Sat, 24 Dec 2016 14:56:51 -0500, Augie Fackler wrote: On Fri, Dec 16, 2016 at 02:30:15PM +0100

Re: [PATCH 1 of 7] py3: have bytes version of os.getenv

2016-12-28 Thread Pierre-Yves David
On 12/25/2016 09:01 AM, Yuya Nishihara wrote: On Thu, 22 Dec 2016 03:33:46 +0530, Pulkit Goyal wrote: # HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1482095138 -19800 # Mon Dec 19 02:35:38 2016 +0530 # Node ID eee84d7c0647a50d4e9828b324e1e37214abd169 # Parent e995

Re: [PATCH 3 of 3 V2] revset: add a changes(file, fromline, toline[, rev]) revset

2016-12-28 Thread Danek Duvall
Denis Laxalde wrote: > # HG changeset patch > # User Denis Laxalde > # Date 1480086890 -3600 > # Fri Nov 25 16:14:50 2016 +0100 > # Node ID 5e5ec2ade2cfc829cffba145193da5801c5b20e7 > # Parent c8dfd10c5865cfe882a00595743f3f709f41317f > # EXP-Topic linerange-log/revset > revset: add a changes

Re: [PATCH 01 of 10] check-code: add AST check for mutable default argument values

2016-12-28 Thread Augie Fackler
> On Dec 27, 2016, at 4:57 AM, Pierre-Yves David > wrote: > >> This patch introduces a check-code check for the sanity of >> default argument values. It does so by parsing and walking the >> AST. Previously, all check-code checks were implemented as >> regular expressions. I probably could have

Re: [PATCH 01 of 10] check-code: add AST check for mutable default argument values

2016-12-28 Thread Augie Fackler
> On Dec 28, 2016, at 7:37 AM, Jun Wu wrote: > > With this change, > > - Code becomes longer (if None is tested explicitly) Yep. > - Slower, extra tests and GCs (especially in a tight loop) Py_None will at worst get decref'd. It’s a singleton, so there won’t be any extra GC’ing. `is` chec

Re: Constant naming convention

2016-12-28 Thread Augie Fackler
> On Dec 28, 2016, at 11:17 AM, Pierre-Yves David > wrote: > >> The sum of those things is that I’d prefer, in new code, to violate the >> oral-history-only (that is, not codified in a check-code rule or other >> formal coding style declaration) convention whereby constants are >> indistingu

Re: Constant naming convention

2016-12-28 Thread Augie Fackler
> On Dec 28, 2016, at 11:17 AM, Pierre-Yves David > wrote: > >> Possible steps forward: we agree to discuss this at the sprint (so probably >> March), knowing that I'll probably want to go and do invasive cleanup of >> constants in network-related code at that time, or we actually discuss >>

Re: [PATCH 1 of 5 flagprocessor v6] documentation: better censor flag documentation

2016-12-28 Thread Augie Fackler
(bcc adgar in case he can provide insight, but I don’t know if he remembers or if he’s on vacation this/next week at all) > On Dec 28, 2016, at 11:20 AM, Pierre-Yves David > wrote: > diff --git a/mercurial/help/internals/revlogs.txt b/mercurial/help/internals/revlogs.txt --- a/

Re: [PATCH 1 of 5 flagprocessor v6] documentation: better censor flag documentation

2016-12-28 Thread Pierre-Yves David
On 12/24/2016 08:48 PM, Augie Fackler wrote: On Sat, Dec 24, 2016 at 07:30:57PM +0100, Pierre-Yves David wrote: On 12/24/2016 05:36 PM, Remi Chaintron wrote: # HG changeset patch # User Remi Chaintron # Date 1482451718 18000 # Thu Dec 22 19:08:38 2016 -0500 # Node ID c1bd9b7750cdfe1f2

Re: Constant naming convention

2016-12-28 Thread Pierre-Yves David
On 12/15/2016 11:38 PM, Augie Fackler wrote: (I’m trying to be brief here - hopefully it doesn’t come across as upset, because I’m not - mostly I was blindsided by a policy claim that I don’t remember.) On Dec 15, 2016, at 3:40 PM, Pierre-Yves David wrote: So, to sum up, my stance is "Le

Re: [PATCH 01 of 10] check-code: add AST check for mutable default argument values

2016-12-28 Thread Jun Wu
With this change, - Code becomes longer (if None is tested explicitly) - Slower, extra tests and GCs (especially in a tight loop) - "None" passed explicitly is ignored I'm aware that some other checkers do the same check but it does not look the best way to avoid these kinds of errors due t