D242: context: rename troubled into isunstable

lothiraldan updated this revision to Diff 665. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D242?vs=626&id=665 REVISION DETAIL https://phab.mercurial-scm.org/D242 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py mercurial/context.py me

D238: context: rename troubles into instabilities

lothiraldan updated this revision to Diff 664. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D238?vs=583&id=664 REVISION DETAIL https://phab.mercurial-scm.org/D238 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py mercurial/context.py me

D237: template: rename troubles templatekw into instabilities

lothiraldan updated this revision to Diff 663. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D237?vs=653&id=663 REVISION DETAIL https://phab.mercurial-scm.org/D237 AFFECTED FILES mercurial/templatekw.py mercurial/templates/map-cmdline.default test

New Phabricator dashboard designed for reviewers is available

Hi, I have been working on a new dashboard for Phabricator to optimize reviewer experience (Thanks for Augie's feedback! [1]). It's now available at: https://phab.mercurial-scm.org/yadda/ The interface is inspired by gmail. Pressing "?" to list keyboard shortcuts. It mainly tracks "unread" sta

D278: tests: make test-highlight code portable to python3

quark accepted this revision. quark added a comment. LGTM. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D278 To: durin42, #hg-reviewers, quark Cc: quark, mercurial-devel ___ Mercurial-devel mailing list Mercurial-deve

D292: repair: move manifest strip to a separate function

durham created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This moves manifest stripping to a separate function so implementations of the manifest that don't support stripping can replace this function with a no-op. I

D291: repair: refactor broken linkrev collection

durham created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This refactors broken linkrev collection such that manifest collection is in a separate function. This allows extensions to replace the manifest collection with a

D290: bundlerepo: move bundle2 part handling out to a function

durham created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This moves the bundle2 part handling for bundlerepo out to a separate function so extensions can participate in bundlerepo setup when using bundle2 bundles. REPOSI

D289: bundle2: seek part back during iteration

durham created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, iterparts would yield the part to users, then consume the part. This changed the part after the user was given it and left it at the end, both of whi

D288: bundlerepo: move temp bundle creation to a separate function

durham created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A future patch will refactor certain parts of bundlerepo initiatlization such that we need to create temp bundles from another function. Let's move this to anothe

D237: template: rename troubles templatekw into instabilities

This revision was automatically updated to reflect the committed changes. Closed by commit rHG511d6ae462f3: template: rename troubles templatekw into instabilities (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D237?vs=582&id=653

D262: test-rebase: add a brute force test

This revision was automatically updated to reflect the committed changes. Closed by commit rHG71b77b61ed60: test-rebase: add a brute force test (authored by quark). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D262?vs=607&id=652 REVISION DETAIL https:/

D269: dirstate: simplify and speed up dirstate's __iter__

This revision was automatically updated to reflect the committed changes. Closed by commit rHG36d216dcae6a: dirstate: simplify dirstate's __iter__ (authored by alex_gaynor). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D269?vs=634&id=651 REVISION DETAIL

D278: tests: make test-highlight code portable to python3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is easier than trying to do some sort of check-code shenanigans. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D278 AFFECTED FI

D279: tests: fix test-notify.t to use $PYTHON

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In doing so, I consolidated the filtering logic. This resulted in some small test output changes, but I think the consistency throughout the test is worth it. R

D271: obsolete: use bytestr() instead of str() so the node is bytes on py3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not sure this is right, since this should either be bytes or str to match what's going on in the revlog layer. REPOSITORY rHG Mercurial REVISION DETAIL h

D277: dagparser: make print statement in doctest Py3 portable

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D277 AFFECTED FILES mercurial/dagparser.py CHANGE DETAILS diff --git a/mercurial/dagparser.py b/mercur

D276: i18n: fix check-translation.py to be less broken on Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These are all simple one-argument print statements, so this syntax works the same way in 2 and 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercu

D274: obsutil: defend against succsmarkers() returning None

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not sure if this is a realistic problem, but doing this avoids some pretty awful test failures on Python 3, and it looks like it should be harmless. REPOSIT

D275: ui: refactor extractchoices so it doesn't break on Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D275 AFFECTED FILES mercurial/ui.py CHANGE DETAILS diff --git a/mercurial/ui.py b/mercurial/ui.py ---

D272: bundle2: convert ints to strings using pycompat.bytestring()

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Fixes some Python 3 regressions. We don't use %d here because the part id is actually an Optional[int]. It should always be initialized to a non-None value by

D270: tests: fix up test-run-tests failures on Python 3.6

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Some of the recent work on run-tests.py didn't work on Python 3. This fixes the regressions. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-

D273: changegroup: more **kwargs

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D273 AFFECTED FILES mercurial/changegroup.py CHANGE DETAILS diff --git a/mercurial/changegroup.py b/me

D269: dirstate: simplify and speed up dirstate's __iter__

alex_gaynor created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH simplify-iter (bookmark) on default (branch) REVISION DETAIL https://phab.mercurial-scm.org/D269 AFFECTED FILES mercurial/dirstate.py CH

D152: repo: skip invalidation of changelog if it has 'delayed' changes (API)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG01a1c4e66816: repo: skip invalidation of changelog if it has 'delayed' changes (API) (authored by martinvonz). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D152?

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

durin42 accepted this revision as: durin42. durin42 added a comment. I'm still a tiny bit worried about potential confusion between --terse and --verbose (in that they're not opposites), but I'm also fine with this. I'll take it in a couple of days if I don't hear any objections. REPOSITORY

Re: [PATCH 4 of 8] template: add minimal obsfate template function

On Wed, 2017-08-09 at 00:19 +0900, Yuya Nishihara wrote: > On Mon, 07 Aug 2017 16:56:23 +0200, Boris Feld wrote: > > # HG changeset patch > > # User Boris Feld > > # Date 1501850856 -7200 > > #  Fri Aug 04 14:47:36 2017 +0200 > > # Node ID a96edc5bcdc8790719e003eefff91a4f656cc559 > > # Parent 

Mercurial 4.4 sprint: September 29-October 1 at Facebook Dublin

Hi everyone, I'm happy to announce that the Mercurial 4.4 sprint will be held from September 29-October 1, 2017, at Facebook Dublin in Ireland. For more details and to mark your attendance and suggest topics, please see https://www.mercurial-scm.org/wiki/4.4sprint. Thanks, Siddharth __

D245: obsstore: rename precursors into predecessors

lothiraldan added inline comments. INLINE COMMENTS > dsp wrote in obsutil.py:210 > should this be called `predecessormarkers`? Ideally yes. I wanted to limit this series to external impacting changes only (either output or API changes) so extensions and tests could be updated once and for all.

D245: obsstore: rename precursors into predecessors

dsp added inline comments. INLINE COMMENTS > obsutil.py:210 > nm = unfi.changelog.nodemap > -precursorsmarkers = unfi.obsstore.precursors > +precursorsmarkers = unfi.obsstore.predecessors > successormarkers = unfi.obsstore.successors should this be called `predecessormarkers`?

Re: [PATCH 4 of 8] template: add minimal obsfate template function

On Mon, 07 Aug 2017 16:56:23 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1501850856 -7200 > # Fri Aug 04 14:47:36 2017 +0200 > # Node ID a96edc5bcdc8790719e003eefff91a4f656cc559 > # Parent e3f0339b83553039dcd87b62dc1dfbdf98548792 > # EXP-Topic obsfatetemplate

D238: context: rename troubles into instabilities

durin42 added inline comments. INLINE COMMENTS > lothiraldan wrote in exchange.py:694 > I think it was easier to display a message when considering a single trouble. > We could do better, but I'm not sure how displaying all troubles would > interact with translation. Let's add a TODO about thi

D264: exchange: drop support for lock-based unbundling (BC)

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfda0867cfe03: exchange: drop support for lock-based unbundling (BC) (authored by indygreg). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D264?vs=614&id=628 REVI

D266: localrepo: remove unused requirements attributes on localpeer (API)

This revision was automatically updated to reflect the committed changes. Closed by commit rHGda3087b8f4a2: localrepo: remove unused requirements attributes on localpeer (API) (authored by indygreg). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D266?vs=61

D265: exchange: access requirements on repo instead of peer

This revision was automatically updated to reflect the committed changes. Closed by commit rHG033484935391: exchange: access requirements on repo instead of peer (authored by indygreg). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D265?vs=615&id=629 REVI

D268: httppeer: make several instance attributes internal (API)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG73fd395ee29e: httppeer: make several instance attributes internal (API) (authored by indygreg). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D268?vs=618&id=632

D267: httppeer: remove unused handler attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc0b317cfecc8: httppeer: remove unused handler attribute (authored by indygreg). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D267?vs=617&id=631 REVISION DETAIL

D231: httppeer: add support for httppostargs when we're sending a file

durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in httppeer.py:96 > It doesn't matter much since it's just a programming error if it happens, but > how will these arguments to ValueError be rendered? ValueError: ('_multifile only supports file objects that have a length but th

D231: httppeer: add support for httppostargs when we're sending a file

durin42 updated this revision to Diff 627. durin42 marked 3 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D231?vs=559&id=627 REVISION DETAIL https://phab.mercurial-scm.org/D231 AFFECTED FILES mercurial/hgweb/protocol.py merc

[PATCH 6 of 6] encoding: drop circular import by proxying through '.charencode'

# HG changeset patch # User Yuya Nishihara # Date 1501510427 -32400 # Mon Jul 31 23:13:47 2017 +0900 # Node ID 0299b63e488b11ff46208b7bb7fd1efe3a797a37 # Parent 6713774405f9b183f5500f65901f1dadbbd4639a encoding: drop circular import by proxying through '.charencode' I decided not to split c

[PATCH 1 of 6] cext: move _dict_new_presized() to header

# HG changeset patch # User Yuya Nishihara # Date 1501506744 -32400 # Mon Jul 31 22:12:24 2017 +0900 # Node ID 9079b0e5c83687ce5c918fc1364a190033408ea5 # Parent 970967e0a917d73ae76870c1533b8a32bdbf7285 cext: move _dict_new_presized() to header Prepares for splitting encoding functions from

[PATCH 4 of 6] cext: modernize charencode.c to use Py_ssize_t

# HG changeset patch # User Yuya Nishihara # Date 1501509486 -32400 # Mon Jul 31 22:58:06 2017 +0900 # Node ID 9a77fc7505ac35764963080f38266b9e5cab0934 # Parent bc781471fcea7c9f2e5dc9db0b6696ad31c681cc cext: modernize charencode.c to use Py_ssize_t diff --git a/mercurial/cext/charencode.c b

[PATCH 5 of 6] policy: reroute proxy modules internally

# HG changeset patch # User Yuya Nishihara # Date 1501512036 -32400 # Mon Jul 31 23:40:36 2017 +0900 # Node ID 6713774405f9b183f5500f65901f1dadbbd4639a # Parent 9a77fc7505ac35764963080f38266b9e5cab0934 policy: reroute proxy modules internally This allows us to split encoding functions from

[PATCH 3 of 6] cext: factor out header for charencode.c

# HG changeset patch # User Yuya Nishihara # Date 1495344202 -32400 # Sun May 21 14:23:22 2017 +0900 # Node ID bc781471fcea7c9f2e5dc9db0b6696ad31c681cc # Parent ef7755af442bdbbbe95c0d75e9375ab17cdb970f cext: factor out header for charencode.c This merges a part of util.h with the header whi

[PATCH 2 of 6] cext: split character encoding functions to new compilation unit

# HG changeset patch # User Yuya Nishihara # Date 1501507707 -32400 # Mon Jul 31 22:28:27 2017 +0900 # Node ID ef7755af442bdbbbe95c0d75e9375ab17cdb970f # Parent 9079b0e5c83687ce5c918fc1364a190033408ea5 cext: split character encoding functions to new compilation unit This extracts charencode

D242: context: rename troubled into isunstable

lothiraldan updated this revision to Diff 626. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D242?vs=587&id=626 REVISION DETAIL https://phab.mercurial-scm.org/D242 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py mercurial/context.py me

D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5544af862286: chg: define _GNU_SOURCE to allow CentOS 5 compilation (authored by Mathiasdm). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D260?vs=605&id=625 REV

D261: centos5: use vault urls

This revision was automatically updated to reflect the committed changes. Closed by commit rHGaa7a3f6e3729: centos5: use vault urls (authored by Mathiasdm). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D261?vs=606&id=624 REVISION DETAIL https://phab.me

D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation

yuja added a comment. I've queued these for stable so 4.3 rpm can be built for CentOS 5. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 To: Mathiasdm, #hg-reviewers, yuja Cc: yuja, quark, mercurial-devel ___ Mercur

D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation

yuja accepted this revision as: yuja. yuja added a comment. Looks good. The manpage says > The O_CLOEXEC, O_DIRECTORY, and O_NOFOLLOW flags are not specified in POSIX.1-2001, but are specified in > POSIX.1-2008. Since glibc 2.12, one can obtain their definitions by defining either _

D238: context: rename troubles into instabilities

lothiraldan added inline comments. INLINE COMMENTS > indygreg wrote in context.py:246-248 > This feels like it should be a set not a list. > > Should this be changed as part of changing the API? Semantically I agree, but the list has the nice property of being sorted. If we change it to a set,

D239: context: rename unstable into orphan

lothiraldan marked an inline comment as done. lothiraldan added inline comments. INLINE COMMENTS > indygreg wrote in context.py:208 > Typo. Can be fixed in flight if you don't submit a new series. I have made the fix as I sent another series REPOSITORY rHG Mercurial REVISION DETAIL https:/

D239: context: rename unstable into orphan

lothiraldan updated this revision to Diff 623. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D239?vs=584&id=623 REVISION DETAIL https://phab.mercurial-scm.org/D239 AFFECTED FILES mercurial/context.py CHANGE DETAILS diff --git a/mercurial/context.py

D240: context: rename divergent into contentdivergent

lothiraldan added inline comments. INLINE COMMENTS > lothiraldan wrote in context.py:227 > Damn it you are right, good catch! Sorry for the tone of my comment, I was only angry against myself, I thought I have fixed this code too many times due to merge conflicts. REPOSITORY rHG Mercurial R

D240: context: rename divergent into contentdivergent

lothiraldan updated this revision to Diff 621. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D240?vs=585&id=621 REVISION DETAIL https://phab.mercurial-scm.org/D240 AFFECTED FILES mercurial/context.py CHANGE DETAILS diff --git a/mercurial/context.py

D241: context: rename bumped into phasedivergent

lothiraldan updated this revision to Diff 622. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D241?vs=586&id=622 REVISION DETAIL https://phab.mercurial-scm.org/D241 AFFECTED FILES mercurial/context.py CHANGE DETAILS diff --git a/mercurial/context.py

[Bug 5650] New: Ability to use timestamp from GIT_AUTHOR_DATE

https://bz.mercurial-scm.org/show_bug.cgi?id=5650 Bug ID: 5650 Summary: Ability to use timestamp from GIT_AUTHOR_DATE Product: Mercurial Version: 4.2.2 Hardware: PC OS: Windows Status: UNCONFIRMED Severity

D240: context: rename divergent into contentdivergent

lothiraldan added inline comments. INLINE COMMENTS > indygreg wrote in context.py:227 > This should be `self.contentdivergent()` no? Damn it you are right, good catch! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D240 To: lothiraldan, #hg-reviewers, indygreg Cc:

D241: context: rename bumped into phasedivergent

lothiraldan added inline comments. INLINE COMMENTS > indygreg wrote in context.py:220 > Shouldn't this be `self.phasedivergent()`? Yes definitely, thanks for the catch REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D241 To: lothiraldan, #hg-reviewers, indygreg Cc: