D447: templatekw: choose {latesttag} by len(changes), not date (issue5659)

2017-08-21 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfb672eac2702: templatekw: choose {latesttag} by len(changes), not date (issue5659) (authored by martinvonz). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D446: tests: use graph log in {latesttag} tests

2017-08-21 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0e15d5ae52cf: tests: use graph log in {latesttag} tests (authored by martinvonz). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D446?vs=1079=1151 REVISION

D471: run-tests: also highlight .py test files in summary messages

2017-08-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With the .t files highlighted, it's very easy to not even notice failed .py tests. REPOSITORY rHG Mercurial REVISION DETAIL

D469: rebase: initial support for multiple destinations

2017-08-21 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch defines `SRC` (a single source revision) and `ALLSRC` (all source revisions) to be valid names in `--dest` revset if `--src` or `--rev` is used. So

D470: rebase: sort destmap topologically

2017-08-21 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously rebase source and destination could not overlap. But with the multi-destination support, source and destination could reasonably partially overlap.

D347: rebase: rewrite _computeobsoletenotrebased

2017-08-21 Thread quark (Jun Wu)
quark updated this revision to Diff 1146. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D347?vs=899=1146 REVISION DETAIL https://phab.mercurial-scm.org/D347 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py

D348: rebase: change internal format to support destination map

2017-08-21 Thread quark (Jun Wu)
quark updated this revision to Diff 1147. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D348?vs=900=1147 REVISION DETAIL https://phab.mercurial-scm.org/D348 AFFECTED FILES hgext/rebase.py tests/test-rebase-legacy.t CHANGE DETAILS diff --git

Re: D464: Use an unambigious path suffix for the commit editor file.

2017-08-21 Thread Sean Farley
mbolin (Michael Bolin) writes: > mbolin created this revision. > Herald added a subscriber: mercurial-devel. > Herald added a reviewer: hg-reviewers. > > REVISION SUMMARY > Changes the path for a commit editor file from `/tmp/hg-editor-XX.txt` > to >

Re: D447: templatekw: choose {latesttag} by len(changes), not date (issue5659)

2017-08-21 Thread Sean Farley
yuja (Yuya Nishihara) writes: > yuja accepted this revision. > yuja added a comment. > This revision is now accepted and ready to land. > > > This one looks good to me, thanks. I leave it to Sean since he said he's > queued the previous series. Thanks. I think

D468: Use ~ as a suffix when creating a temp file in the same directory as a source file.

2017-08-21 Thread mbolin (Michael Bolin)
mbolin created this revision. Herald added a subscriber: mercurial-devel. REVISION SUMMARY Tools like Buck have patterns to ignore the creation of files (in the working copy) that match certain patterns:

D464: commit: use an unambiguous path suffix for the commit editor file

2017-08-21 Thread quark (Jun Wu)
quark accepted this revision. quark added a comment. Looks good to me. I have changed the title to follow the `topic: uncapitalized, no trailing period` pattern suggested by ContributingChanges wiki . REPOSITORY rHG Mercurial

D466: run-tests: make per-line condition support testcase names

2017-08-21 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/rHG7340465bd78819921cc7a07dfed17dc9ca573b7f added multiple test cases support. The latter has a problem - output lines cannot be

[PATCH 3 of 4] client: don't swallow ResponseError inside open()

2017-08-21 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1503327973 -7200 # Mon Aug 21 17:06:13 2017 +0200 # Node ID 8b4d606b49655d44091c2689a3f35a3fff17a28d # Parent e2b082707b44c5d9f630bf0ca722723bad8cefb1 client: don't swallow ResponseError inside open() _readhello()

[PATCH 4 of 4] client: raise ResponseError in _readchannel()

2017-08-21 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1503328417 -7200 # Mon Aug 21 17:13:37 2017 +0200 # Node ID 6f59b1f3360d599dfe66cf509bbde926d87ebe5e # Parent 8b4d606b49655d44091c2689a3f35a3fff17a28d client: raise ResponseError in _readchannel() Make it clearer

D464: Use an unambigious path suffix for the commit editor file.

2017-08-21 Thread mbolin (Michael Bolin)
mbolin created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changes the path for a commit editor file from `/tmp/hg-editor-XX.txt` to `/tmp/hg-editor-XX.hgcommit.txt`. Some editors (such as Atom) make it

Re: [PATCH 4 of 6] i18n: use saved object to get actual function information if available

2017-08-21 Thread FUJIWARA Katsunori
At Mon, 21 Aug 2017 21:46:35 +0900, Yuya Nishihara wrote: > > On Wed, 16 Aug 2017 01:19:04 +0900, FUJIWARA Katsunori wrote: > > # HG changeset patch > > # User FUJIWARA Katsunori > > # Date 1502792844 -32400 > > # Tue Aug 15 19:27:24 2017 +0900 > > # Node ID

D451: revset: remove order information from tree

2017-08-21 Thread quark (Jun Wu)
quark added inline comments. INLINE COMMENTS > quark wrote in revset.py:893 > In this case, `y` is expected to completely redefine the order. So `y`'s > `subset`'s order does not matter. By "y's subset", I mean "getset(repo, subset, x, xorder)". REPOSITORY rHG Mercurial REVISION DETAIL

D451: revset: remove order information from tree

2017-08-21 Thread quark (Jun Wu)
quark added inline comments. INLINE COMMENTS > yuja wrote in revset.py:129 > `subset & xs` should be correct since `dagrange` doesn't have > its own order unlike `rangeset`. > > Most revset functions "follow" the default order even if they > are used where they may "define" order. For `subset

D358: copytrace: move fb extension to core under flag experimental.fastcopytrace

2017-08-21 Thread stash (Stanislau Hlebik)
stash added a comment. Quick heads-up: one of our bootcampers works on the task that does the following: if rebase/merge/graft happens only on the local stack (i.e. base commit is draft), then we fallback to the normal copytrace, because we are sure it's going to be fast enough REPOSITORY

mercurial@33857: 19 new changesets

2017-08-21 Thread Mercurial Commits
19 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/7d5bc0e5b88f changeset: 33839:7d5bc0e5b88f user:Augie Fackler date:Mon Jul 24 14:38:40 2017 -0400 summary: py3: introduce a wrapper for __builtins__.{raw_,}input()

[PATCH 2 of 4] client: kill the server on unrecoverable communication errors (issue5516)

2017-08-21 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1503327734 -7200 # Mon Aug 21 17:02:14 2017 +0200 # Node ID e2b082707b44c5d9f630bf0ca722723bad8cefb1 # Parent 242d719e85ce451e61ab262eec443668bb4792ce client: kill the server on unrecoverable communication errors

[PATCH 1 of 4] client: fail gracefully on unexpected prompts (issue5516)

2017-08-21 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1503326357 -7200 # Mon Aug 21 16:39:17 2017 +0200 # Node ID 242d719e85ce451e61ab262eec443668bb4792ce # Parent 8e959ad6a25c9fe6ab490e1a4cbd5f7445d9bcb1 client: fail gracefully on unexpected prompts (issue5516) Right

D360: log: add a "graphwidth" template variable

2017-08-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. > it may make sense to have a more generic "textwidth" Good idea! That seems like what one usually wants. Can we not simply add that (defined as "termwidth - graphwidth")? If we had that, when would one want termwidth or graphwidth themselves? REPOSITORY

D451: revset: remove order information from tree

2017-08-21 Thread quark (Jun Wu)
quark added a comment. In https://phab.mercurial-scm.org/D451#7257, @yuja wrote: > We could change this policy so all predicates must "define" their own ordering > schemes (as you did, I think), but I guess that would lead to bugs that are hardly > noticed. I think the

[PATCH 3 of 4] client: don't swallow ResponseError inside open()

2017-08-21 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1503327973 -7200 # Mon Aug 21 17:06:13 2017 +0200 # Node ID 8b4d606b49655d44091c2689a3f35a3fff17a28d # Parent e2b082707b44c5d9f630bf0ca722723bad8cefb1 client: don't swallow ResponseError inside open() _readhello()

[PATCH 1 of 4] client: fail gracefully on unexpected prompts (issue5516)

2017-08-21 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1503326357 -7200 # Mon Aug 21 16:39:17 2017 +0200 # Node ID 242d719e85ce451e61ab262eec443668bb4792ce # Parent 8e959ad6a25c9fe6ab490e1a4cbd5f7445d9bcb1 client: fail gracefully on unexpected prompts (issue5516) Right

[PATCH 4 of 4] client: raise ResponseError in _readchannel()

2017-08-21 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1503328417 -7200 # Mon Aug 21 17:13:37 2017 +0200 # Node ID 6f59b1f3360d599dfe66cf509bbde926d87ebe5e # Parent 8b4d606b49655d44091c2689a3f35a3fff17a28d client: raise ResponseError in _readchannel() Make it clearer

[PATCH 2 of 4] client: kill the server on unrecoverable communication errors (issue5516)

2017-08-21 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1503327734 -7200 # Mon Aug 21 17:02:14 2017 +0200 # Node ID e2b082707b44c5d9f630bf0ca722723bad8cefb1 # Parent 242d719e85ce451e61ab262eec443668bb4792ce client: kill the server on unrecoverable communication errors

D340: rebase: choose merge base without unwanted revisions

2017-08-21 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3160876c6e4e: rebase: choose merge base without unwanted revisions (authored by quark). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D340?vs=1085=1124 REVISION

D346: rebase: only change self.state when collapsing in _finishrebase

2017-08-21 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG70354bd4f19b: rebase: only change self.state when collapsing in _finishrebase (authored by quark). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D346?vs=780=1125

D451: revset: remove order information from tree

2017-08-21 Thread yuja (Yuya Nishihara)
yuja added a comment. (just scanned the series; no careful review yet) Perhaps the name `defineorder` was misleading. As of lazyset was introduced, most revset predicates "follow"ed the order of the input `subset`, which was by default rev-ascending. This is also true now. And there

D423: pushvars: do not mangle repo state

2017-08-21 Thread ryanmce (Ryan McElroy)
ryanmce accepted this revision. ryanmce added a comment. It would be really nice to get this change in. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D423 To: quark, #hg-reviewers, dsp, ryanmce Cc: ryanmce, dsp, mercurial-devel

mercurial@33838: 25 new changesets

2017-08-21 Thread Mercurial Commits
25 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/81b12f69ef5b changeset: 33814:81b12f69ef5b user:Matthieu Laneuville date:Fri Aug 11 14:21:49 2017 +0200 summary: run-tests: also color the summary messages (skipped,

Re: [PATCH 8 of 9 V3] template: better prune support in obsfate

2017-08-21 Thread Boris Feld
On Mon, 2017-08-21 at 13:06 +0200, Denis Laxalde wrote: > Boris Feld a écrit : > > # HG changeset patch > > # User Boris Feld > > # Date 1499096336 -7200 > > #  Mon Jul 03 17:38:56 2017 +0200 > > # Node ID 7cb7e67addd11cdbecea49ec707e3e9b30bb8677 > > # Parent  

Re: [PATCH v4] run-tests: also color the summary messages (skipped, failed...)

2017-08-21 Thread Yuya Nishihara
On Fri, 11 Aug 2017 14:25:12 +0200, mlaneuvi...@gmail.com wrote: > # HG changeset patch > # User Matthieu Laneuville > # Date 1502454109 -7200 > # Fri Aug 11 14:21:49 2017 +0200 > # Node ID 26bd9bfc7f679dc521b8056b48875eee71cd8627 > # Parent

D231: httppeer: add support for httppostargs when we're sending a file

2017-08-21 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > httppeer.py:105 > +def read(self, amt=None): > +if amt <= 0: > +return ''.join(f.read() for f in self._fileobjs) Just nits: - `read(0)` should return an empty string. - `None <= 0` is TypeError on Python 3. >

D454: releasenotes: view admonition titles using -l flag

2017-08-21 Thread rishabhmadan96 (Rishabh Madan)
rishabhmadan96 updated this revision to Diff 1123. rishabhmadan96 edited the summary of this revision. rishabhmadan96 retitled this revision from "releasenotes: view admonition titles using -a flag" to "releasenotes: view admonition titles using -l flag". REPOSITORY rHG Mercurial CHANGES

Re: [PATCH 6 of 9 V3] template: compute user in obsfateusers

2017-08-21 Thread Boris Feld
On Mon, 2017-08-21 at 12:55 +0200, Denis Laxalde wrote: > Boris Feld a écrit : > > # HG changeset patch > > # User Boris Feld > > # Date 1499088840 -7200 > > #  Mon Jul 03 15:34:00 2017 +0200 > > # Node ID 2fee3b06f7b09f35dcfa312b645cf94090c11fb9 > > # Parent  

D454: releasenotes: view admonition titles using -a flag

2017-08-21 Thread rishabhmadan96 (Rishabh Madan)
rishabhmadan96 added inline comments. INLINE COMMENTS > pulkit wrote in releasenotes.py:475 > I am not sure whether `-a` is the best choice of flag. Maybe we can have `-l` > and `--list`. > > Also the help can be improved to "list the available admonitions with their > title". `--list`

Re: [PATCH 1 of 9 V3] obsolete: introduce a _succs class

2017-08-21 Thread Boris Feld
On Mon, 2017-08-21 at 12:45 +0200, Denis Laxalde wrote: > Boris Feld a écrit : > > # HG changeset patch > > # User Boris Feld > > # Date 1499036035 -7200 > > #  Mon Jul 03 00:53:55 2017 +0200 > > # Node ID 328789121fa66b99c50ffa2fb139df700cf9fdc8 > > # Parent  

Re: [PATCH 4 of 6] i18n: use saved object to get actual function information if available

2017-08-21 Thread Yuya Nishihara
On Wed, 16 Aug 2017 01:19:04 +0900, FUJIWARA Katsunori wrote: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1502792844 -32400 > # Tue Aug 15 19:27:24 2017 +0900 > # Node ID b6dd19c795147e675b9caf58383b6cafd3f03534 > # Parent

D454: releasenotes: view admonition titles using -a flag

2017-08-21 Thread pulkit (Pulkit Goyal)
pulkit requested changes to this revision. pulkit added a comment. This revision now requires changes to proceed. The patch in general looks good to me. I have some inline comments. INLINE COMMENTS > releasenotes.py:278 > > +def getadmonitionlist(ui, sections): > +for section in

D358: copytrace: move fb extension to core under flag experimental.fastcopytrace

2017-08-21 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D358#7173, @quark wrote: > For config options, I think it's cleaner if we can unify them: > > experimental.copytrace = disable | default | fast > > > - `disable`: no copy tracing > - `default`: old copy tracing

D461: morestatus: check whether the conflict message is None before printing

2017-08-21 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are cases like bisect when the conflict message can be None. So we make sure that we don't print None in that case. Thanks to Martin for catching this.

Re: [PATCH 8 of 9 V3] template: better prune support in obsfate

2017-08-21 Thread Denis Laxalde
Boris Feld a écrit : # HG changeset patch # User Boris Feld # Date 1499096336 -7200 # Mon Jul 03 17:38:56 2017 +0200 # Node ID 7cb7e67addd11cdbecea49ec707e3e9b30bb8677 # Parent faad6d683f7a30996007116d296df9ebf853c44d # EXP-Topic obsfatetemplate template: better

Re: [PATCH 6 of 9 V3] template: compute user in obsfateusers

2017-08-21 Thread Denis Laxalde
Boris Feld a écrit : # HG changeset patch # User Boris Feld # Date 1499088840 -7200 # Mon Jul 03 15:34:00 2017 +0200 # Node ID 2fee3b06f7b09f35dcfa312b645cf94090c11fb9 # Parent 66a2b0407c8cffedfae4897bd7a2f0e2d6a22363 # EXP-Topic obsfatetemplate template: compute

Re: [PATCH 1 of 9 V3] obsolete: introduce a _succs class

2017-08-21 Thread Denis Laxalde
Boris Feld a écrit : # HG changeset patch # User Boris Feld # Date 1499036035 -7200 # Mon Jul 03 00:53:55 2017 +0200 # Node ID 328789121fa66b99c50ffa2fb139df700cf9fdc8 # Parent 3cfc9070245fbaa8c4c010327f24d579a416370f # EXP-Topic obsfatetemplate obsolete: introduce

[Bug 5664] New: hglib should allow prompt handling for all commands, and include --noninteractive when no prompt handler is specified

2017-08-21 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5664 Bug ID: 5664 Summary: hglib should allow prompt handling for all commands, and include --noninteractive when no prompt handler is specified Product: Mercurial

[PATCH 4 of 9 V3] template: add minimal obsfate template function

2017-08-21 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1502987171 -7200 # Thu Aug 17 18:26:11 2017 +0200 # Node ID 84a35f753f9ab500902f5c06ce3845ce85e5b5a9 # Parent 89a659e236b906e58a48dfed8a4e3b89372d7184 # EXP-Topic obsfatetemplate template: add minimal obsfate template

[PATCH 8 of 9 V3] template: better prune support in obsfate

2017-08-21 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499096336 -7200 # Mon Jul 03 17:38:56 2017 +0200 # Node ID 7cb7e67addd11cdbecea49ec707e3e9b30bb8677 # Parent faad6d683f7a30996007116d296df9ebf853c44d # EXP-Topic obsfatetemplate template: better prune support in obsfate

[PATCH 2 of 9 V3] obsolete: add an explicit '_succs.copy()' method

2017-08-21 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499044397 -7200 # Mon Jul 03 03:13:17 2017 +0200 # Node ID 60a7a3ca1dae7dc99b8b018b4aefa24b74d3b149 # Parent 328789121fa66b99c50ffa2fb139df700cf9fdc8 # EXP-Topic obsfatetemplate obsolete: add an explicit '_succs.copy()'

[PATCH 5 of 9 V3] template: compute verb in obsfateverb

2017-08-21 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499088807 -7200 # Mon Jul 03 15:33:27 2017 +0200 # Node ID 66a2b0407c8cffedfae4897bd7a2f0e2d6a22363 # Parent 84a35f753f9ab500902f5c06ce3845ce85e5b5a9 # EXP-Topic obsfatetemplate template: compute verb in obsfateverb Add

[PATCH 7 of 9 V3] template: compute dates in obsfatedate

2017-08-21 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499088850 -7200 # Mon Jul 03 15:34:10 2017 +0200 # Node ID faad6d683f7a30996007116d296df9ebf853c44d # Parent 2fee3b06f7b09f35dcfa312b645cf94090c11fb9 # EXP-Topic obsfatetemplate template: compute dates in obsfatedate

[PATCH 6 of 9 V3] template: compute user in obsfateusers

2017-08-21 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499088840 -7200 # Mon Jul 03 15:34:00 2017 +0200 # Node ID 2fee3b06f7b09f35dcfa312b645cf94090c11fb9 # Parent 66a2b0407c8cffedfae4897bd7a2f0e2d6a22363 # EXP-Topic obsfatetemplate template: compute user in obsfateusers

[PATCH 9 of 9 V3] test: add more obsmarker tests for pruning scenarios

2017-08-21 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1502986172 -7200 # Thu Aug 17 18:09:32 2017 +0200 # Node ID 9821bcb3d8fd64a8ab1f68b2ab5d76b108587048 # Parent 7cb7e67addd11cdbecea49ec707e3e9b30bb8677 # EXP-Topic obsfatetemplate test: add more obsmarker tests for pruning

[PATCH 3 of 9 V3] obsolete: track markers in _succs

2017-08-21 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499045278 -7200 # Mon Jul 03 03:27:58 2017 +0200 # Node ID 89a659e236b906e58a48dfed8a4e3b89372d7184 # Parent 60a7a3ca1dae7dc99b8b018b4aefa24b74d3b149 # EXP-Topic obsfatetemplate obsolete: track markers in _succs We now

[PATCH 1 of 9 V3] obsolete: introduce a _succs class

2017-08-21 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499036035 -7200 # Mon Jul 03 00:53:55 2017 +0200 # Node ID 328789121fa66b99c50ffa2fb139df700cf9fdc8 # Parent 3cfc9070245fbaa8c4c010327f24d579a416370f # EXP-Topic obsfatetemplate obsolete: introduce a _succs class It

[PATCH] bookmarks: allow renaming active bookmark using '.'

2017-08-21 Thread David Demelier
# HG changeset patch # User David Demelier # Date 1503298366 -7200 # Mon Aug 21 08:52:46 2017 +0200 # Node ID f6ee280ea6afef475c3d158c4c4964a05be6ef15 # Parent 1e71a27dee970ec9ef02c004f662b5a99182f69b bookmarks: allow renaming active bookmark using '.' diff -r