dlax added inline comments.
INLINE COMMENTS
> repoview.py:38
> pinned.update([par.rev() for par in repo[None].parents()])
> pinned.update([cl.rev(bm) for bm in repo._bookmarks.values()])
>
Updating a "private" attribute of an object outside the class is not nice.
Not sure about "our"
dlax requested changes to this revision.
dlax added a comment.
This revision now requires changes to proceed.
The idea of using different names to control the behavior of the filter
function sounds strange to me.
Maybe `repoview.filterrevs()` could accept `**kwargs` that would be passed to
dlax added a comment.
In https://phab.mercurial-scm.org/D1012#17020, @dlax wrote:
> (Also having an actual use of the new behavior in the patch series would
help understanding the intent.)
Hm, I now see it's used in some other differentials but they do not appear in
this stack :(
dlax added inline comments.
INLINE COMMENTS
> repoview.py:104
> -
> -Secret and hidden changeset should not pretend to be here."""
> assert not repo.changelog.filteredrevs
Maybe update the docstring instead of removing?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercuri
Augie Fackler a écrit :
On Wed, Oct 04, 2017 at 06:52:45PM +0200, Denis Laxalde wrote:
# HG changeset patch
# User Denis Laxalde
# Date 1507135871 -7200
# Wed Oct 04 18:51:11 2017 +0200
# Node ID ae007b70b03657bbb92f4b73e6e0c807669dae10
# Parent 21115bb034eb168806d485b3b28c3112
#
https://bz.mercurial-scm.org/show_bug.cgi?id=5707
Bug ID: 5707
Summary: hg log filtering using file('path:pattern') does not
work as expected
Product: Mercurial
Version: 4.3
Hardware: PC
OS: Windows
On Wed, 2017-10-11 at 14:16 -0400, Augie Fackler wrote:
> On Fri, Oct 06, 2017 at 11:22:29AM +0200, Boris Feld wrote:
> > # HG changeset patch
> > # User Boris Feld
> > # Date 1498786954 -7200
> > # Fri Jun 30 03:42:34 2017 +0200
> > # Node ID d54526c257afa33b7624f0b94c16822bcbd08df1
> > # Pa
lothiraldan accepted this revision.
lothiraldan added a comment.
Too bad
https://docs.python.org/2/library/platform.html?highlight=python_implementation#platform.python_implementation
is not available in all jython version
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-
lothiraldan accepted this revision.
lothiraldan added a comment.
LGTM but I can't validate the Mac OS and Windows tests.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1021
To: quark, #hg-reviewers, lothiraldan
Cc: lothiraldan, mercurial-devel
__
mbthomas abandoned this revision.
mbthomas added a comment.
Based on Ryan's feedback, I'm going to abandon this stack for now. We're
going to experiment in the fbhistedit extension to see if we can find the best
ux.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.or
dlax added a comment.
Took the time to read this in details. I agree that the algorigthm/idea is
fairly simple to grasp.
I don't remember the old algorithm so I'd trust @pulkit when he says that
it's easier to follow/understand. I'm not sure about the "flakyness" mentioned
in the commit
dlax added inline comments.
INLINE COMMENTS
> pulkit wrote in commands.py:4794
> I can implement your suggestion using following ways:
>
> 1. add 'clean' and 'unknown' to `show` variable and take them out later as
> that variable is used later also
>
> 2. add a new variable which handles this.
# HG changeset patch
# User Boris Feld
# Date 1506711555 -3600
# Fri Sep 29 19:59:15 2017 +0100
# Node ID 8252157034b4e4f9f851f328633ef86df44cc9cf
# Parent 60213a2eca81af4e1daa3ef9e44af859ba1e5756
# EXP-Topic obs-tests
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
# HG changeset patch
# User Boris Feld
# Date 1506807440 -3600
# Sat Sep 30 22:37:20 2017 +0100
# Node ID cf572fd4e79604e0f774869c11e24b05f1d3517f
# Parent 8252157034b4e4f9f851f328633ef86df44cc9cf
# EXP-Topic obs-tests
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
ryanmce added a comment.
> I guess you missed phabricator.callsign = HG in .hg/hgrc.
Yes, that's the case. I've fixed that in my repo.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D930
To: ryanmce, #hg-reviewers, quark
Cc: quark, krbullock, mercurial-devel
ryanmce added inline comments.
INLINE COMMENTS
> bdiff.h:18
> int bdiff_diff(struct bdiff_line *a, int an, struct bdiff_line *b, int bn,
> - struct bdiff_hunk *base);
> + struct bdiff_hunk *base);
> void bdiff_freehunks(struct bdiff_hunk *l);
This doesn't show up in Different
ryanmce accepted this revision.
ryanmce added a comment.
This revision is now accepted and ready to land.
queued
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1009
To: durin42, #hg-reviewers, pulkit, ryanmce
Cc: ryanmce, mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG72985b390d7c: bdiff: format header file with clang-format
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1004?vs=2585&id=261
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGff4c9c6263de: bdiff: sort includes using clang-format
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1003?vs=2584&id=2615
R
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2c79a5a0c7f3: bdiff: remove extra space after * per
clang-format (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1006?vs=2587
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG38463bd96d21: bdiff: re-wrap lines per clang-format
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1007?vs=2588&id=2619
REV
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG72b24ac81d5d: bdiff: fix misplaced comma in macro
definition with clang-format (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7201e3607d90: bdiff: remove trailing newlines (authored by
durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1009?vs=2590&id=2621
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4dea82ee7945: bdiff: rewrap function prototypes per
clang-format (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1008?vs=2589
ryanmce requested changes to this revision.
ryanmce added a comment.
This revision now requires changes to proceed.
I agree that removing is better than leaving bad docs, so I'm +1 on this, but
as @dlax suggests, improving it would be even better.
If you don't have ideas on how to improve
ryanmce added inline comments.
INLINE COMMENTS
> dlax wrote in run-tests.py:2116
> Perhaps also update the indentation of continuation line?
I can do this in-flight
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D948
To: quark, #hg-reviewers
Cc: ryanmce, dlax, mer
ryanmce requested changes to this revision.
ryanmce added a comment.
This revision now requires changes to proceed.
I'm +1 on this series and the rest looks fine but I think this one needs some
improvements before landing.
INLINE COMMENTS
> run-tests.py:2115-2116
> return data
>
ryanmce added inline comments.
INLINE COMMENTS
> ryanmce wrote in run-tests.py:2116
> I can do this in-flight
Actually, since I've asked for changed on the topmost revision, can you fix
this up with the next submission please?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercuria
ryanmce requested changes to this revision.
ryanmce added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> durham wrote in test-directaccess.t:64
> I'm still not sure we want to support rev numbers. I think we definitely
> don't want to support them for write co
ryanmce requested changes to this revision.
ryanmce added inline comments.
INLINE COMMENTS
> remotenames.py:31
>
> +def getremotevfs(repo):
> +""" returns a vfs object for .hg/remotenames/
This is not a great name. It implies it's a vfs on a remote peer, which is
definitely not what we wa
ryanmce requested changes to this revision.
ryanmce added inline comments.
INLINE COMMENTS
> remotenames.py:10
> +
> +def pullremotenames(localrepo, remoterepo, remotepath):
> +""" pulls bookmarks and branches information of the remote repo during a
It might be better to call this `fetchremo
Boris Feld a écrit :
# HG changeset patch
# User Boris Feld
# Date 1506711555 -3600
# Fri Sep 29 19:59:15 2017 +0100
# Node ID 8252157034b4e4f9f851f328633ef86df44cc9cf
# Parent 60213a2eca81af4e1daa3ef9e44af859ba1e5756
# EXP-Topic obs-tests
# Available At https://bitbucket.org/octobus/mercu
Boris Feld a écrit :
# HG changeset patch
# User Boris Feld
# Date 1506807440 -3600
# Sat Sep 30 22:37:20 2017 +0100
# Node ID cf572fd4e79604e0f774869c11e24b05f1d3517f
# Parent 8252157034b4e4f9f851f328633ef86df44cc9cf
# EXP-Topic obs-tests
# Available At https://bitbucket.org/octobus/mercu
dlax added inline comments.
INLINE COMMENTS
> ryanmce wrote in remotenames.py:11-16
> nit: for multiline docblocks, I prefer to leave the first line empty:
>
> """
> pulls bookmarks and branches information of the remote repo during a
> pull or clone operation.
>
> localrepo is our lo
On Wed, 11 Oct 2017 22:46:19 +0200, a.mux--- via Mercurial-devel wrote:
> # HG changeset patch
> # User muxator
> # Date 1507680372 -7200
> # Wed Oct 11 02:06:12 2017 +0200
> # Node ID 0dc5f9e9fd59f0c2289ca3133a0e54d49b7882d7
> # Parent fc144c0ec36089c4b60bb3287adc787a1cfcae78
> build: chg b
ryanmce requested changes to this revision.
ryanmce added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> remotenames.py:10-19
> +def splitremotename(remote):
> +name = ''
> +if '/' in remote:
> +remote, name = remote.split('/', 1)
> +return r
ryanmce requested changes to this revision.
ryanmce added a comment.
I think we need to take a step back and think through how to implement this
more robustly than we have currently done in the remotenames extension:
- storage file names
- storage format
I like that you've split br
https://bz.mercurial-scm.org/show_bug.cgi?id=5708
Bug ID: 5708
Summary: topic-ext: "hg previous" on an obsoleted revision
fails unintentionally, if topic is active
Product: Mercurial
Version: 4.3.3
Hardware: All
On Wed, 2017-10-11 at 22:24 +0900, Yuya Nishihara wrote:
> On Wed, 11 Oct 2017 14:09:51 +0200, Boris Feld wrote:
> > # HG changeset patch
> > # User Boris Feld
> > # Date 1507218176 -7200
> > # Thu Oct 05 17:42:56 2017 +0200
> > # Node ID 34bb2af8638432dea3052eabd4b6eb12a1777e19
> > # Parent
On Wed, 2017-10-11 at 22:35 +0900, Yuya Nishihara wrote:
> On Wed, 11 Oct 2017 14:09:53 +0200, Boris Feld wrote:
> > # HG changeset patch
> > # User Boris Feld
> > # Date 1507299827 -7200
> > # Fri Oct 06 16:23:47 2017 +0200
> > # Node ID b6b6cb2b16cb2c44b10113134e212bae5b47adb0
> > # Parent
On Wed, 2017-10-11 at 22:40 +0900, Yuya Nishihara wrote:
> On Wed, 11 Oct 2017 14:09:56 +0200, Boris Feld wrote:
> > # HG changeset patch
> > # User Boris Feld
> > # Date 1507209918 -7200
> > # Thu Oct 05 15:25:18 2017 +0200
> > # Node ID 79dd127e09281ca88332be9791016cf92936e4e8
> > # Parent
On Thu, 12 Oct 2017 15:29:31 +0200, Boris Feld wrote:
> On Wed, 2017-10-11 at 22:24 +0900, Yuya Nishihara wrote:
> > Ugh, there's templatekw.defaulttempl which provides the default
> > template
> > fragments to all stock/user templates. Maybe we can (ab)use it to
> > define
> > the default '{obsfat
# HG changeset patch
# User Yuya Nishihara
# Date 1507812162 -32400
# Thu Oct 12 21:42:42 2017 +0900
# Node ID d979476b95c0b301988655ee0ec1d7c53fcfa7a0
# Parent 7201e3607d90f0e698963a0b37cc1a767ee618ed
help: fix formatting of template keywords
Our minirst formatter can't render multi-paragr
# HG changeset patch
# User Yuya Nishihara
# Date 1507812482 -32400
# Thu Oct 12 21:48:02 2017 +0900
# Node ID a6cf3a279553d5b089c90585789033988756a24d
# Parent d979476b95c0b301988655ee0ec1d7c53fcfa7a0
help: hide template keywords of obsolescence as they are still experimental
diff --git a/
# HG changeset patch
# User Yuya Nishihara
# Date 1507813751 -32400
# Thu Oct 12 22:09:11 2017 +0900
# Node ID 26273fe219811ac0e87f030a2d9c8ed50f4f4768
# Parent b770d50a3c6256008a6ed6614b21f27e1a09df1b
templater: fix ifcontains() to handle type mismatch gracefully
This was unintentionally c
# HG changeset patch
# User Yuya Nishihara
# Date 1507812973 -32400
# Thu Oct 12 21:56:13 2017 +0900
# Node ID b770d50a3c6256008a6ed6614b21f27e1a09df1b
# Parent a6cf3a279553d5b089c90585789033988756a24d
help: use single quotes in ``template example``
It was hard to read because ``""`` was re
# HG changeset patch
# User Yuya Nishihara
# Date 1507814474 -32400
# Thu Oct 12 22:21:14 2017 +0900
# Node ID 9b41113b9c4397dec6bb198973a8231533f56bce
# Parent 26273fe219811ac0e87f030a2d9c8ed50f4f4768
chg: remove outdated rule to start test server
This rule is no longer useful because chg
yuja added a comment.
> I have added a debug message saying more candidates than the limit which
can give user a hint in this case. Shall I make that a ui.status() thing?
Perhaps.
And I think the status/warning message should be displayed in a stable manner,
which is:
- do not
ryanmce requested changes to this revision.
ryanmce added a comment.
This revision now requires changes to proceed.
I'm +1 on this direction but think we shouldn't `have == 'nt'` as the "is
this windows?" check here.
INLINE COMMENTS
> logtoprocess.py:55
> def uisetup(ui):
> -if platform
ryanmce requested changes to this revision.
ryanmce added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> lfutil.py:83
> return os.path.join(appdata, longname)
> -elif platform.system() == 'Darwin':
> +elif pycompat.sysplatform == 'darwin':
>
ryanmce added a comment.
+1 to this change, happy to land this once my comments on the series are
addressed
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1021
To: quark, #hg-reviewers, lothiraldan
Cc: ryanmce, lothiraldan, mercurial-devel
_
quark added inline comments.
INLINE COMMENTS
> ryanmce wrote in logtoprocess.py:55
> seems like this should be `pycompat.iswindows` (which probably doesn't exist
> yet, but should) because comparisons to things that should be constants
> scattered throughout the code scare me.
This check is co
I've done some sniffing around, and it looks like we could at least start
figuring out *why* we're getting on this spamhaus list if we would enable DMARC
in notify-only mode, and it would definitely help our IP reputation to have an
SPF record. So I think we should configure the following DNS en
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1027
AFFECTED FILES
mercurial/mpatch.c
CHANGE DETAILS
diff --git a/mercurial/mpatch.c b/mercurial/mpa
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1028
AFFECTED FILES
mercurial/mpatch.c
mercurial/mpatch.h
CHANGE DETAILS
diff --git a/mercurial/mpa
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
clang-format is not a fan of PyObject_HEAD.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1031
AFFECTED FILES
mercurial/cext/util
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I may be a weird person for liking this style, but our C style is
historically nominally the Linux Kernel style, and when you configure
clang-format to be kernel
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
A few *s move around, some spaces around parens, a couple of
braces. Nothing remarkable.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1029
AFFECTED FILES
mercurial/mpatch.c
CHANGE DETAILS
diff --git a/mercurial/mpatch.c b/mercurial/mpa
> On Oct 12, 2017, at 10:03, Augie Fackler wrote:
>
> I've done some sniffing around, and it looks like we could at least start
> figuring out *why* we're getting on this spamhaus list if we would enable
> DMARC in notify-only mode, and it would definitely help our IP reputation to
> have an S
quark added inline comments.
INLINE COMMENTS
> ryanmce wrote in lfutil.py:83
> why is this not a pycompat.osname check? It doesn't make sense to abort below
> with pycompat.osname if that might still be posix.
>
> To be clear, your patch isn't making this worse, but it's exposing something
> s
> On Oct 12, 2017, at 03:13, Denis Laxalde wrote:
>
> # HG changeset patch
> # User Denis Laxalde
> # Date 1507793990 -7200
> # Thu Oct 12 09:39:50 2017 +0200
> # Node ID 48cca33a1b611c82a2bd72a2f72b80f321604f42
> # Parent f1c2552c2de78a2f8a0c0ded099ccb200aad27d0
> # Available At http://hg
quark added inline comments.
INLINE COMMENTS
> ryanmce wrote in run-tests.py:2124-2153
> For readability, please add the try/finally (with the finally block being
> just `pass` for now) in a separate patch.
During the meeting deciding to experiment with Phabricator, I think we agreed
that with
# HG changeset patch
# User Yuya Nishihara
# Date 1507821268 -32400
# Fri Oct 13 00:14:28 2017 +0900
# Node ID 69b2780c454aa671eab506050f0dca555f40ee62
# Parent 9b41113b9c4397dec6bb198973a8231533f56bce
configitems: correct default values of web.allow and web.hidden
The default of ui.configb
# HG changeset patch
# User Yuya Nishihara
# Date 1507821774 -32400
# Fri Oct 13 00:22:54 2017 +0900
# Node ID 50217bf3f4f143488d91cce177f5447115b5277e
# Parent 69b2780c454aa671eab506050f0dca555f40ee62
configitems: drop redundant default of web.allow
Otherwise develwarn would be sent to std
Looks good to me, thank for the catch!
I'm gonna double-check the other patches that have landed.
Le jeu. 12 oct. 2017 à 17:37, Yuya Nishihara a écrit :
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1507821774 -32400
> # Fri Oct 13 00:22:54 2017 +0900
> # Node ID 50217bf3f4f1434
quark updated this revision to Diff 2633.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1018?vs=2609&id=2633
REVISION DETAIL
https://phab.mercurial-scm.org/D1018
AFFECTED FILES
mercurial/pycompat.py
mercurial/selectors2.py
CHANGE DETAILS
diff --g
quark updated this revision to Diff 2635.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1024?vs=2613&id=2635
REVISION DETAIL
https://phab.mercurial-scm.org/D1024
AFFECTED FILES
mercurial/hgweb/common.py
tests/test-dispatch.t
CHANGE DETAILS
diff -
quark updated this revision to Diff 2634.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1021?vs=2608&id=2634
REVISION DETAIL
https://phab.mercurial-scm.org/D1021
AFFECTED FILES
contrib/check-code.py
CHANGE DETAILS
diff --git a/contrib/check-code.py
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As suggested by Ryan in https://phab.mercurial-scm.org/D1019, it's cleaner if
we use defined constants
instead of `osname == 'nt'` everywhere.
REPOSITORY
rHG Mer
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1037
AFFECTED FILES
contrib/check-code.py
CHANGE DETAILS
diff --git a/contrib/check-code.py b/contrib/c
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is done by:
sed -i "s/pycompat\.osname == 'nt'/pycompat.iswindows/" **/*.py
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is done by:
sed -i "s/pycompat\.sysplatform == 'darwin'/pycompat.isdarwin/" **/*.py
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-s
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is done by:
sed -i "s/pycompat\.osname == 'posix'/pycompat.isposix/" **/*.py
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/
On Thu, 12 Oct 2017 11:03:01 -0400
Augie Fackler wrote:
> I've done some sniffing around, and it looks like we could at least start
> figuring out *why* we're getting on this spamhaus list if we would enable
> DMARC in notify-only mode, and it would definitely help our IP reputation to
> have
pulkit marked 3 inline comments as done.
pulkit added a comment.
In https://phab.mercurial-scm.org/D985#17043, @dlax wrote:
> Took the time to read this in details. I agree that the algorigthm/idea is
fairly simple to grasp.
Yay! thanks.
> I don't remember the old algorithm s
pulkit requested review of this revision.
pulkit added a comment.
In https://phab.mercurial-scm.org/D1016#17086, @ryanmce wrote:
> I agree that removing is better than leaving bad docs, so I'm +1 on this,
but as @dlax suggests, improving it would be even better.
>
> If you don't have
pulkit added a comment.
In https://phab.mercurial-scm.org/D1012#17023, @dlax wrote:
> In https://phab.mercurial-scm.org/D1012#17020, @dlax wrote:
>
> > (Also having an actual use of the new behavior in the patch series would
help understanding the intent.)
>
>
> Hm, I now see it
pulkit added inline comments.
INLINE COMMENTS
> dlax wrote in repoview.py:38
> Updating a "private" attribute of an object outside the class is not nice.
> Not sure about "our" common practice in this case, but maybe this could be
> handled through a property?
Hm, I will turn that attribute to
pulkit added inline comments.
INLINE COMMENTS
> ryanmce wrote in test-directaccess.t:64
> This is showing the rev numbers are not supported, right?
Yes!
> ryanmce wrote in test-directaccess.t:23-35
> Why so many commits here? It seems to needlessly bloat the test.
Okay will fix in next version
# HG changeset patch
# User Boris Feld
# Date 1506711555 -3600
# Fri Sep 29 19:59:15 2017 +0100
# Node ID 74998bff9b03f613236c22422b0305a25834ef9e
# Parent 60213a2eca81af4e1daa3ef9e44af859ba1e5756
# EXP-Topic obs-tests
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
# HG changeset patch
# User Boris Feld
# Date 1506807440 -3600
# Sat Sep 30 22:37:20 2017 +0100
# Node ID 10194608efe05c44ebcd86e618a313942a65a167
# Parent 74998bff9b03f613236c22422b0305a25834ef9e
# EXP-Topic obs-tests
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
spectral added inline comments.
INLINE COMMENTS
> pycompat.py:24
> +isposix = os.name == r'posix'
> +iswindows = os.name == r'nt'
> +
Since osname might be different (encoding or whatever) depending on python
version, I think moving these after the 'if ispy3/else' block below and using
someth
Boris Feld a écrit :
# HG changeset patch
# User Boris Feld
# Date 1506807440 -3600
# Sat Sep 30 22:37:20 2017 +0100
# Node ID 10194608efe05c44ebcd86e618a313942a65a167
# Parent 74998bff9b03f613236c22422b0305a25834ef9e
# EXP-Topic obs-tests
# Available Athttps://bitbucket.org/octobus/mercuri
pulkit accepted this revision.
pulkit added a comment.
Those who are struggling seeing the diff here or in similar cases, click on
History tab which is next to File one, just under the Revision content on this
page and you will "Whitespace change" thing in the right and change it to show
all
pulkit added a comment.
In https://phab.mercurial-scm.org/D987#17141, @yuja wrote:
> > I have added a debug message saying more candidates than the limit which
can give user a hint in this case. Shall I make that a ui.status() thing?
>
> Perhaps.
>
> And I think the status/warning
# HG changeset patch
# User muxator
# Date 1507834828 -7200
# Thu Oct 12 21:00:28 2017 +0200
# Node ID f91472aa5015bd16b8585e53ba34d64a7a05c8c7
# Parent 7259f0ddfc0f18138420e7c9c7e4145a25016d7b
build: no need to build zstd in the bootstrap phase of a deb/rpm build
When bootstrapping a deb/r
quark added inline comments.
INLINE COMMENTS
> spectral wrote in pycompat.py:24
> Since osname might be different (encoding or whatever) depending on python
> version, I think moving these after the 'if ispy3/else' block below and
> using something like:
>
> isdarwin = sysplatform == 'darwin'
dlax added inline comments.
INLINE COMMENTS
> pulkit wrote in cmdutil.py:558
> Well I agree with you on this. Yesterday I accidentally stumbled on your repo
> at hg.logilab.org/ by clicking a link in one of the commit message and saw
> that you have the above feedback implemented yourself. Bein
spectral accepted this revision.
spectral added a comment.
[Accepted with a very mild concern; I'm fine with it not being addressed]
INLINE COMMENTS
> quark wrote in pycompat.py:24
> For encoding, Python 2 and 3 are compatible if we use `r` prefixed strings.
>
> The `if` condition is to norm
quark added inline comments.
INLINE COMMENTS
> spectral wrote in pycompat.py:24
> Ah, sorry, I didn't mean put it in the if blocks (duplicating it), I meant
> just put it at the end of the file once .osname and
> .sysplatform have been created in a python-version-aware fashion,
> not indented
quark requested review of this revision.
quark added a comment.
I changed it in a later patch.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1020
To: quark, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
___
Merc
quark requested review of this revision.
quark added a comment.
It's changed by https://phab.mercurial-scm.org/D1034.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1019
To: quark, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel
_
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1042
AFFECTED FILES
mercurial/cmdutil.py
CHANGE DETAILS
diff --git a/mercurial/cmdutil.py b/mercurial/
pulkit updated this revision to Diff 2645.
pulkit edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D985?vs=2520&id=2645
REVISION DETAIL
https://phab.mercurial-scm.org/D985
AFFECTED FILES
mercurial/cmdutil.py
mercuri
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Turn dirnode's methods into generators which can be used to update "tersedict"
in caller. So instead of passing the "tersedict" to be mutated here and there,
it's
pulkit added a comment.
The next two patches https://phab.mercurial-scm.org/D1042 and
https://phab.mercurial-scm.org/D1043, though sent by me are patches by Denis.
They were some good cleanups which I think was wrong to fold into my original
patch, hence sent separately.
REPOSITORY
rHG Me
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Other commands that support a state usually have an `--abort` flag that
restores the repo state to before the state. Let's add a similar one for
bisect. It will be
quark updated this revision to Diff 2649.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D950?vs=2451&id=2649
REVISION DETAIL
https://phab.mercurial-scm.org/D950
AFFECTED FILES
tests/run-tests.py
tests/test-run-tests.t
CHANGE DETAILS
diff --git a/t
quark updated this revision to Diff 2651.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1018?vs=2633&id=2651
REVISION DETAIL
https://phab.mercurial-scm.org/D1018
AFFECTED FILES
mercurial/pycompat.py
mercurial/selectors2.py
CHANGE DETAILS
diff --g
1 - 100 of 108 matches
Mail list logo
