D1755: logexchange: introduce helper function to get remote path name

pulkit updated this revision to Diff 4794. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1755?vs=4605&id=4794 REVISION DETAIL https://phab.mercurial-scm.org/D1755 AFFECTED FILES mercurial/logexchange.py tests/test-logexchange.t CHANGE DETAILS dif

D1581: rust: implementation of `hg`

kevincox added a comment. Overall it looks great. I added a bunch of nitpicks. The most common suggestion was to add some contextual information to error messages. Other then that mostly minor style improvements. Feel free to push back on anything you don't agree with :) INLINE COMMENTS >

[PATCH] hgweb: drop support of browsers that don't understand (BC)

# HG changeset patch # User Anton Shestakov # Date 1515666008 -28800 # Thu Jan 11 18:20:08 2018 +0800 # Node ID b9e397c45c99292bb3a285fa118360726b3aebf3 # Parent 98b87b8307e07ad3d93d3854508c362435d80c38 hgweb: drop support of browsers that don't understand (BC) Internet Explorer 8 and belo

[PATCH] pull: hold wlock for the full operation when --update is used

# HG changeset patch # User Boris Feld # Date 1515671879 0 # Thu Jan 11 11:57:59 2018 + # Node ID ba6760b14c221377e11f5a841b6794e7b1f858ad # Parent 58fda95a0202fc6327d1f5d9df26f7ff16538d57 # EXP-Topic update-wlock # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D1581: rust: implementation of `hg`

yuja added inline comments. INLINE COMMENTS > kevincox wrote in main.rs:133 > `CString::new(env.python_exe.as_ref().as_bytes())` That's more correct on Unix, but wouldn't work on Windows since native string is UTF-16 variant (Rust) or ANSI (Python 2.7). REPOSITORY rHG Mercurial REVISION DET

D1813: bookmarks: add bookmarks to hidden revs if directaccess config is set

yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > bookmarks.py:859 > +if ctx.hidden(): > +repo.ui.warn(_("accessing hidden changeset %s\n") % ctx) > +tgt = ctx.node() Perha

D1846: rust: avoid redundant 'static lifetime

yuja added a comment. I think it's new feature. Which Rust version should we support? https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1170-2017-04-27 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1846 To: indygreg, #hg-reviewers Cc: yuja

D1581: rust: implementation of `hg`

kevincox added inline comments. INLINE COMMENTS > yuja wrote in main.rs:133 > That's more correct on Unix, but wouldn't work on Windows since > native string is UTF-16 variant (Rust) or ANSI (Python 2.7). Oops, for some reason I thought this was in a unix block. `as_bytes()` isn't actually ava

Re: [PATCH] pull: hold wlock for the full operation when --update is used

On Thu, 11 Jan 2018 12:11:36 +, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1515671879 0 > # Thu Jan 11 11:57:59 2018 + > # Node ID ba6760b14c221377e11f5a841b6794e7b1f858ad > # Parent 58fda95a0202fc6327d1f5d9df26f7ff16538d57 > # EXP-Topic update-wlock > # Av

Re: [PATCH] hgweb: drop support of browsers that don't understand (BC)

On Thu, 11 Jan 2018 19:20:59 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1515666008 -28800 > # Thu Jan 11 18:20:08 2018 +0800 > # Node ID b9e397c45c99292bb3a285fa118360726b3aebf3 > # Parent 98b87b8307e07ad3d93d3854508c362435d80c38 > hgweb: drop supp

D1848: perf: do not import util.queue

This revision was automatically updated to reflect the committed changes. Closed by commit rHG998b585f156c: perf: do not import util.queue (authored by quark, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1848?vs=4792&id=4795 REVISION DET

D1847: rust: add TODO about lifetime of program_name variable

This revision was automatically updated to reflect the committed changes. Closed by commit rHG74bec9e74831: rust: add TODO about lifetime of program_name variable (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1847?vs

D1845: rust: move import of PathBuf

This revision was automatically updated to reflect the committed changes. Closed by commit rHG11c86ab69e67: rust: move import of PathBuf (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1845?vs=4789&id=4796 REVISION DE

[PATCH 1 of 5] log: make opt2revset table a module constant

# HG changeset patch # User Yuya Nishihara # Date 1514879917 -32400 # Tue Jan 02 16:58:37 2018 +0900 # Node ID da12c978eafe1b414122213c75ce149a5e8d8b5b # Parent 4b68ca118d8d316cff1fbfe260e8fdb0dae3e26a log: make opt2revset table a module constant Just makes it clear that the table isn't upd

[PATCH 4 of 5] log: use revsetlang.formatspec() thoroughly

# HG changeset patch # User Yuya Nishihara # Date 1514882221 -32400 # Tue Jan 02 17:37:01 2018 +0900 # Node ID 438dde28f8693b822898903325d2567c5e618c4b # Parent bab0b8954f8430710ddacf1db852a4420121f677 log: use revsetlang.formatspec() thoroughly This patch replaces %(val)s and %(val)r with

[PATCH 2 of 5] log: simplify 'x or ancestors(x)' expression

# HG changeset patch # User Yuya Nishihara # Date 1514880048 -32400 # Tue Jan 02 17:00:48 2018 +0900 # Node ID c0c7ecef4093eae82fcff7589e534f96c9e8e8c5 # Parent da12c978eafe1b414122213c75ce149a5e8d8b5b log: simplify 'x or ancestors(x)' expression 'ancestors(x)' includes 'x'. diff --git a/m

[PATCH 3 of 5] log: use revsetlang.formatspec() to concatenate list expression

# HG changeset patch # User Yuya Nishihara # Date 1514880798 -32400 # Tue Jan 02 17:13:18 2018 +0900 # Node ID bab0b8954f8430710ddacf1db852a4420121f677 # Parent c0c7ecef4093eae82fcff7589e534f96c9e8e8c5 log: use revsetlang.formatspec() to concatenate list expression This rewrites 'not ancest

[PATCH 5 of 5] log: rewrite --follow-first -rREV like --follow for consistency (BC)

# HG changeset patch # User Yuya Nishihara # Date 1512897933 -32400 # Sun Dec 10 18:25:33 2017 +0900 # Node ID 7c2c82f67697a0957afaa9b4f450d7b03eaa9536 # Parent 438dde28f8693b822898903325d2567c5e618c4b log: rewrite --follow-first -rREV like --follow for consistency (BC) This helps fixing th

D1591: visibility: improve the message when accessing filtered obsolete rev

yuja added inline comments. INLINE COMMENTS > context.py:446 > +reason = obsutil._getfilteredreason(unfilteredrepo, ctx) > +msg = _("hidden revision '%s' %s") % (changeid, reason) > +else: Not translatable. Needs a table of {'pruned': _("hidden revision '%s' i

D1591: visibility: improve the message when accessing filtered obsolete rev

yuja added inline comments. INLINE COMMENTS > obsutil.py:871 > +""" > +successors = successorssets(unfilteredrepo, ctx.node()) > +fate = _getobsfate(successors) Maybe it's okay to pass a "filtered" repo to this function as `templatekw.showsuccessorssets()` does. REPOSITORY rHG Mer

D1795: py3: use pycompat.bytestr() instead of str()

yuja added a comment. `bytes()` or `"%d"` is preferred. Can you send a follow up? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1795 To: pulkit, #hg-reviewers, durin42 Cc: yuja, mercurial-devel ___ Mercurial-devel mai

D1797: py3: make sure we open the file to write in bytes mode

yuja added inline comments. INLINE COMMENTS > subrepo.py:844 > > -fp = self._repo.vfs("hgrc", "w", text=True) > +fp = self._repo.vfs("hgrc", "wb", text=True) > try: No. Here we explicitly states that we want to open a file in "text" mode. Needs something l

Re: [PATCH 2 of 2 V2] filterlang: add a small language to filter files

On Thu, 11 Jan 2018 00:17:39 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1515641014 18000 > # Wed Jan 10 22:23:34 2018 -0500 > # Node ID 548e748cb3f4eea0aedb36a2b2e9fe3b77ffb263 > # Parent 962b2bdd70d094ce4bf9a8135495788166b04510 > filterlang: add a sma

Re: [PATCH 2 of 2 V2] filterlang: add a small language to filter files

> On Jan 11, 2018, at 10:16 AM, Yuya Nishihara wrote: > >> On Thu, 11 Jan 2018 00:17:39 -0500, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1515641014 18000 >> # Wed Jan 10 22:23:34 2018 -0500 >> # Node ID 548e748cb3f4eea0aedb36a2b2e9fe3b77ffb263 >> # Pare

D1581: rust: implementation of `hg`

ruuda added a comment. Awesome! I have just a few things that could be written more briefly. INLINE COMMENTS > build.rs:39 > +let script = "import sysconfig; \ > +c = sysconfig.get_config_vars(); \ > +print('SEPARATOR STRING'.join('%s=%s' % i for i in c.items()))"; You can safely indent

D1846: rust: avoid redundant 'static lifetime

durin42 added a comment. In https://phab.mercurial-scm.org/D1846#31265, @yuja wrote: > I think it's new feature. Which Rust version should we support? > > https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1170-2017-04-27 Hm, that's release notes from April of 2

D1846: rust: avoid redundant 'static lifetime

This revision was automatically updated to reflect the committed changes. Closed by commit rHG24b5106e3e1e: rust: avoid redundant 'static lifetime (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1846?vs=4790&id=4798 R

D1846: rust: avoid redundant 'static lifetime

glandium added a comment. > To my understanding, as long as we're only using the stable channel, we should be fine for the binaries we're building being packageable even on slower-moving distros like Debian. Slow-moving distros like Debian don't update the rust compiler. Debian stable

D1846: rust: avoid redundant 'static lifetime

durin42 added a comment. In https://phab.mercurial-scm.org/D1846#31298, @glandium wrote: > > To my understanding, as long as we're only using the stable channel, we should be fine for the binaries we're building being packageable even on slower-moving distros like Debian. > > Slow-

D1846: rust: avoid redundant 'static lifetime

glandium added a comment. > but it's okay to depend on backports or rustup to /build/ packages The only exception where it's okay is, essentially, Firefox. With a backport of the rust compiler landing in stable about once a year, and even then it won't replace the version in stable. See

Re: [PATCH 2 of 2 V2] filterlang: add a small language to filter files

On Thu, 11 Jan 2018 11:13:57 -0500, Matt Harbison wrote: On Jan 11, 2018, at 10:16 AM, Yuya Nishihara wrote: On Thu, 11 Jan 2018 00:17:39 -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1515641014 18000 # Wed Jan 10 22:23:34 2018 -0500 # Node ID 548e748

Switching to a date-based version scheme?

Mercurial's version numbers (currently 4.4, soon to be 4.5) mean little to nothing. Mercurial's existing .. version scheme doesn't honor semantic versioning in the traditional sense. API guarantees are that each quarterly X.Y release generally maintains API compatibility within the release but ther