mharbison72 added inline comments.
INLINE COMMENTS
> test-narrow-strip.t:81
> + saved backup bundle to $TESTTMP/narrow/.hg/strip-backup/*-backup.hg (glob)
> + $ hg unbundle .hg/strip-backup/*-backup.hg
> + adding changesets
The test failures here on Windows seem to be a case of incoming and u
On Tue, 13 Feb 2018 08:38:27 -0500, Yuya Nishihara wrote:
On Tue, 13 Feb 2018 07:58:50 -0500, Matt Harbison wrote:
> On Feb 13, 2018, at 6:27 AM, Yuya Nishihara wrote:
>
>> On Mon, 12 Feb 2018 22:17:35 -0500, Matt Harbison wrote:
>> # HG changeset patch
>> # User Matt Harbison
>> # Date 151
70 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/4224f26c0d35
changeset: 36162:4224f26c0d35
user:Sandu Turcan
date:Tue Feb 13 14:39:02 2018 -0500
summary: narrow: fix for getting the username when running http server
https://www.mercurial-scm.org/re
idlsoft added inline comments.
INLINE COMMENTS
> martinvonz wrote in narrowbundle2.py:331
> But you're okay with this version for now? This commit is currently the
> bottom-most draft commit in the "committed" repo, so please accept it if
> you're okay with it. I would have accepted, but I saw
indygreg added a comment.
I think it's fine for now. I accepted this commit.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2231
To: idlsoft, #hg-reviewers, durin42
Cc: martinvonz, indygreg, mercurial-devel
___
Mercuri
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG72812ad205d1: wireprotoserver: return to using iscmd()
method (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2285?vs=5772&id
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
FWIW, I plan to add a mechanism to `@wireprotocommand` to declare which
protocols the command is enabled for. I'll likely have those patches within a
week. But until then, we can restor
martinvonz added inline comments.
INLINE COMMENTS
> indygreg wrote in narrowbundle2.py:331
> `REMOTE_USER` is an HTTP-ism and I think it is a layering violation to look
> for `REMOTE_USER` in code that is supposed to be protocol agnostic.
>
> What I'm trying to say is I think we'll need to twea
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was teased out in part so remotefilelog could disable an old
protocol method over http. It got dropped accidentally in the recent
refactor, but the code was
16 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/29dd37a418aa
changeset: 36146:29dd37a418aa
user:Augie Fackler
date:Thu Jan 25 21:16:28 2018 -0500
summary: bdiff: write a native version of splitnewlines
https://www.mercurial-scm.org/repo/hg/rev/6eb7
https://bz.mercurial-scm.org/show_bug.cgi?id=5792
Bug ID: 5792
Summary: include bookmarks in bundle2 file generation
Product: Mercurial
Version: unspecified
Hardware: PC
OS: Linux
Status: UNCONFIRMED
Sever
durin42 added a comment.
thanks, I had an amend misfire
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2281
To: durin42, pulkit, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercur
durin42 updated this revision to Diff 5769.
durin42 marked an inline comment as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2281?vs=5765&id=5769
REVISION DETAIL
https://phab.mercurial-scm.org/D2281
AFFECTED FILES
contrib/python3-whitelist
CH
durin42 updated this revision to Diff 5768.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2280?vs=5764&id=5768
REVISION DETAIL
https://phab.mercurial-scm.org/D2280
AFFECTED FILES
hgext/remotenames.py
CHANGE DETAILS
diff --git a/hgext/remotenames.py
pulkit requested changes to this revision.
pulkit added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> remotenames.py:65
>
> -class lazyremotenamedict(DictMixin):
> +class lazyremotenamedict(dictmixin):
> """
unrelated change? This should be folded in pr
martinvonz added inline comments.
INLINE COMMENTS
> dateutil.py:14-19
> +from ..i18n import _
> +from .. import (
> encoding,
> error,
> -i18n,
> -node as nodemod,
> -policy,
> pycompat,
> )
What else do you foresee moving into the util/ directory? Perhaps these?
REP
lothiraldan added a comment.
I've resent the series as https://phab.mercurial-scm.org/D2282 as a single
changeset. I've included a note for extension authors with a link to the old
series to more easily bisect the changeset breaking their extension.
Do you think it would be hard to updat
lothiraldan updated this revision to Diff 5767.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2282?vs=5766&id=5767
REVISION DETAIL
https://phab.mercurial-scm.org/D2282
AFFECTED FILES
contrib/synthrepo.py
hgext/blackbox.py
hgext/churn.py
hgext/c
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
With this commit, util.py lose 262 lines
Note for extensions author, if this commit breaks your extension, you can pull
the step-by-step split here to hel
martinvonz requested changes to this revision.
martinvonz added a comment.
This revision now requires changes to proceed.
Also make this commit back out
https://phab.mercurial-scm.org/rHG30d0cb279bacf791577e90124b2a94018588f0b8?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercu
durin42 updated this revision to Diff 5765.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2281?vs=5763&id=5765
REVISION DETAIL
https://phab.mercurial-scm.org/D2281
AFFECTED FILES
contrib/python3-whitelist
hgext/remotenames.py
CHANGE DETAILS
diff
durin42 added a comment.
In https://phab.mercurial-scm.org/D2280#37674, @yuja wrote:
> "would that be preferable?"
>
> Perhaps. We'll need that anyway to get around demandimport.
I don't think we do (python3 demandimport is slightly nicer in this regard),
but I've done it anyw
durin42 updated this revision to Diff 5764.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2280?vs=5762&id=5764
REVISION DETAIL
https://phab.mercurial-scm.org/D2280
AFFECTED FILES
hgext/remotenames.py
CHANGE DETAILS
diff --git a/hgext/remotenames.py
queued for hglib, thanks for the review Yuya!
> On Feb 15, 2018, at 07:12, Yuya Nishihara wrote:
>
> On Wed, 14 Feb 2018 15:11:33 +0100, Gábor Stefanik wrote:
>> # HG changeset patch
>> # User Gábor Stefanik
>> # Date 1518443649 -3600
>> # Mon Feb 12 14:54:09 2018 +0100
>> # Node ID b5d058
yuja added a comment.
"would that be preferable?"
Perhaps. We'll need that anyway to get around demandimport.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2280
To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel
__
"would that be preferable?"
Perhaps. We'll need that anyway to get around demandimport.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
# HG changeset patch
# User Anton Shestakov
# Date 1518700497 -28800
# Thu Feb 15 21:14:57 2018 +0800
# Node ID 44ca07c710e009ac64f402ff005130231a44178b
# Parent e4803e41e488aa52e56280bfd6bce4156dc402a6
hgweb: show dates recorded in obsolescence markers
Dates of operations that obsolete com
# HG changeset patch
# User Anton Shestakov
# Date 1518699931 -28800
# Thu Feb 15 21:05:31 2018 +0800
# Node ID e4803e41e488aa52e56280bfd6bce4156dc402a6
# Parent 7c6900cc30ee801b782086d98fdcea878eba2bab
gitweb: make span.age CSS selector more specific
This set of CSS properties is only used
durin42 added inline comments.
INLINE COMMENTS
> remotenames.py:25-28
> +try:
> +from UserDict import DictMixin
> +except ImportError:
> +from collections import MutableMapping as DictMixin
This import style irritates the import checker. We could do
try
import UserDict
dictmixin =
durin42 created this revision.
Herald added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2281
AFFECTED FILES
contrib/python3-whitelist
CHANGE DETAILS
diff --
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
test-logexchange.t doesn't pass after this, but at least the
remotenames extension can be imported.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mer
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This includes a full backout of
https://phab.mercurial-scm.org/rHG59affe7e01d4df54acc91829fe7caf4e8020eea1. Per
the review, we'd rather
adapt the API to behave l
# HG changeset patch
# User Yuya Nishihara
# Date 1451189331 -32400
# Sun Dec 27 13:08:51 2015 +0900
# Node ID 946e9e3e4453780ef4ea9120f3f3dd1acbf5ad44
# Parent 257f3651ada9dbcb2cb97bbe799fa59c57619cc6
hgweb: translate Abort in help command to 404 error
c3784e3c3e8d changed the exception ty
# HG changeset patch
# User Yuya Nishihara
# Date 1515380983 -32400
# Mon Jan 08 12:09:43 2018 +0900
# Node ID 74f1b48042c6595ae49aaee050d1eac3b672fe6d
# Parent d5c440f7e2840eae190246159ec31d74b4df655f
help: use cmdutil.parsealiases() to resolve command name
This seems slightly better than
# HG changeset patch
# User Yuya Nishihara
# Date 1451193207 -32400
# Sun Dec 27 14:13:27 2015 +0900
# Node ID d5c440f7e2840eae190246159ec31d74b4df655f
# Parent 946e9e3e4453780ef4ea9120f3f3dd1acbf5ad44
help: list deprecated and experimental extensions if --verbose
This is common in the othe
# HG changeset patch
# User Yuya Nishihara
# Date 1515294573 -32400
# Sun Jan 07 12:09:33 2018 +0900
# Node ID dd83fb7ec9991355495a72c15b718561780b
# Parent 5a8caa27847f9b8f040589ed182522904f8a9574
templatefilters: add dirname() filter
This is different from stripdir() in that the last
# HG changeset patch
# User Yuya Nishihara
# Date 1515293587 -32400
# Sun Jan 07 11:53:07 2018 +0900
# Node ID 437212580debfa26ee266598f64139b4df5a9cfd
# Parent e7f4a2b09c484d4313aa6624470d92aef3ad5a10
cmdutil: expand filename format string by templater (BC)
This is BC because '{}' could be
# HG changeset patch
# User Yuya Nishihara
# Date 1515290693 -32400
# Sun Jan 07 11:04:53 2018 +0900
# Node ID edc874f03cf670040c4a3cfc257fec1a171e0da6
# Parent 73b14c318785c080637fad3100064fe2c9ca1b8b
templater: extract function scanning template string
This provides a tokenizer-level view
# HG changeset patch
# User Yuya Nishihara
# Date 1515291976 -32400
# Sun Jan 07 11:26:16 2018 +0900
# Node ID 73b14c318785c080637fad3100064fe2c9ca1b8b
# Parent 257f3651ada9dbcb2cb97bbe799fa59c57619cc6
cmdutil: narrow scope of KeyError in makefilename()
It seemed too broad to catch a standa
# HG changeset patch
# User Yuya Nishihara
# Date 1515291685 -32400
# Sun Jan 07 11:21:25 2018 +0900
# Node ID 5a8caa27847f9b8f040589ed182522904f8a9574
# Parent edc874f03cf670040c4a3cfc257fec1a171e0da6
templater: add function to help substituting patterns in template string
This will be use
# HG changeset patch
# User Yuya Nishihara
# Date 1515377466 -32400
# Mon Jan 08 11:11:06 2018 +0900
# Node ID e7f4a2b09c484d4313aa6624470d92aef3ad5a10
# Parent dd83fb7ec9991355495a72c15b718561780b
templatekw: add {reporoot} keyword
The "%b" in filename format string will be replaced wi
67 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/a2a6e724d61a
changeset: 36079:a2a6e724d61a
user:Augie Fackler
date:Mon Jan 29 16:19:33 2018 -0500
summary: narrow: import experimental extension from narrowhg revision
cb51d673e9c5
https://www.mercur
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2278
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git a/mercurial/commands.py b/mercu
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6ea0b78ddcac: py3: use util.forcebytestr instead of str for
converting errors to bytes (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG257f3651ada9: githelp: cast commands to bytes (authored by
indygreg, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D2165?vs=5466&id=5759#toc
REPOSITORY
rHG Mercurial
CHANGE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGddeb7653b31c: py3: use pycompat.bytestr to convert str to
bytes (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2261?vs=5726&i
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
(just clarify the current state of this patch)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2079
To: indygreg, #hg-reviewers, lothiraldan, yuja
Cc: du
On Wed, 14 Feb 2018 15:11:33 +0100, Gábor Stefanik wrote:
> # HG changeset patch
> # User Gábor Stefanik
> # Date 1518443649 -3600
> # Mon Feb 12 14:54:09 2018 +0100
> # Node ID b5d05859a5d7956024b169dd7fe53a6ea45a4d67
> # Parent 1085c904d8c04d51c6897027fe9c7bae0964b64b
> client: ignore clos
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
logfmt is the format which is used to format the log output for that
namespace.
This patch passes "remote {bookmark|branch}: %s" as the logfmt. Space is not
add
pulkit added a comment.
In https://phab.mercurial-scm.org/D2108#35150, @indygreg wrote:
> I'm find with you sending more parts to this series. Especially if they
delete code: if they delete code then my review of the import will be a review
of the final state of the code post deletions.
pulkit added a comment.
In https://phab.mercurial-scm.org/D2096#35158, @indygreg wrote:
> I see the following high-level potential use cases for infinitepush:
>
> 1. A hosting/repo management alternative to //forks//
> 2. A central repository for submitting changesets to a service (e
51 matches
Mail list logo