[PATCH 2 of 2 RFC] test-lfs-test-server: add a testcase for `hg serve`

2018-02-17 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1518937262 18000 # Sun Feb 18 02:01:02 2018 -0500 # Node ID 253cb78bcfe06c3cefc7a675e08024e970e501d1 # Parent ba2e8627d87cfaca00931fe2dcee738c3c9a4f9d test-lfs-test-server: add a testcase for `hg serve` The output

[PATCH 1 of 2 RFC] lfs: add support for serving blob files

2018-02-17 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1518937155 18000 # Sun Feb 18 01:59:15 2018 -0500 # Node ID ba2e8627d87cfaca00931fe2dcee738c3c9a4f9d # Parent 868bb2821e292cdda6050f229ade1af42d52c9e6 lfs: add support for serving blob files There's a ton more to do,

D2315: py3: use default dict iterator instead of iterkeys

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These are the easy cases. Some cases in manifest.py will require more careful inspection. REPOSITORY rHG Mercurial REVISION DETAIL

D2317: manifest: use list(dict) instead of dict.keys() to get a list of keys

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2317 AFFECTED FILES mercurial/manifest.py CHANGE DETAILS diff --git a/mercurial/manifest.py

D2316: manifest: correct the one use of iterkeys() on a dict

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As far as I can tell, this is the only iterkeys() in this file that was actually on a dict. The rest are on custom manifest types. REPOSITORY rHG Mercurial

D2318: py3: whitelist another two passing tests

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2318 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D2313: httppeer: headers are native strings

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2313 AFFECTED FILES mercurial/httppeer.py CHANGE DETAILS diff --git a/mercurial/httppeer.py

D2314: py3: whitelist five more passing tests

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2314 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D2312: hgweb: header dict entries are native strings

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2312 AFFECTED FILES mercurial/hgweb/common.py CHANGE DETAILS diff --git a/mercurial/hgweb/common.py

D2310: wireprotoserver: py3 helpfully calls adds HTTP_ to CONTENT_LENGTH

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Just handle both with a membership check, preferring the HTTP_ namespaced version. Sigh. REPOSITORY rHG Mercurial REVISION DETAIL

D2311: keepalive: headers are native strings, mark them as such

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2311 AFFECTED FILES mercurial/keepalive.py CHANGE DETAILS diff --git a/mercurial/keepalive.py

D2307: tags: don't feed both int and None to min()

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY They're not comparable on Python 3, and we can just map None to 0. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2307 AFFECTED

D2308: hgweb_mod: partially undo 8afc25e7effc to fix py3

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We now bytes-ify the entire request, so this is wrong. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2308 AFFECTED FILES

D2309: tests: port inline Python in test-http-branchmap.t to Python 3

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2309 AFFECTED FILES tests/test-http-branchmap.t CHANGE DETAILS diff --git

D2301: rebase: sort roots by revision

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously we were sorting them by whatever implicit sort order we got between changectx instances. Sorting by rev at least makes some sense, so I chose that.

D2305: webcommands: use pycompat.strkwargs as needed

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2305 AFFECTED FILES mercurial/hgweb/webcommands.py CHANGE DETAILS diff --git

D2306: tests: fix get-with-headers.py on python3 when writing to stdout

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2306 AFFECTED FILES tests/get-with-headers.py CHANGE DETAILS diff --git a/tests/get-with-headers.py

D2303: bundle2: use pycompat.strkwargs as needed

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2303 AFFECTED FILES mercurial/bundle2.py CHANGE DETAILS diff --git a/mercurial/bundle2.py

D2302: tests: add b prefixes to test-rebase-dest.t

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just b prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2302 AFFECTED FILES tests/test-rebase-dest.t CHANGE

D2304: webcommands: unpack contents of length-1 dict portably

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY ((k,v),) = dict.items() was suggested by some friends, but I feel like that's maybe too clever? REPOSITORY rHG Mercurial REVISION DETAIL

D2300: httppeer: use %d to format int

2018-02-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2300 AFFECTED FILES mercurial/httppeer.py CHANGE DETAILS diff --git a/mercurial/httppeer.py

[PATCH 3 of 4 V2] templater: add option to parse template string just like raw string literal

2018-02-17 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518922406 -32400 # Sun Feb 18 11:53:26 2018 +0900 # Node ID 045d2ccca9c6979a31f88e4ac0c69728f4b56837 # Parent 35140c6c0e66f16061bf2757852655b476bacafa templater: add option to parse template string just like raw string

[PATCH 4 of 4 V2] cmdutil: expand filename format string by templater (BC)

2018-02-17 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1515293587 -32400 # Sun Jan 07 11:53:07 2018 +0900 # Node ID 34976879e67e40c36b69090360fcd72af3274160 # Parent 045d2ccca9c6979a31f88e4ac0c69728f4b56837 cmdutil: expand filename format string by templater (BC) This is BC

[PATCH 2 of 4 V2] cmdutil: reorder optional arguments passed to makefileobj()

2018-02-17 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518919095 -32400 # Sun Feb 18 10:58:15 2018 +0900 # Node ID 35140c6c0e66f16061bf2757852655b476bacafa # Parent 44e712e75c4046df45ad5c8f6731aaa0633a6a1b cmdutil: reorder optional arguments passed to makefileobj() **props will

[PATCH 1 of 4 V2] cmdutil: strip "%m" pattern (first line of commit message) from both ends

2018-02-17 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518918864 -32400 # Sun Feb 18 10:54:24 2018 +0900 # Node ID 44e712e75c4046df45ad5c8f6731aaa0633a6a1b # Parent 2b00dda6dad9f775ccb0e1a537c603843bb6511c cmdutil: strip "%m" pattern (first line of commit message) from both ends

Re: [PATCH 5 of 5] extensions: reject any unicode strings in tables before loading

2018-02-17 Thread Augie Fackler
On Sat, Feb 17, 2018 at 07:07:40PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1518855869 -32400 > # Sat Feb 17 17:24:29 2018 +0900 > # Node ID 5fef8aefa687fc61e62f0fd0decc7a9158150d3f > # Parent

D2277: remotenames: don't use the default value of logfmt for namespaces

2018-02-17 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG18e29c65bc5c: remotenames: dont use the default value of logfmt for namespaces (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2296: py3: whitelist test-pull-http.t

2018-02-17 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd3fa5e106e65: py3: whitelist test-pull-http.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2296?vs=5801=5816 REVISION

D2299: py3: port f to Python 3

2018-02-17 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc69e78ef2b54: py3: port f to Python 3 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2299?vs=5812=5814 REVISION DETAIL

D2292: scmutil: bytes-ify IOErrors before wrapping them in abort message

2018-02-17 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2b00dda6dad9: scmutil: bytes-ify IOErrors before wrapping them in abort message (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2292?vs=5813=5815#toc

Re: [PATCH 6 of 6] cmdutil: expand filename format string by templater (BC)

2018-02-17 Thread Yuya Nishihara
On Sat, 17 Feb 2018 13:13:57 -0500, Matt Harbison wrote: > On Thu, 15 Feb 2018 08:18:44 -0500, Yuya Nishihara wrote: > > # HG changeset patch > > # User Yuya Nishihara > > # Date 1515293587 -32400 > > # Sun Jan 07 11:53:07 2018 +0900 > > # Node ID

D2292: scmutil: bytes-ify IOErrors before wrapping them in abort message

2018-02-17 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5813. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2292?vs=5797=5813 REVISION DETAIL https://phab.mercurial-scm.org/D2292 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py

D2299: py3: port f to Python 3

2018-02-17 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This involved a lot of b'' literals, conversion from %s to %d, and using a hashing mechanism that returns bytes instead of str. REPOSITORY rHG Mercurial

D2298: internals: document bundle2 format

2018-02-17 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It seems like a good idea to have thorough documentation of the bundle2 data format, including the format of each part and the capabilities. The added

Re: [PATCH 6 of 6] cmdutil: expand filename format string by templater (BC)

2018-02-17 Thread Matt Harbison
On Thu, 15 Feb 2018 08:18:44 -0500, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1515293587 -32400 # Sun Jan 07 11:53:07 2018 +0900 # Node ID 437212580debfa26ee266598f64139b4df5a9cfd # Parent

D2278: bundle: updates the help text for hg bundle (issue5744) [bugzilla]

2018-02-17 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGff36116f30f3: bundle: updates the help text for hg bundle (issue5744) (authored by khanchi97, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2278?vs=5794=5809#toc REPOSITORY

D2133: py3: replace file() with open() in test-convert-git.t

2018-02-17 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG868bb2821e29: py3: replace file() with open() in test-convert-git.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2278: bundle: updates the help text for hg bundle (issue5744) [bugzilla]

2018-02-17 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued, thanks. Dropped `[` `]` from `[DEST]` because `[]` is the notation meaning that the `DEST` argument may be omitted. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2278 To: khanchi97, #hg-reviewers, yuja Cc: yuja, mercurial-devel

D2133: py3: replace file() with open() in test-convert-git.t

2018-02-17 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 5808. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2133?vs=5396=5808 REVISION DETAIL https://phab.mercurial-scm.org/D2133 AFFECTED FILES tests/test-convert-git.t

D2297: py3: backout 7c54917b31f6 to make sure second argument of open() is str

2018-02-17 Thread yuja (Yuya Nishihara)
yuja added a comment. Can you elaborate why you think it wasn't a good idea to replace open()? IMHO, it's as hackish as replacing '' with b''. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2297 To: pulkit, #hg-reviewers Cc: yuja, mercurial-devel

Re: D2297: py3: backout 7c54917b31f6 to make sure second argument of open() is str

2018-02-17 Thread Yuya Nishihara
Can you elaborate why you think it wasn't a good idea to replace open()? IMHO, it's as hackish as replacing '' with b''. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH 2 of 5] py3: fix bytes-unicode dance while building docstring of extdiff

2018-02-17 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518858891 -32400 # Sat Feb 17 18:14:51 2018 +0900 # Node ID c9ac00127748f7ba34ed4119d2802fba4945235a # Parent d5e06baf9e6bc6705fb4c7e7ab1926bca0a2bae3 py3: fix bytes-unicode dance while building docstring of extdiff diff

[PATCH 5 of 5] extensions: reject any unicode strings in tables before loading

2018-02-17 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518855869 -32400 # Sat Feb 17 17:24:29 2018 +0900 # Node ID 5fef8aefa687fc61e62f0fd0decc7a9158150d3f # Parent 320a41b6eba2532ffbcf2aaa50ec73ecb00f06d4 extensions: reject any unicode strings in tables before loading This

[PATCH 4 of 5] py3: make test-extdiff.t pass on Python 3

2018-02-17 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518859215 -32400 # Sat Feb 17 18:20:15 2018 +0900 # Node ID 320a41b6eba2532ffbcf2aaa50ec73ecb00f06d4 # Parent d21d2aee7b586eb509bee6c8577efc00fed467f6 py3: make test-extdiff.t pass on Python 3 diff --git

[PATCH 3 of 5] py3: make regexp patterns bytes in extdiff

2018-02-17 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518858937 -32400 # Sat Feb 17 18:15:37 2018 +0900 # Node ID d21d2aee7b586eb509bee6c8577efc00fed467f6 # Parent c9ac00127748f7ba34ed4119d2802fba4945235a py3: make regexp patterns bytes in extdiff diff --git a/hgext/extdiff.py

[PATCH 1 of 5] py3: factor out byterepr() which returns an asciified value on py3

2018-02-17 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518858596 -32400 # Sat Feb 17 18:09:56 2018 +0900 # Node ID d5e06baf9e6bc6705fb4c7e7ab1926bca0a2bae3 # Parent c57892ccbb414bb79784dcbaba3ff958ca8915f0 py3: factor out byterepr() which returns an asciified value on py3 diff

D2297: py3: backout 7c54917b31f6 to make sure second argument of open() is str

2018-02-17 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This backouts changeset https://phab.mercurial-scm.org/rHG7c54917b31f6200449bb7afd253ca0561288456a in which code to prevent adding b'' in front of second

D2295: py3: get bytes-repr of network errors portably

2018-02-17 Thread yuja (Yuya Nishihara)
yuja added a comment. Here the exception type is limited, so using `bytestr()` should be okay. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2295 To: durin42, #hg-reviewers Cc: yuja, pulkit, mercurial-devel ___

D2295: py3: get bytes-repr of network errors portably

2018-02-17 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc57892ccbb41: py3: get bytes-repr of network errors portably (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2290: printenv: port to python3

2018-02-17 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcdf4eecddbe5: printenv: port to python3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2290?vs=5795=5802 REVISION DETAIL

D2293: tests: add some b prefixes in test-http-bundle1.t

2018-02-17 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG77abb1ba6393: tests: add some b prefixes in test-http-bundle1.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2291: hgweb: correctly bytes-ify status, not string-ify

2018-02-17 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9a97ad537561: hgweb: correctly bytes-ify status, not string-ify (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2294: hgweb: open server logs in binary mode

2018-02-17 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd527803576b2: hgweb: open server logs in binary mode (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2294?vs=5799=5805

D2295: py3: get bytes-repr of network errors portably

2018-02-17 Thread pulkit (Pulkit Goyal)
pulkit added a comment. For converting error messages to bytes, util.forcebytestr() is preferred. https://phab.mercurial-scm.org/D2269#inline-5791 INLINE COMMENTS > request.py:125 > +self.server_write = self._start_response( > +pycompat.sysstr(status),

D2292: scmutil: bytes-ify IOErrors before wrapping them in abort message

2018-02-17 Thread pulkit (Pulkit Goyal)
pulkit added a comment. It's recommended using `util.forcebytestr()` to convert error messages to bytes. https://phab.mercurial-scm.org/D2269#inline-5791 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2292 To: durin42, #hg-reviewers Cc: pulkit, mercurial-devel

[Bug 5796] New: --config http_proxy.host not accepting 'https' URLs

2018-02-17 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5796 Bug ID: 5796 Summary: --config http_proxy.host not accepting 'https' URLs Product: Mercurial Version: 3.7.3 Hardware: PC OS: Linux Status: UNCONFIRMED