Re: [PATCH] test-acl: mock up util.getuser() to trust $LOGNAME on Windows

On Tue, 27 Feb 2018 09:57:25 -0500, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1519738677 -32400 # Tue Feb 27 22:37:57 2018 +0900 # Node ID 27a69d7c94488b6a21ce4ddbcdb183ce335714e1 # Parent

D2361: remotenames: don't inherit the remotenames class from dict class

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1bd132a021dd: remotenames: dont inherit the remotenames class from dict class (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH] run-tests: resume raising an exception when a server fails to start

On Tue, 27 Feb 2018 00:03:19 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1519706069 18000 > # Mon Feb 26 23:34:29 2018 -0500 > # Node ID 329a10c33dc1234d8e33b1b06c6c072bf6fe8cce > # Parent

Re: [PATCH V2] run-tests: cache hghave results

On Mon, 26 Feb 2018 22:36:23 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1519597345 18000 > # Sun Feb 25 17:22:25 2018 -0500 > # Node ID 4836a9a322caa5545e2dbf7dca3dbdbe060b5f0a > # Parent

D2471: debugcommands: support for triggering push protocol

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The mechanism for pushing to a remote is a bit more complicated than other commands. On SSH, we wait for a positive reply from the server before we start

D2471: debugcommands: support for triggering push protocol

indygreg updated this revision to Diff 6151. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2471?vs=6150=6151 REVISION DETAIL https://phab.mercurial-scm.org/D2471 AFFECTED FILES mercurial/debugcommands.py tests/test-ssh-proto-unbundle.t CHANGE

mercurial@36438: 25 new changesets

25 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/44c4a38bf563 changeset: 36414:44c4a38bf563 user:Yuya Nishihara date:Fri Feb 23 23:09:58 2018 +0900 summary: diff: do not split function name if character encoding is unknown

D2486: wireproto: don't expose changegroupsubset capability if not available

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We just marked the changegroupsubset command as only available to version 1 of the wire transports. There is a capability of the same name of the command that

D2485: wireproto: don't expose legacy commands to version 2 of wire protocol

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have the ability to control which transports a wire protocol command is exposed on, let's put it to use. We flag the "branches," "changegroup,"

D2484: wireprotoserver: identify requests via version 2 of SSH protocol as such

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The protocol handler needs to advertise itself as version 2 in order for a future feature to work. REPOSITORY rHG Mercurial REVISION DETAIL

D2481: wireproto: use named arguments for commandentry

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We'll be adding more arguments in upcoming commits. Using named arguments will make the code easier to read. REPOSITORY rHG Mercurial REVISION DETAIL

D2482: wireprotoserver: move SSHV1 and SSHV2 constants to wireprototypes

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY To avoid a cycle between modules in an upcoming commit. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2482 AFFECTED FILES

D2483: wireproto: allow wire protocol commands to declare transport support

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, wire protocol commands are exposed on all transports. Some wire protocol commands are only supported or sensical on some transports. In the future,

D2464: debugcommands: add debugserve command

indygreg updated this revision to Diff 6179. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2464?vs=6138=6179 REVISION DETAIL https://phab.mercurial-scm.org/D2464 AFFECTED FILES mercurial/debugcommands.py tests/test-completion.t tests/test-help.t

[PATCH 9 of 9] templatekw: add compatlist() as a replacement for showlist()

# HG changeset patch # User Yuya Nishihara # Date 1519542877 -32400 # Sun Feb 25 16:14:37 2018 +0900 # Node ID 1a1f7b96d833af5a29d6d75580d083511ff388f6 # Parent e6b41f06c7bbcbc745814ec066c7f660d63d200f templatekw: add compatlist() as a replacement for showlist() Just like

[PATCH V2] run-tests: cache hghave results

# HG changeset patch # User Matt Harbison # Date 1519597345 18000 # Sun Feb 25 17:22:25 2018 -0500 # Node ID 4836a9a322caa5545e2dbf7dca3dbdbe060b5f0a # Parent 3bdd64ed150679886ee87341ab3fcdda4f23ffc7 run-tests: cache hghave results Spawning a process on Windows is

D2470: wireproto: allow direct stream processing for unbundle

joerg.sonnenberger updated this revision to Diff 6178. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2470?vs=6177=6178 REVISION DETAIL https://phab.mercurial-scm.org/D2470 AFFECTED FILES hgext/largefiles/proto.py mercurial/configitems.py

D2470: wireproto: allow direct stream processing for unbundle

joerg.sonnenberger updated this revision to Diff 6177. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2470?vs=6148=6177 REVISION DETAIL https://phab.mercurial-scm.org/D2470 AFFECTED FILES hgext/largefiles/proto.py mercurial/configitems.py

Re: [PATCH 1 of 2 V2] debug: add debugexplainunstable that explains instabilities

On Tue, 27 Feb 2018 21:11:17 +0800, Anton Shestakov wrote: > On Tue, 27 Feb 2018 20:45:21 +0900 > Yuya Nishihara wrote: > > > On Mon, 26 Feb 2018 22:05:26 +0800, Anton Shestakov wrote: > > > # HG changeset patch > > > # User Anton Shestakov > > > # Date

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

On Mon, 26 Feb 2018 05:45:03 -0500, Feld Boris wrote: On 13/02/2018 12:47, Yuya Nishihara wrote: On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1518448909 -3600 # Mon Feb 12 16:21:49

D2472: pycompat: prevent encoding or decoding values if not required

indygreg added a comment. I agree with @yuja here. I think we should strive to convert URLs to bytes (like most other internal types). Although I do realize that lots of stdlib code has... expectations. Is there a particular test failure you are tracking down with this fix? I've kind of got

Re: [PATCH 1 of 2 V2] debug: add debugexplainunstable that explains instabilities

On Mon, 26 Feb 2018 22:05:26 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1519649041 -28800 > # Mon Feb 26 20:44:01 2018 +0800 > # Node ID 0aa1728931cc2c2c7d6ee0f18e0618fc17add42a > # Parent

D2462: util: add a file object proxy that can notify observers

indygreg added inline comments. INLINE COMMENTS > lothiraldan wrote in util.py:535 > Could we define the `ours` set at the class level so an extension/subclass > could easily update it if needed? That's a good idea. I can do it as a follow-up. There are already a ton of commits in this series

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

On Mon, 26 Feb 2018 21:42:01 -0500, Matt Harbison wrote: > On Mon, 26 Feb 2018 05:45:03 -0500, Feld Boris > wrote: > > On 13/02/2018 12:47, Yuya Nishihara wrote: > >> On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: > >>> # HG changeset patch > >>> # User Boris Feld

[PATCH 3 of 9] templatekw: factor out function to build a list of files per status

# HG changeset patch # User Yuya Nishihara # Date 1519544134 -32400 # Sun Feb 25 16:35:34 2018 +0900 # Node ID e0a72c36b24883cf6dd62144e9b2ca7959fb8b23 # Parent 2f63464d7c83e597c467d930baa9f709186107b7 templatekw: factor out function to build a list of files per status

[PATCH 1 of 9] templatekw: extract non-templatekw function as getgraphnode()

# HG changeset patch # User Yuya Nishihara # Date 1519536512 -32400 # Sun Feb 25 14:28:32 2018 +0900 # Node ID 064d43a16f215e00bc3093733707fd7b9fa1bf56 # Parent 432b85a46717b6852b4550e210c72b21a67012ec templatekw: extract non-templatekw function as getgraphnode() Prepares

[PATCH 5 of 9] log: do not invoke templatekw.showobsfate() as a function

# HG changeset patch # User Yuya Nishihara # Date 1519537338 -32400 # Sun Feb 25 14:42:18 2018 +0900 # Node ID c5d3987504112f372d4d25dfa7e6dec1eb58d1af # Parent 6b3af7c365816188dea95c2a10b0ddcb50f818b8 log: do not invoke templatekw.showobsfate() as a function Prepares for

Re: [PATCH 1 of 2] acl: replace bare getpass.getuser() by platform function

On Sat, 24 Feb 2018 21:43:01 -0500, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1519524781 -32400 # Sun Feb 25 11:13:01 2018 +0900 # Node ID 03eff66adb3b53f9776628f83b6433ee7b57ee52 # Parent

Re: [PATCH 2 of 2 V2] hgweb: explain instabilities of unstable changesets

On Mon, 26 Feb 2018 22:05:27 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1519649061 -28800 > # Mon Feb 26 20:44:21 2018 +0800 > # Node ID 026f4c5a52a0070c5b712cad247818e6566d4748 > # Parent

[PATCH] run-tests: resume raising an exception when a server fails to start

# HG changeset patch # User Matt Harbison # Date 1519706069 18000 # Mon Feb 26 23:34:29 2018 -0500 # Node ID 329a10c33dc1234d8e33b1b06c6c072bf6fe8cce # Parent e8d37838f5df94798c035191db172456114029e4 run-tests: resume raising an exception when a server fails to

[PATCH] test-acl: mock up util.getuser() to trust $LOGNAME on Windows

# HG changeset patch # User Yuya Nishihara # Date 1519738677 -32400 # Tue Feb 27 22:37:57 2018 +0900 # Node ID 27a69d7c94488b6a21ce4ddbcdb183ce335714e1 # Parent 1a1f7b96d833af5a29d6d75580d083511ff388f6 test-acl: mock up util.getuser() to trust $LOGNAME on Windows The test

[PATCH 6 of 9] hgweb: make templater mostly compatible with log templates

# HG changeset patch # User Yuya Nishihara # Date 1513947578 -32400 # Fri Dec 22 21:59:38 2017 +0900 # Node ID 937e0cab3a4d11da84d2f62213901e7405e117ea # Parent c5d3987504112f372d4d25dfa7e6dec1eb58d1af hgweb: make templater mostly compatible with log templates Prepares for

[PATCH 8 of 9] templatekw: add compatdict() as a replacement for showdict()

# HG changeset patch # User Yuya Nishihara # Date 1519542199 -32400 # Sun Feb 25 16:03:19 2018 +0900 # Node ID e6b41f06c7bbcbc745814ec066c7f660d63d200f # Parent c0c1bdb2ae8781ea4b43dfa1019d437652956a41 templatekw: add compatdict() as a replacement for showdict() This is

[PATCH 7 of 9] templatekw: pass templater to _showlist() by an explicit argument

# HG changeset patch # User Yuya Nishihara # Date 1519541015 -32400 # Sun Feb 25 15:43:35 2018 +0900 # Node ID c0c1bdb2ae8781ea4b43dfa1019d437652956a41 # Parent 937e0cab3a4d11da84d2f62213901e7405e117ea templatekw: pass templater to _showlist() by an explicit argument

[PATCH 2 of 9] templatekw: switch non-showlist template keywords to new API

# HG changeset patch # User Yuya Nishihara # Date 1519533646 -32400 # Sun Feb 25 13:40:46 2018 +0900 # Node ID 2f63464d7c83e597c467d930baa9f709186107b7 # Parent 064d43a16f215e00bc3093733707fd7b9fa1bf56 templatekw: switch non-showlist template keywords to new API diff --git

[PATCH 4 of 9] templatekw: inline getfiles()

# HG changeset patch # User Yuya Nishihara # Date 1519544198 -32400 # Sun Feb 25 16:36:38 2018 +0900 # Node ID 6b3af7c365816188dea95c2a10b0ddcb50f818b8 # Parent e0a72c36b24883cf6dd62144e9b2ca7959fb8b23 templatekw: inline getfiles() It's just three lines. We don't need a

Re: [PATCH 1 of 2] acl: replace bare getpass.getuser() by platform function

On Tue, 27 Feb 2018 00:18:39 -0500, Matt Harbison wrote: > On Sat, 24 Feb 2018 21:43:01 -0500, Yuya Nishihara wrote: > > > # HG changeset patch > > # User Yuya Nishihara > > # Date 1519524781 -32400 > > # Sun Feb 25 11:13:01 2018 +0900 > > # Node ID

D2472: pycompat: prevent encoding or decoding values if not required

pulkit updated this revision to Diff 6176. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2472?vs=6152=6176 REVISION DETAIL https://phab.mercurial-scm.org/D2472 AFFECTED FILES mercurial/pycompat.py CHANGE DETAILS diff --git a/mercurial/pycompat.py

Re: [PATCH 1 of 2 V2] debug: add debugexplainunstable that explains instabilities

On Tue, 27 Feb 2018 20:45:21 +0900 Yuya Nishihara wrote: > On Mon, 26 Feb 2018 22:05:26 +0800, Anton Shestakov wrote: > > # HG changeset patch > > # User Anton Shestakov > > # Date 1519649041 -28800 > > # Mon Feb 26 20:44:01 2018 +0800 > > # Node ID

D2478: py3: add b'' prefixes in tests/test-extension.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2218f5bfafca: py3: add b prefixes in tests/test-extension.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2478?vs=6158=6173

D2480: py3: use print as a function in tests/test-hgrc.t

This revision was automatically updated to reflect the committed changes. Closed by commit rHG432b85a46717: py3: use print as a function in tests/test-hgrc.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2469: bookmarks: write bookmarks file deterministically

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbfb4494f846d: bookmarks: write bookmarks file deterministically (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2298: internals: document bundle2 format

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1fa35ca345a5: internals: document bundle2 format (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2298?vs=5811=6167

D2477: py3: convert os.devnull to bytes using pycompat.bytestr

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0e8b76644e20: py3: convert os.devnull to bytes using pycompat.bytestr (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2475: py3: make sure regexes are bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9e3cb58c7ab3: py3: make sure regexes are bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2475?vs=6155=6171 REVISION

D2479: py3: use '%d' to convert integers to bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG580f75f70f39: py3: use %d to convert integers to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2479?vs=6159=6175

D2457: py3: slice over bytes or use .startswith() to prevent getting ascii values

This revision was automatically updated to reflect the committed changes. Closed by commit rHG588048a6a8d3: py3: slice over bytes or use .startswith() to prevent getting ascii values (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2474: py3: use pycompat.strurl to convert url to str

This revision was automatically updated to reflect the committed changes. Closed by commit rHG698fe0f6eb5c: py3: use pycompat.strurl to convert url to str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2460: py3: convert bytes to str using encoding.strfromlocal

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd478c8cd89d1: py3: convert bytes to str using encoding.strfromlocal (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2459: py3: use encoding.strtolocal() to convert str to bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa918c996a881: py3: use encoding.strtolocal() to convert str to bytes (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2459?vs=6130=6165#toc REPOSITORY

D2468: phases: write phaseroots deterministically

This revision was automatically updated to reflect the committed changes. Closed by commit rHGab81e5a8fba5: phases: write phaseroots deterministically (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2468?vs=6146=6166

D2455: py3: use '%d' for integers instead of '%s'

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d58037c6ec0: py3: use %d for integers instead of %s (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2455?vs=6128=6161

D2453: py3: use email.utils module instead of email.Utils

This revision was automatically updated to reflect the committed changes. Closed by commit rHG39c9f339b692: py3: use email.utils module instead of email.Utils (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2472: pycompat: prevent encoding or decoding values if not required

yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. I'm 0 for this move. I'm not a fan of making function inputs and outputs obscure because we'll be likely to have a hard time to fix it in future. Mixing bytes and unicodes is

D2470: wireproto: allow direct stream processing for unbundle

lothiraldan added inline comments. INLINE COMMENTS > wireproto.py:980 > +def cleanup(): > +for p in payload: > +pass It's not perfectly clear why do we need to do this loop? Is it to consume the end of the payload before

D2462: util: add a file object proxy that can notify observers

lothiraldan added inline comments. INLINE COMMENTS > util.py:535 > +# write defined above > +} > + Could we define the `ours` set at the class level so an extension/subclass could easily update it if needed? REPOSITORY rHG Mercurial REVISION DETAIL

D2479: py3: use '%d' to convert integers to bytes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2479 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git a/mercurial/debugcommands.py

D2480: py3: use print as a function in tests/test-hgrc.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY print was made a function in Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2480 AFFECTED FILES tests/test-hgrc.t

D2478: py3: add b'' prefixes in tests/test-extension.t

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We are now close to getting this test pass on Python 3. 1. skip-blame because just b'' prefixes. REPOSITORY rHG Mercurial REVISION DETAIL

D2477: py3: convert os.devnull to bytes using pycompat.bytestr

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY os.devnull returns str on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2477 AFFECTED FILES hgext/convert/common.py

D2476: py3: fix more keyword arguments handling

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2476 AFFECTED FILES hgext/lfs/__init__.py

D2474: py3: use pycompat.strurl to convert url to str

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2474 AFFECTED FILES mercurial/url.py CHANGE DETAILS diff --git a/mercurial/url.py b/mercurial/url.py

D2475: py3: make sure regexes are bytes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because we are adding just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2475 AFFECTED FILES

D2472: pycompat: prevent encoding or decoding values if not required

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY pycompat.py has functions strurl and bytesurl which decodes and encodes the url passed on Python 3 respectively. In some cases, strurl gets a url which is

D2473: py3: use pycompat.strurl to convert url to str

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2473 AFFECTED FILES mercurial/url.py CHANGE DETAILS diff --git a/mercurial/url.py b/mercurial/url.py