D2934: forget: add --confirm option

khanchi97 added a comment. I have made the requested changes. Now --confirm will prompt per file and also added all/skip option which will either include all the remaining files or skip all the remaining files according the user input. INLINE COMMENTS > av6 wrote in cmdutil.py:2007 >

[PATCH 1 of 2] lfs: avoid an improper usage of os.path.basename() to parse a URI

# HG changeset patch # User Matt Harbison # Date 1522554476 14400 # Sat Mar 31 23:47:56 2018 -0400 # Node ID bdef5a344ebfd54cf454b184e14d0c37400f7547 # Parent 2ed180117f7658d0cbf6a1ece20944465c55c947 lfs: avoid an improper usage of os.path.basename() to parse a URI

[PATCH 2 of 2] lfs: ensure the transfer request is for a known URI

# HG changeset patch # User Matt Harbison # Date 1522555088 14400 # Sat Mar 31 23:58:08 2018 -0400 # Node ID 61133b211f50194afc52f576d93c58d3f5f6c529 # Parent bdef5a344ebfd54cf454b184e14d0c37400f7547 lfs: ensure the transfer request is for a known URI Since the

[PATCH V2] lfs: add an experimental knob to disable blob serving

# HG changeset patch # User Matt Harbison # Date 1522524043 14400 # Sat Mar 31 15:20:43 2018 -0400 # Node ID 6d38647fb53d4f8b5a874105befd9994d1a9f2f5 # Parent 40f0b221aee73bca2072812062d0f112a134bedf lfs: add an experimental knob to disable blob serving The use

[PATCH 5 of 8] templater: drop unneeded generator from mappable object

# HG changeset patch # User Yuya Nishihara # Date 1521287908 -32400 # Sat Mar 17 20:58:28 2018 +0900 # Node ID cc616e233d253af1aeb4cc2576a38a437c3be95a # Parent 9a9b1047830a742e914d7085cfd9df34f5577d64 templater: drop unneeded generator from mappable object Per the

[PATCH 1 of 8] templater: pass context down to unwraphybrid()

# HG changeset patch # User Yuya Nishihara # Date 1521284945 -32400 # Sat Mar 17 20:09:05 2018 +0900 # Node ID 529838f7858556c0f9d180a276b483578c6d55d4 # Parent 02079695afdd39020b13f238c69691dce14b932f templater: pass context down to unwraphybrid() See the subsequent patches

[PATCH 7 of 8] templater: extract private function to evaluate generator to byte string

# HG changeset patch # User Yuya Nishihara # Date 1521808816 -32400 # Fri Mar 23 21:40:16 2018 +0900 # Node ID 5d5ecd0c1e91676bc1ac6a481679cad21fb0e108 # Parent d7a44391a574f6526d4d14925abe1dce048a83e3 templater: extract private function to evaluate generator to byte string

[PATCH 6 of 8] templater: pass context down to unwrapvalue()

# HG changeset patch # User Yuya Nishihara # Date 1521382461 -32400 # Sun Mar 18 23:14:21 2018 +0900 # Node ID d7a44391a574f6526d4d14925abe1dce048a83e3 # Parent cc616e233d253af1aeb4cc2576a38a437c3be95a templater: pass context down to unwrapvalue() The same reason as why I

[PATCH 4 of 8] templater: mark .gen as a private attribute

# HG changeset patch # User Yuya Nishihara # Date 1521287802 -32400 # Sat Mar 17 20:56:42 2018 +0900 # Node ID 9a9b1047830a742e914d7085cfd9df34f5577d64 # Parent c8be87f32f1cdf473685b8302300265d57f3b512 templater: mark .gen as a private attribute diff --git

[PATCH 3 of 8] templatekw: do not directly call .gen

# HG changeset patch # User Yuya Nishihara # Date 1521299496 -32400 # Sun Mar 18 00:11:36 2018 +0900 # Node ID c8be87f32f1cdf473685b8302300265d57f3b512 # Parent a26aace92f3a4e7e0acfa8d0e61ad11ec182902c templatekw: do not directly call .gen diff --git

[PATCH 8 of 8] templater: define interface for objects requiring unwrapvalue()

# HG changeset patch # User Yuya Nishihara # Date 1521288196 -32400 # Sat Mar 17 21:03:16 2018 +0900 # Node ID 7e5b902521dc5d58b3da8f6bd8b4b8e8cb33dad7 # Parent 5d5ecd0c1e91676bc1ac6a481679cad21fb0e108 templater: define interface for objects requiring unwrapvalue()

[PATCH 2 of 8] templater: define interface for objects requiring unwraphybrid()

# HG changeset patch # User Yuya Nishihara # Date 1521287570 -32400 # Sat Mar 17 20:52:50 2018 +0900 # Node ID a26aace92f3a4e7e0acfa8d0e61ad11ec182902c # Parent 529838f7858556c0f9d180a276b483578c6d55d4 templater: define interface for objects requiring unwraphybrid() Prepares

[PATCH] templatefuncs: do not crash because of invalid value fed to mailmap()

# HG changeset patch # User Yuya Nishihara # Date 1522548389 -32400 # Sun Apr 01 11:06:29 2018 +0900 # Node ID 02079695afdd39020b13f238c69691dce14b932f # Parent 2ed180117f7658d0cbf6a1ece20944465c55c947 templatefuncs: do not crash because of invalid value fed to mailmap()

D3001: templatefuncs: remove redundant "or author" from mailmap return statement

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3685a79ea51b: templatefuncs: remove redundant or author from mailmap return statement (authored by sheehan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3002: stringutil: rename local email/names variables to their plural forms

This revision was automatically updated to reflect the committed changes. Closed by commit rHG54b896f195d1: stringutil: rename local email/names variables to their plural forms (authored by sheehan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3002?vs=7478=7482#toc

D3004: stringutil: edit comment to reflect actual data type name

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2ed180117f76: stringutil: edit comment to reflect actual data type name (authored by sheehan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3003: stringutil: improve check for failed mailmap line parsing

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0e7550b0964c: stringutil: improve check for failed mailmap line parsing (authored by sheehan, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3003?vs=7479=7484#toc REPOSITORY

D3000: addremove: remove opts from scmutil.addremove

yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Sorry, I didn't notice that the opts dict carries extra options other than subrepos, dry_run, and similarity. Because of that, my idea of dropping `opts` turns out to be worse than

D3003: stringutil: improve check for failed mailmap line parsing

yuja added a comment. Queued the series, thanks. INLINE COMMENTS > stringutil.py:169 > > +def ismailmaplineinvalid(names, emails): > +'''Returns True if the parsed names and emails I renamed this to `_ismailmaplineinvalid` since this will never be publicly used. REPOSITORY rHG

Re: [PATCH 1 of 4] lfs: improve the client message when the server signals an object error

On Sat, 31 Mar 2018 18:28:24 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1519620242 18000 > # Sun Feb 25 23:44:02 2018 -0500 > # Node ID 0cd7c41df75ac914d95f398105317afb53f7e5db > # Parent

Re: [PATCH 3 of 4] lfs: add an experimental knob to disable blob serving

On second thought, I can probably just not wrap the wire protocol function. But the other patches here shouldn’t depend on this. > On Mar 31, 2018, at 6:28 PM, Matt Harbison wrote: > > # HG changeset patch > # User Matt Harbison > # Date

[PATCH 2 of 4] lfs: add the 'Content-Type' header called out in the file transfer spec

# HG changeset patch # User Matt Harbison # Date 1519520219 18000 # Sat Feb 24 19:56:59 2018 -0500 # Node ID 40f0b221aee73bca2072812062d0f112a134bedf # Parent 0cd7c41df75ac914d95f398105317afb53f7e5db lfs: add the 'Content-Type' header called out in the file transfer

[PATCH 4 of 4] check-code: tighten the check for `ls -R`

# HG changeset patch # User Matt Harbison # Date 1522526066 14400 # Sat Mar 31 15:54:26 2018 -0400 # Node ID 0d8b5aa297053419ed4a46678462aa295803cbeb # Parent f3e750cdf0b3fb1977b7ea0f7685d2a86d3c199c check-code: tighten the check for `ls -R` Otherwise, this was

[PATCH 3 of 4] lfs: add an experimental knob to disable blob serving

# HG changeset patch # User Matt Harbison # Date 1522524043 14400 # Sat Mar 31 15:20:43 2018 -0400 # Node ID f3e750cdf0b3fb1977b7ea0f7685d2a86d3c199c # Parent 40f0b221aee73bca2072812062d0f112a134bedf lfs: add an experimental knob to disable blob serving The use

[PATCH 1 of 4] lfs: improve the client message when the server signals an object error

# HG changeset patch # User Matt Harbison # Date 1519620242 18000 # Sun Feb 25 23:44:02 2018 -0500 # Node ID 0cd7c41df75ac914d95f398105317afb53f7e5db # Parent 97ab6f2dc3c3b0d689e90b4872b3874e649ce4e6 lfs: improve the client message when the server signals an object

D3003: stringutil: improve check for failed mailmap line parsing

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The existing check for a bad mailmap file entry fails with inputs like b'>@<'. This commit adds a function to check if a sufficient amount of information has

D3002: stringutil: rename local email/names variables to their plural forms

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY email and name variables are renamed to emails and names (respectively). This is because the email variable name shadows the email function within the

D3001: templatefuncs: remove redundant "or author" from mailmap return statement

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3001 AFFECTED FILES mercurial/templatefuncs.py CHANGE DETAILS diff --git

D3004: stringutil: edit comment to reflect actual data type name

sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In development the data type used to hold an email/name pair was called a "mailmaptup" since it was implemented as a namedtuple. The implementation has since

D3000: addremove: remove opts from scmutil.addremove

khanchi97 added a subscriber: yuja. khanchi97 added a comment. I ran all the tests those are related to addremove and they are passing. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3000 To: khanchi97, #hg-reviewers Cc: yuja, mercurial-devel

D2999: infinitepush: use zope.interface to define indexapi interface

indygreg added a comment. Oh, when you add test coverage, watch out for `mysql.connector` being unavailable. You may want to register a fake module in `sys.modules['mysql.connector']` to ensure it always is available. REPOSITORY rHG Mercurial REVISION DETAIL

D2999: infinitepush: use zope.interface to define indexapi interface

indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. Please also add test coverage to `test-check-interfaces.py`, otherwise these interfaces mean practically nothing. `zope.interface` doesn't perform run-time interface

D2998: infinitepush: add tests for `hg pull -r `

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb5caa13d1a73: infinitepush: add tests for `hg pull -r rev` (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2998?vs=7465=7475

D2994: bunlde2: add 'source' as an optional argument to processbundle()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9041c91561fc: bunlde2: add source as an optional argument to processbundle() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2995: bundleoperation: pass the source argument from all the users

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf7d3915d5b3a: bundleoperation: pass the source argument from all the users (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2996: bundle2: make source a mandatory argument for bundle2.applybundle() (API)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG684a6a261f30: bundle2: make source a mandatory argument for bundle2.applybundle() (API) (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2997: infinitepush: use bundleoperation.source instead of hacking on tr

This revision was automatically updated to reflect the committed changes. Closed by commit rHG40ee0af04e3a: infinitepush: use bundleoperation.source instead of hacking on tr (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2998: infinitepush: add tests for `hg pull -r `

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Oh, I assumed `hg pull -r` would magically work here. Boo. But at least we have test coverage for it now. REPOSITORY rHG Mercurial REVISION DETAIL

D2991: infinitepush: drop the default value of config options which are registered

This revision was automatically updated to reflect the committed changes. Closed by commit rHG912f4f64047f: infinitepush: drop the default value of config options which are registered (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2992: infinitepush: don't force ipv6 while connecting to mysql server

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc1fac3878196: infinitepush: dont force ipv6 while connecting to mysql server (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2992?vs=7459=7469#toc

Re: [PATCH 11 of 11] templater: drop global exception catcher from runfilter() (API)

On Sat, Mar 31, 2018 at 10:49:39AM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1521359827 -32400 > # Sun Mar 18 16:57:07 2018 +0900 > # Node ID 9a2646947602dd11d7f65422e3ea27fabb3ee555 > # Parent

D2903: utils: add isauthorwellformed function

sheehan abandoned this revision. sheehan added a comment. Abandoning, this was landed as another differential. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2903 To: sheehan, #hg-reviewers Cc: yuja, lothiraldan, pulkit, mercurial-devel

D2999: infinitepush: use zope.interface to define indexapi interface

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch makes indexapi use zope.interface which is now vendored with mercurial. REPOSITORY rHG Mercurial REVISION DETAIL

D2998: infinitepush: add tests for `hg pull -r `

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds test for `hg pull -r ` when the infinitepush extension is not present on the client side and the server by defaults pushes all the incoming push

D2996: bundle2: make source a mandatory argument for bundle2.applybundle() (API)

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently all the callers in the core pass the source argument, making it mandatory will help us storing right source value in bundleoperation() class. REPOSITORY

D2997: infinitepush: use bundleoperation.source instead of hacking on tr

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previous patches added a soutce attribute to bundle2.bundleoperation class which stores the command which leads to current bundleoperation. Let's use that to

D2995: bundleoperation: pass the source argument from all the users

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We now have a source attribute to the bundle2.bundleoperation class which stores the operation which leads to the current bundling/unbundling. Let's make sure we

D2993: bundle2: add 'source' atrribute to bundleoperation class

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will help us in easily finding out which command leads to the current operation without hacking on the transaction. REPOSITORY rHG Mercurial REVISION

D2994: bunlde2: add 'source' as an optional argument to processbundle()

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will help us to pass the source variable to bundleoperation class. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2994 AFFECTED

D2992: infinitepush: don't force ipv6 while connecting to mysql server

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Facebook internally enforces this but looks like we can't force this for pur users. REPOSITORY rHG Mercurial REVISION DETAIL

D2991: infinitepush: drop the default value of config options which are registered

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2991 AFFECTED FILES hgext/infinitepush/__init__.py CHANGE DETAILS diff --git

D2990: infinitepush: replace `remotenames.hoist` with `remotenames.hoistedpeer`

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The remotenames.hoist config option was renamed to remotenames.hoistedpeer while moving to core as an extension. Let's start using the config option provided by

D2989: context: drop support for changeid of type long (API?)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG97ab6f2dc3c3: context: drop support for changeid of type long (API?) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 1 of 2] server: refactor 'daemon_postexec' instructions into a dictionary

On Fri, 30 Mar 2018 23:39:51 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1522466506 14400 > # Fri Mar 30 23:21:46 2018 -0400 > # Node ID 6e77d0a68122a6513521c94c4b8256b7e6da6f93 > # Parent

Re: [PATCH] lfs: drop a duplicate blob verification method

On Sat, 31 Mar 2018 00:16:30 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1522468951 14400 > # Sat Mar 31 00:02:31 2018 -0400 > # Node ID 9837cda5fd115adecf860d3a97e5a01c07ca72fc > # Parent

D2978: cbor: import CBORDecoder and CBOREncoder

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3bc609bcfe77: cbor: import CBORDecoder and CBOREncoder (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2978?vs=7432=7455

Re: [PATCH] py3: fix fix doctests to be bytes-safe

On Sat, Mar 31, 2018 at 7:18 AM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1522459698 -32400 > # Sat Mar 31 10:28:18 2018 +0900 > # Node ID 40be6a8728a046b3673a517af2a3e15574457728 > # Parent

D2989: context: drop support for changeid of type long (API?)

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I don't see a reason to support type long. It's pretty much the same type as int. There was some discussion about it on the mailing list around the time of