D3185: context: convert binary changeid to hex also for filtered ones

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Funnily enough, within about a day of writing https://phab.mercurial-scm.org/D3144, I ran into the exception in practice. I spent some time trying figure out w

D3177: wireproto: crude support for version 2 HTTP peer

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of implementing the server-side bits of the wire protocol command handlers for version 2, we want a way to easily test those commands. Currently, we use

D3184: wireproto: only expose "debugwireargs" to version 1 transports

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not even sure this command should be enabled for version 1 transports. It is just a reflection endpoint for argument data. We definitely don't need to suppo

D3182: wireproto: port branchmap to wire protocol v2

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3182 AFFECTED FILES mercurial/help/internals/wireprotocol.txt mercurial/wireproto.py tests/test-wi

D3183: wireproto: only expose "hello" command to version 1 transports

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This command is only ever used for the handshake in the SSH protocol. We probably don't even need for it to be a proper command. Let's not carry it forward to v

D3176: tests: extract wire protocol shell helpers to standalone file

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will make it easier for other tests to get up and running without the boilerplate. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.

D3180: wireproto: port keep command to wire protocol v2

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is pretty straightforward. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3180 AFFECTED FILES mercurial/help/internals/wirep

D3181: wireproto: port listkeys commands to wire protocol v2

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3181 AFFECTED FILES mercurial/help/internals/wireprotocol.txt mercurial/wireproto.py tests/test-ht

D3178: largefiles: wrap heads command handler more directly

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY extensions.wrapfunction() is a more robust method for wrapping a function, since it allows multiple wrappers. While we're here, wrap the function registered

D3179: wireproto: port heads command to wire protocol v2

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY After much thought and consideration, wire protocol version 2's commands will be defined in different functions from the existing commands. This will make it ea

D3154: filelog: wrap revlog instead of inheriting it (API)

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 7860. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3154?vs=7768&id=7860 REVISION DETAIL https://phab.mercurial-scm.org/D3154 AFFECTED FILES mercurial/bundlerepo.py mercurial/filelog.py mercurial/unionrepo.p

D3162: bookmarks: introduce a repo._bookmarks.changectx(mark) method and use it

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG81d35d5d35f9: bookmarks: introduce a repo._bookmarks.changectx(mark) method and use it (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercu

D3163: discovery: look up bookmarks only among bookmarks

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG444ed53f93df: discovery: look up bookmarks only among bookmarks (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3163?vs=78

D3164: destutil: look up bookmarks only among bookmarks

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2b38c80557a4: destutil: look up bookmarks only among bookmarks (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3164?vs=779

D3165: infinitepush: look up bookmarks only among bookmarks

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2735d08e9788: infinitepush: look up bookmarks only among bookmarks (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3165?vs

D3165: infinitepush: look up bookmarks only among bookmarks

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg added subscribers: smf, indygreg. indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. These changes all seem reasonable to me. And I'm pretty sure I use you and @smf discussing this in IRC. So LGTM. REPOSITORY rHG Mercurial R

[PATCH 2 of 3] py3: convert parsed message items to bytes in patch.extract()

2018-04-06 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523076157 -32400 # Sat Apr 07 13:42:37 2018 +0900 # Node ID e500a16779ebbd095bacc793a42ff57a91c47737 # Parent 5f401721fa2a4ba1e5b5ea570c9c0978481a20f7 py3: convert parsed message items to bytes in patch.extract() Appears that BytesParser()

[PATCH 3 of 3] py3: byte-stringify test-import.t

2018-04-06 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523076392 -32400 # Sat Apr 07 13:46:32 2018 +0900 # Node ID b4c8e3550154dc61a5f6fbfac3bd8923c2b022f9 # Parent e500a16779ebbd095bacc793a42ff57a91c47737 py3: byte-stringify test-import.t Still the test doesn't pass. # skip-blame because just

[PATCH 1 of 3] py3: silence warning about deprecation of imp module

2018-04-06 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523074919 -32400 # Sat Apr 07 13:21:59 2018 +0900 # Node ID 5f401721fa2a4ba1e5b5ea570c9c0978481a20f7 # Parent a0d71618074f3c90180b4e6615544ab20b2cdda4 py3: silence warning about deprecation of imp module Well, we could fix that, but we aren

D3154: filelog: wrap revlog instead of inheriting it (API)

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D3154#51010, @durin42 wrote: > test-unionrepo.t: > + t = self.revision(node) > +File "/tmp/hgtests.wmoy8H/install/lib/python/mercurial/filelog.py", line 93, in revision > + return self._revlog.revision

D2941: node: rename wdirnodes to clarify they are for manifest/filelogs

2018-04-06 Thread yuja (Yuya Nishihara)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd7114f883505: node: rename wdirnodes to clarify they are for manifest/filelogs (authored by yuja, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2

D2942: revlog: detect pseudo file nodeids to raise WdirUnsupported exception

2018-04-06 Thread yuja (Yuya Nishihara)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa0d71618074f: revlog: detect pseudo file nodeids to raise WdirUnsupported exception (authored by yuja, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.o

D2940: workingctx: build _manifest on filenode() or flags() request

2018-04-06 Thread yuja (Yuya Nishihara)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG067e8d1178a2: workingctx: build _manifest on filenode() or flags() request (authored by yuja, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2940?

D3168: tests: enter full hex hash in plain text in bundle part

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd46d4f14300a: tests: enter full hex hash in plain text in bundle part (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3168

D3154: filelog: wrap revlog instead of inheriting it (API)

2018-04-06 Thread durin42 (Augie Fackler)
durin42 added a comment. test-unionrepo.t: + t = self.revision(node) +File "/tmp/hgtests.wmoy8H/install/lib/python/mercurial/filelog.py", line 93, in revision + return self._revlog.revision(node, _df=_df, raw=raw) + TypeError: revision() got an unexpected keywo

D3117: tests: make test-convert-git.t more deterministic

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D3117#50998, @durin42 wrote: > This seems to break things with git 1.8.3.1, which is what's on gcc112. Should we just ratchet our test requirements forward, or try and figure out what changed? You can drop it for now. I

D3117: tests: make test-convert-git.t more deterministic

2018-04-06 Thread durin42 (Augie Fackler)
durin42 added a comment. This seems to break things with git 1.8.3.1, which is what's on gcc112. Should we just ratchet our test requirements forward, or try and figure out what changed? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3117 To: indygreg, #hg-rev

D3152: upgrade: sniff for filelog type

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc8666a9e9e11: upgrade: sniff for filelog type (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3152?vs=7766&id=7850 REVISION

D3147: tests: run some largefiles and lfs tests with simple store

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG556984ae0005: tests: run some largefiles and lfs tests with simple store (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D314

D3119: commands: don't violate storage abstractions in `manifest --all`

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7b7ca9ba2de5: commands: don't violate storage abstractions in `manifest --all` (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D3151: revlog: move censor logic into main revlog class

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG65250a66b55c: revlog: move censor logic into main revlog class (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3151?vs=7765&

D3118: commands: document the layering violation in `manifest --all`

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG814e080a1215: commands: document the layering violation in `manifest --all` (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D3150: revlog: move parsemeta() and packmeta() from filelog (API)

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0596d27457c6: revlog: move parsemeta() and packmeta() from filelog (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D315

D3153: tests: call rawsize() directly

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcc4b569975ed: tests: call rawsize() directly (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3153?vs=7767&id=7851 REVISION

D3148: repository: define existing interface for file storage

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4335a75f0bd0: repository: define existing interface for file storage (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3148?vs

D3114: tests: work around potential repo incompatibility

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3fbd8b862d66: tests: work around potential repo incompatibility (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3114?vs=7696

D3110: tests: disable `hg clone --stream` test with simple store

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4f5d8c68cfa: tests: disable `hg clone --stream` test with simple store (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3110

D3149: filelog: declare that filelog implements a storage interface

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa3202fa83aff: filelog: declare that filelog implements a storage interface (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3

D3112: tests: conditionalize test-treemanifest.t

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG28ee8b28b213: tests: conditionalize test-treemanifest.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3112?vs=7694&id=7839

D3111: tests: use unbundle in test-symlink-os-yes-fs-no.py

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5ac84b20f184: tests: use unbundle in test-symlink-os-yes-fs-no.py (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3111?vs=76

D3115: tests: `hg init` after resetting HGRCPATH

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0c1b895511b9: tests: `hg init` after resetting HGRCPATH (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3115?vs=7697&id=7842

D3096: tests: conditionalize tests for various repo features

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7542e97c7867: tests: conditionalize tests for various repo features (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3096?vs=

D3095: simplestore: use a custom store for the simple store repo

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc2c8962a9465: simplestore: use a custom store for the simple store repo (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3095

D3109: tests: use `hg unbundle` in test-setdiscovery.t

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7d0a29f70bbe: tests: use `hg unbundle` in test-setdiscovery.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3109?vs=7691&i

D3116: simplestore: correctly implement flag processors

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9d4f09bfe3ec: simplestore: correctly implement flag processors (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3116?vs=7698&

D3113: tests: disable test-keyword.t with simple store

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9168792422a0: tests: disable test-keyword.t with simple store (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3113?vs=7695&i

D3108: tests: require revlog store for test-verify.t

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG52bb6c1224ae: tests: require revlog store for test-verify.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3108?vs=7690&id=

D3106: tests: conditionalize test-bundle.t

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG09907cd7a17a: tests: conditionalize test-bundle.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3106?vs=7688&id=7832 REVI

D3107: tests: conditionalize test-commandserver.t based on extra extensions

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6282c1965f8e: tests: conditionalize test-commandserver.t based on extra extensions (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-sc

D3100: tests: port test-convert-filemap.t to simple store

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG84e7d2d8c098: tests: port test-convert-filemap.t to simple store (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3100?vs=768

D3102: tests: skip test-hgweb-bundle.t if we don't support bundlerepos

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9fa4a1fdba15: tests: skip test-hgweb-bundle.t if we don't support bundlerepos (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org

D3103: tests: disable shallow narrow tests with simple store

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8d033b348d85: tests: disable shallow narrow tests with simple store (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3103?vs=

D3101: tests: disable test-audit-path.t with simple store

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9984488550ea: tests: disable test-audit-path.t with simple store (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3101?vs=768

D3105: tests: require revlog store with test-repair-strip.t

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe1d4be95cd68: tests: require revlog store with test-repair-strip.t (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3105?vs=7

D3104: simplestore: back up index when adding a revision

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG06674aab2b4c: simplestore: back up index when adding a revision (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3104?vs=7686

D3099: tests: disable test-static-http.t with simple store

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa84b6eeb2c39: tests: disable test-static-http.t with simple store (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3099?vs=76

D3098: tests: don't drop global hgrc

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGafd7b0afe4a6: tests: don't drop global hgrc (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3098?vs=7680&id=7824 REVISION D

D3097: verify: allow suppressing warnings about extra files

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG76d2115cb817: verify: allow suppressing warnings about extra files (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3097?vs=7

D3165: infinitepush: look up bookmarks only among bookmarks

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 7820. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3165?vs=7792&id=7820 REVISION DETAIL https://phab.mercurial-scm.org/D3165 AFFECTED FILES hgext/infinitepush/bundleparts.py CHANGE DETAILS diff --git a/hgex

D3163: discovery: look up bookmarks only among bookmarks

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 7819. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3163?vs=7790&id=7819 REVISION DETAIL https://phab.mercurial-scm.org/D3163 AFFECTED FILES mercurial/discovery.py CHANGE DETAILS diff --git a/mercurial/disco

D3162: bookmarks: introduce a repo._bookmarks.changectx(mark) method and use it

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 7818. martinvonz retitled this revision from "bookmarks: introduce a repo._bookmarks.ctx(mark) method and use it" to "bookmarks: introduce a repo._bookmarks.changectx(mark) method and use it". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https:

D3162: bookmarks: introduce a repo._bookmarks.ctx(mark) method and use it

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3162#50746, @indygreg wrote: > How do you feel about `changectx` instead of `ctx`? This would seemingly jive with other naming throughout the code base. I agree, that's better to make it clear that it's not some kind o

D2470: wireproto: allow direct stream processing for unbundle

2018-04-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2d965bfeb8f6: wireproto: allow direct stream processing for unbundle (authored by joerg.sonnenberger, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D2470: wireproto: allow direct stream processing for unbundle

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the feature! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2470 To: joerg.sonnenberger, #hg-reviewers, lothiraldan, indygreg Cc: indygre

D2470: wireproto: allow direct stream processing for unbundle

2018-04-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger updated this revision to Diff 7816. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2470?vs=6178&id=7816 REVISION DETAIL https://phab.mercurial-scm.org/D2470 AFFECTED FILES hgext/largefiles/proto.py mercurial/configitems.py mercu

D3175: commands: implement `export --format=X` with support for CBOR

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. This is more of an RFC patch. My actual goal is support for ingesting CBOR patches via `hg import`. I figured it would be easier to test that if we had support for CBOR with `hg export`. And the reason I want CBOR support for patch ingestion is because it is safer:

[PATCH 1 of 2] hgweb: fallback to checking wsgireq.env for REPO_NAME for 3rd party hosting

2018-04-06 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1522957360 14400 # Thu Apr 05 15:42:40 2018 -0400 # Node ID d2fd52e2e5e0ce6369c551e7e00c06d36c21658f # Parent d3286dd2ca2f9f9e2b332e00c4b25b21729c54f5 hgweb: fallback to checking wsgireq.env for REPO_NAME for 3rd party hosting Starting with d

[PATCH 2 of 2] lfs: teach the blob server to handle --prefix

2018-04-06 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1522961825 14400 # Thu Apr 05 16:57:05 2018 -0400 # Node ID 6f40284542f14c7c4e68e685268d75f8f5b5a09f # Parent d2fd52e2e5e0ce6369c551e7e00c06d36c21658f lfs: teach the blob server to handle --prefix diff --git a/hgext/lfs/wireprotolfsserver.py

D3174: cmdutil: refactor I/O for exporting

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Using generators for feeding chunks into I/O is more flexible than passing a file object or write function around. This commit refactors the patch exporting

D3172: cborutil: implement streaming arrays and maps

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The vendored cbor2 package doesn't have support for streaming / indefinite length items when encoding. This is kind of unfortunate. While it might be worth o

D3175: commands: implement `export --format=X` with support for CBOR

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY What's better than having to parse patch files? Not having to parse them. The current text-based patch file format used by `hg export` is good for humans t

D3173: cmdutil: drop unused rev arguments from _exportsingle()

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY No clue when we stopped using it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3173 AFFECTED FILES mercurial/cmdutil.py CHANGE

D3171: wireproto: send server capabilities in canonical order

2018-04-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG33af46d639b4: wireproto: send server capabilities in canonical order (authored by joerg.sonnenberger, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D3169: wireproto: turn client capabilities into sets, sorted on the wire

2018-04-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3e1688711efd: wireproto: turn client capabilities into sets, sorted on the wire (authored by joerg.sonnenberger, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercu

D3170: wireproto: don't special case bundlecaps, but sort all scsv arguments

2018-04-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1d459f61b42a: wireproto: don't special case bundlecaps, but sort all scsv arguments (authored by joerg.sonnenberger, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.

D3171: wireproto: send server capabilities in canonical order

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. THANK YOU for this cleanup. The wonky ordering due to the way capabilities are added on the server has annoyed me too. As part of reviewing this, it is more obvious than before that

D3170: wireproto: don't special case bundlecaps, but sort all scsv arguments

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. `scsv` types are parsed into a `set`. So this should pose no BC problems. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3170 To: joerg.sonnenberger, #hg-

D3171: wireproto: send server capabilities in canonical order

2018-04-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3171 AFFECTED FILES mercurial/wireproto.py tests/test-debugcommands.t tests/test-hgweb-c

D3170: wireproto: don't special case bundlecaps, but sort all scsv arguments

2018-04-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3170 AFFECTED FILES mercurial/wireproto.py CHANGE DETAILS diff --git a/mercurial/wireproto

D3169: wireproto: turn client capabilities into sets, sorted on the wire

2018-04-06 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3169 AFFECTED FILES mercurial/httppeer.py mercurial/sshpeer.py CHANGE DETAILS diff --git

D3168: tests: enter full hex hash in plain text in bundle part

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We were looking it up be prefix by repo.__getitem__, which I'm about to drop support for. It's easiest to just include the full hash in plain text. REPOSITOR

D3153: tests: call rawsize() directly

2018-04-06 Thread quark (Jun Wu)
quark added a comment. It was `revlog.revlog.size`, and got changed to `rawsize` before committed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3153 To: indygreg, #hg-reviewers Cc: quark, mercurial-devel ___ Mercuria

D3093: store: make file filtering during walk configurable

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4c15bee42e9c: store: make file filtering during walk configurable (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3093?vs=76

D3091: tests: extract dumprevlog tests to own file

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG567bddcb4271: tests: extract dumprevlog tests to own file (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3091?vs=7673&id=78

D3094: verify: drop "revlog" from warning message

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa6651f5e2c78: verify: drop "revlog" from warning message (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3094?vs=7676&id=780

D3092: simplestore: shore up lookup errors

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdd2753729853: simplestore: shore up lookup errors (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3092?vs=7674&id=7802 REVI

D3090: tests: skip test-censor.t when using simple store

2018-04-06 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8c37c3220ebc: tests: skip test-censor.t when using simple store (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3090?vs=7672

D3092: simplestore: shore up lookup errors

2018-04-06 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3092#50126, @martinvonz wrote: > > When revisions or nodes can't be resolved, we're expected to raise > > an error.LookupError. When I ported code from revlog.py, I failed > > to realize that "LookupError" in that module is

Re: [PATCH 8 of 8] templater: deduplicate iterator of overlay mappings

2018-04-06 Thread Augie Fackler
On Thu, Apr 05, 2018 at 11:37:26PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1522673652 -32400 > # Mon Apr 02 21:54:12 2018 +0900 > # Node ID 0e92d8efaea91db21670c7158b1128f924b30cf4 > # Parent 00c9dda81b49f4242f174fd218c68b5c8bbc5fea > templater: d

D3158: histedit: look up partial nodeid as partial nodeid

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > indygreg wrote in histedit.py:446 > Err wait. Why is `repo.unfiltered()` being used here? If the previous code > worked on on the filtered repo, shouldn't this code? > > The side effect of this change is that a histedit rule could reference a

D3158: histedit: look up partial nodeid as partial nodeid

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > histedit.py:446 > ha = node.hex(self.node) > -try: > -self.node = repo[ha].node() > -except error.RepoError: > -

D3158: histedit: look up partial nodeid as partial nodeid

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. This is a layering violation. But I don't care because we don't yet have an interface for changelog. Once we do, we'll likely promote `_partialmatch` to a public method. REPOSITORY r

D3162: bookmarks: introduce a repo._bookmarks.ctx(mark) method and use it

2018-04-06 Thread indygreg (Gregory Szorc)
indygreg added a comment. How do you feel about `changectx` instead of `ctx`? This would seemingly jive with other naming throughout the code base. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3162 To: martinvonz, #hg-reviewers Cc: indygreg, mercurial-devel _

D3167: bookmarks: use isrevsymbol() for detecting collision with existing symbol

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG46d9f998c3ed: bookmarks: use isrevsymbol() for detecting collision with existing symbol (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercu

D3166: debugwhyunstable: add support for revsets

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9966f44ecab4: debugwhyunstable: add support for revsets (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3166?vs=7793&id=77

D3160: convert: remove unused/unnecessary variable "parentctx"

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG65705fbc9c37: convert: remove unused/unnecessary variable "parentctx" (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3160

D3161: convert: look up branch only among branches

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG810413b745ff: convert: look up branch only among branches (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3161?vs=7788&id=

D3162: bookmarks: introduce a repo._bookmarks.ctx(mark) method and use it

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 7795. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3162?vs=7789&id=7795 REVISION DETAIL https://phab.mercurial-scm.org/D3162 AFFECTED FILES mercurial/bookmarks.py CHANGE DETAILS diff --git a/mercurial/bookm

D3167: bookmarks: use isrevsymbol() for detecting collision with existing symbol

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3167 AFFECTED FILES mercurial/bookmarks.py CHANGE DETAILS diff --git a/mercurial/bookmarks.py b/me

D3166: debugwhyunstable: add support for revsets

2018-04-06 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3166 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git a/mercurial/debugcommands

  1   2   >