mercurial@37840: 4 new changesets

4 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/e0f30c91dfd8 changeset: 37837:e0f30c91dfd8 user:Yuya Nishihara date:Sun Apr 29 15:44:17 2018 +0900 summary: log: cache diffopts instance https://www.mercurial-scm.org/repo/hg/rev/3fe1c9263024 changeset

Re: [PATCH 4 of 4] bookmarks: cache reverse mapping (issue5868)

> On May 5, 2018, at 10:53 PM, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1525488162 -32400 > # Sat May 05 11:42:42 2018 +0900 > # Node ID 9ae8a72dec358d33c96725e1f94c631e869deb80 > # Parent f8b12218af5c8d09da0965d631ad6a19fc9df3de > bookmarks: cache r

D3439: template filters: add commonprefix

yuja added a comment. Can you add test for failure cases? such as - `str|commonprefix` - `int|commonprefix` - nothing common (e.g. `["/foo", "bar"]`) - empty list - paths normalized by `os.path.normcase()` `os.path.commonprefix()` isn't what we want, but it might provide some

Re: D3444: tests: comprehensively test exit handling

I generally like the direction of this series, but I think there's no point to extend Mercurial's exit code handling to support all weird Python types. Only ints and (None for 0) are ever valid. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-

D3445: dispatch: shore up exit handling

yuja added a comment. IIRC, SystemExit is caught at callcatch and translated to a status code. > +# The logic here attempts to mimic how CPython's pythonrun.c does things. > +# Essentially: > +# > +# * Exit is controlled by returning a value or raising SystemExit.

Re: D3439: template filters: add commonprefix

Can you add test for failure cases? such as * `str|commonprefix` * `int|commonprefix` * nothing common (e.g. `["/foo", "bar"]`) * empty list * paths normalized by `os.path.normcase()` `os.path.commonprefix()` isn't what we want, but it might provide some hints. ___

Re: D3445: dispatch: shore up exit handling

IIRC, SystemExit is caught at callcatch and translated to a status code. > +# The logic here attempts to mimic how CPython's pythonrun.c does things. > +# Essentially: > +# > +# * Exit is controlled by returning a value or raising SystemExit. > +# * An integer value exits with

D3444: tests: comprehensively test exit handling

yuja added a comment. I generally like the direction of this series, but I think there's no point to extend Mercurial's exit code handling to support all weird Python types. Only ints and (None for 0) are ever valid. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-s

D3442: tests: remove #require killdaemons

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4b7427b5786: tests: remove #require killdaemons (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3442?vs=8457&id=8472 REVIS

D3443: tests: remove pid file by default

This revision was automatically updated to reflect the committed changes. Closed by commit rHG89793289c891: tests: remove pid file by default (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3443?vs=8458&id=8473 REVISI

D3454: Assign to result from block.

kevincox created this revision. kevincox added a reviewer: indygreg. Herald added subscribers: mercurial-devel, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is more idiomatic because you don't have uninitialized variables and has less typing. REPOSITORY rHG Mercurial

D3447: rust: make exit handling consistent with `hg`

kevincox accepted this revision. kevincox added inline comments. INLINE COMMENTS > main.rs:204 > +Ok(value) => value, > +Err(_) => panic!("non-integer value returned by > dispatch.run()"), > +}; s/unreachable/panic/ since the code can neve