# HG changeset patch
# User Matt Harbison
# Date 1536114578 14400
# Tue Sep 04 22:29:38 2018 -0400
# Node ID 2cce57226251044ce3406ad92e4edbf01efcde72
# Parent 197521083166579f6c80d7532ec6e919af2fe2cf
cbor: teach the encoder to handle python `long` type for Windows
The tests for 2**32 and -7
On Tue, Sep 4, 2018 at 7:33 PM Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1536114578 14400
> # Tue Sep 04 22:29:38 2018 -0400
> # Node ID 5a44192e15a600f244ee7b77a77a2add7731b61c
> # Parent 197521083166579f6c80d7532ec6e919af2fe2cf
> cbor: teach the encoder
# HG changeset patch
# User Matt Harbison
# Date 1536114578 14400
# Tue Sep 04 22:29:38 2018 -0400
# Node ID 5a44192e15a600f244ee7b77a77a2add7731b61c
# Parent 197521083166579f6c80d7532ec6e919af2fe2cf
cbor: teach the encoder to handle python `long` type for Windows
The tests for 2**32 and -7
quark accepted this revision.
quark added a comment.
LGTM
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4464
To: martinvonz, #hg-reviewers, quark
Cc: quark, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-d
On Tue, 04 Sep 2018 17:34:11 -0400, Martin von Zweigbergk
wrote:
On Sat, Sep 1, 2018 at 9:31 PM Matt Harbison
wrote:
On Sat, 01 Sep 2018 02:05:32 -0400, Matt Harbison
wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1535216964 14400
> # Sat Aug 25 13:09:24 2018 -0
# HG changeset patch
# User Matt Harbison
# Date 1536108881 14400
# Tue Sep 04 20:54:41 2018 -0400
# Node ID 197521083166579f6c80d7532ec6e919af2fe2cf
# Parent ae1442742d796285b85bf9e0e0159665414f0478
help: correct a typo in tweakdefaults
diff --git a/mercurial/help/config.txt b/mercurial/he
# HG changeset patch
# User Matt Harbison
# Date 1536108502 14400
# Tue Sep 04 20:48:22 2018 -0400
# Node ID ae1442742d796285b85bf9e0e0159665414f0478
# Parent ab20ee07b82df985133f4e3fa3afa2ad48516340
absorb: clarify the reason for not finding changesets to modify
I'm used to pushing to non-
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGab20ee07b82d: narrow: add '--import-rules' flag
to tracked command (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4125?vs=107
martinvonz added a comment.
I'll reply to my own question: The context is in
https://phab.mercurial-scm.org/D2679.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4479
To: lothiraldan, #hg-reviewers
Cc: martinvonz, mercurial-devel
___
lothiraldan added a comment.
Hi Pulkit,
Thanks for your patience. I had a couple of important things to get out of
the way before I could turn my attention to this.
I reached out to Ryan and he sent me the code he wrote at the 4.6 Sprint. I
made it available here to support the disc
martinvonz added a comment.
Why? (Sorry if I'm asking to early and you were just about to send an update.)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4479
To: lothiraldan, #hg-reviewers
Cc: martinvonz, mercurial-devel
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch is not ready to land and only sent for discussion.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4479
AFFECTED FILES
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
All I/O is supposed to be performed via vfs instances so filesystems
can be abstracted. The previous commit ported the old code in purge,
which didn't go throug
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Working directory purging feels like functionality that should be
in core rather than in an extension.
This commit effectively moves the core purging logic f
spectral added a comment.
In https://phab.mercurial-scm.org/D4351#67751, @yuja wrote:
> Can't apply. Can you rebase?
Done, sorry for the delay.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4351
To: spectral, #hg-reviewers
Cc: yuja, durin42, mercur
spectral updated this revision to Diff 10774.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4351?vs=10534&id=10774
REVISION DETAIL
https://phab.mercurial-scm.org/D4351
AFFECTED FILES
mercurial/match.py
CHANGE DETAILS
diff --git a/mercurial/match.py
meirambek77 created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
output before: "500 files, 2035 changesets, 2622 total revisions"
output after: "checked 2035 changesets with 2622 changes to
On Sat, Sep 1, 2018 at 9:31 PM Matt Harbison wrote:
> On Sat, 01 Sep 2018 02:05:32 -0400, Matt Harbison
>
> wrote:
>
> > # HG changeset patch
> > # User Matt Harbison
> > # Date 1535216964 14400
> > # Sat Aug 25 13:09:24 2018 -0400
> > # Node ID 9a5c52a1933072c6d88ba33d64ccc14f24472115
> >
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
I'm a bit wary of version sniffing for the same reason that `User-Agent`
sniffing is bad in web design: it assumes that version number strings map to
behavior. The best way to test for
pulkit added a subscriber: durin42.
pulkit added a comment.
cc: @durin42
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4475
To: pulkit, #hg-reviewers
Cc: durin42, mercurial-devel
___
Mercurial-devel mailing list
Mercu
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
codecs.escape_encode() raises SystemError if an empty bytestring is passed. We
do that at some places in our code and because of this bug, things break.
Therefore
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, wire protocol version 2 inherited version 1's model of
having separate types to represent the results of different wire
protocol commands.
As I
indygreg created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, wire protocol version 2 would buffer all response data.
Only once all data was received did we CBOR decode it and resolve
the future assoc
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It implements the set of CBOR needed for the wire protocol.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4469
AFFECTED FILES
me
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
An upcoming commit introduces a wire protocol command that can emit
hundreds of thousands of small objects. Without a buffering layer,
we would emit a single, s
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Again, test output changed slightly because of map key ordering
differences. This shouldn't matter.
I could have called oncommandresponsereadygen() with the
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was the last consumer of the vendored CBOR package in
core.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4471
AFFECTED FIL
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Behavior should be the same in order to preserve backwards
compatibility. We obviously want to stream values in this code.
We'll do that in subsequent commits.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Moving away from the vendored package.
Again, our encoder normalizes keys differently from the vendored
package (for now), hence the test changes.
REPOSITOR
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Tests changed because our CBOR encoder appears to sort map keys
differently from the vendored CBOR package. The CBOR specification
does define canonical sorting
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We just implemented our own CBOR decoder. Let's use it in
httppeer.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4465
AFFECTED
indygreg updated this revision to Diff 10761.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4436?vs=10693&id=10761
REVISION DETAIL
https://phab.mercurial-scm.org/D4436
AFFECTED FILES
mercurial/httppeer.py
CHANGE DETAILS
diff --git a/mercurial/httpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdc61a67c1fc0: internals: extract wire protocol version 2
commands to standalone doc (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-s
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc734a5c82f38: wireprotov2peer: split responsedata handling
into separate function (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3c6f7eebc010: httppeer: add TODO about delayed handling of
^C (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4438?vs=10695&
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3fe028b657bf: httppeer: log commands for version 2 peer
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4437?vs=10694&id=107
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1467b6c27ff9: wireprotov2peer: add TODO about streaming
responses (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4435?vs=10
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was caught by someone who was looking for the
super(cls, self).__init__(self, ...)
pattern in all code in our Google-internal repo.
REPOSITORY
idlsoft updated this revision to Diff 10754.
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4312?vs=10508&id=10754
REVISION DETAIL
https://phab.mercurial-scm.org/D4312
AFFECTED FILES
hgext/bookflow.py
tests/test-bookflow.t
CHANGE DETAILS
diff --git a/tests/test-bookflow.t b/
33 new changesets (3 on stable) in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/da84cca65036
changeset: 39387:da84cca65036
user:Yuya Nishihara
date:Fri Aug 31 21:10:28 2018 +0900
summary: shelve: fix crash on unshelve without .shelve metadata file
https://www.mercur
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4971c9724206: tests: update relnotes test for actual output
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4463?vs=10752&id=
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I'm unclear why I didn't see this before but I consistently see it
now. In any event, it doesn't appear to be a regression, so let's just
bake it into the test.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8466c6075161: py3: use print as a function in
tests/test-hgweb.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4461?vs=10740
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc3491d3f8984: py3: add more missing b'' prefixes
in test files (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4458?vs=10737&i
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG16c27483f50f: py3: bytestr a bytes val to make sure we get
bytechr while iterating (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5bf99c27a7b6: py3: make regexes in hgext/keyword.py bytes
(authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4459?vs=10738&id=107
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7450f6500b6e: py3: write the file in str mode in
tests/test-rename-merge2.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D44
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGcbfab495dbcf: py3: add missing b'' prefixes in
tests/badserverext.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4456?vs=1
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG34fe76b31ca4: py3: don't return the revid as unicode
in hgext/convert/subversion.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3694c9aaf5e4: py3: handle keyword arguments correctly in
hgext/acl.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4455?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2dd9519b8c8a: py3: make sure we pass str in os.sysconf in
hgext/convert/common.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.o
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch improves the error message and uses util.readfile() for reading
narrowspecs file while cloning.
REPOSITORY
rHG Mercu
On Fri, Aug 31, 2018 at 10:44 PM Matt Harbison
wrote:
> I don't know much about the wire protocol, so this is mostly for my
> understanding...
>
> On Fri, 31 Aug 2018 18:47:34 -0400, Gregory Szorc
> wrote:
>
> > Another problem that seemingly becomes simpler is large file storage. I
> > argue th
pulkit updated this revision to Diff 10741.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4125?vs=10564&id=10741
REVISION DETAIL
https://phab.mercurial-scm.org/D4125
AFFECTED FILES
hgext/narrow/narrowcommands.py
tests/test-narrow-trackedcmd.t
CHAN
On Tue, Sep 4, 2018 at 7:23 AM Yuya Nishihara wrote:
> On Fri, 10 Apr 2015 09:53:05 -0700, Bryan O'Sullivan wrote:
> > If you haven't come across the Address Sanitizer that's shipped with
> clang
> > and gcc the past few years, start here:
> > https://code.google.com/p/address-sanitizer/wiki/Addr
idlsoft added inline comments.
INLINE COMMENTS
> pulkit wrote in bookflow.py:14
> Can we switch the way help is described here. From 'cmdname: help' to
>
> `To create a new bookmark: hg book mark`.
Also, this way it looks more like a cheatsheet
REVISION DETAIL
https://phab.mercurial-scm.org/
martinvonz requested changes to this revision.
martinvonz added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> narrowcommands.py:374-378
> +try:
> +filepath = os.path.join(pycompat.getcwd(), newrules)
> +fp = open(filepath, 'rb')
Yes, thanks for fixing!
On Tue, Sep 4, 2018 at 8:13 AM Pulkit Goyal <7895pul...@gmail.com> wrote:
>
>
> On Tue, Sep 4, 2018 at 4:21 PM Matt Harbison
> wrote:
>
>>
>> > On Sep 4, 2018, at 12:38 AM, Yuya Nishihara wrote:
>> >
>> > # HG changeset patch
>> > # User Yuya Nishihara
>> > # Date 15360
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4461
AFFECTED FILES
tests/test-hgweb.t
CHANGE DETAILS
diff --git a/tests/test-hgweb.t b/tests/test-hgw
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4460
AFFECTED FILES
hgext/keyword.py
CHANGE DETAILS
diff --git a/hgext/keyword.py b/hgext/keyword.py
-
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame because just b'' prefixes
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4459
AFFECTED FILES
hgext/keyword.py
CHANGE
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame because just b'' prefixes
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4458
AFFECTED FILES
tests/test-hgweb-command
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is better then converting the value the value of sys.argv to bytes.
This makes the test pass on Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
htt
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame because just b'' prefixes
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4456
AFFECTED FILES
tests/badserverext.py
C
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The keys of keyword arguments on python 3 should be str, so when we try to get
some key from them, we must make sure we are using str.
1. skip-blame because ju
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I tried digging why u'' was added in first place, and I was unable to found
something relevant. This might be because some API's takes unicodes, I am not
sure.
R
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame because just r'' prefix
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4453
AFFECTED FILES
hgext/convert/common.py
C
On Tue, Sep 4, 2018 at 4:21 PM Matt Harbison wrote:
>
> > On Sep 4, 2018, at 12:38 AM, Yuya Nishihara wrote:
> >
> > # HG changeset patch
> > # User Yuya Nishihara
> > # Date 1536035361 -32400
> > # Tue Sep 04 13:29:21 2018 +0900
> > # Node ID b69fbdd77c405dc755a45ddf93c6388a4a1915ae
> > #
On Fri, 10 Apr 2015 09:53:05 -0700, Bryan O'Sullivan wrote:
> If you haven't come across the Address Sanitizer that's shipped with clang
> and gcc the past few years, start here:
> https://code.google.com/p/address-sanitizer/wiki/AddressSanitizer
>
> I spent some time building and testing Mercuria
> On Sep 4, 2018, at 12:38 AM, Yuya Nishihara wrote:
>
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1536035361 -32400
> # Tue Sep 04 13:29:21 2018 +0900
> # Node ID b69fbdd77c405dc755a45ddf93c6388a4a1915ae
> # Parent 1cbe19eb496d2dd8d4c8cae849a513348fefadf2
> revlog: fix size o
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Before this patch, we are testing `hg tracked --addinclude` by adding a
command
which is not introduced in the changesets till no
https://bz.mercurial-scm.org/show_bug.cgi?id=5978
Bug ID: 5978
Summary: Add default -> shortlog to json map
Product: Mercurial
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: featu
72 matches
Mail list logo
