This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1d09ba0d2ed3: narrow: move remaining narrow-limited
dirstate walks to core (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4fd0fac48922: localrepo: allow narrowmatch() to accept
matcher to intersect with (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG41fcdfe3bfeb: narrow: allow repo.narrowmatch(match) to
include exact matches from match (authored by martinvonz, committed
by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGaa41f1b01f31: narrow: filter files by narrowspec in
ctx.matches() (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG48a0ce67d67a: status: intersect matcher with narrow matcher
instead of filtering afterwards (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
9 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/1ea80ac13f19
changeset: 40072:1ea80ac13f19
user:Pulkit Goyal
date:Fri Oct 05 20:24:07 2018 +0300
summary: narrow: move the code to generate a widening bundle2 to core
yuja added a comment.
> I remember Yuya saying we need to use bytestr() or '%r' because '%s' was
clever.
> Not sure it applies to this or not.
This should be fine since we don't care the prettiness of the debug output.
Last time, I pointed out that '%f' was incompatible since
yuja added a comment.
Queued, thanks. I've folded this into the fix since the traceback message
is pretty much environment dependent.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4883
To: Zharaskhan, #hg-reviewers, pulkit
Cc: yuja, mercurial-devel
> I remember Yuya saying we need to use bytestr() or '%r' because '%s' was
> clever.
> Not sure it applies to this or not.
This should be fine since we don't care the prettiness of the debug output.
Last time, I pointed out that '%f' was incompatible since the value was a
version number,
Queued, thanks. I've folded this into the fix since the traceback message
is pretty much environment dependent.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa4d62ff9a86d: obsolete: fix ValueError when stored note
contains : char (issue5783) (authored by Zharaskhan, committed by ).
CHANGED PRIOR TO COMMIT
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG56d4f88530fc: narrow: update TODO.rst now that we share
format with sparse (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGeb70acc173e7: narrow: update TODO.rst now that we filter
status in ctx (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The comment referred to was addressed in
https://phab.mercurial-scm.org/rHGe411774a2e0f0a616f44bab787cbbf80ed5f7f48
(narrow:
martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We no longer have the unfortunate wrappostshare() and
unsharenarrowspec() since
martinvonz updated this revision to Diff 11726.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4901?vs=11725=11726
REVISION DETAIL
https://phab.mercurial-scm.org/D4901
AFFECTED FILES
hgext/narrow/TODO.rst
hgext/narrow/narrowdirstate.py
martinvonz added a comment.
In https://phab.mercurial-scm.org/D4901#73949, @pulkit wrote:
> > These places now end up doing an unrestricted dirstate walk after this
> > patch:
> >
> > debugfileset
> > perfwalk
> > sparse (but restricted to sparse config)
> > largefiles
> >
pulkit added a comment.
> These places now end up doing an unrestricted dirstate walk after this
> patch:
>
> debugfileset
> perfwalk
> sparse (but restricted to sparse config)
> largefiles
>
> I'll let anyone who cares about these cases adapt them to work with
> narrow
pulkit added inline comments.
INLINE COMMENTS
> changegroup.py:1056
>
> -yield tree, deltas
> +if not tree or not self._oldfilematcher.visitdir(store.tree[:-1]
> or '.'):
> +yield tree, deltas
Also, I think this is not the right place to case this
martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In most places we now filter at a higher level (the context object),
but there are few places that relied on the dirstate
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It's pretty common that we need to intersect a matcher we already have
(usually from the user) with the narrow matcher. Let's make
repo.narrowmatch() take an
martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4900
AFFECTED FILES
hgext/narrow/narrowdirstate.py
martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Narrow has been walking only paths matching the narrowspec when
walking the working copy. We have not done the same filtering
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This has no effect yet because 1) for committed changes, ctx.matches()
just calls ctx.walk(), which we updated in the previous patch, and 2)
for the working
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I seem to have done a very naive move of the code from the narrow
extension into core in
pulkit added a comment.
@martinvonz Thanks a lot for putting time and effort in trying alternate
approach. Sadly this does not work. I didn't tested this on our repo yet, but I
tested this on test-narrow-widen-no-ellipsis.t. You can also do that, by
removing the globs from this line
12 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/6346e21eecc8
changeset: 40060:6346e21eecc8
user:Augie Fackler
date:Thu Oct 04 21:35:12 2018 -0400
summary: remotenames: follow-up on D3639 to make revset funcs take only one
arg
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGdaff528e00d7: py3: add 8 new passing tests to whitelist
found by buildbot (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2e9378f62232: py3: use %f for floats instead of
%s (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4894?vs=11713=11718
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGad8d8dc9be3f: narrow: move adding of narrow server
capabilities to core (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf7011b44d205: wireprotoserver: move narrow capabilities to
wireprototypes.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe92454e69dc3: narrow: introduce a config option to check if
narrow is enabled or not (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is what I had in mind as an alternative to
https://phab.mercurial-scm.org/D4887. This should not
include subdirectory
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I remember Yuya saying we need to use bytestr() or '%r' because '%s' was
clever.
Not sure it applies to this or not.
REPOSITORY
rHG Mercurial
REVISION DETAIL
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We are getting close!
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4893
AFFECTED FILES
contrib/python3-whitelist
CHANGE DETAILS
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch drops the narrow bundle2 capabilities since we introduced narrow
server
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We use the experimental.narrow config option introduced in one of the previous
patch and
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is done because wireprotoserver import wireprotov1server, so you cannot
import
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch introduces a new config option experimental.narrow which is set to
False by
43 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/426cb2859013
changeset: 40017:426cb2859013
user:Gregory Szorc
date:Wed Sep 26 14:54:15 2018 -0700
summary: debugcommands: print all CBOR objects
https://www.mercurial-scm.org/repo/hg/rev/f80db6adabbe
10 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/1470183068b8
changeset: 40007:1470183068b8
user:Gregory Szorc
date:Fri Sep 28 11:51:17 2018 -0700
summary: storageutil: invert logic of file data comparison
3 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/fa3dc85a747e
changeset: 40004:fa3dc85a747e
user:Gregory Szorc
date:Fri Sep 28 11:29:05 2018 -0700
summary: storageutil: extract functionality for resolving strip revisions
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1ea80ac13f19: narrow: move the code to generate a widening
bundle2 to core (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit updated this revision to Diff 11706.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4887?vs=11700=11706
REVISION DETAIL
https://phab.mercurial-scm.org/D4887
AFFECTED FILES
mercurial/bundle2.py
mercurial/changegroup.py
CHANGE DETAILS
diff
pulkit updated this revision to Diff 11705.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4886?vs=11699=11705
REVISION DETAIL
https://phab.mercurial-scm.org/D4886
AFFECTED FILES
mercurial/bundle2.py
mercurial/changegroup.py
CHANGE DETAILS
diff
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a part of moving more narrow related bits to core.
REPOSITORY
rHG Mercurial
pulkit added a comment.
In https://phab.mercurial-scm.org/D4887#73793, @martinvonz wrote:
>
> I'm still fine with queuing this for now if you need this patch somewhat
urgently even though I think the code in this patch and in
https://phab.mercurial-scm.org/D4886 should
martinvonz added a comment.
I don't think this is quite the right approach. If we're using treemanifest
and widening from `{foo/, bar/}` to `{foo/, bar/, baz/}`, then we'd still be
sending manifests for all those directories (and their subdirectories, right)?
We should only have to send
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe8132a8897da: narrow: start returning bundle2 from
widen_bundle() (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8feae5b989bc: narrow: the first version of narrow_widen
wireprotocol command (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit updated this revision to Diff 11701.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4838?vs=11592=11701
REVISION DETAIL
https://phab.mercurial-scm.org/D4838
AFFECTED FILES
hgext/narrow/narrowbundle2.py
hgext/narrow/narrowwirepeer.py
CHANGE
pulkit added inline comments.
INLINE COMMENTS
> indygreg wrote in narrowwirepeer.py:107
> This may want to catch `Exception`.
Okay, I will followup if this got pushed. Also I copied it from getbundle, do
we want to change it there also?
REPOSITORY
rHG Mercurial
REVISION DETAIL
indygreg added a comment.
This looks pretty reasonable to me from a wire protocol perspective.
INLINE COMMENTS
> narrowwirepeer.py:107
> +part.addparam('treemanifest', '1')
> +except error.Abort as exc:
> +manargs = [('message', pycompat.bytestr(exc))]
This may
pulkit planned changes to this revision.
pulkit added a comment.
This one does not apply cleanly on it's parent now. I will rebase and resend.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4838
To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: mercurial-devel
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
When a narrow clone is done initially the whole manifest is send. In case of
treemanifests,
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch removes the changelog argument added to cgpacker.generate() few
weeks
ago and
On Fri, Oct 5, 2018 at 4:31 PM Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1538742561 -32400
> # Fri Oct 05 21:29:21 2018 +0900
> # Node ID 25533575d04ebad69036892808c0e149fbefbf85
> # Parent 5c3585a588458a70338fb112708c9b0cd2af2526
> remotenames: inline
# HG changeset patch
# User Yuya Nishihara
# Date 1538744917 -32400
# Fri Oct 05 22:08:37 2018 +0900
# Node ID 4cb84ca878258306a364c6b1502081e469dabd64
# Parent fea3ce7f43989d7fd50a04cf2f8ff402031cdbd8
chg: upgrade client to use "setumask2" command
No compatibility code is added to the
# HG changeset patch
# User Yuya Nishihara
# Date 1538743181 -32400
# Fri Oct 05 21:39:41 2018 +0900
# Node ID 5b90cef0b86041b89572d4655e4507a9641c3be4
# Parent ce04586865554a0f3017e209ec66268e3ef4091c
remotenames: remove unneeded sorted() from revset implementation
The order is
# HG changeset patch
# User Yuya Nishihara
# Date 1538663155 -32400
# Thu Oct 04 23:25:55 2018 +0900
# Node ID fea3ce7f43989d7fd50a04cf2f8ff402031cdbd8
# Parent 4fcbf5e3c74ec52e78026376b09d4cb4e7ff9783
chgserver: add "setumask2" command which uses correct message frame
The first 4 bytes
# HG changeset patch
# User Yuya Nishihara
# Date 1538743437 -32400
# Fri Oct 05 21:43:57 2018 +0900
# Node ID 4fcbf5e3c74ec52e78026376b09d4cb4e7ff9783
# Parent 5b90cef0b86041b89572d4655e4507a9641c3be4
remotenames: abort if literal revset pattern matches nothing
This is the convention of
# HG changeset patch
# User Yuya Nishihara
# Date 1538743008 -32400
# Fri Oct 05 21:36:48 2018 +0900
# Node ID ce04586865554a0f3017e209ec66268e3ef4091c
# Parent fe64178103b7155d343f0d4bb02d5ecf8f49981b
remotenames: don't call a set of nodes as "revs"
diff --git a/hgext/remotenames.py
# HG changeset patch
# User Yuya Nishihara
# Date 1538742655 -32400
# Fri Oct 05 21:30:55 2018 +0900
# Node ID fe64178103b7155d343f0d4bb02d5ecf8f49981b
# Parent 25533575d04ebad69036892808c0e149fbefbf85
remotenames: use util.always instead of handcrafted lambda
diff --git
# HG changeset patch
# User Yuya Nishihara
# Date 1538742561 -32400
# Fri Oct 05 21:29:21 2018 +0900
# Node ID 25533575d04ebad69036892808c0e149fbefbf85
# Parent 5c3585a588458a70338fb112708c9b0cd2af2526
remotenames: inline _parseargs() into _revsetutil()
The _parseargs() function gets quite
On Fri, Oct 5, 2018 at 2:37 PM Yuya Nishihara wrote:
> On Thu, 04 Oct 2018 22:39:24 -0400, Augie Fackler wrote:
> > # HG changeset patch
> > # User Augie Fackler
> > # Date 1538703312 14400
> > # Thu Oct 04 21:35:12 2018 -0400
> > # Node ID 969132f98a74ecad2095c9099556fe7c54d1c84f
> > #
yuja added a comment.
I did `clang-format -i` over this patch to fix test failure.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4879
To: durin42, #hg-reviewers, indygreg
Cc: yuja, indygreg, mercurial-devel
___
I did `clang-format -i` over this patch to fix test failure.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7aae2d82045a: repo: remove the last few pass
statements in localrepo.__getitem__ (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5daa2f94588e: repo: create changectx in a single place in
localrepo.__getitem__ (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb13a080101e9: filectx: correct docstring about
changeid (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGccc739706d08: context: drop incorrect and superfluous
docstring (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6638bd3f061b: remotenames: add names argument to
remotenames revset (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
On Thu, 04 Oct 2018 22:39:24 -0400, Augie Fackler wrote:
> # HG changeset patch
> # User Augie Fackler
> # Date 1538703312 14400
> # Thu Oct 04 21:35:12 2018 -0400
> # Node ID 969132f98a74ecad2095c9099556fe7c54d1c84f
> # Parent 6638bd3f061b89b3b0bf432799da79e1fee5eb62
> remotenames:
73 matches
Mail list logo
