D4997: absorb: use a formatter to generate output

2018-10-12 Thread yuja (Yuya Nishihara)
yuja added a comment. > +fm.startitem() > +fm.write('hunk', '%s\n', > + '@@ -%d,%d +%d,%d @@' > + % (a1, a2 - a1, b1, b2 - b1), label='diff.hunk') > +fm.data(path=self.path, linetype='hunk') > + > +def wri

Re: D4997: absorb: use a formatter to generate output

2018-10-12 Thread Yuya Nishihara
> +fm.startitem() > +fm.write('hunk', '%s\n', > + '@@ -%d,%d +%d,%d @@' > + % (a1, a2 - a1, b1, b2 - b1), label='diff.hunk') > +fm.data(path=self.path, linetype='hunk') > + > +def writeline(idx, diffchar, line, linetype, linela

D5042: py3: add some glob to make output compatible with python 3

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0b46e1aa7760: py3: add some glob to make output compatible with python 3 (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5042?

D5041: py3: add a b'' prefix in tests/test-requires.t

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfed5e57c8dc7: py3: add a b'' prefix in tests/test-requires.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5041?vs=11975&id=

D5037: py3: use stringutil.pprint() instead of '%r'

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0d403e9f049a: py3: use stringutil.pprint() instead of '%r' (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5037?vs=11971&id=11

D5038: py3: more globing of things to make output compatible between py2 and py3

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf4893b59230f: py3: more globing of things to make output compatible between py2 and py3 (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial

D5040: py3: use '%d' for rev nums instead of '%s'

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa17c07793dcd: py3: use '%d' for rev nums instead of '%s' (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5040?vs=11974&id=1199

D5036: py3: use '%d' for integers instead of '%s'

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG474809790256: py3: use '%d' for integers instead of '%s' (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5036?vs=11970&id=1199

D5035: py3: add some py3 specific output to test

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG63245ad598af: py3: add some py3 specific output to test (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5035?vs=11969&id=11990

D5033: py3: add b'' prefixes in tests/test-progress.t

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGaf5e2b23040a: py3: add b'' prefixes in tests/test-progress.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5033?vs=11967&id=

D5034: py3: use stringutil.pprint() in color.py instead of '%r'

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcabf09dbc6e0: py3: use stringutil.pprint() in color.py instead of '%r' (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5034?vs

D5030: py3: glob some difference between py2 and py3 output

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7ba6b880b09a: py3: glob some difference between py2 and py3 output (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5030?vs=119

D5032: py3: add b'' prefixes to tests/test-keyword.t

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6d52c2275c30: py3: add b'' prefixes to tests/test-keyword.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5032?vs=11966&id=1

D5031: py3: use stringutil.pprint() if we are printing bool values

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc7ffc53fbd19: py3: use stringutil.pprint() if we are printing bool values (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5031

D5025: py3: make test-contrib-perf.t work on python 3

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb456b2e0ad9f: py3: make test-contrib-perf.t work on python 3 (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5025?vs=11959&id=11980#toc REPOSITORY rHG Me

D5028: py3: add b'' prefixes in tests/test-help.t

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6e7789064c21: py3: add b'' prefixes in tests/test-help.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5028?vs=11962&id=1198

D5029: py3: byteify tests/wireprotosimplecache.py

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb27bcf81071b: py3: byteify tests/wireprotosimplecache.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5029?vs=11963&id=1198

D5026: py3: use '%s' instead of %r in hgext/convert/subversion.py

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4d6019c0e0ef: py3: use '%s' instead of %r in hgext/convert/subversion.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5026?

D5027: py3: use sys.stdout.buffer for binary output in tests/svnxml.py

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc17d73bf6a4d: py3: use sys.stdout.buffer for binary output in tests/svnxml.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D5020: py3: r'' prefix default values for mimetypes.guess_mime()

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd216ae4cc3f6: py3: r'' prefix default values for mimetypes.guess_mime() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5020

D5024: py3: add 3 more passing tests to whitelist caught by buildbot

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG83912321bf09: py3: add 3 more passing tests to whitelist caught by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D50

D5023: py3: add some r'' prefixes in hgext/narrow/narrowwirepeer.py

2018-10-12 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG885d5cf9b6a4: py3: add some r'' prefixes in hgext/narrow/narrowwirepeer.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D502

Re: [PATCH 1 of 2 V3] revlog: allow flag processors to be applied via store options

2018-10-12 Thread Yuya Nishihara
On Fri, 12 Oct 2018 23:41:29 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1539136401 14400 > # Tue Oct 09 21:53:21 2018 -0400 > # Node ID fad7f4426a669a4f3b29ebda547b23a64d9e9326 > # Parent 8f192f2c4a1e04ac69dec66c48efcb96bc738533 > revlog: allow flag pr

D5039: py3: add more py3 specific output to test

2018-10-12 Thread yuja (Yuya Nishihara)
yuja added a comment. > - a/tests/test-custom-filters.t +++ b/tests/test-custom-filters.t @@ -52,6 +52,7 @@ $ echo "Very very carefully." >> stuff.txt $ hg stat M stuff.txt + ? __pycache__/prefix.cpython-3*.pyc (glob) (py3k !) It's probably better to add `__pycache__` to .hgignore as we

Re: D5039: py3: add more py3 specific output to test

2018-10-12 Thread Yuya Nishihara
> --- a/tests/test-custom-filters.t > +++ b/tests/test-custom-filters.t > @@ -52,6 +52,7 @@ >$ echo "Very very carefully." >> stuff.txt >$ hg stat >M stuff.txt > + ? __pycache__/prefix.cpython-3*.pyc (glob) (py3k !) It's probably better to add `__pycache__` to .hgignore as we do for `

D5025: py3: make test-contrib-perf.t work on python 3

2018-10-12 Thread yuja (Yuya Nishihara)
yuja added a comment. > - a/contrib/perf.py +++ b/contrib/perf.py @@ -75,14 +75,16 @@ _byteskwargs = pycompat.byteskwargs # since 4.1 (or https://phab.mercurial-scm.org/rHGfbc3f73dc802774fbda1fa5da02af1157b637038) _sysstr = pycompat.sysstr # since 4.0 (or https://phab.mercurial-scm

Re: D5025: py3: make test-contrib-perf.t work on python 3

2018-10-12 Thread Yuya Nishihara
> --- a/contrib/perf.py > +++ b/contrib/perf.py > @@ -75,14 +75,16 @@ > _byteskwargs = pycompat.byteskwargs # since 4.1 (or fbc3f73dc802) > _sysstr = pycompat.sysstr # since 4.0 (or 2219f4f82ede) > _xrange = pycompat.xrange # since 4.8 (or 7eba8f83129b) > +fsenco

Re: [PATCH 2 of 2 V3] lfs: register the flag processors per repository

2018-10-12 Thread Yuya Nishihara
On Fri, 12 Oct 2018 23:41:30 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1538626646 14400 > # Thu Oct 04 00:17:26 2018 -0400 > # Node ID ae3bc2b74520fd510c431d02c6266fe0d21adca4 > # Parent fad7f4426a669a4f3b29ebda547b23a64d9e9326 > lfs: register the fla

Re: [PATCH] py3: use str to query registry values on Windows

2018-10-12 Thread Yuya Nishihara
On Fri, 12 Oct 2018 17:44:47 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1539380085 14400 > # Fri Oct 12 17:34:45 2018 -0400 > # Node ID 473751b3bbfce976fd6a821859d1d45f27c1ace1 > # Parent 5b8bab9a7e07692e8d827c5315502301a11e4803 > py3: use str to query

D5014: py3: use %d in a few places

2018-10-12 Thread yuja (Yuya Nishihara)
yuja added a comment. > - time = str(sample.time) +time = sample.time stack = sample.stack sites = ['\1'.join([s.path, str(s.lineno), s.function]) for s in stack] > - file.write("%s\0%s\n" % (time, '\0'.join(sites))) + file.write("%d\0%s\n" % (time, '\0'.join(sites))

Re: D5014: py3: use %d in a few places

2018-10-12 Thread Yuya Nishihara
> -time = str(sample.time) > +time = sample.time > stack = sample.stack > sites = ['\1'.join([s.path, str(s.lineno), s.function]) > for s in stack] > -file.write("%s\0%s\n" % (time, '\0'.join(sites))) > +

[PATCH 2 of 2 V3] lfs: register the flag processors per repository

2018-10-12 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1538626646 14400 # Thu Oct 04 00:17:26 2018 -0400 # Node ID ae3bc2b74520fd510c431d02c6266fe0d21adca4 # Parent fad7f4426a669a4f3b29ebda547b23a64d9e9326 lfs: register the flag processors per repository Previously, enabling the extension for any

[PATCH 1 of 2 V3] revlog: allow flag processors to be applied via store options

2018-10-12 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1539136401 14400 # Tue Oct 09 21:53:21 2018 -0400 # Node ID fad7f4426a669a4f3b29ebda547b23a64d9e9326 # Parent 8f192f2c4a1e04ac69dec66c48efcb96bc738533 revlog: allow flag processors to be applied via store options This allows flag processors t

D5042: py3: add some glob to make output compatible with python 3

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes test-pathconflicts-basic.t and test-origbackup-conflict.t passing on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.

D5041: py3: add a b'' prefix in tests/test-requires.t

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes the test pass on Python 3. 1. skip-blame because just b'' prefix. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5041

D5040: py3: use '%d' for rev nums instead of '%s'

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes test-close-head.t pass on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5040 AFFECTED FILES contrib/python3-w

D5039: py3: add more py3 specific output to test

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Something changed with Python 3 just like million on things. Maybe they should named Python 3 as anaconda or cobra instead of just increasing the version

D5038: py3: more globing of things to make output compatible between py2 and py3

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This also makes the test-ssh-repoerror.t pass on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5038 AFFECTED FILES contr

D5037: py3: use stringutil.pprint() instead of '%r'

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes test-pager-legacy.t pass on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5037 AFFECTED FILES contrib/python3

D5036: py3: use '%d' for integers instead of '%s'

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5036 AFFECTED FILES hgext/convert/monotone.py CHANGE DETAILS diff --git a/hgext/convert/monotone.py b/

D5035: py3: add some py3 specific output to test

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes the test work on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5035 AFFECTED FILES contrib/python3-

D5034: py3: use stringutil.pprint() in color.py instead of '%r'

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes the test-status-color.t on python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5034 AFFECTED FILES contrib/python3-

D5033: py3: add b'' prefixes in tests/test-progress.t

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes the test pass on Python 3. 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5033

D5032: py3: add b'' prefixes to tests/test-keyword.t

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This test is now pretty close to passing on Python 3. 1. skip-blame because just b'' prefixes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercur

D5030: py3: glob some difference between py2 and py3 output

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY On py2, the directory names are under quotes and on py3 they are not and I don't know why. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-sc

D5031: py3: use stringutil.pprint() if we are printing bool values

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5031 AFFECTED FILES hgext/keyword.py CHANGE DETAILS diff --git a/hgext/keyword.py b/hgext/keyword.py -

D5029: py3: byteify tests/wireprotosimplecache.py

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5029 AFFECTED FILES tests/wireprotosimplecac

D5028: py3: add b'' prefixes in tests/test-help.t

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This takes us close to make the test passing. 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.o

D5027: py3: use sys.stdout.buffer for binary output in tests/svnxml.py

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Just following https://phab.mercurial-scm.org/rHG6c0b1d964537ab62d76c208f5f04ab414814c94e here. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial

D5026: py3: use '%s' instead of %r in hgext/convert/subversion.py

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Using '%r' on bytes in python 3 adds b'' prefixes to output which is bad. I don't see a reason why we want to repr() the string here, so just switched to '%s'. Th

D5025: py3: make test-contrib-perf.t work on python 3

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5025 AFFECTED FILES contrib/perf.py contrib/python3-whitelist CHANGE DETAILS diff --git a/

D5024: py3: add 3 more passing tests to whitelist caught by buildbot

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5024 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist b/

[PATCH] py3: use str to query registry values on Windows

2018-10-12 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1539380085 14400 # Fri Oct 12 17:34:45 2018 -0400 # Node ID 473751b3bbfce976fd6a821859d1d45f27c1ace1 # Parent 5b8bab9a7e07692e8d827c5315502301a11e4803 py3: use str to query registry values on Windows This blew up launching any command if extd

D5023: py3: add some r'' prefixes in hgext/narrow/narrowwirepeer.py

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes test-narrow-widen-no-ellipsis.t on Python 3. 1. skip-blame because just r'' pre

D4849: store: introduce a function to get tracked path from a fncache entry

2018-10-12 Thread pulkit (Pulkit Goyal)
pulkit added a subscriber: yuja. pulkit added a comment. @yuja You might want to look at this. This is what I was referencing to when I mentioned about getting the filename back from a fncache entry. We need this for narrow-stream clones. REPOSITORY rHG Mercurial REVISION DETAIL https:/

D5022: absorb: update help text

2018-10-12 Thread mbthomas (Mark Thomas)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8f192f2c4a1e: absorb: update help text (authored by mbthomas, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5022?vs=11943&id=11956 REVISION DETA

Re: [PATCH 1 of 2] tests: configure fsmonitor.mode=paranoid always if fsmonitor is used

2018-10-12 Thread Yuya Nishihara
On Fri, 12 Oct 2018 19:50:19 +0200, FUJIWARA Katsunori wrote: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1539328028 -32400 > # Fri Oct 12 16:07:08 2018 +0900 > # Node ID 2994abbbfddc09425be23a84423d34be34d474a9 > # Parent c3b7d9c54edd045fd463011faa736ef4e5fdc8f9 > # Availabl

Re: [PATCH 1 of 5] tests: fix style issue of importing hgweb in embedded code fragments

2018-10-12 Thread Yuya Nishihara
On Fri, 12 Oct 2018 09:48:43 +0200, FUJIWARA Katsunori wrote: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1538961006 -32400 > # Mon Oct 08 10:10:06 2018 +0900 > # Node ID 46871703ab061d8370eb1a56c0df3e5d748ae154 > # Parent 57500950f40e2903df0e1fe20a3dfab7ad0df3cb > # Availabl

D5010: py3: encode str to bytes

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG56ea22fa55f0: py3: encode str to bytes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5010?vs=11923&id=11955 REVISION DETA

D5018: py3: flush stdout

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9cc411952ab9: py3: flush stdout (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5018?vs=11931&id=11953 REVISION DETAIL ht

D5016: py3: sprinkle statprof.py with utf-8 encoding

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7df42042636d: py3: sprinkle statprof.py with utf-8 encoding (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5016?vs=11929&id

D5017: py3: use raw strings in statprof.py

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb594db74dc13: py3: use raw strings in statprof.py (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5017?vs=11930&id=11952 RE

D5015: py3: switch from print(..., file=) to write()

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9d3034348c4f: py3: switch from print(..., file=) to write() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5015?vs=11928&id

D5014: py3: use %d in a few places

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG113adb1b3f24: py3: use %d in a few places (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5014?vs=11927&id=11950 REVISION D

D5013: py3: use raw strings for stack names

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2864f8d3fcd6: py3: use raw strings for stack names (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5013?vs=11926&id=11949 R

D5011: py3: use write() instead of print()

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1ae0faa14797: py3: use write() instead of print() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5011?vs=11924&id=11947 RE

D5012: py3: use sysbytes for converting code attributes

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG720355c7b7c9: py3: use sysbytes for converting code attributes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5012?vs=11925

D5009: py3: use %d to format ints

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb25fbe7e494e: py3: use %d to format ints (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5009?vs=11922&id=11946 REVISION DE

D5007: py3: encode json output to bytes and use write()

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4b7eb862692e: py3: encode json output to bytes and use write() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5007?vs=11920

D5008: py3: convert sorting field to sysstr

2018-10-12 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb8f6a99ad89b: py3: convert sorting field to sysstr (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5008?vs=11921&id=11945 R

D5022: absorb: update help text

2018-10-12 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Update the help text to reflect the recent changes to absorb in https://phab.mercurial-scm.org/D4999. The `-p` option actually only affects the `-a` option: w

D5019: pager: disable auto pager if we think it doesn't support F, R, X

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg added a comment. I need to review this on a fresher brain. But I'll be honest, I'm not sure how I feel about this. Do you know of other programs that jump through similar hoops to properly set up a pager? INLINE COMMENTS > ui.py:1120 > +desiredargs = 'FRrX' > +

[PATCH 1 of 2] tests: configure fsmonitor.mode=paranoid always if fsmonitor is used

2018-10-12 Thread FUJIWARA Katsunori
# HG changeset patch # User FUJIWARA Katsunori # Date 1539328028 -32400 # Fri Oct 12 16:07:08 2018 +0900 # Node ID 2994abbbfddc09425be23a84423d34be34d474a9 # Parent c3b7d9c54edd045fd463011faa736ef4e5fdc8f9 # Available At https://bitbucket.org/foozy/mercurial-wip # hg pull https:

[PATCH 2 of 2] fsmonitor: use vfs instead of opener (issue5938)

2018-10-12 Thread FUJIWARA Katsunori
# HG changeset patch # User FUJIWARA Katsunori # Date 1539330346 -32400 # Fri Oct 12 16:45:46 2018 +0900 # Node ID e7939b7fa76137718b4f4591de7d85c8ce546df5 # Parent 2994abbbfddc09425be23a84423d34be34d474a9 # Available At https://bitbucket.org/foozy/mercurial-wip # hg pull https:

D4999: absorb: prompt user to accept absorb changes by default

2018-10-12 Thread mbthomas (Mark Thomas)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG31dfa7dac4c9: absorb: prompt user to accept absorb changes by default (authored by mbthomas, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4999?v

D5000: templatefuncs: add truncate parameter to pad

2018-10-12 Thread mbthomas (Mark Thomas)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9458dbfa7f33: templatefuncs: add truncate parameter to pad (authored by mbthomas, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5000?vs=11904&id=

D4999: absorb: prompt user to accept absorb changes by default

2018-10-12 Thread mbthomas (Mark Thomas)
mbthomas updated this revision to Diff 11940. mbthomas added a comment. Rebase and fix conflicts REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4999?vs=11903&id=11940 BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D4999 AFFECTED FI

[PATCH] py3: get around unicode docstrings in test-encoding-textwrap.t and test-help.t

2018-10-12 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1539365108 -7200 # Fri Oct 12 19:25:08 2018 +0200 # Node ID fc11940aeb629be72d144cf77cea245c3369c850 # Parent ba70e3acf58a6a929a23f5b80e08c98a4ad776d4 py3: get around unicode docstrings in test-encoding-textwrap.t and test-help.t On Python 3

D5021: absorb: prompt user to accept absorb changes by default

2018-10-12 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Change the default absorb behaviour to print the changes out and then prompt the user if they want to absorb the changes or not. Providing the `-p` option st

D5020: py3: r'' prefix default values for mimetypes.guess_mime()

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As suggested by @yuja in https://phab.mercurial-scm.org/D4967. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5020 AFFECTED FILES

D5019: pager: disable auto pager if we think it doesn't support F, R, X

2018-10-12 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5019 AFFECTED FILES mercurial/ui.py CHANGE DETAILS diff --git a/mercurial/ui.py b/mercurial/ui.py --

D4998: absorb: print summary of changesets affected

2018-10-12 Thread mbthomas (Mark Thomas)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2c5316796f45: absorb: print summary of changesets affected (authored by mbthomas, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4998?vs=11902&id=11935#toc REPOSITORY rHG Me

D4997: absorb: use a formatter to generate output

2018-10-12 Thread mbthomas (Mark Thomas)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdcda50856843: absorb: use a formatter to generate output (authored by mbthomas, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4997?vs=11901&id=11

D4999: absorb: prompt user to accept absorb changes by default

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. This one failed to apply for some reason. Please resubmit. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4999 To: mbthomas, #hg-reviewers, indy

D4999: absorb: prompt user to accept absorb changes by default

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Niiice. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D4999 To: mbthomas, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel

D4998: absorb: print summary of changesets affected

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. This seems reasonable as a first "something better." REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D4998 To: mbthomas, #hg-reviewers, in

D5001: polib: update to latest release 1.0.7 (upstream rev d75ce6dbbc2a)

2018-10-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG19fc5a986669: polib: update to latest release 1.0.7 (upstream rev d75ce6dbbc2a) (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D5003: tests: fix up test-bad-extension.t's inline extension

2018-10-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9cbc2579f5be: tests: fix up test-bad-extension.t's inline extension (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5003?vs=1

D5004: tests: add lots of globs and conditional output lines

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I think this will clean up (possibly be unnecessary) after `%s`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5004 To: durin42, #hg-reviewers,

D5002: extensions: fix up many many debug logs that use %r

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > extensions.py:178 > return _extensions[shortname] > -log(' - loading extension: %r\n', shortname) > +log(' - loading extension: %r\n', p

D5018: py3: flush stdout

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This avoids buffering due to mixed print() and sys.stdout.write() by profiling code. And with this, test-profile.t passes on Python 3 \o/. Honestly, I'd

D5017: py3: use raw strings in statprof.py

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows main() and argument parsing to work. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5017 AFFECTED FILES mercurial/sta

D5016: py3: sprinkle statprof.py with utf-8 encoding

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Trying to chase the long tail of unicode badness in this file due to frame / code objects holding str everywhere. REPOSITORY rHG Mercurial REVISION DETAIL h

D5015: py3: switch from print(..., file=) to write()

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Because Python 3's print() doesn't like bytes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5015 AFFECTED FILES mercurial/statp

D5014: py3: use %d in a few places

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5014 AFFECTED FILES mercurial/statprof.py CHANGE DETAILS diff --git a/mercurial/statprof.py b/mercur

D5013: py3: use raw strings for stack names

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These are used for simple compares. We don't need to normalize to bytes. As part of this, I expanded a set literal so entries are 1 per line. REPOSITORY rHG

D5012: py3: use sysbytes for converting code attributes

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5012 AFFECTED FILES mercurial/lsprofcalltree.py CHANGE DETAILS diff --git a/mercurial/lsprofcalltree

D5011: py3: use write() instead of print()

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Because print() expects str and we want to write bytes. There should be no functional changes as part of this. REPOSITORY rHG Mercurial REVISION DETAIL h

D5010: py3: encode str to bytes

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These fields are str on Python 2 and 3. This module doesn't import any Mercurial modules. So I just did the str -> bytes inline. REPOSITORY rHG Mercurial REV

D5009: py3: use %d to format ints

2018-10-12 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5009 AFFECTED FILES mercurial/lsprof.py CHANGE DETAILS diff --git a/mercurial/lsprof.py b/mercurial/

  1   2   3   >