D5025: py3: make test-contrib-perf.t work on python 3

2018-10-15 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In https://phab.mercurial-scm.org/D5025#76443, @mharbison72 wrote: > In https://phab.mercurial-scm.org/D5025#75556, @yuja wrote: > > > > def perfstartup(ui, repo, **opts): > > > opts = _byteskwargs(opts) > > > timer, fm = gettimer(ui,

D5025: py3: make test-contrib-perf.t work on python 3

2018-10-15 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In https://phab.mercurial-scm.org/D5025#75556, @yuja wrote: > > def perfstartup(ui, repo, **opts): > > opts = _byteskwargs(opts) > > timer, fm = gettimer(ui, opts) > > > > - cmd = sys.argv[0] +cmd = fsencode(sys.argv[0]) > >

[PATCH] py3: byteify extension in test-relink.t

2018-10-15 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1539536753 14400 # Sun Oct 14 13:05:53 2018 -0400 # Node ID bb67d54942a16a556cdf257d67ef8f98638728a7 # Parent 0947a5818862b8cbd0689d9bb943baa35361a436 py3: byteify extension in test-relink.t diff --git a/tests/test-relink.t

[Bug 5999] New: Build bots need the vcr module installed

2018-10-15 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5999 Bug ID: 5999 Summary: Build bots need the vcr module installed Product: Mercurial project Version: unspecified Hardware: All OS: All Status: UNCONFIRMED

D5104: tests: use regex instead of Python versions for archive hash changes

2018-10-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6519f5aee06f: tests: use regex instead of Python versions for archive hash changes (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5061: f: fix a Python 3 bytes/string issue

2018-10-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGda1629c7dda1: f: fix a Python 3 bytes/string issue (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5061?vs=12070=12155

D5108: context: raise runtime errors with sysstrs

2018-10-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGaf2306bf7d5d: context: raise runtime errors with sysstrs (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5108?vs=12140=12151

D5100: notify: a ton of encoding dancing to deal with the email module

2018-10-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf6ef89cf8234: notify: a ton of encoding dancing to deal with the email module (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5109: tests: add missing b prefix in test-context-metadata.t

2018-10-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb8db53f786f0: tests: add missing b prefix in test-context-metadata.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5107: localrepo: ensure we properly %-format ints vs strings in exception throw

2018-10-15 Thread yuja (Yuya Nishihara)
yuja added a comment. > raise error.FilteredRepoLookupError(_("filtered revision '%s'") > % pycompat.bytestr(changeid)) > except (IndexError, LookupError): > > +if isinstance(changeid, int): > +raise

Re: D5107: localrepo: ensure we properly %-format ints vs strings in exception throw

2018-10-15 Thread Yuya Nishihara
> raise error.FilteredRepoLookupError(_("filtered revision '%s'") > % pycompat.bytestr(changeid)) > except (IndexError, LookupError): > +if isinstance(changeid, int): > +raise error.RepoLookupError(

Re: [PATCH 1 of 2 V5] rust: rustlazyancestors.__contains__

2018-10-15 Thread Yuya Nishihara
On Mon, 15 Oct 2018 11:49:49 +0200, Georges Racinet wrote: > # HG changeset patch > # User Georges Racinet > # Date 1539018701 -7200 > # Mon Oct 08 19:11:41 2018 +0200 > # Node ID a7cbd02e936e6724068219ee4c1c50dd4da2b22c > # Parent 9cadb0f5f2279a60a79b1d0e50eccd60638495c0 > # EXP-Topic

D5110: tests: test-parseindex.t requires no-pure

2018-10-15 Thread adgar (Michael Edgar)
adgar created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Custom python code in test-parseindex.t calls reachableroots2 which is only available in the C revlog index implementation. Marking it #require no-pure ensure it

D4312: New bookflow extension for bookmark-based branching

2018-10-15 Thread idlsoft (Sandu Turcan)
idlsoft updated this revision to Diff 12149. CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4312?vs=10789=12149 REVISION DETAIL https://phab.mercurial-scm.org/D4312 AFFECTED FILES hgext/bookflow.py tests/test-bookflow.t CHANGE DETAILS diff --git a/tests/test-bookflow.t

D4312: New bookflow extension for bookmark-based branching

2018-10-15 Thread markand (David Demelier)
markand added inline comments. INLINE COMMENTS > bookflow.py:30 > + > +configitem(MY_NAME, 'protect', ['@']) > +configitem(MY_NAME, 'require_bookmark', True) Please see this: https://www.mercurial-scm.org/wiki/UIGuideline#adding_new_options REPOSITORY rHG Mercurial REVISION DETAIL

D4312: New bookflow extension for bookmark-based branching

2018-10-15 Thread idlsoft (Sandu Turcan)
idlsoft added a comment. If this is accepted we might want to look into changing the behavior of `hg pull -u`. It should update the working directory only if the active bookmark was moved remotely. I didn't find an easy way to do this without changes to core. REPOSITORY rHG Mercurial

D4312: New bookflow extension for bookmark-based branching

2018-10-15 Thread idlsoft (Sandu Turcan)
idlsoft added a comment. At some point RhodeCode was checking if the destination bookmark was a descendant of the source, and not allowing such pull requests to be created. That would have to be handled as a fast-forward, in other words just moving the destination bookmark. REPOSITORY

D4312: New bookflow extension for bookmark-based branching

2018-10-15 Thread marcink (Marcin K)
marcink accepted this revision. marcink added a comment. This looks fine to me. Works very well with RhodeCode pull-requests based model with bookmark support. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4312 To: idlsoft, #hg-reviewers, pulkit, marcink Cc:

Re: [PATCH 2 of 2 V4] rust: rustlazyancestors.__contains__

2018-10-15 Thread Georges Racinet
On 10/14/2018 05:42 PM, Yuya Nishihara wrote: > On Sun, 14 Oct 2018 15:22:07 +0200, Georges Racinet wrote: >> # HG changeset patch >> # User Georges Racinet >> # Date 1539018701 -7200 >> # Mon Oct 08 19:11:41 2018 +0200 >> # Node ID 50d03c9079ffe3932955353be076ff24c4e87804 >> # Parent

[PATCH 1 of 2 V5] rust: rustlazyancestors.__contains__

2018-10-15 Thread Georges Racinet
# HG changeset patch # User Georges Racinet # Date 1539018701 -7200 # Mon Oct 08 19:11:41 2018 +0200 # Node ID a7cbd02e936e6724068219ee4c1c50dd4da2b22c # Parent 9cadb0f5f2279a60a79b1d0e50eccd60638495c0 # EXP-Topic rustancestors-contains rust: rustlazyancestors.__contains__ This changeset

[PATCH 2 of 2 V5] rust: rustfmt config for hg-direct-ffi

2018-10-15 Thread Georges Racinet
# HG changeset patch # User Georges Racinet on ishtar.racinet.fr # Date 1539594972 -7200 # Mon Oct 15 11:16:12 2018 +0200 # Node ID 58a939a95d72e90a78f795609fe59a1adef88ddf # Parent a7cbd02e936e6724068219ee4c1c50dd4da2b22c # EXP-Topic rustancestors-contains rust: rustfmt config for

D5088: hghave: add pyXY features for Python version numbers

2018-10-15 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D5088#76415, @durin42 wrote: > Ah, so I could do (no-py27 no-py35 !) I suppose. Doesn't help with the other half, but it's still only three lines... `(no-py27 no-py35 !)` would be "<2.7 & < 3.5", which would only be true

Re: [PATCH 3 of 3] help: fix a missing quote character in ui.tweakdefaults

2018-10-15 Thread Yuya Nishihara
On Sun, 14 Oct 2018 12:41:55 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1539495562 14400 > # Sun Oct 14 01:39:22 2018 -0400 > # Node ID 660485f92014dbd8787d3e54b7ef3516f5652dca > # Parent 8b25e88b588d5be2b6a511d4f76e3c0230122e10 > help: fix a missing

Re: [PATCH 2 of 3] py3: appease urllib.request.pathname2url() with a str in Windows

2018-10-15 Thread Yuya Nishihara
On Sun, 14 Oct 2018 12:41:54 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1539492655 14400 > # Sun Oct 14 00:50:55 2018 -0400 > # Node ID 8b25e88b588d5be2b6a511d4f76e3c0230122e10 > # Parent edf769c43bbb10048dceed4cc2ddd46197943ff3 > py3: appease