mharbison72 created this revision.
mharbison72 added a reviewer: indygreg.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is based on a patch by Gregory Szorc. I made small adjustments to
clean up the messaging when the server has the
adgar added a comment.
I had been seeing test failures, but I suspect it is due to a misconfigured
build and not an actual bug. Withdrawing this change.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5110
To: adgar, #hg-reviewers
Cc: yuja, mercurial-devel
mharbison72 accepted this revision.
mharbison72 added a comment.
LGTM, thanks.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5121
To: durin42, #hg-reviewers, mharbison72
Cc: mharbison72, mercurial-devel
___
durin42 abandoned this revision.
durin42 added a comment.
Replaced by a more principled collection of refactors that has the benefit of
working.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5125
To: durin42, #hg-reviewers
Cc: mercurial-devel
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The value of this constant appeared in too many places. While we're
here, rename it to be more consistent with our naming conventions for
experimental
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a mess, in part because there should be more constants
throughout. I know we typically do exp- instead of the x_ business in
this change, but I also had
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I think I want to delete this, but for now we'll just rename this so
it's easy to tell apart from other strings that have the same value.
REPOSITORY
rHG
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Bonus: we catch a spot where the shallowrepo requirement was being
misused as the bundle2 capability.
REPOSITORY
rHG Mercurial
REVISION DETAIL
martinvonz updated this revision to Diff 12184.
martinvonz marked an inline comment as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4895?vs=12175=12184
REVISION DETAIL
https://phab.mercurial-scm.org/D4895
AFFECTED FILES
martinvonz planned changes to this revision.
martinvonz marked an inline comment as done.
martinvonz added inline comments.
INLINE COMMENTS
> pulkit wrote in changegroup.py:1056
> Also, I think this is not the right place to case this because not yielding
> these deltas will prevent the
martinvonz added a comment.
In https://phab.mercurial-scm.org/D4931#76571, @indygreg wrote:
> In https://phab.mercurial-scm.org/D4931#76568, @martinvonz wrote:
>
> > In https://phab.mercurial-scm.org/D4931#76476, @pulkit wrote:
> >
> > > @martinvonz Looks like this got missed for
durin42 updated this revision to Diff 12182.
durin42 edited the summary of this revision.
durin42 retitled this revision from "remotefilelog: rip out lz4 support (WIP)"
to "remotefilelog: rip out lz4 support".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 updated this revision to Diff 12181.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4943?vs=11809=12181
REVISION DETAIL
https://phab.mercurial-scm.org/D4943
AFFECTED FILES
hgext/remotefilelog/basepack.py
hgext/remotefilelog/datapack.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a mess, in part because there should be more constants
throughout.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5125
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We've never used this at Google, and it's strictly an optimization
that indygreg and I are confident we can handle more elegantly
later. Let's rip it out to
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5123
AFFECTED FILES
hgext/remotefilelog/remotefilelogserver.py
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5124
AFFECTED FILES
hgext/remotefilelog/wirepack.py
CHANGE DETAILS
diff --git
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5121
AFFECTED FILES
mercurial/utils/procutil.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 12176.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4782?vs=11802=12176
REVISION DETAIL
https://phab.mercurial-scm.org/D4782
AFFECTED FILES
hgext/remotefilelog/README.md
hgext/remotefilelog/__init__.py
indygreg added a comment.
In https://phab.mercurial-scm.org/D4931#76568, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D4931#76476, @pulkit wrote:
>
> > @martinvonz Looks like this got missed for discussing in sprint, can you
have a look at this please? This is important
martinvonz updated this revision to Diff 12175.
martinvonz retitled this revision from "RFC: narrow: don't include manifests
the client already has" to "narrow: don't include manifests the client already
has".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
martinvonz added a comment.
In https://phab.mercurial-scm.org/D4931#76476, @pulkit wrote:
> @martinvonz Looks like this got missed for discussing in sprint, can you
have a look at this please? This is important because once we have narrowspecs
greater than 255 length and and don't use
https://bz.mercurial-scm.org/show_bug.cgi?id=6002
Bug ID: 6002
Summary: allsuccessors(-1) complains about nullid being pruned
Product: Mercurial
Version: unspecified
Hardware: PC
OS: Mac OS
Status: UNCONFIRMED
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5120
AFFECTED FILES
mercurial/match.py
CHANGE DETAILS
diff --git a/mercurial/match.py
durin42 updated this revision to Diff 12173.
durin42 retitled this revision from "localrepo: ensure we properly %-format
ints vs strings in exception throw" to "localrepo: ensure we properly %-format
int in exception throw".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2c0aa02ecd5a: testing: switch to inserting deltas (authored
by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5116?vs=12164=12172
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGddeb510d6815: testing: remove expectation of error on bad
node insert (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
On Sun, Oct 14, 2018 at 12:30 PM Kyle Lippincott
wrote:
> Per the recent discussion at the 4.8 Sprint, let's discuss the next sprint
> now. The next one, for what is currently assumed to be the 5.0 release in
> Spring 2019, is currently scheduled to happen in Asia and I'm proposing
> Japan
indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> exchange.py:1631
> +kwargs['includepats'] = pullop.includepats or None
> +kwargs['excludepats'] = pullop.excludepats or None
> +
I'd prefer if we
On Tue, Oct 16, 2018 at 10:38 AM Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1539120395 -7200
> # Tue Oct 09 23:26:35 2018 +0200
> # Node ID c835d3020e536e8ef368223d628b9e0c6d0c8251
> # Parent a075ac3487d6d266ec5f2dbd6901da21c38d4ed9
> # EXP-Topic slim-bundle
> #
On Tue, Oct 16, 2018 at 10:36 AM Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1539115321 -7200
> # Tue Oct 09 22:02:01 2018 +0200
> # Node ID a075ac3487d6d266ec5f2dbd6901da21c38d4ed9
> # Parent a69790aaac1946e80e35b28c8f41b14a7f6c0f64
> # EXP-Topic slim-bundle
> #
On Tue, Oct 16, 2018 at 10:35 AM Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1539114828 -7200
> # Tue Oct 09 21:53:48 2018 +0200
> # Node ID a69790aaac1946e80e35b28c8f41b14a7f6c0f64
> # Parent 43f0a37bd9ed20b45d73f667acbb0c3035492e1a
> # EXP-Topic slim-bundle
> #
indygreg added a subscriber: lothiraldan.
indygreg added a comment.
This patch will be invalidated by @lothiraldan's changegroup series, which
I'm reviewing right now. The rebase should be trivial.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4928
To:
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This will help in implementing narrow stream clone.
The narrow extension does add these arguments, but we want to move narrow bits
to core and this will help
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6994a8be3663: storageutil: convert fileid to bytes to avoid
cast to %s (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9b2e1b00ee94: tests: use byte literals in test-storage.py
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://bz.mercurial-scm.org/show_bug.cgi?id=6001
Bug ID: 6001
Summary: Performance regression on bundle in 4.7
Product: Mercurial
Version: default branch
Hardware: PC
OS: Linux
Status: UNCONFIRMED
indygreg updated this revision to Diff 12167.
indygreg edited the summary of this revision.
indygreg retitled this revision from "sqlitestore: file storage backend using
SQLite (RFC)" to "sqlitestore: file storage backend using SQLite".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This function is super hacky and isn't correct 100% of the time. I'm going
to need this functionality on a future non-revlog store.
Let's copy things to
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As the comment in the test specifies, this was relying on storage backend
implementation details. We switch to inserting a raw delta, skipping the
regular
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
test-storage.py manages to trigger this on Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5117
AFFECTED FILES
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
addgroup() doesn't necessarily validate the hashes of each incoming revision.
This is an optimization that allows delta group application to complete
faster.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This fixes a Python 3 breakage due to unknown key due to str/bytes type
mismatch.
1. skip-blame just b'' literals
REPOSITORY
rHG Mercurial
REVISION
lothiraldan updated this revision to Diff 12161.
lothiraldan edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4820?vs=11521=12161
REVISION DETAIL
https://phab.mercurial-scm.org/D4820
AFFECTED FILES
On Tue, Oct 16, 2018 at 10:28 AM Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1539666041 -7200
> # Tue Oct 16 07:00:41 2018 +0200
> # Node ID 0001bda2e00c73f9f82591d3ce7b44f552d0b936
> # Parent da1629c7dda17853c8cbaad0ef14a899af6e9361
> py3: convert string
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Previously, if using `experimental.revisions.disambiguatewithin` (and it
didn't
include rev0), and '0' was the shortest identifier in that disambiguation set,
pulkit added a comment.
@martinvonz Looks like this got missed for discussing in sprint, can you have
a look at this please? This is important because once we have narrowspecs
greater than 255 length and and don't use ellipses, we hit
https://bz.mercurial-scm.org/show_bug.cgi?id=5952
spectral added a comment.
hooper and I talked at the sprint, and they wrote up the following for why
they feel we should keep this out of graphmod/templatekw for now:
> I don't think configurable graph log characters in core is a great idea
right now, since it makes the empty promise
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Currently, if the configuration for a graph edge draw style has multiple bytes
(at least on python2), it is interpreted as "this is a request to draw the
line
https://bz.mercurial-scm.org/show_bug.cgi?id=6000
Bug ID: 6000
Summary: ui.tweakdefaults needs to be better documented
Product: Mercurial
Version: default branch
Hardware: PC
OS: Mac OS
Status: UNCONFIRMED
4 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/1bd3e922de18
changeset: 40309:1bd3e922de18
user:Yuya Nishihara
date:Tue Oct 16 12:39:21 2018 +0200
summary: check-commit: update test expectation per removal of "double empty
line" rule
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5644f7c8982e: branchmap: remove redundant sort (authored by
mjpieters, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5111?vs=12157=12158
On Tue, 16 Oct 2018 12:09:01 +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1539220433 -7200
> # Thu Oct 11 03:13:53 2018 +0200
> # Node ID 16ae7c19c2a2bb89ad4d201630cd87f6c635b7e0
> # Parent a66594c5fad422499bfaf669d182e02fe3c0be32
> # EXP-Topic revset-doc
> #
mjpieters created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There is absoluty no benefit in sorting a list that's being merged into a set
on the next line. The changelog.ancestors() call later on also doesn't benefit
New changeset in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/47084b5ffd80
changeset: 40308:47084b5ffd80
bookmark:@
tag: tip
user:Martijn Pieters
date:Sun Oct 14 15:40:16 2018 +0200
summary: style: drop requirement to only use single lines between
# HG changeset patch
# User Boris Feld
# Date 1539220504 -7200
# Thu Oct 11 03:15:04 2018 +0200
# Node ID c1241e62986a91ebaf5a421c6d78560113be7111
# Parent 16ae7c19c2a2bb89ad4d201630cd87f6c635b7e0
# EXP-Topic revset-doc
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
# HG changeset patch
# User Boris Feld
# Date 1539220433 -7200
# Thu Oct 11 03:13:53 2018 +0200
# Node ID 16ae7c19c2a2bb89ad4d201630cd87f6c635b7e0
# Parent a66594c5fad422499bfaf669d182e02fe3c0be32
# EXP-Topic revset-doc
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
yuja added a comment.
> +def _describemerge(ui, repo, env, toolpath, args):
> +template = ui.config('ui', 'pre-merge-tool-output-template')
> +if not template:
> +return
> +
> +# Remove HG_ prefix from entries in `env` and lowercase them
> +def
> +def _describemerge(ui, repo, env, toolpath, args):
> +template = ui.config('ui', 'pre-merge-tool-output-template')
> +if not template:
> +return
> +
> +# Remove HG_ prefix from entries in `env` and lowercase them
> +def sanitizeenv(k):
> +if k.startswith('HG_'):
# HG changeset patch
# User Boris Feld
# Date 1539123662 -7200
# Wed Oct 10 00:21:02 2018 +0200
# Node ID 153b15991f547ab7aa05e06999a8aa6ee56b7fc3
# Parent c835d3020e536e8ef368223d628b9e0c6d0c8251
# EXP-Topic slim-bundle
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
# HG changeset patch
# User Boris Feld
# Date 1539120395 -7200
# Tue Oct 09 23:26:35 2018 +0200
# Node ID c835d3020e536e8ef368223d628b9e0c6d0c8251
# Parent a075ac3487d6d266ec5f2dbd6901da21c38d4ed9
# EXP-Topic slim-bundle
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
# HG changeset patch
# User Boris Feld
# Date 1539115321 -7200
# Tue Oct 09 22:02:01 2018 +0200
# Node ID a075ac3487d6d266ec5f2dbd6901da21c38d4ed9
# Parent a69790aaac1946e80e35b28c8f41b14a7f6c0f64
# EXP-Topic slim-bundle
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
# HG changeset patch
# User Boris Feld
# Date 1539114828 -7200
# Tue Oct 09 21:53:48 2018 +0200
# Node ID a69790aaac1946e80e35b28c8f41b14a7f6c0f64
# Parent 43f0a37bd9ed20b45d73f667acbb0c3035492e1a
# EXP-Topic slim-bundle
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
28 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/170cd2a5a1da
changeset: 40280:170cd2a5a1da
user:Augie Fackler
date:Sun Oct 14 04:11:35 2018 -0400
summary: fuzz: try *even harder* to prevent Python from looking up usernames
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG47084b5ffd80: style: drop requirement to only use single
lines between top-level objects (authored by mjpieters, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
At the 4.8 sprint, we agreed to repo mass rewriting with style that is more
PEP-8 like. The tentative plan is to use black, which is very opinionated and
doesn't give us much room for
indygreg accepted this revision as: indygreg.
indygreg added a comment.
Get that non-standard LZ4 format outta here!
Yes, we should probably add a compression engine API for doing one-shot
compression/decompression. I could use that in the SQLite extension. If you
don't implement it, I
# HG changeset patch
# User Yuya Nishihara
# Date 1539667110 -7200
# Tue Oct 16 07:18:30 2018 +0200
# Node ID 8190570be13dc584dfab6b8470546c298d6900b6
# Parent a202f1b4611205a08a6730db63dfead59b69f42b
py3: flush std streams before/after running user code in heredoctest.py
Otherwise, things
# HG changeset patch
# User Yuya Nishihara
# Date 1539667178 -7200
# Tue Oct 16 07:19:38 2018 +0200
# Node ID b618c834d8a9a30b7a16927b7ab59f272dee7a43
# Parent 8190570be13dc584dfab6b8470546c298d6900b6
py3: byte-stringify literals in test-keyword.t
# skip-blame just some b'' prefixes
diff
# HG changeset patch
# User Yuya Nishihara
# Date 1539669977 -7200
# Tue Oct 16 08:06:17 2018 +0200
# Node ID a202f1b4611205a08a6730db63dfead59b69f42b
# Parent 94b452b2cfab5442a50b43daf3c6796c8ce8126b
py3: rewrite StringIO fallback for Python 3
diff --git a/contrib/hgclient.py
# HG changeset patch
# User Yuya Nishihara
# Date 1539666247 -7200
# Tue Oct 16 07:04:07 2018 +0200
# Node ID 94b452b2cfab5442a50b43daf3c6796c8ce8126b
# Parent ec5c140cee73da79dc3f48c4e75991cf6e34b7cd
py3: reinvent print() function for contrib/hgclient.py
diff --git a/contrib/hgclient.py
# HG changeset patch
# User Yuya Nishihara
# Date 1539666492 -7200
# Tue Oct 16 07:08:12 2018 +0200
# Node ID ec5c140cee73da79dc3f48c4e75991cf6e34b7cd
# Parent 0001bda2e00c73f9f82591d3ce7b44f552d0b936
py3: work around unicode stdio streams in contrib/hgclient.py
diff --git
# HG changeset patch
# User Yuya Nishihara
# Date 1539666041 -7200
# Tue Oct 16 07:00:41 2018 +0200
# Node ID 0001bda2e00c73f9f82591d3ce7b44f552d0b936
# Parent da1629c7dda17853c8cbaad0ef14a899af6e9361
py3: convert string literals to bytes in contrib/hgclient.py
# skip-blame just many b''
yuja added a comment.
> Custom python code in test-parseindex.t calls reachableroots2 which is
only
> available in the C revlog index implementation. Marking it #require
no-pure
> ensure it will not run for --pure test runs.
It's surrounded with `#if no-pure`. Did you
> Custom python code in test-parseindex.t calls reachableroots2 which is only
> available in the C revlog index implementation. Marking it #require no-pure
> ensure it will not run for --pure test runs.
It's surrounded with `#if no-pure`. Did you experience any test failure?
On Mon, 15 Oct 2018 22:21:23 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date 1539536753 14400
> # Sun Oct 14 13:05:53 2018 -0400
> # Node ID bb67d54942a16a556cdf257d67ef8f98638728a7
> # Parent 0947a5818862b8cbd0689d9bb943baa35361a436
> py3: byteify
76 matches
Mail list logo
