Re: [PATCH 2 of 2] py3: roll up threading.Thread constructor args into **kwargs

2018-10-30 Thread Yuya Nishihara
On Mon, 29 Oct 2018 21:32:14 -0400, Matt Harbison wrote: > On Fri, 26 Oct 2018 04:05:00 -0400, Boris FELD > wrote: > > > LGTM. > > > > I couldn't find any code that was passing those arguments and as the > > class is local to the `_windowsworker` function, can we remove the > > support for thos

Re: [PATCH STABLE] http: work around custom http client classes that refuse extra attrs

2018-10-30 Thread Yuya Nishihara
On Mon, 29 Oct 2018 16:28:03 -0400, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1540844622 14400 > # Mon Oct 29 16:23:42 2018 -0400 > # Branch stable > # Node ID 588f1e9a4d1665b8dc02ab409312f59d06414d02 > # Parent 7e4ffe2719e4af2a9e56c9ee097ed6720f5c3906 > htt

D5194: wireprotov2: add an extension to cache wireproto v2 responses in S3

2018-10-30 Thread sheehan (Connor Sheehan)
sheehan added a comment. In https://phab.mercurial-scm.org/D5194#77606, @martinvonz wrote: > Is this useful enough to others that it should live in the hg core repo? It doesn't seem like it to me, but maybe I'm wrong. My thought process was that since the new wire protocol support

Re: [PATCH 3 of 3 STABLE] rust: propagate Python exception raised from index_get_parents_checked()

2018-10-30 Thread Georges Racinet
On 10/29/2018 02:03 PM, Yuya Nishihara wrote: > On Sun, 28 Oct 2018 22:11:03 +0900, Yuya Nishihara wrote: >> # HG changeset patch >> # User Yuya Nishihara >> # Date 1540730473 -32400 >> # Sun Oct 28 21:41:13 2018 +0900 >> # Branch stable >> # Node ID c40ceec4d993927b6788ad430dc6b4f3087d9aeb >

D5196: changegroup: restore default node ordering (issue6001)

2018-10-30 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changeset https://phab.mercurial-scm.org/rHGdb5501d93bcf6ada3426a45e901094fd877e370f changed the default node ordering from "storage" to "linearize". Wh

D5195: changegroup: introduce an explicit linear sorting

2018-10-30 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We still need to linearize the revisions in some cases, introduce an explicit `linear` sorting before changing back the defa

D5102: beautifygraph: add configs for customizing the characters

2018-10-30 Thread hooper (Danny Hooper)
hooper added a comment. I'll elaborate a bit. I think the idea of using unicode to make the graph good looking is flawed. There are no characters that properly serve common cases like this: o | \ o That's part of why there was some disagreement in early discussion o

[Bug 6015] New: IntegrityError when applying changesets

2018-10-30 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6015 Bug ID: 6015 Summary: IntegrityError when applying changesets Product: Mercurial Version: stable branch Hardware: All OS: All Status: UNCONFIRMED Keywords:

Re: [PATCH 3 of 3 STABLE] rust: propagate Python exception raised from index_get_parents_checked()

2018-10-30 Thread Yuya Nishihara
On Tue, 30 Oct 2018 15:48:43 +0100, Georges Racinet wrote: > On 10/29/2018 02:03 PM, Yuya Nishihara wrote: > >> - return rustlazyancestors_contains(self->iter, PyInt_AS_LONG(rev)); > >> + res = rustlazyancestors_contains(self->iter, PyInt_AS_LONG(rev)); > >> + if (PyErr_Occurred()) > >> +