On Mon, 5 Nov 2018 11:17:59 -0500
Augie Fackler wrote:
> Howdy folks,
>
> I think I'd like to expire all reviews from Phabricator that haven't been
> updated since September 1st of this year. That's a lot of reviews, but they
> all seem pretty dormant at this point. Obviously people can
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
IIRC we `#define` `PyInt` and `PyLong` in the source for Python 3
compatibility. I remember doing something really hacky to unblock getting the C
extensions to compile on
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1419f780207c: remotefilelog: fix various minor py3 problems
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG433189151d5d: remotefilelog: rip out a missed mention of
lz4 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
rdamazio created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Python 3 recommends detecting OSs with the prefix of the platform, but we were
comparing the full string for macOS. We also didn't have Linux detection,
which
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8239d4e5d05f: tweakdefaults: remove
commands.resolve.mark-check=abort, it is too broken (authored by spectral,
committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
hooper updated this revision to Diff 12437.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5226?vs=12436=12437
REVISION DETAIL
https://phab.mercurial-scm.org/D5226
AFFECTED FILES
hgext/fix.py
tests/test-fix-clang-format.t
hooper created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This name was always inaccurate, since the config accepts any pattern.
Hopefully so few people use this right now that it won't matter, but there
will
now be a
hooper added a comment.
In https://phab.mercurial-scm.org/D5200#77865, @yuja wrote:
> Looks good, but test-check-config.t failed probably because the doc couldn't
> be found by the checker.
Looks like it's picky about whitespace.
REPOSITORY
rHG Mercurial
REVISION DETAIL
hooper updated this revision to Diff 12435.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5200?vs=12355=12435
REVISION DETAIL
https://phab.mercurial-scm.org/D5200
AFFECTED FILES
hgext/fix.py
tests/test-fix.t
CHANGE DETAILS
diff --git
spectral added a comment.
(Please queue this on stable, thanks!)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5225
To: spectral, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
See issue6020 for the current case. I don't want to continue attempting to fix
this on the stable branch, so I'm removing from tweakdefaults and will send
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This fixes
SystemError: PyEval_EvalFrameEx returned a result with an error set
in test-storage.py on Python 3. I believe we should audit *all*
callsites
https://bz.mercurial-scm.org/show_bug.cgi?id=6020
Bug ID: 6020
Summary: commands.resolve.mark-check breaks `hg resolve -m` if
files are deleted
Product: Mercurial
Version: unspecified
Hardware: PC
OS: Linux
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame b prefixes and pycompat.long, nothing remotely interesting
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5223
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5222
AFFECTED FILES
hgext/remotefilelog/README.md
CHANGE DETAILS
diff --git
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Various 3rd party extensions supplement where per-repo config data
lives. Looking at their sources, they resort to unorthodox means to
inject the config data.
https://bz.mercurial-scm.org/show_bug.cgi?id=6019
Bug ID: 6019
Summary: Unknown exception during narrow clone
Product: Mercurial
Version: 4.6.1
Hardware: PC
OS: Linux
Status: UNCONFIRMED
Severity: feature
queued, thanks
> On Nov 4, 2018, at 07:55, Yuya Nishihara wrote:
>
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1541234843 -32400
> # Sat Nov 03 17:47:23 2018 +0900
> # Node ID ff828815f180a36706d51602ecd451d9294f0c36
> # Parent 03e070898f1b617263663a2c0cee2eb3599d8c2a
> ui:
queued, thanks
> On Nov 4, 2018, at 07:50, Yuya Nishihara wrote:
>
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1541331866 -32400
> # Sun Nov 04 20:44:26 2018 +0900
> # Node ID 217637aec0097552e2353740c0b1c9b66f77fa69
> # Parent 78e5b9d815facdba962950aad03e8e1b3ae60288
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGfc2766860796: remotefilelog: consolidate and rename on-disk
store requirement (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6f0b6905ef6f: shallowutil: introduce a helper function
isenabled() (authored by pulkit, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D5190?vs=12337=12426#toc
REPOSITORY
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG67e35dceab9b: tests: remove lz4 as dependency while running
tests (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2dd3a0201307: remotefilelog: drop compat code for
getbundle_shallow wireprotocol command (authored by pulkit,
committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1c34b31a6c9c: remotefilelogserver: add a matcher argument
to _walkstreamfiles() (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG466dd4d70bff: remotefilelog: rename wireproto methods and
remaining capabilities (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG525dcf5c1d41: remotefilelog: remove some BC code related to
streamclone (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb35a096b9bff: remotefilelog: add some docstring (authored
by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5131?vs=12193=12424
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG10c10da14c5d: remotefilelog: bump pack file formats to
version 2 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe2a1584e9e3f: remotefilelog: rip out lz4 support (authored
by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4944?vs=12182=12419
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGed19958dbf5d: remotefilelog: consolidate and rename bundle2
capability (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG354acd0dc637: remotefilelog: rename capability for legacy
ssh file fetching method (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6d64e2abe8d3: remotefilelog: remove support for fetching
packs (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb6b2a3d22344: remotefilelog: avoid hard-coding pack names
in tests (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3b90087623fd: remotefilelogserver: remove pack-serving
functionality (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG64b16de2c66a: remotefilelog: remove now-unused wirepack
code (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf21543d7f611: remotefilelog: jettison example cache client
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb67854106edb: remotefilelog: prune obsolete method
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4940?vs=12404=12412
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3fbfbc8c9f82: remotefilelog: transplant runbgcommand to
procutil (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2e09d1cae90c: logtoprocess: use new runbgcommand from
procutil (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8fab95aa5280: procutil: port over windows encoding fixes
from logtoprocess (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG60eb35b0c11c: remotefilelog: remove function that was
described as deprecated (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3a333a582d7b: remotefilelog: import pruned-down
remotefilelog extension from hg-experimental (authored by durin42, committed by
).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 updated this revision to Diff 12406.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4943?vs=12181=12406
REVISION DETAIL
https://phab.mercurial-scm.org/D4943
AFFECTED FILES
hgext/remotefilelog/basepack.py
hgext/remotefilelog/datapack.py
durin42 updated this revision to Diff 12405.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4782?vs=12403=12405
REVISION DETAIL
https://phab.mercurial-scm.org/D4782
AFFECTED FILES
hgext/remotefilelog/README.md
hgext/remotefilelog/__init__.py
durin42 updated this revision to Diff 12404.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4940?vs=11806=12404
REVISION DETAIL
https://phab.mercurial-scm.org/D4940
AFFECTED FILES
hgext/remotefilelog/remotefilelog.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 12403.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4782?vs=12401=12403
REVISION DETAIL
https://phab.mercurial-scm.org/D4782
AFFECTED FILES
hgext/remotefilelog/README.md
hgext/remotefilelog/__init__.py
durin42 updated this revision to Diff 12402.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4939?vs=11805=12402
REVISION DETAIL
https://phab.mercurial-scm.org/D4939
AFFECTED FILES
hgext/logtoprocess.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 12401.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4782?vs=12176=12401
REVISION DETAIL
https://phab.mercurial-scm.org/D4782
AFFECTED FILES
hgext/remotefilelog/README.md
hgext/remotefilelog/__init__.py
durin42 added a comment.
In https://phab.mercurial-scm.org/D5216#77936, @markand wrote:
> Guys I wonder if you really consider HGTESTCATAPULTSERVERPIPE as readable.
Not really, but it's hg-developer-only, so I'm not super-inclined to worry
about it. I won't turn down patches to
Could we get a quick review before we spend more time on the series?
On 18/10/2018 19:37, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1539880502 -7200
> # Thu Oct 18 18:35:02 2018 +0200
> # Node ID 9b6b8f0b3d821f17db216ba346934b8ffb6de1d5
> # Parent
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Foozy documented the differences between revsets branch(), tag(),
bookmark(), and named() in
markand added a comment.
Guys I wonder if you really consider HGTESTCATAPULTSERVERPIPE as readable.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5216
To: spectral, #hg-reviewers
Cc: markand, mercurial-devel
___
https://bz.mercurial-scm.org/show_bug.cgi?id=6018
Bug ID: 6018
Summary: revset bookmark('re:nonexistent') aborts
Product: Mercurial
Version: 4.8
Hardware: PC
OS: Linux
Status: UNCONFIRMED
Severity: bug
Howdy folks,
I think I'd like to expire all reviews from Phabricator that haven't been
updated since September 1st of this year. That's a lot of reviews, but they all
seem pretty dormant at this point. Obviously people can reopen them or start
new ones as appropriate. My methodology would
New changeset (1 on stable) in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/da2e874fe582
changeset: 40472:da2e874fe582
branch: stable
tag: tip
parent: 40459:5eaa5eb0db4e
user:Kyle Lippincott
date:Fri Nov 02 11:57:45 2018 -0700
summary: resolve:
martinvonz added a comment.
I noticed I had an unsubmitted comment on this patch. Can be done in a
follow-up (if at all).
INLINE COMMENTS
> narrowcommands.py:142-143
> include, exclude = repo.narrowpats
> kwargs['oldincludepats'] = include
> kwargs['oldexcludepats'] = exclude
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG440f5b65be57: exchange: pass includepats and excludepats as
arguments to getbundle() (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9aeb9e2d28a7: store: introduce _matchtrackedpath() and use
it to filter store files (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa2c4502e409b: narrow: only send includepats and excludepats
if they are not empty (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added inline comments.
INLINE COMMENTS
> store.py:39
> +elif path.startswith('meta/'):
> +return matcher.visitdir(path[len('meta/'):-len('/00manifest.i')] or
> '.')
> +
Please follow up with a patch that raises ProgrammingError at the end of this
function - right now you
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc311424ea579: catapult: add a bit more documentation on how
to use catapult tracing (authored by spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG889424be7ad2: catapult: introduce HGTESTCATAPULTSERVERPIPE
to control run-tests tracing (authored by spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa9e00c48c5ef: catapult: rename active to
activetrace; this isnt storing a boolean state (authored by
spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
(In fact by this point we've already broken backwards compat with old
installs, just by using zlib instead of lz4)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5189
To: pulkit, #hg-reviewers, durin42
Cc: mercurial-devel
On Mon, 05 Nov 2018 11:42:19 +0100, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1526995577 -7200
> # Tue May 22 15:26:17 2018 +0200
> # Node ID f4f31bac4057231d97000967cb731ac0da25f30b
> # Parent e0dea186ab6edfab124b1dfd84237a4b8142f13b
> # EXP-Topic
# HG changeset patch
# User Boris Feld
# Date 1526995577 -7200
# Tue May 22 15:26:17 2018 +0200
# Node ID f4f31bac4057231d97000967cb731ac0da25f30b
# Parent e0dea186ab6edfab124b1dfd84237a4b8142f13b
# EXP-Topic gratuitous-cleanup
# Available At https://bitbucket.org/octobus/mercurial-devel/
#
67 matches
Mail list logo
