[PATCH] tests: disable remotefilelog on Windows

2018-11-24 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1543086662 18000 # Sat Nov 24 14:11:02 2018 -0500 # Node ID 99e50fb3ffc6fa3d5e81427c69e5280c84254ab0 # Parent 1f9de5636e5f7f4bfe2d3fb8c5dde543a1870161 tests: disable remotefilelog on Windows I've spent a non trivial amount of time trying to e

D5295: branchmap: define a hasbranch() to find whether a branch exists or not

2018-11-24 Thread yuja (Yuya Nishihara)
yuja added a comment. I don't think it's good idea to re-scan the cache file per hasbranch() call. Instead, we'll probably need a lazy parser backed by a in-memory cache data. The current cache file format is text-based, which wouldn't be easily bisected without loading (or memmap) the wh

Re: D5295: branchmap: define a hasbranch() to find whether a branch exists or not

2018-11-24 Thread Yuya Nishihara
I don't think it's good idea to re-scan the cache file per hasbranch() call. Instead, we'll probably need a lazy parser backed by a in-memory cache data. The current cache file format is text-based, which wouldn't be easily bisected without loading (or memmap) the whole content. > +def hasbranch(r

D5297: tests: add test for `--version` flag of perfchangegroupchangelog

2018-11-24 Thread yuja (Yuya Nishihara)
yuja added a comment. > + $ hg perfchangegroupchangelog --version 01 > + Mercurial Distributed SCM (version 4.8+262-efd0f79246e3+20181122) > + (see https://mercurial-scm.org for more information) > + > + Copyright (C) 2005-2018 Matt Mackall and others > + This is free soft

Re: D5297: tests: add test for `--version` flag of perfchangegroupchangelog

2018-11-24 Thread Yuya Nishihara
> + $ hg perfchangegroupchangelog --version 01 > + Mercurial Distributed SCM (version 4.8+262-efd0f79246e3+20181122) > + (see https://mercurial-scm.org for more information) > + > + Copyright (C) 2005-2018 Matt Mackall and others > + This is free software; see the source for copying conditio

D5297: tests: add test for `--version` flag of perfchangegroupchangelog

2018-11-24 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcfaf3843491b: perf: rename version flag of perfchangegroupchangelog to cgversion (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5297?vs=12588&id=12593#toc

Re: [PATCH] push: config option to control behavior when pushing to a publishing server

2018-11-24 Thread Yuya Nishihara
On Fri, 23 Nov 2018 13:23:43 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1541397139 -28800 > # Mon Nov 05 13:52:19 2018 +0800 > # Node ID ea18d94ac7006faff7148cb2eca3b970655955b9 > # Parent efd0f79246e3e6633dfd06226464a48584f69b19 > # EXP-Topic push

Re: [PATCH 1 of 4 V2] perf: add a `clear-revlogs` flag to `perftags`

2018-11-24 Thread Yuya Nishihara
On Fri, 23 Nov 2018 18:25:47 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1542710780 0 > # Tue Nov 20 10:46:20 2018 + > # Node ID 2e15140b7b18f40ebbcf71e82c99acf8edadb69b > # Parent 4369c00a8ee168565fba97112283bbc00be8ce44 > # EXP-Topic perf-tags > # Avail

Re: [PATCH 3 of 4 V2] perf: add a `clear-revlogs` flag to `perfbookmarks`

2018-11-24 Thread Yuya Nishihara
On Fri, 23 Nov 2018 18:25:49 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1542711320 0 > # Tue Nov 20 10:55:20 2018 + > # Node ID 438718ecc3058c55b0d5a4a9742b3325b83e78cc > # Parent 832048aabff97aa43cd306cd70cea00227f5e19e > # EXP-Topic perf-tags > # Avail

Re: [PATCH 2 of 4 V2] tags: cache `repo.changelog` access when checking tags nodes

2018-11-24 Thread Yuya Nishihara
On Fri, 23 Nov 2018 18:25:48 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1542710295 0 > # Tue Nov 20 10:38:15 2018 + > # Node ID 832048aabff97aa43cd306cd70cea00227f5e19e > # Parent 2e15140b7b18f40ebbcf71e82c99acf8edadb69b > # EXP-Topic perf-tags > # Avail

Re: [PATCH 1 of 2] remotefilelog: drop some compatibility cruft for finding the hg exeutable

2018-11-24 Thread Yuya Nishihara
On Sat, 24 Nov 2018 01:46:36 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1543029536 18000 > # Fri Nov 23 22:18:56 2018 -0500 > # Node ID 2abf33243bea3e4679ac944315d82fce21918d8f > # Parent 197f7eebf5f89fb2b9d0e117157b4a040dde0a89 > remotefilelog: drop s

D5299: phabricator: fallback reading arcanist config files

2018-11-24 Thread mharbison72 (Matt Harbison)
mharbison72 added inline comments. INLINE COMMENTS > phabricator.py:179 > +""" > +if os.name == 'nt': > +paths = [ pycompat.iswindows > phabricator.py:181 > +paths = [ > +os.path.join(os.environ['ProgramData'], > + 'Phabricator', I th

[PATCH 4 of 4] annotate: remove dead code to not convert path to relative path

2018-11-24 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1543057555 -32400 # Sat Nov 24 20:05:55 2018 +0900 # Node ID 1aac31914fee54803cd5c206f0dddcc18f6120e2 # Parent 3ba66c3809b43da8216aea05b0cef15bf3a53109 annotate: remove dead code to not convert path to relative path It's annotate. There shou

[PATCH 3 of 4] annotate: start pager soon after command options are validated

2018-11-24 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1543052504 -32400 # Sat Nov 24 18:41:44 2018 +0900 # Node ID 3ba66c3809b43da8216aea05b0cef15bf3a53109 # Parent b37d6fbea8df01bd7ea822435f4bfce2a97112e7 annotate: start pager soon after command options are validated It helps extracting helper

[PATCH 2 of 4] annotate: check and update command options first

2018-11-24 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1543052324 -32400 # Sat Nov 24 18:38:44 2018 +0900 # Node ID b37d6fbea8df01bd7ea822435f4bfce2a97112e7 # Parent 4c5309a4bd4028c260fcc6ceda1ba48167e8733e annotate: check and update command options first It helps extracting helper class. diff

[PATCH 1 of 4] annotate: format local tables in less-dense form

2018-11-24 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1543052204 -32400 # Sat Nov 24 18:36:44 2018 +0900 # Node ID 4c5309a4bd4028c260fcc6ceda1ba48167e8733e # Parent 50a64c321c1e74b98ec1fa959bdc92efdc6f4ee7 annotate: format local tables in less-dense form I'll move these to a class, where one-ex