Re: Auto-formatting code with black - object now if you have a strong opinion

2018-11-29 Thread Anton Shestakov
On Thu, 29 Nov 2018 16:29:30 -0500 Augie Fackler wrote: > On Wed, Nov 28, 2018 at 7:13 AM Yuya Nishihara wrote: > > Can we somehow reject patches automatically if they disagree with the > > formatter? I'm not interested in fixing test-check-* failure in flight. > > Two possibilities here: > >

Re: Auto-formatting code with black - object now if you have a strong opinion

2018-11-29 Thread Anton Shestakov
On Tue, 27 Nov 2018 10:52:56 -0500 Augie Fackler wrote: > In https://phab.mercurial-scm.org/D5064 we're talking about using the `black` > formatter from Ɓukasz Langa on hg. This will imply a few style changes to our > codebase, notably: > > * We'll use " everywhere instead of ' > * Import

[Bug 6029] New: lfconvert --to-normal fails

2018-11-29 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6029 Bug ID: 6029 Summary: lfconvert --to-normal fails Product: Mercurial Version: 4.7 Hardware: PC OS: Windows Status: UNCONFIRMED Severity: bug

Re: Auto-formatting code with black - object now if you have a strong opinion

2018-11-29 Thread Gregory Szorc
On Thu, Nov 29, 2018 at 1:28 PM Augie Fackler wrote: > On Tue, Nov 27, 2018 at 6:42 PM Gregory Szorc > wrote: > > > > On Tue, Nov 27, 2018 at 8:13 AM Augie Fackler wrote: > >> > >> > >> > >> > On Nov 27, 2018, at 11:09, Pulkit Goyal <7895pul...@gmail.com> wrote: > >> > > >> > I am +1 on using

D5064: style: run black on a subset of mercurial

2018-11-29 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D5064#78994, @mharbison72 wrote: > In https://phab.mercurial-scm.org/D5064#78990, @durin42 wrote: > > > Does anyone strongly object, or do we want to embrace black and the formatting changes it implies? > > > Is there a

D5347: manifest: reject lines shorter than 42 bytes, not 22

2018-11-29 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Yuya correctly spotted during the review of https://phab.mercurial-scm.org/rHGf27f8e9ef1e731723146b670a1a9a86e1a088069 that we're dealing with hexlified hashes

D5270: tests: sniff for libfuzzer actually being available in test-fuzz-targets.t

2018-11-29 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 12658. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5270?vs=12616=12658 REVISION DETAIL https://phab.mercurial-scm.org/D5270 AFFECTED FILES tests/test-fuzz-targets.t CHANGE DETAILS diff --git

D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t

2018-11-29 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 12657. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5269?vs=12615=12657 REVISION DETAIL https://phab.mercurial-scm.org/D5269 AFFECTED FILES tests/test-fuzz-targets.t CHANGE DETAILS diff --git

[PATCH STABLE] tests: stabilize test-inherit-mode.t on FreeBSD and macOS (issue6026)

2018-11-29 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1543526737 18000 # Thu Nov 29 16:25:37 2018 -0500 # Branch stable # Node ID 2a350cb39a459fea5767aa25804180be10849408 # Parent 25b7c4cb5de1593e16bbd7a7dafbd28baa743995 tests: stabilize test-inherit-mode.t on FreeBSD and macOS (issue6026)

Re: Auto-formatting code with black - object now if you have a strong opinion

2018-11-29 Thread Augie Fackler
On Wed, Nov 28, 2018 at 7:13 AM Yuya Nishihara wrote: > > On Tue, 27 Nov 2018 15:42:21 -0800, Gregory Szorc wrote: > > I also have some issues with black's formatting. I dislike black's use of > > double quotes for strings (maybe a holdover from my knowledge of shell, > > Perl, and PHP, where

Re: Auto-formatting code with black - object now if you have a strong opinion

2018-11-29 Thread Augie Fackler
On Tue, Nov 27, 2018 at 6:42 PM Gregory Szorc wrote: > > On Tue, Nov 27, 2018 at 8:13 AM Augie Fackler wrote: >> >> >> >> > On Nov 27, 2018, at 11:09, Pulkit Goyal <7895pul...@gmail.com> wrote: >> > >> > I am +1 on using black. >> > >> > Adding to what Augie said, we plan to preserve the

[Bug 6028] New: evolve fails with mercurial.error.ProgrammingError: unsupported changeid '' of type

2018-11-29 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6028 Bug ID: 6028 Summary: evolve fails with mercurial.error.ProgrammingError: unsupported changeid '' of type Product: Mercurial Version: 4.8 Hardware: Macintosh

D5345: sparse-revlog: enabled by default

2018-11-29 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Thanks for all the numbers and a detailed commit message \o/. Can you help finding answers to following extra questions? - What will be effect on existing repositories which don't convert to sparse revlog due to some reasons? - If enabled by default in 4.9,

D2880: bundle: add the possibility to bundle bookmarks (issue5792)

2018-11-29 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Just a reminder that this has not been queued yet. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2880 To: lothiraldan, #hg-reviewers, indygreg Cc: martinvonz, indygreg, pulkit, mercurial-devel

Re: [PATCH 2 of 2] remotefilelog: prevent this extension from loading on Windows

2018-11-29 Thread Augie Fackler
> On Nov 29, 2018, at 08:18, Yuya Nishihara wrote: > > Can't we blacklist them on the buildbot then? > > #require is hard requirement, which make not possible to run the remotefilelog > tests on Windows. I'm happy to patch out the #require on a per-test basis as I tackle making them work on

[PATCH] sparse-revlog: protect C code against delta chain including nullrev

2018-11-29 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1543508919 -3600 # Thu Nov 29 17:28:39 2018 +0100 # Node ID 5a6a715f4ed0fa4d47bdd6b6413797fe6cb17f88 # Parent 2f14d1bbc9a7a142b421285c0708320b46be7a56 # EXP-Topic sparse-followup # Available At https://bitbucket.org/octobus/mercurial-devel/ #

Re: [PATCH 2 of 2] remotefilelog: prevent this extension from loading on Windows

2018-11-29 Thread Yuya Nishihara
On Thu, 29 Nov 2018 08:08:06 -0500, Augie Fackler wrote: > On Thu, Nov 29, 2018, 08:03 Matt Harbison > > > > > On Nov 29, 2018, at 6:24 AM, Yuya Nishihara wrote: > > > > > >> On Wed, 28 Nov 2018 18:41:05 -0500, Matt Harbison wrote: > > >> > > On Nov 28, 2018, at 1:59 PM, Augie Fackler

Re: [PATCH 2 of 2] remotefilelog: prevent this extension from loading on Windows

2018-11-29 Thread Augie Fackler
On Thu, Nov 29, 2018, 08:03 Matt Harbison > > On Nov 29, 2018, at 6:24 AM, Yuya Nishihara wrote: > > > >> On Wed, 28 Nov 2018 18:41:05 -0500, Matt Harbison wrote: > >> > On Nov 28, 2018, at 1:59 PM, Augie Fackler wrote: > > On Nov 27, 2018, at 22:46, Matt Harbison > wrote: >

Re: [PATCH 2 of 2] remotefilelog: prevent this extension from loading on Windows

2018-11-29 Thread Matt Harbison
> On Nov 29, 2018, at 6:24 AM, Yuya Nishihara wrote: > >> On Wed, 28 Nov 2018 18:41:05 -0500, Matt Harbison wrote: >> On Nov 28, 2018, at 1:59 PM, Augie Fackler wrote: On Nov 27, 2018, at 22:46, Matt Harbison wrote: # HG changeset patch # User Matt Harbison

Re: [PATCH 1 of 2 STABLE] wireprotov2peer: always return a bool from _processredirect()

2018-11-29 Thread Yuya Nishihara
On Wed, 28 Nov 2018 12:56:21 -0800, Gregory Szorc wrote: > # HG changeset patch > # User Gregory Szorc > # Date 1543430263 28800 > # Wed Nov 28 10:37:43 2018 -0800 > # Branch stable > # Node ID 94b0d0f996e11aece0d601201f074c5a9eb0e741 > # Parent 25b7c4cb5de1593e16bbd7a7dafbd28baa743995 >

D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t

2018-11-29 Thread yuja (Yuya Nishihara)
yuja added a comment. > +which(1) could exit nonzero, but that's fine because we'll still end > +up without a valid executable, so we don't need to check $? here. True, but the exit code is printed as `[1]`. > + $ GMAKE=`which gmake` > + $ if [ -n "$GMAKE" -a -x $GMAKE ] ;

Re: D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t

2018-11-29 Thread Yuya Nishihara
> +which(1) could exit nonzero, but that's fine because we'll still end > +up without a valid executable, so we don't need to check $? here. True, but the exit code is printed as `[1]`. > + $ GMAKE=`which gmake` > + $ if [ -n "$GMAKE" -a -x $GMAKE ] ; then > + > MAKE=$GMAKE Can you try

D5309: match: remove obsolete catching of OverflowError

2018-11-29 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f14d1bbc9a7: match: remove obsolete catching of OverflowError (authored by martinvonz, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5309?vs=12618=12656#toc REPOSITORY

D5308: store: don't pass 'atomictemp=True' while appending to fncache

2018-11-29 Thread yuja (Yuya Nishihara)
yuja added a comment. > > As I said, we'll also need to somehow hide partial data from another > > reader processes. There's no read lock. > > > Read locks! was there a previous attempt on implementing them? I will try to take a shot at implementing them. I am unable to

Re: D5308: store: don't pass 'atomictemp=True' while appending to fncache

2018-11-29 Thread Yuya Nishihara
> > As I said, we'll also need to somehow hide partial data from another > > reader processes. There's no read lock. > > > Read locks! was there a previous attempt on implementing them? I will try > to take a shot at implementing them. I am unable to find any good detail > except

D5309: match: remove obsolete catching of OverflowError

2018-11-29 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued, thanks. > regex = '(?:%s)' % '|'.join([_regex(k, p, globsuffix) >for (k, p, s) in kindpats]) > > - if len(regex) > 2: > - raise OverflowError > - return regex, _rematcher(regex) > - except OverflowError: +

Re: D5309: match: remove obsolete catching of OverflowError

2018-11-29 Thread Yuya Nishihara
Queued, thanks. > regex = '(?:%s)' % '|'.join([_regex(k, p, globsuffix) > for (k, p, s) in kindpats]) > -if len(regex) > 2: > -raise OverflowError > -return regex, _rematcher(regex) > -except OverflowError: > +

Re: [PATCH] sparse: raise a move verbose index error from the C code

2018-11-29 Thread Yuya Nishihara
On Wed, 28 Nov 2018 19:36:46 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1543281014 -3600 > # Tue Nov 27 02:10:14 2018 +0100 > # Node ID 237d0b9e6b04740845930e1322bde978bab7da92 > # Parent 0800d9e6e216b2ca59f05788b288685b8d7b2d93 > # EXP-Topic sparse-cext >

Re: [PATCH 2 of 2] remotefilelog: prevent this extension from loading on Windows

2018-11-29 Thread Yuya Nishihara
On Wed, 28 Nov 2018 18:41:05 -0500, Matt Harbison wrote: > > > On Nov 28, 2018, at 1:59 PM, Augie Fackler wrote: > > > >> On Nov 27, 2018, at 22:46, Matt Harbison wrote: > >> > >> # HG changeset patch > >> # User Matt Harbison > >> # Date 1543376352 18000 > >> # Tue Nov 27 22:39:12 2018