[Bug 6038] New: log + diffstat is really slow with big changes

2018-12-13 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6038 Bug ID: 6038 Summary: log + diffstat is really slow with big changes Product: Mercurial Version: unspecified Hardware: PC OS: All Status: UNCONFIRMED

mercurial@40935: 10 new changesets (1 on stable)

2018-12-13 Thread Mercurial Commits
10 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/21f5810df848 changeset: 40926:21f5810df848 branch: stable parent: 40820:4265bfb53dd3 user:Julien Cristau date:Wed Dec 12 06:41:19 2018 +0100 summary: test: fix

D5418: perfdiscovery: benching findcommonheads()

2018-12-13 Thread gracinet (Georges Racinet)
gracinet added a comment. @pulkit indeed, I didn't think of that, seems like a good idea, thanks. I wouldn't go as far as putting `path=default` by default, though, so that users don't start hammering providers unwillingly. REPOSITORY rHG Mercurial REVISION DETAIL

D5418: perfdiscovery: benching findcommonheads()

2018-12-13 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Looks like it does not support specifying paths stored in [paths] config, like `hg perfdiscovery default` says 'repository default not found'. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5418 To: gracinet, #hg-reviewers Cc: pulkit,

D5418: perfdiscovery: benching findcommonheads()

2018-12-13 Thread gracinet (Georges Racinet)
gracinet created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This works between the local repo and any peer given by its path, and should be useful for further work on discovery REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH 1 of 2] templatefuncs: add regexp search() function that extracts substring

2018-12-13 Thread Pulkit Goyal
On Thu, Dec 13, 2018 at 4:36 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1544620797 -32400 > # Wed Dec 12 22:19:57 2018 +0900 > # Node ID eeb0c3a62092414713689e9dce6e8949bd27692b > # Parent a6ba978d9ffb0dc8b0edb8f892a947776b6377c5 > templatefuncs: add

Re: [PATCH 1 of 2] templatefuncs: add regexp search() function that extracts substring

2018-12-13 Thread Pulkit Goyal
On Thu, Dec 13, 2018 at 4:36 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1544620797 -32400 > # Wed Dec 12 22:19:57 2018 +0900 > # Node ID eeb0c3a62092414713689e9dce6e8949bd27692b > # Parent a6ba978d9ffb0dc8b0edb8f892a947776b6377c5 > templatefuncs: add

[PATCH 2 of 2] templatefuncs: specialize "no match" value of search() to allow % operation

2018-12-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1544622302 -32400 # Wed Dec 12 22:45:02 2018 +0900 # Node ID d64fec2ec72303c86d51f342a7b8d22143e069d4 # Parent eeb0c3a62092414713689e9dce6e8949bd27692b templatefuncs: specialize "no match" value of search() to allow % operation If Python

[PATCH 1 of 2] templatefuncs: add regexp search() function that extracts substring

2018-12-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1544620797 -32400 # Wed Dec 12 22:19:57 2018 +0900 # Node ID eeb0c3a62092414713689e9dce6e8949bd27692b # Parent a6ba978d9ffb0dc8b0edb8f892a947776b6377c5 templatefuncs: add regexp search() function that extracts substring This can be used to

Re: [PATCH] py3: teach run-tests.py to handle exe with spaces when --local isn't specified

2018-12-13 Thread Yuya Nishihara
On Thu, 13 Dec 2018 08:04:28 -0500, Matt Harbison wrote: > > > On Dec 13, 2018, at 6:34 AM, Yuya Nishihara wrote: > > > >> On Thu, 13 Dec 2018 00:24:41 -0500, Matt Harbison wrote: > >> # HG changeset patch > >> # User Matt Harbison > >> # Date 1544678327 18000 > >> # Thu Dec 13 00:18:47

Re: [PATCH] py3: teach run-tests.py to handle exe with spaces when --local isn't specified

2018-12-13 Thread Matt Harbison
> On Dec 13, 2018, at 6:34 AM, Yuya Nishihara wrote: > >> On Thu, 13 Dec 2018 00:24:41 -0500, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1544678327 18000 >> # Thu Dec 13 00:18:47 2018 -0500 >> # Node ID bf9c96ebceeab2cbad25b2aac07c43eb48fbc664 >> #

D5415: rust: changed Graph.parents to return [Revision; 2]

2018-12-13 Thread yuja (Yuya Nishihara)
yuja added a comment. > Another point is that there is no firm guarantee that a valid revision occurs before `NULL_REVISION`. I've found examples in `revlog.c` where the second parent is (seemlingly on purpose) not ignored if the first is `NULL_REVISION`, but I wouldn't want at this point

Re: D5415: rust: changed Graph.parents to return [Revision; 2]

2018-12-13 Thread Yuya Nishihara
> Another point is that there is no firm guarantee that a valid revision occurs > before `NULL_REVISION`. I've found examples in `revlog.c` where the second > parent is (seemlingly on purpose) not ignored if the first is > `NULL_REVISION`, but I wouldn't want at this point to impose it from the

D5415: rust: changed Graph.parents to return [Revision; 2]

2018-12-13 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued the first two, thanks. > This is a nice improvement. It still seems odd to me to return a list of two parents when there could be 0, 1 or 2 parents. I guess this is for performance reasons? It's a direct mapping from the revlog storage. I think

Re: D5415: rust: changed Graph.parents to return [Revision; 2]

2018-12-13 Thread Yuya Nishihara
Queued the first two, thanks. > This is a nice improvement. It still seems odd to me to return a list of > two parents when there could be 0, 1 or 2 parents. I guess this is for > performance reasons? It's a direct mapping from the revlog storage. I think `[Revision; 2]` is good enough at

D5415: rust: changed Graph.parents to return [Revision; 2]

2018-12-13 Thread gracinet (Georges Racinet)
This revision was automatically updated to reflect the committed changes. gracinet marked 2 inline comments as done. Closed by commit rHGa6ba978d9ffb: rust: changed Graph.parents to return [Revision; 2] (authored by gracinet, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5414: rust: improved docstring

2018-12-13 Thread gracinet (Georges Racinet)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGceb695c3c154: rust: improved docstring (authored by gracinet, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5414?vs=12827=12834 REVISION DETAIL

D5409: remotefilelog: accepting a None node to cmp

2018-12-13 Thread yuja (Yuya Nishihara)
yuja added a comment. > Oops, my oversight - what's passed to cmp is not the same that's compared to None in that if :) I have even less confidence on this now. And `workingfilectx.cmp(self, fctx)` flips `self` and `fctx` as it knows `self._filenode` is None, and the other's wouldn't

Re: D5409: remotefilelog: accepting a None node to cmp

2018-12-13 Thread Yuya Nishihara
> Oops, my oversight - what's passed to cmp is not the same that's compared > to None in that if :) I have even less confidence on this now. And `workingfilectx.cmp(self, fctx)` flips `self` and `fctx` as it knows `self._filenode` is None, and the other's wouldn't be None. I don't like it, but

Re: [PATCH] py3: teach run-tests.py to handle exe with spaces when --local isn't specified

2018-12-13 Thread Yuya Nishihara
On Thu, 13 Dec 2018 00:24:41 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1544678327 18000 > # Thu Dec 13 00:18:47 2018 -0500 > # Node ID bf9c96ebceeab2cbad25b2aac07c43eb48fbc664 > # Parent 008f3491dc5377e9e6f210e0a3f161323049db5d > py3: teach

Re: [PATCH] revset: move subscript relation functions to its own dict

2018-12-13 Thread Yuya Nishihara
On Thu, 13 Dec 2018 19:03:22 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1544692737 -28800 > # Thu Dec 13 17:18:57 2018 +0800 > # Node ID ae0a18541e4354201303032cd37ccc819d64c5a0 > # Parent 008f3491dc5377e9e6f210e0a3f161323049db5d > revset: move

Re: [PATCH] py3: teach run-tests.py to handle exe with spaces when --local isn't specified

2018-12-13 Thread Yuya Nishihara
On Thu, 13 Dec 2018 00:24:41 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1544678327 18000 > # Thu Dec 13 00:18:47 2018 -0500 > # Node ID bf9c96ebceeab2cbad25b2aac07c43eb48fbc664 > # Parent 008f3491dc5377e9e6f210e0a3f161323049db5d > py3: teach

[PATCH] revset: move subscript relation functions to its own dict

2018-12-13 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1544692737 -28800 # Thu Dec 13 17:18:57 2018 +0800 # Node ID ae0a18541e4354201303032cd37ccc819d64c5a0 # Parent 008f3491dc5377e9e6f210e0a3f161323049db5d revset: move subscript relation functions to its own dict This will help adding more