yuja added a comment.
> In case of a failed example, all needed information
> for reproduction is included in the panic message,
> so that we don't need to
> seed the random generator explicitely. This is how
> `test_remove_ancestors_from_case1()` has been generated.
Can
> In case of a failed example, all needed information
> for reproduction is included in the panic message,
> so that we don't need to
> seed the random generator explicitely. This is how
> `test_remove_ancestors_from_case1()` has been generated.
Can we turn this into a utility command?
This revision was automatically updated to reflect the committed changes.
gracinet marked an inline comment as done.
Closed by commit rHG5817c3b186a7: rust: translation of missingancestors
(authored by gracinet, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja added a comment.
Queued this, thanks.
> +/// Add rev's parents to self.bases
> +#[inline]
> +fn add_parents( self, rev: Revision) -> Result<(), GraphError> {
> +// No need to bother the set with inserting NULL_REVISION over and
> +// over
>
Queued this, thanks.
> +/// Add rev's parents to self.bases
> +#[inline]
> +fn add_parents( self, rev: Revision) -> Result<(), GraphError> {
> +// No need to bother the set with inserting NULL_REVISION over and
> +// over
> +for p in
On Fri, 14 Dec 2018 21:24:37 +, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1544089163 -3600
> # Thu Dec 06 10:39:23 2018 +0100
> # Node ID 571449ab5d585525640279fef7979f9cc4f31637
> # Parent 2ae099bc17b55791398ebc00d38fb4f988a1e2e3
> # EXP-Topic
On Fri, 14 Dec 2018 21:24:36 +, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1544089145 -3600
> # Thu Dec 06 10:39:05 2018 +0100
> # Node ID 2ae099bc17b55791398ebc00d38fb4f988a1e2e3
> # Parent db0227d6f9291d9dac23f6f07699cf1fb7d1ea3d
> # EXP-Topic
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGccc28cc067dc: help: present boolean arguments as
--[no-]foo (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGde88c4f3e954: help: show default: off for
boolean flags that default to off (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2c10c4eaa777: help: use default: on instead of
default: True (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa08e12149bcb: absorb: dont prompt to apply changes
when there are none to apply (authored by hooper, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG7da54cff8743: check-commit: disallow capitalization only
right after topic (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja added a comment.
> - if isinstance(text, buffer): +if isinstance(text, util.buffer):
text = str(text)
`util.buffer` isn't a type object on Python 3. Given `str(text)` didn't
explode, such cases wouldn't be covered by the tests.
REPOSITORY
rHG Mercurial
REVISION DETAIL
> -if isinstance(text, buffer):
> +if isinstance(text, util.buffer):
> text = str(text)
`util.buffer` isn't a type object on Python 3. Given `str(text)` didn't
explode, such cases wouldn't be covered by the tests.
___
yuja added a comment.
> class RevlogError(StorageError):
> __bytes__ = _tobytes
>
>
> +def __str__(self):
> +# avoid cycle, and directly implement unimethod for this
> +# __str__ to allow delaying the import of encoding until
> +# someone
> class RevlogError(StorageError):
> __bytes__ = _tobytes
>
> +def __str__(self):
> +# avoid cycle, and directly implement unimethod for this
> +# __str__ to allow delaying the import of encoding until
> +# someone actually wants the __str__ of a RevlogError
martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This should make it much more discoverable (we document it in `hg help
flags`, but most users don't think to look there).
martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5431
AFFECTED FILES
mercurial/help.py
tests/test-extension.t
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
"True" feels like a Python thing and not something that users should
see.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5430
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It should be okay to write "topic: change 'default: True' to 'default:
on'".
REPOSITORY
rHG Mercurial
REVISION DETAIL
# HG changeset patch
# User Boris Feld
# Date 1544089163 -3600
# Thu Dec 06 10:39:23 2018 +0100
# Node ID 571449ab5d585525640279fef7979f9cc4f31637
# Parent 2ae099bc17b55791398ebc00d38fb4f988a1e2e3
# EXP-Topic sparse-revlog-corner-cases
# Available At
# HG changeset patch
# User Paul Morelle
# Date 1544807719 -3600
# Fri Dec 14 18:15:19 2018 +0100
# Node ID e7cc20159b972dbaf602737b8bbc900ba60b2438
# Parent 571449ab5d585525640279fef7979f9cc4f31637
# EXP-Topic sparse-revlog-corner-cases
# Available At
# HG changeset patch
# User Boris Feld
# Date 1544089145 -3600
# Thu Dec 06 10:39:05 2018 +0100
# Node ID 2ae099bc17b55791398ebc00d38fb4f988a1e2e3
# Parent db0227d6f9291d9dac23f6f07699cf1fb7d1ea3d
# EXP-Topic sparse-revlog-corner-cases
# Available At
# HG changeset patch
# User Boris Feld
# Date 1544089110 -3600
# Thu Dec 06 10:38:30 2018 +0100
# Node ID db0227d6f9291d9dac23f6f07699cf1fb7d1ea3d
# Parent e13ab4acf555daf8fac593127b6a076288551710
# EXP-Topic sparse-revlog-corner-cases
# Available At
https://bz.mercurial-scm.org/show_bug.cgi?id=6039
Bug ID: 6039
Summary: The experimental evolution configs can silently
prevent evolve from fully initializing
Product: Mercurial
Version: 4.8.1
Hardware: All
On 03/12/2018 11:10, Yuya Nishihara wrote:
> On Sun, 2 Dec 2018 16:42:18 +0100, Boris FELD wrote:
>> On 30/11/2018 12:45, Yuya Nishihara wrote:
>>> On Thu, 29 Nov 2018 18:55:01 +0100, Boris Feld wrote:
# HG changeset patch
# User Boris Feld
# Date 1543508919 -3600
# Thu
On 14/12/2018 11:54, Yuya Nishihara wrote:
> On Fri, 14 Dec 2018 10:18:42 +, Boris FELD wrote:
>> On 09/12/2018 05:29, Yuya Nishihara wrote:
>>> On Fri, 7 Dec 2018 15:44:44 +0100, Boris FELD wrote:
> I'm not sure what to do here. Yuya objected to the fileset one in
> these. I don't
hooper created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5428
AFFECTED FILES
hgext/absorb.py
tests/test-absorb.t
CHANGE DETAILS
diff --git
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG288c554e33ae: py3: add a b prefix in
tests/test-remotefilelog-pull-noshallow.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This makes the test pass on Python 3.
1. skip-blame because just b'' prefix.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5427
gracinet marked 2 inline comments as done.
gracinet added a comment.
Thanks for the useful tips!
INLINE COMMENTS
> kevincox wrote in ancestors.rs:154
> Why not just write:
>
> self.bases.iter().any(|b| != NULL_REVISION)
>
> It is much clearer what you mean and I suspect the performance
gracinet updated this revision to Diff 12856.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5417?vs=12833=12856
REVISION DETAIL
https://phab.mercurial-scm.org/D5417
AFFECTED FILES
rust/Cargo.lock
rust/hg-core/Cargo.toml
gracinet updated this revision to Diff 12855.
gracinet marked an inline comment as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5416?vs=12832=12855
REVISION DETAIL
https://phab.mercurial-scm.org/D5416
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGbad316cda645: perf: add two more missing b prefixes for
Python 3 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG248c53e169a0: error: implement __str__ on RevlogError to
fix some output defects on Py3 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa3e57c69d47d: match: fix doctest to use bytes instead of
str (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame just two more b prefixes
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5425
AFFECTED FILES
contrib/perf.py
CHANGE
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We open-code encoding.unimethod here to avoid cycles, and do a local
import of encoding when someone str()s a RevlogError. It's not my
favorite solution, but it
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This fixes test-remotefilelog-bundles.t on Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5424
AFFECTED FILES
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Fixes doctests on Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5423
AFFECTED FILES
mercurial/match.py
CHANGE DETAILS
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6b9469527cff: py3: add a missing b prefix in
contrib/perf.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4acba5621a63: py3: use %d for integers instead
of %s (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5420?vs=12840=12845
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5702c3ead5de: py3: use pycompat.bytechr() instead of chr()
in test-fastannotate-revmap.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1f1c0bdaa98b: py3: whitelist another passing test caught by
buildbot (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
pulkit updated this revision to Diff 12843.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5422?vs=12842=12843
REVISION DETAIL
https://phab.mercurial-scm.org/D5422
AFFECTED FILES
contrib/python3-whitelist
tests/test-fastannotate-revmap.py
CHANGE
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This makes the test pass on Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5422
AFFECTED FILES
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
skip-blame because just b'' prefixes
This fixes test-contrib-perf.t on Python 3 which started failing.
REPOSITORY
rHG
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This should fix test-rebase-inmemory.t which started failing on Python 3 after
recent changes.
REPOSITORY
rHG Mercurial
REVISION DETAIL
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5419
AFFECTED FILES
contrib/python3-whitelist
CHANGE DETAILS
diff --git a/contrib/python3-whitelist
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG716ce792886c: perfdiscovery: benching findcommonheads()
(authored by gracinet, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5418?vs=12837=12838
On Fri, Dec 14, 2018 at 3:49 PM Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1544789959 -32400
> # Fri Dec 14 21:19:19 2018 +0900
> # Node ID 55d0252b56e9af55bc4ccbda921fdd01f0c2ff54
> # Parent eed9a62e1f1098f641aacd3de6e0d84d53a1cdd6
> py3: fix bad
New changeset in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/e06719b7544d
changeset: 40936:e06719b7544d
bookmark:@
tag: tip
parent: 40935:4591c9791a82
parent: 40926:21f5810df848
user:Augie Fackler
date:Thu Dec 13 14:44:54 2018 -0500
summary:
# HG changeset patch
# User Yuya Nishihara
# Date 1544789959 -32400
# Fri Dec 14 21:19:19 2018 +0900
# Node ID 55d0252b56e9af55bc4ccbda921fdd01f0c2ff54
# Parent eed9a62e1f1098f641aacd3de6e0d84d53a1cdd6
py3: fix bad escapes of sub() replacement pattern in test-template-basic.t
Python 3.7
On Fri, 14 Dec 2018 10:18:42 +, Boris FELD wrote:
> On 09/12/2018 05:29, Yuya Nishihara wrote:
> > On Fri, 7 Dec 2018 15:44:44 +0100, Boris FELD wrote:
> >>> I'm not sure what to do here. Yuya objected to the fileset one in
> >>> these. I don't have a problem omitting this, the template and
gracinet updated this revision to Diff 12837.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5418?vs=12836=12837
REVISION DETAIL
https://phab.mercurial-scm.org/D5418
AFFECTED FILES
contrib/perf.py
tests/test-contrib-perf.t
CHANGE DETAILS
diff
On 09/12/2018 05:29, Yuya Nishihara wrote:
> On Fri, 7 Dec 2018 15:44:44 +0100, Boris FELD wrote:
>>> I'm not sure what to do here. Yuya objected to the fileset one in
>>> these. I don't have a problem omitting this, the template and revset
>>> support, but I'm not sure what sort of problems
For the record, this issue got discussed on #hg-evolve in length and a
fix has been pushed yesterday. Thanks to Pulkit and Martin for helping
with the review.
On 04/12/2018 21:11, James Reynolds wrote:
> # HG changeset patch
> # User James Reynolds
> # Date 1543952045 18000
> # Tue Dec 04
57 matches
Mail list logo
