[PATCH 8 of 8] largefiles: eliminate an unnecessary import of configitems

# HG changeset patch # User Matt Harbison # Date 1545976438 18000 # Fri Dec 28 00:53:58 2018 -0500 # Node ID f91292b9e400a63b462aa736448cecc07480a65a # Parent dae589aba13fe0327b1a975a4d5b39dfd33ef4ff largefiles: eliminate an unnecessary import of configitems Thanks to Yuya for pointing this

[PATCH 7 of 8] exthelper: add some examples for using registrar aliases

# HG changeset patch # User Matt Harbison # Date 1545976262 18000 # Fri Dec 28 00:51:02 2018 -0500 # Node ID dae589aba13fe0327b1a975a4d5b39dfd33ef4ff # Parent 1ff39d5b72312a9ae3c4b9fc424fed25bbdd67b6 exthelper: add some examples for using registrar aliases Maybe it's my general lack of pyth

[PATCH 6 of 8] exthelper: reintroduce the ability to register filesets

# HG changeset patch # User Matt Harbison # Date 1545972395 18000 # Thu Dec 27 23:46:35 2018 -0500 # Node ID 1ff39d5b72312a9ae3c4b9fc424fed25bbdd67b6 # Parent 75ad6f9b2df7c8f7d4d8b2613242cc46298e618c exthelper: reintroduce the ability to register filesets Same mechanism as revsets earlier i

[PATCH 5 of 8] exthelper: reintroduce the ability to register templates

# HG changeset patch # User Matt Harbison # Date 1545965722 18000 # Thu Dec 27 21:55:22 2018 -0500 # Node ID 75ad6f9b2df7c8f7d4d8b2613242cc46298e618c # Parent 2b04921466a9ff3428ac83a0ae9da35ee2d75dd5 exthelper: reintroduce the ability to register templates Same mechanism as revsets earlier

[PATCH 4 of 8] extensions: deprecate extsetup without a `ui` argument (API)

# HG changeset patch # User Matt Harbison # Date 1545965163 18000 # Thu Dec 27 21:46:03 2018 -0500 # Node ID 2b04921466a9ff3428ac83a0ae9da35ee2d75dd5 # Parent 60d298e4ddb59bee804766c9fd95a552bfd8d56a extensions: deprecate extsetup without a `ui` argument (API) 9.5 years should be enough tim

[PATCH 3 of 8] largefiles: port revset registration to exthelper

# HG changeset patch # User Matt Harbison # Date 1545964063 18000 # Thu Dec 27 21:27:43 2018 -0500 # Node ID 60d298e4ddb59bee804766c9fd95a552bfd8d56a # Parent fed98646d0421021268ea0b4f91e0d1870bc4bde largefiles: port revset registration to exthelper This tests the merge code that wasn't tes

[PATCH 2 of 8] exthelper: reintroduce the ability to register revsets

# HG changeset patch # User Matt Harbison # Date 1545963977 18000 # Thu Dec 27 21:26:17 2018 -0500 # Node ID fed98646d0421021268ea0b4f91e0d1870bc4bde # Parent 7598b362dfbf7cb43a14fdd9296f0d1f4fd67627 exthelper: reintroduce the ability to register revsets I think this is what Yuya and Boris

[PATCH 1 of 8] largefiles: drop the uisetup module

# HG changeset patch # User Matt Harbison # Date 1545624111 18000 # Sun Dec 23 23:01:51 2018 -0500 # Node ID 7598b362dfbf7cb43a14fdd9296f0d1f4fd67627 # Parent 6603de284b0aaa030f180d28b809e4cc764c0ac1 largefiles: drop the uisetup module This is small enough to live in the __init__ module. d

Re: D5442: rust-cpython: using the new bindings from Python

On Thu, 27 Dec 2018 19:49:46 +, gracinet (Georges Racinet) wrote: > @yuja about the lazy importer, and just to clarify: so you're saying it's > not worth it to delay until rustext is actually used. Yes. I don't think importing a cext module would be significant overhead. And the policy impo

D5441: rust-cpython: binding for LazyAncestors

yuja added a comment. > > Does the class name actually matter? Personally I don't care if > > lazyancestors() function returns a LazyAncestors object. We'll anyway > > need a wrapper function to make pure ancestors and rustext ancestors > > compatible. > > Yes, that's

Re: D5441: rust-cpython: binding for LazyAncestors

> > Does the class name actually matter? Personally I don't care if > > lazyancestors() function returns a LazyAncestors object. We'll anyway > > need a wrapper function to make pure ancestors and rustext ancestors > > compatible. > > Yes, that's in line with your other comments, wh

Re: [PATCH 02 of 10 V2] revlog: fix pure python slicing code when chain contains nullrev

On Fri, 28 Dec 2018 00:24:48 +0100, Boris FELD wrote: > > Can you turn these tests into a unittest to cover both pure and C > > implementations? > Turning this specific test is a bit more complicated than we would like > as we are taking advantage of _testrevlog flexibility to produce a > simple bu

Re: [PATCH 06 of 10 V2] revlog: add a native implementation of issnapshot

On Fri, 28 Dec 2018 00:26:54 +0100, Boris FELD wrote: > On 22/12/2018 05:38, Yuya Nishihara wrote: > > On Sat, 22 Dec 2018 13:07:25 +0900, Yuya Nishihara wrote: > >> On Fri, 21 Dec 2018 12:47:09 +0100, Boris Feld wrote: > >>> # HG changeset patch > >>> # User Boris Feld > >>> # Date 1545040633 -36

Re: [PATCH 1 of 6] exthelper: add a cautionary note about adding attributes to containers

On Thu, 27 Dec 2018 16:33:29 -0500, Matt Harbison wrote: > On Thu, 27 Dec 2018 06:45:26 -0500, Yuya Nishihara wrote: > >> example:: > >> > >> @eh.addattr(context.changectx, 'babar') > > > > Can you update this example as well? Given most class instances belong to > > ui or re

Re: [PATCH 3 of 6] largefiles: port configitems to exthelper

On Thu, 27 Dec 2018 16:13:02 -0500, Matt Harbison wrote: > On Thu, 27 Dec 2018 06:29:09 -0500, Yuya Nishihara wrote: > > > On Wed, 26 Dec 2018 16:33:35 -0500, Matt Harbison wrote: > >> # HG changeset patch > >> # User Matt Harbison > >> # Date 1545599773 18000 > >> # Sun Dec 23 16:16:13 201

D5486: branches: add -r option to show branch name(s) of a given rev (issue5948)

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4506f801e492: branches: add -r option to show branch name(s) of a given rev (issue5948) (authored by navaneeth.suresh, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5486?vs=1

[Bug 6042] New: commit --interactive surprising behavior when .hgrc includes [diff] ignorews=True

https://bz.mercurial-scm.org/show_bug.cgi?id=6042 Bug ID: 6042 Summary: commit --interactive surprising behavior when .hgrc includes [diff] ignorews=True Product: Mercurial Version: earlier Hardware: All OS:

D5487: remotefilelog: fix bug in maybesparsematch returning alwaysmatcher

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The description of the method says that it should return None if sparse is not used in this repository; since sparse.matcher() returns alwaysmatcher if sparse

Re: [PATCH 07 of 10 V2] revlog: use the native implementation of issnapshot

On 22/12/2018 05:11, Yuya Nishihara wrote: > On Fri, 21 Dec 2018 12:47:10 +0100, Boris Feld wrote: >> # HG changeset patch >> # User Boris Feld >> # Date 1545366458 -3600 >> # Fri Dec 21 05:27:38 2018 +0100 >> # Node ID 4b515705427c5ce7f4d55611738ab7f62662dc6b >> # Parent d15f3f46ca1e52f06d5

Re: [PATCH 06 of 10 V2] revlog: add a native implementation of issnapshot

On 22/12/2018 05:38, Yuya Nishihara wrote: > On Sat, 22 Dec 2018 13:07:25 +0900, Yuya Nishihara wrote: >> On Fri, 21 Dec 2018 12:47:09 +0100, Boris Feld wrote: >>> # HG changeset patch >>> # User Boris Feld >>> # Date 1545040633 -3600 >>> # Mon Dec 17 10:57:13 2018 +0100 >>> # Node ID d15f3f4

Re: [PATCH 02 of 10 V2] revlog: fix pure python slicing code when chain contains nullrev

On 22/12/2018 04:20, Yuya Nishihara wrote: > On Fri, 21 Dec 2018 12:47:05 +0100, Boris Feld wrote: >> # HG changeset patch >> # User Boris Feld >> # Date 1545296356 -3600 >> # Thu Dec 20 09:59:16 2018 +0100 >> # Node ID df9b79e863d6e5215175487330b1469067e20bbd >> # Parent d51d82a46d9545235b

Re: [PATCH 1 of 6] exthelper: add a cautionary note about adding attributes to containers

On Thu, 27 Dec 2018 06:45:26 -0500, Yuya Nishihara wrote: On Wed, 26 Dec 2018 16:33:33 -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1545594763 18000 # Sun Dec 23 14:52:43 2018 -0500 # Node ID 900b0af134505b6e5d227888212a17d8dd68342a # Parent 0214962773921

Re: [PATCH 3 of 6] largefiles: port configitems to exthelper

On Thu, 27 Dec 2018 06:29:09 -0500, Yuya Nishihara wrote: On Wed, 26 Dec 2018 16:33:35 -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1545599773 18000 # Sun Dec 23 16:16:13 2018 -0500 # Node ID be536e648c4f96fa625a6222e9c50d45fee38bb5 # Parent 04b6bbd552360

D5442: rust-cpython: using the new bindings from Python

gracinet added a comment. @yuja about the lazy importer, and just to clarify: so you're saying it's not worth it to delay until rustext is actually used. I'm fine with that, will do it. I didn't amend that patch yet, but you might have received notifications due to evolve of the whole sta

D5441: rust-cpython: binding for LazyAncestors

gracinet marked 2 inline comments as done. gracinet added a comment. > Does the class name actually matter? Personally I don't care if > lazyancestors() function returns a LazyAncestors object. We'll anyway > need a wrapper function to make pure ancestors and rustext ancestors > compat

D5438: rust-cpython: implementing Graph using C parents function

gracinet added a comment. @yuja, thanks for the queueing ! > Index could be backed by e.g. Rc> to allow any objects to own > copies, but I don't feel like this is a good design. If we want one day to have Mercurial work in a multi-threaded way, I guess that something like `Arc>`

D5477: branches: add -r option to show branch name(s) of a given rev (issue5948)

navaneeth.suresh added a comment. In https://phab.mercurial-scm.org/D5477#81186, @yuja wrote: > I tried to queue this, but the patch doesn't include any metadata (e.g. author > and date.) Please check your configuration. > > https://www.mercurial-scm.org/wiki/Phabricator @y

D5486: branches: add -r option to show branch name(s) of a given rev (issue5948)

navaneeth.suresh created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5486 AFFECTED FILES mercurial/commands.py tests/test-branches.t tests/test-completion.t C

D5477: branches: add -r option to show branch name(s) of a given rev (issue5948)

navaneeth.suresh updated this revision to Diff 12988. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5477?vs=12980&id=12988 REVISION DETAIL https://phab.mercurial-scm.org/D5477 AFFECTED FILES mercurial/commands.py tests/test-branches.t tests/test-

D5483: amend:added rewrite.updatetimestamp config option(issue5828)

taapas1128 added a comment. @yuja Corrected the tests. Added in config.txt and changed the config option according to the guideline. Please review when you are free. REVISION DETAIL https://phab.mercurial-scm.org/D5483 To: taapas1128, #hg-reviewers Cc: yuja, mercurial-devel __

D5483: amend:added rewrite.updatetimestamp config option(issue5828)

taapas1128 updated this revision to Diff 12987. CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5483?vs=12979&id=12987 REVISION DETAIL https://phab.mercurial-scm.org/D5483 AFFECTED FILES mercurial/cmdutil.py mercurial/configitems.py mercurial/help/config.txt tests/test-amen

D5477: branches: add -r option to show branch name(s) of a given rev (issue5948)

yuja added a comment. > We like the UX of `hg branch --rev R XXX` for changing the branch of a commit, it's the same UX than bookmark and topic. It's also easier than `hg branch --force XXX; hg amend`. What I don't like about `hg branch --rev` is that it actually rewrites the commits

Re: D5477: branches: add -r option to show branch name(s) of a given rev (issue5948)

> We like the UX of `hg branch --rev R XXX` for changing the branch of a > commit, it's the same UX than bookmark and topic. It's also easier than `hg > branch --force XXX; hg amend`. What I don't like about `hg branch --rev` is that it actually rewrites the commits, which is IMHO different in

Re: [PATCH evolve-ext] exthelper: remove '_' in final_xxx() function names to conform to hg style

Pushed thanks. On 22/12/2018 07:44, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1545460199 18000 > # Sat Dec 22 01:29:59 2018 -0500 > # Node ID 0252c830b4d7c277341772c80566ec395c6aebf2 > # Parent 980565468003bd66d782fde6d4128476e407dc48 > exthelper: remove '_

D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

yuja added a comment. > @@ -4438,7 +4438,7 @@ > > remotebookmarks = fremotebookmarks.result() > remotebookmarks = bookmarks.unhexlifybookmarks(remotebookmarks) > pullopargs['remotebookmarks'] = remotebookmarks > > - for b in opts['bookmark']: +for b in opts.get('

Re: D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

> @@ -4438,7 +4438,7 @@ > remotebookmarks = fremotebookmarks.result() > remotebookmarks = bookmarks.unhexlifybookmarks(remotebookmarks) > pullopargs['remotebookmarks'] = remotebookmarks > -for b in opts['bookmark']: > +for b in opts.get

D5477: branches: add -r option to show branch name(s) of a given rev (issue5948)

lothiraldan added a comment. In https://phab.mercurial-scm.org/D5477#81096, @yuja wrote: > > 0. I move metaedit command to core > > 1. I move branch changing functionality to metaedit > > No opinion about 0 and 1. I've never used the metaedit. > > > 2. and then we implement `

D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

pulkit updated this revision to Diff 12986. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5484?vs=12981&id=12986 REVISION DETAIL https://phab.mercurial-scm.org/D5484 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/command

D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

yuja added a comment. >> commands.py:4441 > > pullopargs['remotebookmarks'] = remotebookmarks > > for b in opts['bookmark']: > > b = repo._bookmarks.expandname(b) > > @yuja this one? Yes. REPOSITORY rHG Mercurial REVISION DETAIL

Re: D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

> > commands.py:4441 > > pullopargs['remotebookmarks'] = remotebookmarks > > for b in opts['bookmark']: > > b = repo._bookmarks.expandname(b) > > @yuja this one? Yes. ___ Mercurial-devel mailing list Mercurial-

D5408: progress: avoid ui.configbool() lookup when progress bar is active

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6603de284b0a: progress: avoid ui.configbool() lookup when progress bar is active (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.

D5482: wireproto: in batch queries, support queries with immediate responses

This revision was automatically updated to reflect the committed changes. Closed by commit rHG55e8da487b8a: wireproto: in batch queries, support queries with immediate responses (authored by valentin.gatienbaron, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab

D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

pulkit added inline comments. INLINE COMMENTS > commands.py:4441 > pullopargs['remotebookmarks'] = remotebookmarks > for b in opts['bookmark']: > b = repo._bookmarks.expandname(b) @yuja this one? I thought if the above condition is true, this will be fi

D5477: branches: add -r option to show branch name(s) of a given rev (issue5948)

yuja added a comment. I tried to queue this, but the patch doesn't include any metadata (e.g. author and date.) Please check your configuration. https://www.mercurial-scm.org/wiki/Phabricator > +revs = opts.get('rev') > +selectedbranches = None > +if revs: > +

Re: D5477: branches: add -r option to show branch name(s) of a given rev (issue5948)

I tried to queue this, but the patch doesn't include any metadata (e.g. author and date.) Please check your configuration. https://www.mercurial-scm.org/wiki/Phabricator > +revs = opts.get('rev') > +selectedbranches = None > +if revs: > +revs = scmutil.revrange(repo, revs) > +

D5483: amend:added rewrite.updatetimestamp config option(issue5828)

yuja added a comment. > +$ hg amend --config rewrite.updatetimestamp=True > +$ hg log --limit 2 > +changeset: 40473:e64479cbaf37 Okay, so these tests don't run because these lines don't start with ` $`. > +coreconfigitem('rewrite', 'updatetimestamp', Need dash per https:

Re: D5483: amend:Added rewrite.updatetimestamp config option(issue5828)

> +$ hg amend --config rewrite.updatetimestamp=True > +$ hg log --limit 2 > +changeset: 40473:e64479cbaf37 Okay, so these tests don't run because these lines don't start with ` $`. > +coreconfigitem('rewrite', 'updatetimestamp', Need dash per https://www.mercurial-scm.org/wiki/UIGuideline#con

D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

yuja added a comment. > nodes = None > > - if opts['bookmark'] or revs: +if opts.get('bookmark') or revs: There's one more `opts['bookmark']`. That's why `opts.get('bookmark')` was rewritten as `opts[...]`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercur

Re: D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

> nodes = None > -if opts['bookmark'] or revs: > +if opts.get('bookmark') or revs: There's one more `opts['bookmark']`. That's why `opts.get('bookmark')` was rewritten as `opts[...]`. ___ Mercurial-devel mailing list Mercurial-de

D5485: log: fixes line wrap on diffstat (issue5800)

navaneeth.suresh created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5485 AFFECTED FILES mercurial/patch.py CHANGE DETAILS diff --git a/mercurial/patch.py b/merc

Re: [PATCH 1 of 6] exthelper: add a cautionary note about adding attributes to containers

On Wed, 26 Dec 2018 16:33:33 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1545594763 18000 > # Sun Dec 23 14:52:43 2018 -0500 > # Node ID 900b0af134505b6e5d227888212a17d8dd68342a > # Parent 0214962773921f15333f11d97212b307422aaaf5 > exthelper: add a caut

Re: [PATCH 5 of 6] largefiles: port commands to exthelper

On Wed, 26 Dec 2018 16:33:37 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1545603985 18000 > # Sun Dec 23 17:26:25 2018 -0500 > # Node ID 32aa43e038570b844946896376b358cada94f972 > # Parent a341e513e16c560082afaf06ce6041091f8d40f1 > largefiles: port comm

Re: [PATCH 3 of 6] largefiles: port configitems to exthelper

On Wed, 26 Dec 2018 16:33:35 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1545599773 18000 > # Sun Dec 23 16:16:13 2018 -0500 > # Node ID be536e648c4f96fa625a6222e9c50d45fee38bb5 > # Parent 04b6bbd552360d479d44e956d1e0c201d19f15ef > largefiles: port conf

Re: [PATCH] exthelper: drop a compatibility shim with '^command' syntax

On Thu, 27 Dec 2018 01:43:35 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1545887440 18000 > # Thu Dec 27 00:10:40 2018 -0500 > # Node ID 0fd3f0947fbea9ff60c8fc447d751bf653d70303 > # Parent 32aa43e038570b844946896376b358cada94f972 > exthelper: drop a com