On Sat, Jan 5, 2019 at 12:26 PM Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1546670695 -32400
> # Sat Jan 05 15:44:55 2019 +0900
> # Branch stable
> # Node ID b576b9960390abbf29b2d103d7578938fdb65e4a
> # Parent fbd5e2f0bba7661f6f09e6cfd2bc2ffd07559a41
> ma
On Sat, Jan 5, 2019 at 4:15 AM Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1546620599 -3600
> # Fri Jan 04 17:49:59 2019 +0100
> # Node ID 562198ca3bb37b9764dfe93d56cbbf70c2bb093d
> # Parent 5c68b617ba2463eb6f1372a24b139a376c6bf6bd
> # EXP-Topic discovery-refactor
navaneeth.suresh added a comment.
In https://phab.mercurial-scm.org/D5490#81294, @pulkit wrote:
> I am not sure whether this change is correct or not, but please add more
description to your commit message explaining what this patch is doing, what
the issue is about and how it fixes that
gracinet abandoned this revision.
gracinet added a comment.
Given this conversation, and its outcome as materialised with latest versions
of https://phab.mercurial-scm.org/D5441 and
https://phab.mercurial-scm.org/D5442, we can now simply abandon this one.
REPOSITORY
rHG Mercurial
REVISION
On Sat, Jan 5, 2019 at 4:15 AM Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1545964082 -3600
> # Fri Dec 28 03:28:02 2018 +0100
> # Node ID f3c439000eb772272745c344f5257f3ecce369c0
> # Parent 18ff26b2cb10286556b57cc580bb4e76d84c5c10
> # EXP-Topic discovery-refactor
On Sat, Jan 5, 2019 at 8:45 PM Pulkit Goyal <7895pul...@gmail.com> wrote:
>
>
> On Sat, Jan 5, 2019 at 4:15 AM Boris Feld wrote:
>
>> # HG changeset patch
>> # User Boris Feld
>> # Date 1545964082 -3600
>> # Fri Dec 28 03:28:02 2018 +0100
>> # Node ID f3c439000eb772272745c344f5257f3ecce369c
pulkit added a comment.
Nice work! Can you update description of this patch with details in commit
message about behavior of the new config option and how it solves the given
issue?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5491
To: taapas1128, #hg-review
taapas1128 updated this revision to Diff 13012.
taapas1128 retitled this revision from "amend: added config option to update
time to current in hg amend (issue5828)" to "amend: added config option to
update time to current and avoid update when other attribs are unchanged
(issue5828)".
REPOSITO
taapas1128 updated this revision to Diff 13013.
taapas1128 edited the summary of this revision.
taapas1128 retitled this revision from "amend: added config option to update
time to current and avoid update when other attribs are unchanged (issue5828)"
to "amend: added config option to update time
taapas1128 added a comment.
@pulkit done . Please review.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5491
To: taapas1128, #hg-reviewers
Cc: pulkit, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@m
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb31a41f24864: rust-cpython: binding for LazyAncestors
(authored by gracinet, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5441?vs=13007&id=13014
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG536c83535cbd: rust-cpython: using the new bindings from
Python (authored by gracinet, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5442?vs=13008
mharbison72 added inline comments.
INLINE COMMENTS
> navaneeth.suresh wrote in histedit.py:1707
> Otherwise, the user won't be able to see the warning as the editor opens for
> histedit.
Oh, OK. Does it make sense to make this an interactive prompt to continue/bail
instead, to ensure this isn
On Fri, 04 Jan 2019 23:45:20 +0100, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld
> # Date 1546620599 -3600
> # Fri Jan 04 17:49:59 2019 +0100
> # Node ID 562198ca3bb37b9764dfe93d56cbbf70c2bb093d
> # Parent 5c68b617ba2463eb6f1372a24b139a376c6bf6bd
> # EXP-Topic discovery-refac
> > mharbison72 wrote in histedit.py:1707
> > Out of curiosity, why the sleep?
>
> Otherwise, the user won't be able to see the warning as the editor opens for
> histedit.
Maybe `ui.prompt()`?
I don't like this sort of `sleep()` use. 1 sec wouldn't be enough to notice the
warning.
_
yuja added a comment.
>> mharbison72 wrote in histedit.py:1707
> > Out of curiosity, why the sleep?
>
> Otherwise, the user won't be able to see the warning as the editor opens
for histedit.
Maybe `ui.prompt()`?
I don't like this sort of `sleep()` use. 1 sec wouldn't be enoug
# HG changeset patch
# User Yuya Nishihara
# Date 1546741784 -32400
# Sun Jan 06 11:29:44 2019 +0900
# Node ID 25c142f679c23fbc210d5bcbdf2f913e4dd55402
# Parent 536c83535cbdafdfe060cea2b8c80b0789863227
rust-cpython: remove invalid __package__ attribute
Since mercurial.rustext is a package,
# HG changeset patch
# User Yuya Nishihara
# Date 1545223326 -32400
# Wed Dec 19 21:42:06 2018 +0900
# Node ID e87cc0ce61a67f7fbc9c12ab1505a23e23b8217d
# Parent 25c142f679c23fbc210d5bcbdf2f913e4dd55402
rust-ancestors: adjust indent level to make next change easier to follow
diff --git a/rus
# HG changeset patch
# User Yuya Nishihara
# Date 1545223868 -32400
# Wed Dec 19 21:51:08 2018 +0900
# Node ID 01b61bcb9abd37024369ce80eb2c585d47add935
# Parent e87cc0ce61a67f7fbc9c12ab1505a23e23b8217d
rust-ancestors: duplicate loop that visits parents of revs/bases
As the inline comment sa
# HG changeset patch
# User Yuya Nishihara
# Date 1545223960 -32400
# Wed Dec 19 21:52:40 2018 +0900
# Node ID b1f97e06bd1e0923165a16a6ba4894feadf735c0
# Parent 01b61bcb9abd37024369ce80eb2c585d47add935
rust-ancestors: remove unreachable conditions from missing_ancestors()
diff --git a/rust/
# HG changeset patch
# User Yuya Nishihara
# Date 1545225860 -32400
# Wed Dec 19 22:24:20 2018 +0900
# Node ID 16fb6aa9ffcb433f133dd4ca3475cff60c204754
# Parent b1f97e06bd1e0923165a16a6ba4894feadf735c0
rust-ancestors: adjust branches and inline comments per previous change
Now the top-level
navaneeth.suresh created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5494
AFFECTED FILES
hgext/histedit.py
CHANGE DETAILS
diff
navaneeth.suresh added a comment.
@mharbison72 @yuja Thank you for the suggestions. I've created a follow-up
patch making the suggested changes. Please see
https://phab.mercurial-scm.org/D5494.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5489
To: navaneeth.
2 new changesets (2 on stable) in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/70e3e3da24be
changeset: 41021:70e3e3da24be
branch: stable
user:Matt Harbison
date:Fri Jan 04 21:01:10 2019 -0500
summary: templatekw: fix documentation typos
https://www.mercurial-sc
24 matches
Mail list logo
