mercurial@41134: 5 new changesets

2019-01-07 Thread Mercurial Commits
5 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/d43719bd01f0 changeset: 41130:d43719bd01f0 user:Yuya Nishihara date:Sun Jan 06 11:29:44 2019 +0900 summary: rust-cpython: remove invalid __package__ attribute

D5503: vfs: add support for repo names with `$` when using with env vars (issue5739)

2019-01-07 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added a comment. > This is logically incorrect. The problem is that we're doing variable > expansion at too lower layer. `vfs(expand(user_specified_path))` makes > some sense, but `vfs(expand(getcwd()))` is clearly wrong. And the vfs class > can't know where the

Re: [PATCH 4 of 4] amend: add -D/--currentdate option

2019-01-07 Thread Augie Fackler
On Mon, Jan 07, 2019 at 10:33:13PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1546864986 -32400 > # Mon Jan 07 21:43:06 2019 +0900 > # Node ID e39414322e34d799c2f22df815fae5b7efa839ff > # Parent d3181b286250540ecae30e46518c0fbdd43b5bb9 > amend: add

Re: [PATCH 4 of 4] rust-ancestors: adjust branches and inline comments per previous change

2019-01-07 Thread Augie Fackler
On Sun, Jan 06, 2019 at 12:54:07PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1545225860 -32400 > # Wed Dec 19 22:24:20 2018 +0900 > # Node ID 16fb6aa9ffcb433f133dd4ca3475cff60c204754 > # Parent b1f97e06bd1e0923165a16a6ba4894feadf735c0 >

Re: [PATCH] rust-cpython: remove invalid __package__ attribute

2019-01-07 Thread Augie Fackler
On Sun, Jan 06, 2019 at 12:53:46PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1546741784 -32400 > # Sun Jan 06 11:29:44 2019 +0900 > # Node ID 25c142f679c23fbc210d5bcbdf2f913e4dd55402 > # Parent 536c83535cbdafdfe060cea2b8c80b0789863227 >

mercurial@41129: 107 new changesets (3 on stable)

2019-01-07 Thread Mercurial Commits
107 new changesets (3 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/197f092b2cd9 changeset: 41023:197f092b2cd9 branch: stable tag: 4.8.2 user:Augie Fackler date:Sun Jan 06 14:58:54 2019 -0500 summary: server: always close http socket if

D5517: tests: use more portable flags in test-fix.t

2019-01-07 Thread hooper (Danny Hooper)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd8f5c615e811: tests: use more portable flags in test-fix.t (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5516: fix: add some arguments to facilitate extensions

2019-01-07 Thread durin42 (Augie Fackler)
durin42 added a comment. I'm -0 on this: what's special about this functionality that it needs to be an extension of an extension instead of something that can be done in core? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5516 To: hooper, #hg-reviewers Cc:

D5524: cleanup: stop including thirdparty.cbor in builds

2019-01-07 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5524 AFFECTED FILES contrib/import-checker.py setup.py CHANGE

D5523: tests: get access to thirdparty.cbor without requiring it to be installed

2019-01-07 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes the test a noop when run from a tarball, but in return we can stop shipping a library we don't use. REPOSITORY

D5522: tests: migrate test-wireproto-serverreactor.py to our internal CBOR

2019-01-07 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This leaves the only client of thirdparty.cbor as test-cbor.py, which appears to be testing the behavior of cborutil against

D5521: tests: add simplestorerepo to test-check-interfaces.py

2019-01-07 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not thrilled with this, but it'll help avoid future bitrot. REPOSITORY rHG Mercurial REVISION DETAIL

D5520: simplestorerepo: migrate to in-hg CBOR code

2019-01-07 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is the only use of thirdparty.cbor outside of a test-* file, so it felt worthwhile to clean it up. REPOSITORY rHG

D5519: simplestorerepo: minimal changes required to get this mostly working again

2019-01-07 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I was going to change this code's use of CBOR to use our in-house CBOR code, but discovered it's been broken for a while. This

D5518: state: update comment about use of CBOR

2019-01-07 Thread durin42 (Augie Fackler)
durin42 created this revision. durin42 added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We use our internal cbor library, not the vendored one in thirdparty. REPOSITORY rHG Mercurial REVISION DETAIL

D5517: tests: use more portable flags in test-fix.t

2019-01-07 Thread hooper (Danny Hooper)
hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `head --lines N` is known to not exist on OSX. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5517 AFFECTED FILES hgext/fix.py

D5516: fix: add some arguments to facilitate extensions

2019-01-07 Thread hooper (Danny Hooper)
hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For example, these additions allow wrapping `hg fix` to do things like: - Telling fixer tools what commit a file belongs to - Cleaning up temporary files

[Bug 6050] New: `hg split` fails on long paths

2019-01-07 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6050 Bug ID: 6050 Summary: `hg split` fails on long paths Product: Mercurial Version: 4.8 Hardware: PC OS: Linux Status: UNCONFIRMED Severity: bug

[Bug 6049] New: `hg split` fails on long paths

2019-01-07 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6049 Bug ID: 6049 Summary: `hg split` fails on long paths Product: Mercurial Version: 4.8 Hardware: PC OS: Linux Status: UNCONFIRMED Severity: bug

Re: [PATCH 6 of 7] strip: introduce a soft strip option

2019-01-07 Thread Augie Fackler
> On Jan 4, 2019, at 08:09, Pulkit Goyal <7895pul...@gmail.com> wrote: > > > > On Fri, Jan 4, 2019 at 4:31 AM Augie Fackler > wrote: > > > > On Jan 3, 2019, at 10:23 AM, Pulkit Goyal <7895pul...@gmail.com > > > wrote: > > > > > > >

D5498: server: always close http socket if responding with an error (issue6033)

2019-01-07 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG197f092b2cd9: server: always close http socket if responding with an error (issue6033) (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5509: narrow: move copytonarrowspec() out of setnarrowpats()

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13058. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5509?vs=13037=13058 REVISION DETAIL https://phab.mercurial-scm.org/D5509 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/narrowcommands.py

D5512: narrow: use merge.ACTION_GET instead of duplicating 'g' constant

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13061. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5512?vs=13034=13061 REVISION DETAIL https://phab.mercurial-scm.org/D5512 AFFECTED FILES mercurial/narrowspec.py CHANGE DETAILS diff --git

D5510: narrow: reuse narrowspec.updateworkingcopy() when widening

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13059. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5510?vs=13038=13059 REVISION DETAIL https://phab.mercurial-scm.org/D5510 AFFECTED FILES hgext/narrow/narrowcommands.py

D5511: narrow: reuse narrowspec.updateworkingcopy() when narrowing

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13060. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5511?vs=13039=13060 REVISION DETAIL https://phab.mercurial-scm.org/D5511 AFFECTED FILES hgext/narrow/narrowcommands.py mercurial/narrowspec.py CHANGE

D5506: narrow: copy store narrowspec to working copy immediately

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13055. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5506?vs=13035=13055 REVISION DETAIL https://phab.mercurial-scm.org/D5506 AFFECTED FILES hgext/narrow/narrowcommands.py mercurial/hg.py

D5508: narrow: extract repo property for store narrowmatcher

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13057. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5508?vs=13036=13057 REVISION DETAIL https://phab.mercurial-scm.org/D5508 AFFECTED FILES hgext/lfs/__init__.py mercurial/localrepo.py CHANGE DETAILS

D5507: narrow: drop now-unnecessary reassignment of repo attributes

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13056. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5507?vs=13029=13056 REVISION DETAIL https://phab.mercurial-scm.org/D5507 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git

D5505: narrow: include working copy narrowspec in transaction journal

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13054. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5505?vs=13027=13054 REVISION DETAIL https://phab.mercurial-scm.org/D5505 AFFECTED FILES mercurial/localrepo.py mercurial/narrowspec.py CHANGE DETAILS

D5504: narrow: make dirstateguard back up and restore working copy narrowspec instead

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13053. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5504?vs=13026=13053 REVISION DETAIL https://phab.mercurial-scm.org/D5504 AFFECTED FILES mercurial/dirstateguard.py mercurial/narrowspec.py CHANGE

D5515: narrow: drop explicit dirstate write

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The dirstate is written when the wlock is released, so we don't need to write it explicitly in updateworkingcopy(). I don't

D5498: server: always close http socket if responding with an error (issue6033)

2019-01-07 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D5498#81525, @pulkit wrote: > Is this meant for stable? It'd be fine on stable if it applies cleanly there, but it's only /needed/ on default: the tests are exposing what is, frankly, a theoretical problem that extant

D5514: test: change test's diff generation to use mdiff for nicer output

2019-01-07 Thread sangeet259 (Sangeet Kumar Mishra)
sangeet259 added a comment. Note: To see this in action, one needs to add the changes from this `mdiff.py` to the mdiff.py of their installed mercurial. This is because unless you do that, you cannot import `mdiff.new_patch` as that function won't be there in your installed version, and

D5514: test: change test's diff generation to use mdiff for nicer output

2019-01-07 Thread sangeet259 (Sangeet Kumar Mishra)
sangeet259 updated this revision to Diff 13051. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5514?vs=13050=13051 REVISION DETAIL https://phab.mercurial-scm.org/D5514 AFFECTED FILES mercurial/mdiff.py tests/run-tests.py CHANGE DETAILS diff --git

D5513: amend: concise logic for rewrite.updatetimestamp

2019-01-07 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Thanks for the quick follow-up. Yuya did it better and I pushed his patches which can be found at https://www.mercurial-scm.org/repo/hg-committed/rev/b153a4aa06f8 and https://www.mercurial-scm.org/repo/hg-committed/rev/cffa8e0ba77a. This one can be abandoned.

Re: [PATCH 4 of 4] amend: add -D/--currentdate option

2019-01-07 Thread Pulkit Goyal
On Mon, Jan 7, 2019 at 7:11 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1546864986 -32400 > # Mon Jan 07 21:43:06 2019 +0900 > # Node ID e39414322e34d799c2f22df815fae5b7efa839ff > # Parent d3181b286250540ecae30e46518c0fbdd43b5bb9 > amend: add

Re: [PATCH 1 of 4] test-amend: remove uninteresting fields from log output to deduplicate tests

2019-01-07 Thread Pulkit Goyal
On Mon, Jan 7, 2019 at 7:07 PM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1546865843 -32400 > # Mon Jan 07 21:57:23 2019 +0900 > # Node ID 37086867ab18484c093a188851c3847d695c8629 > # Parent 5967995c32bb802eee6ef8f75ff6b31278bd9e38 > test-amend: remove

D5495: revset: add "branch" positional arguments to the merge revset

2019-01-07 Thread yuja (Yuya Nishihara)
yuja added a comment. > +@predicate('merge(*withbranch)', safe=True) > > def merge(repo, subset, x): > > - """Changeset is a merge changeset. +"""Changeset is a merge changeset + +All merge revisions are returned by default. If one or more "withbranch" +names are

Re: D5495: revset: add "branch" positional arguments to the merge revset

2019-01-07 Thread Yuya Nishihara
> +@predicate('merge(*withbranch)', safe=True) > def merge(repo, subset, x): > -"""Changeset is a merge changeset. > +"""Changeset is a merge changeset > + > +All merge revisions are returned by default. If one or more "withbranch" > +names are provided only merges with those

[PATCH 4 of 4] amend: add -D/--currentdate option

2019-01-07 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1546864986 -32400 # Mon Jan 07 21:43:06 2019 +0900 # Node ID e39414322e34d799c2f22df815fae5b7efa839ff # Parent d3181b286250540ecae30e46518c0fbdd43b5bb9 amend: add -D/--currentdate option It bumps the date field even if there's no other

[PATCH 3 of 4] amend: add boolean to ignore date-only change

2019-01-07 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1546864775 -32400 # Mon Jan 07 21:39:35 2019 +0900 # Node ID d3181b286250540ecae30e46518c0fbdd43b5bb9 # Parent 224a7e7feb44b205dcb3900e1a0e003287278640 amend: add boolean to ignore date-only change I want to add -D/--currentdate option,

[PATCH 2 of 4] amend: refactor commit date handling

2019-01-07 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1546864198 -32400 # Mon Jan 07 21:29:58 2019 +0900 # Node ID 224a7e7feb44b205dcb3900e1a0e003287278640 # Parent 37086867ab18484c093a188851c3847d695c8629 amend: refactor commit date handling There's no need to parse a date tuple. Just do it

[PATCH 1 of 4] test-amend: remove uninteresting fields from log output to deduplicate tests

2019-01-07 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1546865843 -32400 # Mon Jan 07 21:57:23 2019 +0900 # Node ID 37086867ab18484c093a188851c3847d695c8629 # Parent 5967995c32bb802eee6ef8f75ff6b31278bd9e38 test-amend: remove uninteresting fields from log output to deduplicate tests We aren't

D5503: vfs: add support for repo names with `$` when using with env vars (issue5739)

2019-01-07 Thread yuja (Yuya Nishihara)
yuja added a comment. > def __init__(self, base, audit=True, cacheaudited=False, expandpath=False, >realpath=False): > > +if '$' in base and os.path.isdir(base): > +# when there exists a repo '$foo' and an env var foo=bar, stop > +

Re: D5503: vfs: add support for repo names with `$` sign while using with env vars (issue5739)

2019-01-07 Thread Yuya Nishihara
> def __init__(self, base, audit=True, cacheaudited=False, > expandpath=False, > realpath=False): > +if '$' in base and os.path.isdir(base): > +# when there exists a repo '$foo' and an env var foo=bar, stop > +# expanding path. refer

D5513: amend: concise logic for rewrite.updatetimestamp

2019-01-07 Thread taapas1128 (Taapas Agrawal)
taapas1128 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5513 AFFECTED FILES mercurial/cmdutil.py CHANGE DETAILS diff --git a/mercurial/cmdutil.py

D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

2019-01-07 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5967995c32bb: pull: use opts.get(bookmark) instead of opts[bookmark] (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5503: vfs: add support for repo names with `$` when using with env vars (issue5739)

2019-01-07 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 13046. navaneeth.suresh retitled this revision from "vfs: add support for repo names with `$` sign while using with env vars (issue5739)" to "vfs: add support for repo names with `$` when using with env vars (issue5739)". REPOSITORY rHG Mercurial

D5491: amend: added config option to update time to current in hg amend(issue5828)

2019-01-07 Thread taapas1128 (Taapas Agrawal)
taapas1128 added a comment. Thanks for queueing. I will make the follow up patch for the inline comments. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5491 To: taapas1128, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel

D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

2019-01-07 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 13045. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5484?vs=12986=13045 REVISION DETAIL https://phab.mercurial-scm.org/D5484 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git

D5478: tests: add tests for narrow clone when both sparse and narrow are enabled

2019-01-07 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Ping for review! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5478 To: pulkit, durin42, #hg-reviewers Cc: mjpieters, mercurial-devel ___ Mercurial-devel mailing list

D5491: amend: added config option to update time to current in hg amend(issue5828)

2019-01-07 Thread taapas1128 (Taapas Agrawal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGec51a430ec51: amend: added config option to update time to current in hg amend(issue5828) (authored by taapas1128, committed by ). CHANGED PRIOR TO COMMIT

D5491: amend: added config option to update time to current in hg amend(issue5828)

2019-01-07 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added a comment. Queueing this, many thanks! I have left some inline comments, can you follow-up on them? INLINE COMMENTS > cmdutil.py:2447 > > +if ui.configbool('rewrite','update-timestamp'): > +if opts.get('date'): This one

D5502: tests: correct version check in clientreactor test

2019-01-07 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG685cf59a134f: tests: correct version check in clientreactor test (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5501: py3: buildbot spotted more passing tests

2019-01-07 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8d03d131f7d3: py3: buildbot spotted more passing tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5501?vs=13023=13042

D5500: tests: add lots of b prefix goo to test-fastannotate-revmap.py

2019-01-07 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0fea133780bf: tests: add lots of b prefix goo to test-fastannotate-revmap.py (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5499: fastannotate: add a missing b prefix

2019-01-07 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1205ba8f11ac: fastannotate: add a missing b prefix (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5499?vs=13021=13040

[Bug 6048] New: splitting a secret commit produces drafts

2019-01-07 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6048 Bug ID: 6048 Summary: splitting a secret commit produces drafts Product: Mercurial Version: stable branch Hardware: PC OS: Linux Status: UNCONFIRMED

D5498: server: always close http socket if responding with an error (issue6033)

2019-01-07 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Is this meant for stable? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5498 To: durin42, #hg-reviewers, mharbison72, pulkit Cc: mharbison72, mercurial-devel ___ Mercurial-devel mailing list

D5509: narrow: move copytonarrowspec() out of setnarrowpats()

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13037. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5509?vs=13031=13037 REVISION DETAIL https://phab.mercurial-scm.org/D5509 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/narrowcommands.py

D5506: narrow: copy store narrowspec to working copy immediately

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13035. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5506?vs=13028=13035 REVISION DETAIL https://phab.mercurial-scm.org/D5506 AFFECTED FILES hgext/narrow/narrowcommands.py mercurial/hg.py

D5511: narrow: reuse narrowspec.updateworkingcopy() when narrowing

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13039. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5511?vs=13033=13039 REVISION DETAIL https://phab.mercurial-scm.org/D5511 AFFECTED FILES hgext/narrow/narrowcommands.py mercurial/narrowspec.py CHANGE

D5510: narrow: reuse narrowspec.updateworkingcopy() when widening

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13038. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5510?vs=13032=13038 REVISION DETAIL https://phab.mercurial-scm.org/D5510 AFFECTED FILES hgext/narrow/narrowcommands.py

D5508: narrow: extract repo property for store narrowmatcher

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 13036. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5508?vs=13030=13036 REVISION DETAIL https://phab.mercurial-scm.org/D5508 AFFECTED FILES hgext/lfs/__init__.py mercurial/localrepo.py CHANGE DETAILS

Re: [PATCH 4 of 4] mmapindex: set default to 1MB

2019-01-07 Thread Boris FELD
On 03/01/2019 09:58, Yuya Nishihara wrote: > On Wed, 2 Jan 2019 23:40:11 +0100, Boris FELD wrote: >> On 04/12/2018 12:09, Yuya Nishihara wrote: >>> On Sun, 02 Dec 2018 17:17:43 +0100, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1542949784 -3600 # Fri

D5509: narrow: move copytonarrowspec() out of setnarrowpats()

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think it was a mistake to write the working copy's narrowspec every time the store narrowspec is written. This starts

D5511: narrow: reuse narrowspec.updateworkingcopy() when narrowing

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Similar to the previous patch for widening, but here we also need to teach updateworkingcopy() to forcefully delete files

D5506: narrow: copy store narrowspec to working copy immediately

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We no longer need to delay it until the end of the transaction since we now restore a backup if the transaction aborts.

D5508: narrow: extract repo property for store narrowmatcher

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When a repo lock is released, we try to persist the manifest cache. That involves getting the narrowmatcher for the manifestlog. That should not fail if the

D5507: narrow: drop now-unnecessary reassignment of repo attributes

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5507 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git a/mercurial/localrepo.py

D5505: narrow: include working copy narrowspec in transaction journal

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have separate narrowspecs for the store and the working copy, we need to include both in the transaction journal. REPOSITORY rHG

D5504: narrow: make dirstateguard back up and restore working copy narrowspec instead

2019-01-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We used to have only one narrowspec for the store and the working copy, but now that we have one narrowspec for each, it seems clear that the dirstateguard

D5503: vfs: add support for repo names with `$` sign while using with env vars (issue5739)

2019-01-07 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `$ foo=bar hg root` fails to recognise the repo `$foo`. I stopped expanding env vars from vfs when there exists a repo with the same name as the env