# HG changeset patch
# User Yuya Nishihara
# Date 1547282616 -32400
# Sat Jan 12 17:43:36 2019 +0900
# Node ID f52ca65e212c9a56eb631c81434c4c1fe262ea68
# Parent 4f675c12d083a23049d75930bb765ed8bd27cd2c
repair: move ui.history-editing-backup to [rewrite] section
Since we have the "rewrite" s
# HG changeset patch
# User Yuya Nishihara
# Date 1547282866 -32400
# Sat Jan 12 17:47:46 2019 +0900
# Node ID ead5fb5b2f2908c77aee99cde8b298e407a6efc8
# Parent f52ca65e212c9a56eb631c81434c4c1fe262ea68
help: document rewrite.backup-bundle option
diff --git a/hgext/histedit.py b/hgext/histed
# HG changeset patch
# User Yuya Nishihara
# Date 1537964953 -32400
# Wed Sep 26 21:29:13 2018 +0900
# Node ID c5a71f1cdd3278159500360435863ee01c842cf4
# Parent ead5fb5b2f2908c77aee99cde8b298e407a6efc8
ui: move protectedstdio() context manager from procutil
This is a follow-up series for 23
# HG changeset patch
# User Yuya Nishihara
# Date 1537965712 -32400
# Wed Sep 26 21:41:52 2018 +0900
# Node ID 8e956cead2023a3afdfb3f06a08b24290dffc244
# Parent c5a71f1cdd3278159500360435863ee01c842cf4
ui: proxy protect/restorestdio() calls to update internal flag
It should be better to man
kevincox added inline comments.
INLINE COMMENTS
> ancestors.rs:170
> +bases_vec.push(rev.to_py_object(py).into_object());
> +}
> +Ok(PyTuple::new(py, bases_vec.as_slice()))
This could be a `.collect()` call. Something like:
let bases_vec: Vec = bases_set.into_iter(
Thanks for the comments!
> Maybe need to check the .gui flag of the tool. Otherwise the console
> would be messed up if the tool wasn't a GUI program.
Good point, although the existing extdiff code doesn't seem to be checking
that, no? So should I do that in a separate patch?
> Well, I think
Queued, thanks.
> + $ echo '[extensions]' >> $HGRCPATH
> + $ echo 'histedit =' >> $HGRCPATH
Removed these lines. The extension is enabled at the beginning.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.or
yuja added a comment.
Queued, thanks.
> + $ echo '[extensions]' >> $HGRCPATH
> + $ echo 'histedit =' >> $HGRCPATH
Removed these lines. The extension is enabled at the beginning.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5552
To: navaneeth.sur
> + $ cat >> testmocks.py << EOF
> + > # mock out util.makedate() to supply testable values
> + > import os
> + > from mercurial import pycompat, util
> + > from mercurial.utils import dateutil
> + >
> + > def mockmakedate():
> + > filename = os.path.join(os.environ['TESTTMP'], 'testti
yuja added a comment.
> + $ cat >> testmocks.py << EOF
> + > # mock out util.makedate() to supply testable values
> + > import os
> + > from mercurial import pycompat, util
> + > from mercurial.utils import dateutil
> + >
> + > def mockmakedate():
> + > filenam
> --- a/mercurial/cmdutil.py
> +++ b/mercurial/cmdutil.py
> @@ -237,6 +237,7 @@
> def dorecord(ui, repo, commitfunc, cmdsuggest, backupall,
> filterfn, *pats, **opts):
> opts = pycompat.byteskwargs(opts)
> +ignorews = opts.get('ignorews', False)
It isn't nice to mix command
yuja added a comment.
> - a/mercurial/cmdutil.py +++ b/mercurial/cmdutil.py @@ -237,6 +237,7 @@ def
dorecord(ui, repo, commitfunc, cmdsuggest, backupall, filterfn, *pats, **opts):
opts = pycompat.byteskwargs(opts) +ignorews = opts.get('ignorews', False)
It isn't nice to mix command o
> +if p.returncode:
> +raise Exception('failed to build docker image: %s %s' % (p.stdout,
> p.stderr))
Can you change the exception type? test-check-code.t complains about it.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.or
yuja added a comment.
> +if p.returncode:
> +raise Exception('failed to build docker image: %s %s' %
(p.stdout, p.stderr))
Can you change the exception type? test-check-code.t complains about it.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG172296c6db91: tests: add test for warning on histedit with
tagged commits (authored by navaneeth.suresh, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D5552?vs=13134&id=13188#t
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4f0ae5c64c1b: tests: make HGCATAPULTSERVERPIPE imply
HGTESTCATAPULTSERVERPIPE (authored by spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org
> > It was intentionally added by
> https://phab.mercurial-scm.org/rHG3f1dccea9510c122cf9ab0e7a5a19ceed3600a7f
> (with no tests.)
>
> Do you want me to add tests for that? If yes, please mention the things I
> need to take care of on
>writing those tests.
I think you can reuse the t
yuja added a comment.
> > It was intentionally added by
https://phab.mercurial-scm.org/rHG3f1dccea9510c122cf9ab0e7a5a19ceed3600a7f
(with no tests.)
>
> Do you want me to add tests for that? If yes, please mention the things
I need to take care of on
>writing those tests.
On Sat, 12 Jan 2019 09:26:25 -0800, Ludovic Chabant wrote:
> Thanks for the comments!
>
> > Maybe need to check the .gui flag of the tool. Otherwise the console
> > would be messed up if the tool wasn't a GUI program.
>
> Good point, although the existing extdiff code doesn't seem to be checking
> -if self._initempty:
> -# changelogs don't benefit from generaldelta
> +if self._initempty and (self.version & 0x == revlog.REVLOGV1):
> +# changelogs don't benefit from generaldelta.
Perhaps, `debugdeltachain()` and `debugrevlog()` has to be updated a
yuja added a comment.
> - if self._initempty:
> - # changelogs don't benefit from generaldelta +if self._initempty
and (self.version & 0x == revlog.REVLOGV1): +# changelogs don't
benefit from generaldelta.
Perhaps, `debugdeltachain()` and `debugrevlog()` has to
Queued up to this, thanks.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
yuja added a comment.
Queued up to this, thanks.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5564
To: indygreg, #hg-reviewers
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.
> I'm not sure when ``opener.options`` would ever be explicitly
> set to None. It is definitely not possible to construct a repo
> this way because ``localrepo.resolvestorevfsoptions()`` always
> returns a dict and ``localrepo.makelocalrepository()`` always
> sets ``opener.options`` to th
yuja added a comment.
> I'm not sure when ``opener.options`` would ever be explicitly
> set to None. It is definitely not possible to construct a repo
> this way because ``localrepo.resolvestorevfsoptions()`` always
> returns a dict and ``localrepo.makelocalrepository()`` always
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd8fe67db5234: internals: minor rewriting of revlogs
documentation (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5558?vs=13
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGcecf3f8bccd3: revlog: always process opener options
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5559?vs=13155&id=13191
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6439cefaeb64: revlog: rename v to versionflags (authored by
indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5560?vs=13156&id=13192
REVIS
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd0de4fdd87aa: revlog: store mmaplargeindex as an instance
attribute (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5562?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe3cfe0702eac: revlog: inline opener options logic into
_loadindex() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5563?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3f807237dc94: revlog: use separate variables to track
version flags (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5564?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe7a2cc84dbc0: revlog: always enable generaldelta on version
2 revlogs (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5561?v
# HG changeset patch
# User Yuya Nishihara
# Date 1547357171 -32400
# Sun Jan 13 14:26:11 2019 +0900
# Node ID ec7bc9f70e3982f30c2801d3af51d57c498b0851
# Parent 3f807237dc94925b7f92aeb6a822440856cc8b47
archival: construct progress helper through ui.makeprogress()
No idea why we didn't.
dif
# HG changeset patch
# User Yuya Nishihara
# Date 1547356895 -32400
# Sun Jan 13 14:21:35 2019 +0900
# Node ID e13ab96098d053c755988b4e94e5c99b203f70e8
# Parent ec7bc9f70e3982f30c2801d3af51d57c498b0851
progress: change _updatebar() to take parameters as arguments
I want to move updatebar()
# HG changeset patch
# User Yuya Nishihara
# Date 1547357805 -32400
# Sun Jan 13 14:36:45 2019 +0900
# Node ID ed29a1a69f505fb8b35e8a36c220a50c99baa4cd
# Parent e13ab96098d053c755988b4e94e5c99b203f70e8
progress: specify updatebar() function by constructor argument
This makes it easy for ui
# HG changeset patch
# User Yuya Nishihara
# Date 1547358284 -32400
# Sun Jan 13 14:44:44 2019 +0900
# Node ID 9e4ccae74c4793f1e10f2b89991466247eb8e76a
# Parent ed29a1a69f505fb8b35e8a36c220a50c99baa4cd
histedit: fix weird indent of i18n text
diff --git a/hgext/histedit.py b/hgext/histedit.p
# HG changeset patch
# User Yuya Nishihara
# Date 1547358375 -32400
# Sun Jan 13 14:46:15 2019 +0900
# Node ID 81fb0d015830b5ddf89b398aa63e0b56501dc6ac
# Parent 9e4ccae74c4793f1e10f2b89991466247eb8e76a
histedit: remove trailing space from warning message
diff --git a/hgext/histedit.py b/hge
taapas1128 updated this revision to Diff 13197.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13138&id=13197
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
tests/test-histedit-edit.t
tests/test-histe
# HG changeset patch
# User Yuya Nishihara
# Date 1547358986 -32400
# Sun Jan 13 14:56:26 2019 +0900
# Node ID eb6ba8bc27e0f8cc28268d6601b97f2c2a63c1c3
# Parent 81fb0d015830b5ddf89b398aa63e0b56501dc6ac
revlog: document that mmap resources are released implicitly by GC
It's okay-ish, but cur
taapas1128 updated this revision to Diff 13198.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13197&id=13198
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
tests/mockmakedate.py
tests/test-histedit-e
taapas1128 updated this revision to Diff 13199.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13198&id=13199
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
tests/mockmakedate.py
tests/test-histedit-e
taapas1128 updated this revision to Diff 13200.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13199&id=13200
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
tests/mockmakedate.py
tests/test-histedit-e
On Sat, Jan 12, 2019 at 2:50 AM Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1547282866 -32400
> # Sat Jan 12 17:47:46 2019 +0900
> # Node ID ead5fb5b2f2908c77aee99cde8b298e407a6efc8
> # Parent f52ca65e212c9a56eb631c81434c4c1fe262ea68
> help: document rewri
taapas1128 added a comment.
I have extracted mockdate function as `tests/mockdate.py` and dealt with the
commas and spaces.
> def commiteditor(self):
> """The editor to be used to edit the commit message."""
>
> @@ -800,6 +804,8 @@
>
> 1. date if self.firstdate(): comm
On 12/01/2019 05:04, Yuya Nishihara wrote:
> On Fri, 11 Jan 2019 12:29:06 +0100, Boris Feld wrote:
>> # HG changeset patch
>> # User Boris Feld
>> # Date 1547130238 -3600
>> # Thu Jan 10 15:23:58 2019 +0100
>> # Node ID 38733dd8559578267617514a42f253efabb6
>> # Parent 427247e84e29c14432
On 12/01/2019 05:38, Yuya Nishihara wrote:
> On Fri, 11 Jan 2019 12:29:09 +0100, Boris Feld wrote:
>> # HG changeset patch
>> # User Boris Feld
>> # Date 1546575973 -3600
>> # Fri Jan 04 05:26:13 2019 +0100
>> # Node ID 4a56fbdacff33c3985bbb84f2e19ddfbd48ed4fa
>> # Parent 438ea9b8a44c181d627
On 12/01/2019 06:00, Yuya Nishihara wrote:
> On Fri, 11 Jan 2019 12:29:10 +0100, Boris Feld wrote:
>> # HG changeset patch
>> # User Boris Feld
>> # Date 1546605681 -3600
>> # Fri Jan 04 13:41:21 2019 +0100
>> # Node ID 73926c4ab24d6c01723ed050601b134bdc89562f
>> # Parent 4a56fbdacff33c3985
On Sat, Jan 12, 2019 at 10:48 PM Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1547357805 -32400
> # Sun Jan 13 14:36:45 2019 +0900
> # Node ID ed29a1a69f505fb8b35e8a36c220a50c99baa4cd
> # Parent e13ab96098d053c755988b4e94e5c99b203f70e8
> progress: specify u
taapas1128 updated this revision to Diff 13201.
taapas1128 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5554?vs=13200&id=13201
REVISION DETAIL
https://phab.mercurial-scm.org/D5554
AFFECTED FILES
hgext/histedit.py
49 matches
Mail list logo