D5585: histedit: fix call to _getgoal() by adding a byteskwargs() wrapper

martinvonz added a comment. Just for my understanding, this is just a py3 thing, right? Or is it somehow broken with py2 as well? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5585 To: durin42, #hg-reviewers Cc: martinvonz, mercurial-devel

D5585: histedit: fix call to _getgoal() by adding a byteskwargs() wrapper

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I also added some b-prefixes while I was here because I got confused and it seems silly to not just add them since it clarifies the whole change. REPOSITORY

D5551: rust-cpython: using MissingAncestors from Python code

gracinet updated this revision to Diff 13219. gracinet edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5551?vs=13129=13219 REVISION DETAIL https://phab.mercurial-scm.org/D5551 AFFECTED FILES mercurial/revlog.py

D5584: rust: MissingAncestors.basesheads()

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This new API method on `MissingAncestors` leverages directly the Rust implementation for relative heads of a set, and also lowers the cost of

D5579: rust: factorized testing Graphs

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY it will useful to use these outside of `ancestors`, too. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5579

D5583: discovery: using the new basesheads()

gracinet created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Our ultimate goal is to switch eventually to a Rust implementation, but this move actually seems to increase the performance in a pure Python build. What

D5580: rust: dagop.headrevs() Rust counterparts

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This introduces two Rust implementations for `mercurial.dagop.headrevs`. The algorithm is identical to the Python version. Depending on the

D5581: rust-cpython: set conversion for MissingAncestors.bases()

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Also I hope that the separate `py_set()` helper will help transition to proper `PySet` support in `rust-cpython` Took the opportunity to

D5582: ancestor: incrementalmissingancestors.basesheads()

gracinet created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This new method will avoid the need to access the `bases` attribute directly in `setdiscovery`, and to prefilter `nullrev` before passing it to the `heads()`

D5578: rust-cpython: moved generic conversion fn out of ancestors module

gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will allow to use it easily from other submodules REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5578

D5550: rust-cpython: bindings for MissingAncestors

gracinet marked 2 inline comments as done. gracinet added inline comments. INLINE COMMENTS > gracinet wrote in ancestors.rs:170 > Thanks for the detailed answer. > > Then the problem, in case of iterators coming directly from Python, is that > they don't currently implement `size_hint()`, so

D5550: rust-cpython: bindings for MissingAncestors

gracinet added inline comments. INLINE COMMENTS > kevincox wrote in ancestors.rs:170 > Iterator has a size_hint > > method which can provide a clue as to the size of the iterator if know. There > is also the

D5495: revset: add "branch" positional arguments to the merge revset

angel.ezquerra added a comment. In https://phab.mercurial-scm.org/D5495#82397, @yuja wrote: > Generally looks good. > > Can you fix a couple of nits? And if possible, fold the tests from https://phab.mercurial-scm.org/D5577 > into this and the next patch. We prefer including

D5495: revset: add "branch" positional arguments to the merge revset

angel.ezquerra updated this revision to Diff 13210. Herald added a subscriber: mjpieters. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5495?vs=13204=13210 REVISION DETAIL https://phab.mercurial-scm.org/D5495 AFFECTED FILES mercurial/revset.py

D5496: revset: add "samebranch" keyword argument to the merge revset

angel.ezquerra updated this revision to Diff 13211. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5496?vs=13205=13211 REVISION DETAIL https://phab.mercurial-scm.org/D5496 AFFECTED FILES mercurial/revset.py tests/test-help.t tests/test-revset.t

mercurial@41215: 33 new changesets

33 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/c01fac6749e5 changeset: 41183:c01fac6749e5 user:Augie Fackler date:Thu Jan 10 10:23:22 2019 -0500 summary: fuzz: stop building Python in the Makefile

D5550: rust-cpython: bindings for MissingAncestors

kevincox added inline comments. INLINE COMMENTS > gracinet wrote in ancestors.rs:170 > Hi @kevincox. I have a general question for these, please correct me if I'm > making wrong assumptions. > > Given that we know in advance exactly the number of elements required, and > that it can be large,

Sprint 5.0

(Sending as a separate thread in case people had muted the other one) Please update your availability on the wiki page: https://www.mercurial-scm.org/wiki/5.0sprint, I'd like to have a date (and location) picked on Friday. ___ Mercurial-devel mailing

D5550: rust-cpython: bindings for MissingAncestors

gracinet added inline comments. INLINE COMMENTS > kevincox wrote in ancestors.rs:170 > This could be a `.collect()` call. Something like: > > let bases_vec: Vec = bases_set.into_iter() > .map(|rev| rev.to_py_object(py).into_object()) > .collect(); Hi @kevincox. I have a general

D5551: rust-cpython: using MissingAncestors from Python code

gracinet added a comment. @yuja I talked with @lothiraldan about this today. It turns out that it'd be better to provide a `basesheads` returning a set directly from the MissingAncestors object (I do have a Rust implementation for heads). This would make the call from `setdiscovery`

D5571: packaging: allow running packaging with custom uid+gid for CentOS

Mathiasdm updated this revision to Diff 13209. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5571?vs=13176=13209 REVISION DETAIL https://phab.mercurial-scm.org/D5571 AFFECTED FILES contrib/packaging/docker/centos5 contrib/packaging/docker/centos6

D5570: hg-docker: fix Python 3.4 compatibility (for CentOS 7)

Mathiasdm updated this revision to Diff 13208. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5570?vs=13175=13208 REVISION DETAIL https://phab.mercurial-scm.org/D5570 AFFECTED FILES contrib/packaging/hg-docker CHANGE DETAILS diff --git

Re: [PATCH] formatting: apply clang-format using the format-source extension

> On Jan 14, 2019, at 05:49, Boris Feld wrote: > > # HG changeset patch > # User Boris Feld > # Date 1547462137 -3600 > # Mon Jan 14 11:35:37 2019 +0100 > # Node ID 1b6f196b7e094278f9956a479e10e02cd1108a12 > # Parent 8d0d695fc7910665452b81052d1bbc55b3829b14 > # EXP-Topic format-source >

[PATCH 7 of 7 V3] revset: introduce an API that avoids `formatspec` input serialization

# HG changeset patch # User Boris Feld # Date 1546605681 -3600 # Fri Jan 04 13:41:21 2019 +0100 # Node ID 466ba919947b7ced476c3669ac444f0b74ade8f0 # Parent 1def212ed730ce024963fd41f2d341f584521bbf # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 6 of 7 V3] revset: detect integer list on parsing

# HG changeset patch # User Boris Feld # Date 1546575973 -3600 # Fri Jan 04 05:26:13 2019 +0100 # Node ID 1def212ed730ce024963fd41f2d341f584521bbf # Parent 2c5c8e76f2a95b10f367e50c17ae903471337b69 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 5 of 7 V3] revert: extract "%ld" formatting in a _formatintlist function

# HG changeset patch # User Boris Feld # Date 1546575417 -3600 # Fri Jan 04 05:16:57 2019 +0100 # Node ID 2c5c8e76f2a95b10f367e50c17ae903471337b69 # Parent 3e2bfc71b5408b23ba2ed50cf8d655c4ebab3401 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 4 of 7 V3] revset: extract parsing logic out of formatspec

# HG changeset patch # User Boris Feld # Date 1546565344 -3600 # Fri Jan 04 02:29:04 2019 +0100 # Node ID 3e2bfc71b5408b23ba2ed50cf8d655c4ebab3401 # Parent 18309ce7974f4479b089f0dc6f849afd19f9e629 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 3 of 7 V3] revset: enforce "%d" to be interpreted as literal revision number (API) (BC)

# HG changeset patch # User Boris Feld # Date 1547130238 -3600 # Thu Jan 10 15:23:58 2019 +0100 # Node ID 18309ce7974f4479b089f0dc6f849afd19f9e629 # Parent 4005f4a1c34ec9121983bb07b4a1895892645f30 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 2 of 7 V3] revset: remove the last usage of "%d" for a non-revision entry

# HG changeset patch # User Boris Feld # Date 1547132587 -3600 # Thu Jan 10 16:03:07 2019 +0100 # Node ID 4005f4a1c34ec9121983bb07b4a1895892645f30 # Parent 15458ddc966d002a781d0be59cf2fa961790aa4c # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 1 of 7 V3] revset: remove a rare usage of "%d" for a non-revision item

# HG changeset patch # User Boris Feld # Date 1547132233 -3600 # Thu Jan 10 15:57:13 2019 +0100 # Node ID 15458ddc966d002a781d0be59cf2fa961790aa4c # Parent c339a01acd9a5fda3ea9ed15b4342a0d08af5f96 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

Re: [PATCH 7 of 7 V2] revset: introduce an API that avoids `formatspec` input serialization

Please ignore the V2 version, I sent the wrong version. Sorry for the inconvenience. I'm sending the V3 now with the correct version On 14/01/2019 13:13, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1546605681 -3600 > # Fri Jan 04 13:41:21 2019 +0100 > # Node ID

D5495: revset: add "branch" positional arguments to the merge revset

yuja added a comment. > What about making the argument a revset instead of a branch name. You can get the same result `merge(branch("foo")` but have a more expressive result `merge(only(4.8, 4.7))` ? That's basically a simpler form of my `filter()` proposal. The problem of

Re: D5495: revset: add "branch" positional arguments to the merge revset

> What about making the argument a revset instead of a branch name. You can > get the same result `merge(branch("foo")` but have a more expressive result > `merge(only(4.8, 4.7))` ? That's basically a simpler form of my `filter()` proposal. The problem of `merge(branch("foo"))` is that it's

D5577: tests: replaced mockmakedate function in test-amend.t

taapas1128 added a comment. @lothiraldan I am not sure but my aim is to supply mock values to `dateutil.makedate()` everytime is it called but I will go through what `devel.default-date` does . REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5577 To:

D5577: tests: replaced mockmakedate function in test-amend.t

taapas1128 added a comment. @lothiraldan I am not sure that would work because my aim is to supply mock values everytime `dateutil.makedate()` is called so as to avoid the change in test results at any time the test is executed. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH] discovery: compute newly discovered missing in a more efficient way

# HG changeset patch # User Boris Feld # Date 1546614288 -3600 # Fri Jan 04 16:04:48 2019 +0100 # Node ID 39d6a1edd0b944c3590d95b8af3686059ede574a # Parent 8d0d695fc7910665452b81052d1bbc55b3829b14 # EXP-Topic discovery.revset # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D5495: revset: add "branch" positional arguments to the merge revset

lothiraldan added a comment. What about making the argument a revset instead of a branch name. You can get the same result `merge(branch("foo")` but have a more expressive result `merge(only(4.8, 4.7))` ? (Sorry to be a bit late to the party) REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH 7 of 7 V2] revset: introduce an API that avoids `formatspec` input serialization

# HG changeset patch # User Boris Feld # Date 1546605681 -3600 # Fri Jan 04 13:41:21 2019 +0100 # Node ID 8bcaad324401bd275886a0ae4340a876ac82ab84 # Parent 1def212ed730ce024963fd41f2d341f584521bbf # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 6 of 7 V2] revset: detect integer list on parsing

# HG changeset patch # User Boris Feld # Date 1546575973 -3600 # Fri Jan 04 05:26:13 2019 +0100 # Node ID 1def212ed730ce024963fd41f2d341f584521bbf # Parent 2c5c8e76f2a95b10f367e50c17ae903471337b69 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 5 of 7 V2] revert: extract "%ld" formatting in a _formatintlist function

# HG changeset patch # User Boris Feld # Date 1546575417 -3600 # Fri Jan 04 05:16:57 2019 +0100 # Node ID 2c5c8e76f2a95b10f367e50c17ae903471337b69 # Parent 3e2bfc71b5408b23ba2ed50cf8d655c4ebab3401 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 4 of 7 V2] revset: extract parsing logic out of formatspec

# HG changeset patch # User Boris Feld # Date 1546565344 -3600 # Fri Jan 04 02:29:04 2019 +0100 # Node ID 3e2bfc71b5408b23ba2ed50cf8d655c4ebab3401 # Parent 18309ce7974f4479b089f0dc6f849afd19f9e629 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 3 of 7 V2] revset: enforce "%d" to be interpreted as literal revision number (API) (BC)

# HG changeset patch # User Boris Feld # Date 1547130238 -3600 # Thu Jan 10 15:23:58 2019 +0100 # Node ID 18309ce7974f4479b089f0dc6f849afd19f9e629 # Parent 4005f4a1c34ec9121983bb07b4a1895892645f30 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 2 of 7 V2] revset: remove the last usage of "%d" for a non-revision entry

# HG changeset patch # User Boris Feld # Date 1547132587 -3600 # Thu Jan 10 16:03:07 2019 +0100 # Node ID 4005f4a1c34ec9121983bb07b4a1895892645f30 # Parent 15458ddc966d002a781d0be59cf2fa961790aa4c # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 1 of 7 V2] revset: remove a rare usage of "%d" for a non-revision item

# HG changeset patch # User Boris Feld # Date 1547132233 -3600 # Thu Jan 10 15:57:13 2019 +0100 # Node ID 15458ddc966d002a781d0be59cf2fa961790aa4c # Parent c339a01acd9a5fda3ea9ed15b4342a0d08af5f96 # EXP-Topic revs-efficiency # Available At https://bitbucket.org/octobus/mercurial-devel/ #

Re: [PATCH 8 of 8] revset: introduce an API that avoids `formatspec` input serialization

On 13/01/2019 10:53, Yuya Nishihara wrote: > On Sun, 13 Jan 2019 08:40:41 +0100, Boris FELD wrote: >> On 12/01/2019 06:00, Yuya Nishihara wrote: >>> On Fri, 11 Jan 2019 12:29:10 +0100, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1546605681 -3600 # Fri

[PATCH] formatting: apply clang-format using the format-source extension

# HG changeset patch # User Boris Feld # Date 1547462137 -3600 # Mon Jan 14 11:35:37 2019 +0100 # Node ID 1b6f196b7e094278f9956a479e10e02cd1108a12 # Parent 8d0d695fc7910665452b81052d1bbc55b3829b14 # EXP-Topic format-source # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH V3] update: fix edge-case with update.atomic-file and read-only files

# HG changeset patch # User Boris Feld # Date 1547128621 -3600 # Thu Jan 10 14:57:01 2019 +0100 # Node ID 0a3fe47decbe8920754e44d6448bfa474990edd3 # Parent 963462786f6e028563bcedc9008622e0f3b59c86 # EXP-Topic atomic-update-read-only # Available At

D5577: tests: replaced mockmakedate function in test-amend.t

lothiraldan added a comment. @taapas1128 You can also set the option `devel.default-date` that should do the trick REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5577 To: taapas1128, #hg-reviewers Cc: lothiraldan, yuja, mercurial-devel