navaneeth.suresh updated this revision to Diff 13736.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5813?vs=13735=13736
REVISION DETAIL
https://phab.mercurial-scm.org/D5813
AFFECTED FILES
mercurial/revset.py
tests/test-revset.t
CHANGE DETAILS
navaneeth.suresh marked 2 inline comments as done.
navaneeth.suresh added a comment.
@pulkit Thanks for the quick review! I've updated the revision with the
suggested changes. @durin42 It would be great if you let us know your opinion
on `one()` as an alias for `expect(, 1)`. I did it as it
navaneeth.suresh updated this revision to Diff 13735.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5813?vs=13731=13735
REVISION DETAIL
https://phab.mercurial-scm.org/D5813
AFFECTED FILES
mercurial/revset.py
tests/test-revset.t
CHANGE DETAILS
On Sun, Feb 3, 2019 at 7:41 PM Anton Shestakov wrote:
> On Sun, 3 Feb 2019 14:27:22 -0800
> Martin von Zweigbergk wrote:
>
> > test-contrib-relnotes.t fails as follows. Expected? Should we amend it in
> > in flight?
>
> Oops, yes. TIL there are python3-only tests.
>
Fixed in the hg-committed
On Sun, 3 Feb 2019 14:27:22 -0800
Martin von Zweigbergk wrote:
> test-contrib-relnotes.t fails as follows. Expected? Should we amend it in
> in flight?
Oops, yes. TIL there are python3-only tests.
___
Mercurial-devel mailing list
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5800#85220, @yuja wrote:
> > > Looks good, but I find it isn't easy to parse the meaning of
> > > `getuipathfn(repo, forcevalue=True)`. Perhaps it can be spelled as
> > > `forcerelative=True`.
> >
> > The
yuja added a comment.
> > Looks good, but I find it isn't easy to parse the meaning of
> > `getuipathfn(repo, forcevalue=True)`. Perhaps it can be spelled as
> > `forcerelative=True`.
>
> The problem is that this an override value for a boolean value, so it's
easy to
> > Looks good, but I find it isn't easy to parse the meaning of
> > `getuipathfn(repo, forcevalue=True)`. Perhaps it can be spelled as
> > `forcerelative=True`.
>
> The problem is that this an override value for a boolean value, so it's
> easy to mistake `forcerelative=False` to
test-contrib-relnotes.t fails as follows. Expected? Should we amend it in
in flight?
@@ -266,7 +266,6 @@
* diff: disable diff.noprefix option for diffstat (Bts:issue5759)
* evolution: make reporting of new unstable changesets optional
* extdata: abort if external command exits with
martinvonz updated this revision to Diff 13732.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5800?vs=13698=13732
REVISION DETAIL
https://phab.mercurial-scm.org/D5800
AFFECTED FILES
mercurial/commands.py
mercurial/configitems.py
martinvonz updated this revision to Diff 13734.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5802?vs=13700=13734
REVISION DETAIL
https://phab.mercurial-scm.org/D5802
AFFECTED FILES
mercurial/commands.py
tests/test-status.t
CHANGE DETAILS
diff
martinvonz updated this revision to Diff 13733.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5801?vs=13699=13733
REVISION DETAIL
https://phab.mercurial-scm.org/D5801
AFFECTED FILES
mercurial/cmdutil.py
tests/test-locate.t
CHANGE DETAILS
diff
martinvonz added a comment.
In https://phab.mercurial-scm.org/D5800#85128, @yuja wrote:
> Looks good, but I find it isn't easy to parse the meaning of
> `getuipathfn(repo, forcevalue=True)`. Perhaps it can be spelled as
> `forcerelative=True`.
The problem is that this an
pulkit added subscribers: durin42, pulkit.
pulkit added a comment.
> This then allows an alias for hg next to be update -r one(children(.))
> with sane failure behavior, and also makes some other scripting tasks
> a little less difficult.
Just for record, `hg next` has a nice prompt
> Generally looks good. Can you add some tests?
Oh right, that's another thing I wanted to ask -- how would I test that? The
only idea I have is to log some verbose message ("tool %s has a graphical
interface, launching processes simultaneously") and detect that in test. Is
there any better
navaneeth.suresh created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
`expect(, )` revset fails if `` is not exactly ``
elements.
`expect(, , )` revset fails if `` is not exactly between
`` and `` inclusive.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf3f6719951a3: revert: add prompt before undeleting a file
in -i (issue6008) (authored by taapas1128, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG02a8c912d2cb: py3: add some b prefixes in
test-notify.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5811?vs=13715=13725
yuja added a comment.
> I am not whether this is correct. This should have fix failure of
`test-lfs-serve.t#lfsremote-on` failure on py3 but it does not.
As you guess, this isn't correct. For example, `_(unicode_sring)` will crash
if gettext is enabled.
I don't know why
> I am not whether this is correct. This should have fix failure of
> `test-lfs-serve.t#lfsremote-on` failure on py3 but it does not.
As you guess, this isn't correct. For example, `_(unicode_sring)` will crash
if gettext is enabled.
I don't know why ValueError is used extensively in
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGae79747a1920: py3: use pycompat.long in
hgext/convert/monotone.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3b5228f74887: py3: add three new passing tests found by
buildbot (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG512eb4af4295: py3: do a fsdecode(), fsencode() dance in
posix.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
On Sat, 02 Feb 2019 22:24:34 -0800, Ludovic Chabant wrote:
> # HG changeset patch
> # User Ludovic Chabant
> # Date 1549173529 28800
> # Sat Feb 02 21:58:49 2019 -0800
> # Node ID b08ea934c2d5ac097b171ca74e826e4f9dea86a9
> # Parent 3a3b053d0882a33ba7ea667052e445b193ffa4df
> extdiff: support
On Sat, 02 Feb 2019 22:43:59 -0800, Ludovic Chabant wrote:
> One thing I'm not quite sure about this change is how to handle the new "gui"
> config flag.
>
> I wanted to use (abuse?) the difference between False and None in order to
> figure out if we found the flag in a section or not (and
pulkit added a comment.
In https://phab.mercurial-scm.org/D5792#85088, @taapas1128 wrote:
> @pulkit I have made an attempt to import the code please review.
@lothiraldan can you please review and help me if I have missed out any
portion of interactive from `evolve`
@taapas1128
pulkit added a comment.
I am not whether this is correct. This should have fix failure of
`test-lfs-serve.t#lfsremote-on` failure on py3 but it does not.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5812
To: pulkit, durin42, martinvonz, #hg-reviewers
Cc:
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: martinvonz.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame because mostly just r'' prefixes
REPOSITORY
rHG Mercurial
REVISION DETAIL
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame as just b'' prefixes
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5811
AFFECTED FILES
tests/test-notify.t
CHANGE
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5810
AFFECTED FILES
hgext/convert/monotone.py
CHANGE DETAILS
diff --git a/hgext/convert/monotone.py
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5809
AFFECTED FILES
contrib/python3-whitelist
CHANGE DETAILS
diff --git a/contrib/python3-whitelist
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We have to use `fsdecode()` instead of sysstr() because they are abusing
`PyUnicode_EncodeFSDefault()` to get back bytes.
REPOSITORY
rHG Mercurial
REVISION
32 matches
Mail list logo
