Re: [PATCH] chistedit: use magenta for current line as in crecord (issue6071)

test-check-code.t was unhappy with the line length, so I added break before "curses.color_pair()". On Thu, Feb 14, 2019 at 2:42 PM Martin von Zweigbergk wrote: > > On Wed, Feb 13, 2019 at 2:02 PM Jordi Gutiérrez Hermoso < > jord...@octave.org> wrote: > >> # HG changeset patch >> # User Jordi

Re: [PATCH] chistedit: use magenta for current line as in crecord (issue6071)

On Wed, Feb 13, 2019 at 2:02 PM Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1550095104 18000 > # Wed Feb 13 16:58:24 2019 -0500 > # Node ID e31eb021571e1a6a63aab8090819184576236c58 > # Parent 5d383d9636d0b81b416398913b32b8c715e98db5 >

D5967: chistedit: improve proper username in histedit curses interfacein changeset section (issue6072)

akshjain.jain74 added a comment. okay , thanks @martinvonz REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5967 To: akshjain.jain74, durin42, #hg-reviewers, martinvonz Cc: martinvonz, mercurial-devel ___

D5967: chistedit: improve proper username in histedit curses interfacein changeset section (issue6072)

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdf1f3ba56157: chistedit: improve proper username in histedit curses interface (authored by akshjain.jain74, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5967: chistedit: improve proper username in histedit curses interfacein changeset section (issue6072)

martinvonz accepted this revision. martinvonz added a comment. This revision is now accepted and ready to land. Looks like there's plenty of space there to show the full username. I suspect it was the way it was because it came from FB where just the username is enough to identify people.

D5967: curses: improve proper username in histedit curses interfacein changeset section (issue6072)

akshjain.jain74 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5967 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff

[Bug 6078] New: histedit fails with "abort: No module named _curses!"

https://bz.mercurial-scm.org/show_bug.cgi?id=6078 Bug ID: 6078 Summary: histedit fails with "abort: No module named _curses!" Product: Mercurial Version: 4.9 Hardware: PC OS: Windows Status: UNCONFIRMED

Re: [PATCH] crecord: remove obsolete version check

On Thu, Feb 14, 2019 at 6:48 PM Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1550158907 18000 > # Thu Feb 14 10:41:47 2019 -0500 > # Node ID 9c5c236afcc631d0dfc6a3e1424e353f6c6c85bf > # Parent 5d383d9636d0b81b416398913b32b8c715e98db5 >

D5940: uncommit: add -f/--force when possibly hiding data (issue5977)

navaneeth.suresh updated this revision to Diff 14096. navaneeth.suresh edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5940?vs=14036=14096 REVISION DETAIL https://phab.mercurial-scm.org/D5940 AFFECTED FILES

D5965: test: stabilize test-run-tests.t output

lothiraldan abandoned this revision. lothiraldan added a comment. Replaced by https://phab.mercurial-scm.org/D5966 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5965 To: lothiraldan, #hg-reviewers Cc: mercurial-devel

[PATCH] crecord: remove obsolete version check

# HG changeset patch # User Jordi Gutiérrez Hermoso # Date 1550158907 18000 # Thu Feb 14 10:41:47 2019 -0500 # Node ID 9c5c236afcc631d0dfc6a3e1424e353f6c6c85bf # Parent 5d383d9636d0b81b416398913b32b8c715e98db5 crecord: remove obsolete version check An internal function shouldn't be

D5940: uncommit: add -f/--force when possibly hiding data (issue5977)

pulkit added a comment. In https://phab.mercurial-scm.org/D5940#87087, @navaneeth.suresh wrote: > In https://phab.mercurial-scm.org/D5940#87026, @pulkit wrote: > > > Hi, it will be good if you specify that the patch is authored by someone else, mention their name and also provide the

D5940: uncommit: add -f/--force when possibly hiding data (issue5977)

navaneeth.suresh added a comment. In https://phab.mercurial-scm.org/D5940#87026, @pulkit wrote: > Hi, it will be good if you specify that the patch is authored by someone else, mention their name and also provide the link to the original PR of this patch. @pulkit the link of WIP

Re: [PATCH V2] fix: change the default fix pattern (issue6077)

On Wed, 13 Feb 2019 17:54:18 -0500, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1550096863 18000 > # Wed Feb 13 17:27:43 2019 -0500 > # Node ID d8ba3b6466b220a5e04d07a5eccd3c1d45a2f501 > # Parent 5d383d9636d0b81b416398913b32b8c715e98db5 >

D5966: test: stabilize test-run-tests.t output

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have reached a point where the duration in JSON reports of `test-run-tests.t` were greater or equal than 10 seconds, which doesn't match anymore the

D5965: test: stabilize test-run-tests.t output

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We have reached a point where the duration in `test-run-tests.t` were greater or equal than 10s, which doesn't match anymore the regex. For example here:

D5963: copies: handle the case when both merging csets are not descendant of merge base

khanchi97 added inline comments. INLINE COMMENTS > copies.py:571 > + copy, bothdiverge, bothincompletediverge) > +remainder.update(remainder1) > +elif dirtyc1: I am not sure if combining of partial copies in this case is correct or not. But I did

D5964: copies: return True instead of filename as it is expected to return boolean

khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As the function documentation says this function should True if we hit a match and False otherwise. And I see that we are not using that returned filename

D5963: copies: handle the case when both merging csets are not descendant of merge base

khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previous discussion on this issue can be found at this link: https://phab.mercurial-scm.org/D3896 Copying description from previous patch sent by Pulkit:

D5962: copies: add test that makes both the merging csets dirty and fails

khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Discussion related to this issue can be found here: https://phab.mercurial-scm.org/D3896 There can be cases when both the changesets which we are

Re: [PATCH] histedit: remove "chistedit" mention from interface

On Thu, Feb 14, 2019 at 12:05 AM Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1550091764 18000 > # Wed Feb 13 16:02:44 2019 -0500 > # Node ID 94ccf890584ee3bae9e543fade578e0f05281347 > # Parent 5d383d9636d0b81b416398913b32b8c715e98db5 >

D5961: copies: add test that makes both the merging csets dirty and run w/o error

khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Adding a test for fullcopytracing algorithm where both the merging csets are dirty, which means no cset is descendant of merging base. This test shows that

D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When running the test suite with multiple processes, we often get flaky outputs, like here: https://ci.octobus.net/job/MercurialPy2/274/console -

Re: [PATCH 3 of 4 V2] changelog: prefilter in headrevs()

On 2/13/19 2:18 PM, Yuya Nishihara wrote: > On Wed, 13 Feb 2019 12:47:56 +0100, Georges Racinet wrote: >> # HG changeset patch >> # User Georges Racinet >> # Date 1547815081 -3600 >> # Fri Jan 18 13:38:01 2019 +0100 >> # Node ID eae29e210636ee44851e0caa385097a090c60af8 >> # Parent

D5941: tweakdefault: Add better documentation for ui.tweakdefault(issue6000)

akshjain.jain74 added a comment. okay REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5941 To: akshjain.jain74, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel ___ Mercurial-devel mailing list

D5941: tweakdefault: Add better documentation for ui.tweakdefault(issue6000)

pulkit requested changes to this revision. pulkit added a comment. This revision now requires changes to proceed. In https://phab.mercurial-scm.org/D5941#87025, @akshjain.jain74 wrote: > @pulkit like what else we required to improve the documentation for the issue , in general what

D5940: uncommit: add -f/--force when possibly hiding data (issue5977)

pulkit added a comment. Hi, it will be good if you specify that the patch is authored by someone else, mention their name and also provide the link to the original PR of this patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5940 To: navaneeth.suresh,

D5941: tweakdefault: Add better documentation for ui.tweakdefault(issue6000)

akshjain.jain74 added a comment. @pulkit like what else we required to improve the documentation for the issue , in general what tweakdefault do for mercurial is already mention in the issue 樂 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5941 To:

D5941: tweakdefault: Add better documentation for ui.tweakdefault(issue6000)

pulkit added a comment. Hi, thanks for the patch. This is adding just un required churn to help text. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5941 To: akshjain.jain74, #hg-reviewers Cc: pulkit, mercurial-devel

D5953: revset: improve documentation on expectsize()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG735da363556d: revset: improve documentation on expectsize() (authored by navaneeth.suresh, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5953?vs=14068=14087#toc REPOSITORY

D5956: scmutil: fix a comment that doesn't match the code

This revision was automatically updated to reflect the committed changes. Closed by commit rHG879495c68e31: scmutil: fix a comment that doesnt match the code (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5958: remotefilelog: remove strkwargs()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4eeed5eac0f4: remotefilelog: remove strkwargs() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5958?vs=14082=14085

D5957: remotefilelog: use raw strings when looking for variable names

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe37bd7ccfee3: remotefilelog: use raw strings when looking for variable names (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5792: uncommit: added interactive mode(issue6062)

pulkit added a comment. The import looks fine to me. I will let someone else review the code because I authored this code in first place in evolve extension. Also it will be nice if you specify that the code is imported from evolve extension and also specify the commit hash from which you