Re: [PATCH STABLE] subrepo: add test for Windows relative-ish path with drive letter

On Fri, Feb 8, 2019 at 6:42 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1549540241 -32400 > # Thu Feb 07 20:50:41 2019 +0900 > # Branch stable > # Node ID adf01cdceea20b5ad6dacb11dbb1d94e5055e39c > # Parent 87a6e3c953e045d92147925fc71aad7c327fdbfd >

Re: [PATCH] chistedit: ensure a locale is set

On Tue, 19 Feb 2019 23:16:03 -0500, Jordi Gutiérrez Hermoso wrote: > On Wed, 2019-02-20 at 11:22 +0900, Yuya Nishihara wrote: > > Perhaps, we shouldn't do setlocale() until curses is actually used. > > Hm, that's a good point. Move it to _chisteditmain? That's the entry > point, I think. > > Or

Re: [PATCH 3 of 3 V2] color: change color of grep.rev label

On Tue, 19 Feb 2019 23:11:13 -0500, Jordi Gutiérrez Hermoso wrote: > On Wed, 2019-02-20 at 11:49 +0900, Yuya Nishihara wrote: > > > I've marked this as "(BC)" since this is IMHO a significant change. > > Blue on black is unreadable on my machine. > > It's kind of hard to predict what will be

Re: [PATCH] chistedit: ensure a locale is set

On Wed, 2019-02-20 at 11:22 +0900, Yuya Nishihara wrote: > Perhaps, we shouldn't do setlocale() until curses is actually used. Hm, that's a good point. Move it to _chisteditmain? That's the entry point, I think. Or maybe we should make our own wrapper curses module so it can be demandimported

Re: [PATCH 3 of 3 V2] color: change color of grep.rev label

On Wed, 2019-02-20 at 11:49 +0900, Yuya Nishihara wrote: > I've marked this as "(BC)" since this is IMHO a significant change. > Blue on black is unreadable on my machine. It's kind of hard to predict what will be readable. Linux terminal emulators usually let you define "blue" to be whatever

Re: [PATCH RFC] cmdtest: add a new command that checks revset matching

On Tue, 19 Feb 2019 19:17:03 +0100, Boris FELD wrote: > On 19/02/2019 13:52, Pulkit Goyal wrote: > > > > > > On Fri, Feb 15, 2019 at 6:11 PM Raphaël Gomès > > mailto:raphael.go...@octobus.net>> wrote: > > > > # HG changeset patch > > # User Raphaël Gomès mailto:rgo...@octobus.net>> > >

Re: [PATCH 3 of 3 V2] color: change color of grep.rev label

On Mon, 18 Feb 2019 20:03:42 -0500, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1550263757 18000 > # Fri Feb 15 15:49:17 2019 -0500 > # Node ID 4b06afa25bb124da32fcaa56d2b81405b4163b61 > # Parent 1ef5e748ebdeec679227f78179bd36bb9b3a1667 >

Re: [PATCH] chistedit: ensure a locale is set

On Fri, 15 Feb 2019 14:59:37 -0500, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1550260567 18000 > # Fri Feb 15 14:56:07 2019 -0500 > # Node ID 611f94479e62c720f7f90f3a58137e97aa600fcb > # Parent a22321f2b1ee18ea09a70fee9e524d2f0298 >

mercurial@41718: 2 new changesets

2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/9060af281be7 changeset: 41717:9060af281be7 user:Georges Racinet date:Mon Feb 04 19:46:57 2019 +0100 summary: rust: itering less on MissingAncestors.bases for max()

Re: rust hg status

On Tue, Feb 19, 2019 at 10:46 AM Augie Fackler wrote: > On Fri, Feb 15, 2019 at 02:39:44PM -0500, Valentin Gatien-Baron wrote: > > Hello, > > > > I wrote a fraction of hg status in rust, just the minimum needed to > > compare current revision and working copy with few of the flags and > > config

D5966: test: stabilize test-run-tests.t output

lothiraldan added inline comments. INLINE COMMENTS > durin42 wrote in test-run-tests.t:1177 > I don't feel strongly, let's just make it permissive so the test passes on > both fast and slow systems. I think it's the case, the first part of the regex `\d+` will match any amount of seconds and

D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output

lothiraldan added a comment. In https://phab.mercurial-scm.org/D5960#87357, @durin42 wrote: > In https://phab.mercurial-scm.org/D5960#87330, @lothiraldan wrote: > > > In https://phab.mercurial-scm.org/D5960#87251, @durin42 wrote: > > > > > Huh. That's strictly a bug, as

Re: [PATCH RFC] cmdtest: add a new command that checks revset matching

On 19/02/2019 13:52, Pulkit Goyal wrote: > > > On Fri, Feb 15, 2019 at 6:11 PM Raphaël Gomès > mailto:raphael.go...@octobus.net>> wrote: > > # HG changeset patch > # User Raphaël Gomès mailto:rgo...@octobus.net>> > # Date 1550068454 -3600 > #      Wed Feb 13 15:34:14 2019 +0100 >

D5792: uncommit: added interactive mode(issue6062)

taapas1128 added a comment. @durin42 please review this whenever you are free. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5792 To: taapas1128, #hg-reviewers, durin42 Cc: durin42, pulkit, lothiraldan, mercurial-devel

D5983: debugpathcopies: sort output so it's deterministic

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5983 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git

Re: rust hg status

On Fri, Feb 15, 2019 at 02:39:44PM -0500, Valentin Gatien-Baron wrote: > Hello, > > I wrote a fraction of hg status in rust, just the minimum needed to > compare current revision and working copy with few of the flags and > config settings supported. As you can imagine, the goal was better >

Re: D5514: test: change test's diff generation to use mdiff for nicer output

Apologies, I didn't run the tests after the latest addition.  On Tue, Feb 19, 2019, 20:39 durin42 (Augie Fackler) < phabrica...@mercurial-scm.org wrote: > durin42 added a comment. > > > Even with my in-flight fixes, I can't get this to use the > non-unified_diff codepath. Can you test again?

Re: [PATCH 7 of 7] tests: bulk changes to avoid whitespace errors of check-code.py

On Mon, Feb 18, 2019 at 02:19:30AM +0900, FUJIWARA Katsunori wrote: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1550417245 -32400 > # Mon Feb 18 00:27:25 2019 +0900 > # Node ID 2f6a1d093864a07557a439d6c8fa0f583bc6a4ce > # Parent 4f1714df74136e8b46a35810e2e46a7d25b243a8 > #

Re: [PATCH] chistedit: ensure a locale is set

> On Feb 19, 2019, at 10:33, Jordi Gutiérrez Hermoso wrote: > > On Tue, 2019-02-19 at 10:29 -0500, Augie Fackler wrote: >> On Fri, Feb 15, 2019 at 02:59:37PM -0500, Jordi Gutiérrez Hermoso wrote: >>> # HG changeset patch >>> # User Jordi Gutiérrez Hermoso >>> # Date 1550260567 18000 >>> #

Re: [PATCH] chistedit: ensure a locale is set

On Tue, 2019-02-19 at 10:29 -0500, Augie Fackler wrote: > On Fri, Feb 15, 2019 at 02:59:37PM -0500, Jordi Gutiérrez Hermoso wrote: > > # HG changeset patch > > # User Jordi Gutiérrez Hermoso > > # Date 1550260567 18000 > > # Fri Feb 15 14:56:07 2019 -0500 > > # Node ID

Re: [PATCH 2 of 2] tests: conditionalize msys path mangling in test-bundle.t

On Sat, Feb 16, 2019 at 10:58:50PM -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1550372638 18000 > # Sat Feb 16 22:03:58 2019 -0500 > # Node ID 99ed0ac693fb7c6045ecf69cf17909e8dc48a85a > # Parent f1646b79dafcca63a5681713da6e7b9db5d71afa > tests:

Re: [PATCH] chistedit: ensure a locale is set

On Fri, Feb 15, 2019 at 02:59:37PM -0500, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1550260567 18000 > # Fri Feb 15 14:56:07 2019 -0500 > # Node ID 611f94479e62c720f7f90f3a58137e97aa600fcb > # Parent

Re: Auto-formatting code with black - object now if you have a strong opinion

On Wed, Feb 13, 2019 at 10:33:15AM +0100, Boris FELD wrote: > On 01/12/2018 02:35, Matt Harbison wrote: > > On Fri, 30 Nov 2018 07:25:04 -0500, Boris FELD > > wrote: > > > >> I think using automatic formatting is a great idea and we should move > >> forward with this plan. Black seems a good

rust hg status

Hello, I wrote a fraction of hg status in rust, just the minimum needed to compare current revision and working copy with few of the flags and config settings supported. As you can imagine, the goal was better performance. Before trying to upstream bits of this, I figured I'd check there's

[Bug 6084] New: `hg merge` can loose file renames

https://bz.mercurial-scm.org/show_bug.cgi?id=6084 Bug ID: 6084 Summary: `hg merge` can loose file renames Product: Mercurial Version: 4.8 Hardware: PC OS: Linux Status: UNCONFIRMED Severity: feature

D5981: tests: drop a few unnecessary "(glob)"

mharbison72 added a comment. In https://phab.mercurial-scm.org/D5981#87343, @martinvonz wrote: > In https://phab.mercurial-scm.org/D5981#87341, @mharbison72 wrote: > > > The tests run clean with this. > > > > But I'm a bit confused. The test harness has been doing '\' -> '/'

D5966: test: stabilize test-run-tests.t output

durin42 added inline comments. INLINE COMMENTS > lothiraldan wrote in test-run-tests.t:1177 > Yes we could. > > I think the regex was previously `{4,5}` for two reasons: > > - We expected the duration to be less than 10 seconds. > > - The precision of the number was 3 digits or 4 digits after

D5960: test: stabilize test-remotefilelog-bgprefetch.t flaky output

durin42 added a comment. In https://phab.mercurial-scm.org/D5960#87330, @lothiraldan wrote: > In https://phab.mercurial-scm.org/D5960#87251, @durin42 wrote: > > > Huh. That's strictly a bug, as `debugwaitonrepack` should actually be waiting. > > > I've created a ticket to track

D5514: test: change test's diff generation to use mdiff for nicer output

durin42 added a comment. Even with my in-flight fixes, I can't get this to use the non-unified_diff codepath. Can you test again? https://bitbucket.org/snippets/durin42/nejj94 has my in-flight fixes, but you may find it challenging to apply (the test output in the commit message

D5514: test: change test's diff generation to use mdiff for nicer output

durin42 added a comment. I've done some cleanups (dropped an unused import, copyedited the commit message a bit) and should push this soon. Thanks! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5514 To: sangeet259, #hg-reviewers, durin42 Cc: pulkit, durin42,

Re: [PATCH V2] templatekw: add a {negrev} keyword

On Mon, 18 Feb 2019 14:25:42 -0500, Jordi Gutiérrez Hermoso wrote: > On Mon, 2019-02-18 at 22:29 +0900, Yuya Nishihara wrote: > > The word "negative revision" isn't correct, > > Why do you think so? The full phrase is "negative revision number", > isn't it? I don't think {negrev} is a revision

Re: [PATCH] negrev: return empty for wdir() and nullrev

On Mon, 18 Feb 2019 23:48:00 -0500, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1550551420 18000 > # Mon Feb 18 23:43:40 2019 -0500 > # Node ID 379d5bef7d3601d43c5d7d4c4c39d7014bc71208 > # Parent 37b33c34bf4f890857b5e8728febbc82a99368a5 >

Re: [PATCH RFC] cmdtest: add a new command that checks revset matching

On Fri, Feb 15, 2019 at 6:11 PM Raphaël Gomès wrote: > # HG changeset patch > # User Raphaël Gomès > # Date 1550068454 -3600 > # Wed Feb 13 15:34:14 2019 +0100 > # Node ID f850e5c8547df95cd4bcb38b4ade5b5af955 > # Parent 91701785c2c56a3ee395038488758ad2e1865265 > # EXP-Topic cmd-test >

Re: caching pull - stable partitioning of bundle requests

On 15/02/2019 21:16, Pulkit Goyal wrote: > > > On Thu, Oct 4, 2018 at 6:16 PM Boris FELD > wrote: > > The road for moving this in Core is clear, but not short. So far > we have not been able to free the necessary time to do it. Between > the paying-client

Re: [PATCH] test-sqlitestore: run sqlite3 with no init file

Queued, thanks On 19/02/2019 02:15, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1550533461 18000 > # Mon Feb 18 18:44:21 2019 -0500 > # Node ID 3cac2f5ea9314a7d45079e629e0570bebcb3b6bf > # Parent 37b33c34bf4f890857b5e8728febbc82a99368a5 >

D5514: test: change test's diff generation to use mdiff for nicer output

sangeet259 added a comment. Hey @durin42 , take a look at the changes when you get time. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5514 To: sangeet259, #hg-reviewers, durin42 Cc: pulkit, durin42, mercurial-devel