Re: D5961: copies: add test that makes both the merging csets dirty and run w/o error

That's totally fine, reviews it when you have time. Thanks :) On Thu 28 Feb, 2019, 6:08 AM martinvonz (Martin von Zweigbergk) < phabrica...@mercurial-scm.org wrote: > martinvonz added a comment. > > > In https://phab.mercurial-scm.org/D5961#87961, @khanchi97 wrote: > > > @martinvonz I have

D6033: py3: convert return values of inspect.getabsfile() to bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG78027e7bc544: py3: convert return values of inspect.getabsfile() to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6032: py3: add two new passing tests found by buildbot

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc7fc463b8e8e: py3: add two new passing tests found by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6036: absorb: let scmutil.cleanupnodes() take care of setting phase

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb38c7304974f: absorb: let scmutil.cleanupnodes() take care of setting phase (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6035: absorb: use scmutil.cleanupnodes() also when obsmarkers are disabled

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc91321e86071: absorb: use scmutil.cleanupnodes() also when obsmarkers are disabled (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6031: py3: make contrib/debugshell.py work with Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb10bbbe995eb: py3: make contrib/debugshell.py work with Python 3 (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6031?vs=14257=14267#toc REPOSITORY rHG

D6034: absorb: use scmutil.cleanupnodes() so operation gets set

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa008e0af892e: absorb: use scmutil.cleanupnodes() so operation gets set (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5296: store: don't read the whole fncache in memory

yuja added a comment. > - self.entries = set(decodedir(fp.read()).splitlines()) + + self.entries = [] +totalsize = self.vfs.stat('fncache').st_size I don't think `totalsize` has to be stat()ed. We can just loop over until `fp.read()` reaches to EOF. It's unreliable to

Re: D5296: store: don't read the whole fncache in memory

> -self.entries = set(decodedir(fp.read()).splitlines()) > + > +self.entries = [] > +totalsize = self.vfs.stat('fncache').st_size I don't think `totalsize` has to be stat()ed. We can just loop over until `fp.read()` reaches to EOF. It's unreliable to assume that the

Re: [PATCH FOLLOW-UP] test: follow-up on 1c4d6ab2ecb8, stabilize test-remotefilelog-bgprefetch.t

On Mon, 25 Feb 2019 09:08:51 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1551081749 -3600 > # lun. févr. 25 09:02:29 2019 +0100 > # Node ID f611bf911c863d35aced20dfb2546725c911a722 > # Parent 1c1c4ef8b72e39f5ed1c62dc4e31e02e9e08b652 > # EXP-Topic

Re: [PATCH] tests: add more wildcards to test-extdiff.t

On Mon, 25 Feb 2019 21:21:41 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1551147016 18000 > # Mon Feb 25 21:10:16 2019 -0500 > # Node ID 6ec63ae7b61f0bf5e14c208667c484a4f589c991 > # Parent 68bbcc70e27476fbfa3cc6aada1a99ce39c1306b > tests: add more

D6036: absorb: let scmutil.cleanupnodes() take care of setting phase

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6036 AFFECTED FILES hgext/absorb.py CHANGE DETAILS diff --git a/hgext/absorb.py b/hgext/absorb.py

D6035: absorb: use scmutil.cleanupnodes() also when obsmarkers are disabled

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A side-effect of this is the new warning in the test case, but the warning is valid, so I don't think that's a problem. REPOSITORY rHG Mercurial REVISION

D5961: copies: add test that makes both the merging csets dirty and run w/o error

martinvonz added a comment. In https://phab.mercurial-scm.org/D5961#87961, @khanchi97 wrote: > @martinvonz I have moved the tests in `test-copies.t` Thanks. https://phab.mercurial-scm.org/D5963 seems more complicated, so I'll review this series when I can find a larger chunk of

D6034: absorb: use scmutil.cleanupnodes() so operation gets set

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The operation is useful for e.g. `hg obslog` output. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6034 AFFECTED FILES

D6033: py3: convert return values of inspect.getabsfile() to bytes

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's weird that python docs for inspect does not mention getabsfile(). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6033 AFFECTED

D6032: py3: add two new passing tests found by buildbot

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6032 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D6031: py3: make contrib/debugshell.py work with Python 3

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I changed default mercurial installation of my personal laptop to one installed with python 3.7. debugshell is one of the extension which I have enabled and it

D5296: store: don't read the whole fncache in memory

pulkit updated this revision to Diff 14256. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5296?vs=14255=14256 REVISION DETAIL https://phab.mercurial-scm.org/D5296 AFFECTED FILES mercurial/store.py CHANGE DETAILS diff --git a/mercurial/store.py

D5296: store: don't read the whole fncache in memory

pulkit added a comment. In https://phab.mercurial-scm.org/D5296#87890, @indygreg wrote: > I suspect https://phab.mercurial-scm.org/rHG9fca5b056c0a2f673aefa64f7ec7488bd9188d9d made things faster because the code before was using 1 I/O operation for every entry. I would also not be

D5296: store: don't read the whole fncache in memory

pulkit added a comment. In https://phab.mercurial-scm.org/D5296#87892, @yuja wrote: > (resend without the "On ... wrote:" line) > > > Seeing the performance benefit it brings on our repo, I want to try other ways we can do this. Do we like having a conditional which checks the

Re: D5962: copies: add test that makes both the merging csets dirty and fails

@martinvonz updated this one too. On Mon, Feb 25, 2019 at 11:01 PM martinvonz (Martin von Zweigbergk) < phabrica...@mercurial-scm.org> wrote: > martinvonz added inline comments. > > INLINE COMMENTS > > > test-copytrace-heuristics.t:931-980 > > + $ hg graft -r 6 --base c9241b0f2d5b --hidden > >

Re: D5961: copies: add test that makes both the merging csets dirty and run w/o error

@martinvonz I have moved the tests in `test-copies.t` On Mon, Feb 25, 2019 at 10:58 PM martinvonz (Martin von Zweigbergk) < phabrica...@mercurial-scm.org> wrote: > martinvonz added inline comments. > > INLINE COMMENTS > > > test-copytrace-heuristics.t:724-728 > > + $ cat >> $HGRCPATH << EOF > >

D5296: store: don't read the whole fncache in memory

pulkit updated this revision to Diff 14255. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5296?vs=12583=14255 REVISION DETAIL https://phab.mercurial-scm.org/D5296 AFFECTED FILES mercurial/store.py CHANGE

D6030: store: move logic to check for invalid entry in fncache to own function

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This helps separate the original reading logic from the one which finds for an invalid entry. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH 2 of 2 "] storage: introduce a `revlog.reuse-external-delta` config

# HG changeset patch # User Pierre-Yves David # Date 1551267618 -3600 # Wed Feb 27 12:40:18 2019 +0100 # Node ID d1df36a5e877119ca96134b0ee2e886c32f40c38 # Parent ed7aebbee814840433cf40ce02aecde83d6129c1 # EXP-Topic delta-control # Available At https://bitbucket.org/octobus/mercurial-devel/

[PATCH 1 of 2 "] storage: introduce a `revlog.reuse-external-delta-parent` config

# HG changeset patch # User Pierre-Yves David # Date 1551260965 -3600 # Wed Feb 27 10:49:25 2019 +0100 # Node ID ed7aebbee814840433cf40ce02aecde83d6129c1 # Parent 090a41251f093e8b8b97046deeef59f1d060d4e4 # EXP-Topic delta-control # Available At https://bitbucket.org/octobus/mercurial-devel/

D6029: Bug 1477205 - Remove the exception when a node is created after closing the AudioContext. r?padenot

marmoute added a comment. Hi Valentin, It looks like you are not using the right Phabricator instance. This one is dedicated to the Mercurial projet, not Firefox. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6029 To: vmillet, #hg-reviewers Cc: marmoute,

D5299: phabricator: fallback reading arcanist config files

philpep marked 3 inline comments as done. philpep added inline comments. INLINE COMMENTS > mharbison72 wrote in phabricator.py:187 > s/.encoding/.environ/ ? Woops... Thanks for catching this! > mharbison72 wrote in phabricator.py:200 > Should this be using vfs to open, instead of raw open?

D5299: phabricator: fallback reading arcanist config files

philpep updated this revision to Diff 14253. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5299?vs=14175=14253 REVISION DETAIL https://phab.mercurial-scm.org/D5299 AFFECTED FILES hgext/phabricator.py CHANGE DETAILS diff --git

D6029: Bug 1477205 - Remove the exception when a node is created after closing the AudioContext. r?padenot

vmillet created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6029 AFFECTED FILES dom/media/webaudio/AnalyserNode.cpp dom/media/webaudio/AudioBufferSourceNode.cpp

D6028: branchmap: prevent reading the file twice through different iterators

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8ad46ac6728e: branchmap: prevent reading the file twice through different iterators (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6028: branchmap: prevent reading the file twice through different iterators

lothiraldan added subscribers: yuja, lothiraldan. lothiraldan accepted this revision. lothiraldan added a comment. Queued thanks, the test now pass both locally and on gcc112. @yuja nice catch! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6028 To: pulkit,

D5955: watchman: ignore some of watchman errors

lothiraldan added a comment. Gentle ping on this series REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5955 To: lothiraldan, #hg-reviewers Cc: indygreg, mercurial-devel ___ Mercurial-devel mailing list