Re: Stop bugzilla bot from marking issues as "RESOLVED ARCHIVED".

2019-03-01 Thread Anton Shestakov
I think the bot has certain rules that are generally more helpful, such as bumping issues that need to be confirmed or urgent issues. I only know that these rules exist because I've been browsing around the bugzilla or am subscribed to some of such issues. I really think there needs to be more tran

Re: Stop bugzilla bot from marking issues as "RESOLVED ARCHIVED".

2019-03-01 Thread Josef 'Jeff' Sipek
On Thu, Feb 28, 2019 at 21:33:31 -0500, Augie Fackler wrote: > On Wed, Feb 27, 2019 at 03:31:11AM +0530, Faheem Mitha wrote: ... > > practice was a good idea, anyway? > > Without the bot, the bug backlog grows without bound. Nobody actually > checks to see if old bugs are fixed, and eventually the

[Bug 6095] New: `hg amend` on windows can lead to a broken repository

2019-03-01 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6095 Bug ID: 6095 Summary: `hg amend` on windows can lead to a broken repository Product: Mercurial Version: stable branch Hardware: PC OS: Windows Status: UNCONFIRMED

D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)

2019-03-01 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > uncommit.py:162 > +hint = _('requires experimental.uncommitondirtywdir to uncommit') > +if not pats: > +cmdutil.bailifchanged(repo, hint=hint) how about `if not pats or isdirtypath`? REPOSITORY rHG Mercuri

Re: Stop bugzilla bot from marking issues as "RESOLVED ARCHIVED".

2019-03-01 Thread Gregory Szorc
On Fri, Mar 1, 2019 at 3:15 AM Josef 'Jeff' Sipek wrote: > On Thu, Feb 28, 2019 at 21:33:31 -0500, Augie Fackler wrote: > > On Wed, Feb 27, 2019 at 03:31:11AM +0530, Faheem Mitha wrote: > ... > > > practice was a good idea, anyway? > > > > Without the bot, the bug backlog grows without bound. Nob

Re: Sprint 5.0

2019-03-01 Thread Pulkit Goyal
That's sad. Maybe we can start having office hours once a month where we can video chat and discuss ideas, share problems related to hg. That will help in making progress on things which are stuck because of in-person discussion or things which people plan to discuss at sprints. I have some of the

D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)

2019-03-01 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 14281. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5940?vs=14280&id=14281 REVISION DETAIL https://phab.mercurial-scm.org/D5940 AFFECTED FILES hgext/uncommit.py tests/test-uncommit.t CHANGE DETAILS

D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)

2019-03-01 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh marked an inline comment as done. navaneeth.suresh added inline comments. INLINE COMMENTS > pulkit wrote in uncommit.py:162 > how about `if not pats or isdirtypath`? That's sweet. I've tried that earlier and failed to work because I thought bailifchanged couldn't handle dirty P

Re: Stop bugzilla bot from marking issues as "RESOLVED ARCHIVED".

2019-03-01 Thread Augie Fackler
On Fri, Mar 1, 2019 at 1:44 PM Gregory Szorc wrote: > > On Fri, Mar 1, 2019 at 3:15 AM Josef 'Jeff' Sipek > wrote: >> >> On Thu, Feb 28, 2019 at 21:33:31 -0500, Augie Fackler wrote: >> > On Wed, Feb 27, 2019 at 03:31:11AM +0530, Faheem Mitha wrote: >> ... >> > > practice was a good idea, anyway?

D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)

2019-03-01 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. I don't understand the commit message. `experimental.uncommitondirtydir` already works with PATH, doesn't it? I think you mean something like "uncommit: allow dirty working copy with PATH". Did I understand that right? INLINE COMMENTS > test-uncommit.t:421 > + a

D6039: py3: make sure return value of posix.groupname() is bytes

2019-03-01 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6039 AFFECTED FILES mercurial/posix.py CHANGE DETAILS diff --git a/mercurial/posix.py b/mercurial/posi

D6040: py3: port things from chgserver.py

2019-03-01 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I have installed mercurial on my personal laptop using Python 3.7. I also have hg aliased to chg. Before this commit, `hg version` didn't work. After this patch,

D6041: py3: pass a str to getpass.getpass()

2019-03-01 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise I see `password: b''` on the prompt. 1. skip-blame because just prefix REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6

D6042: py3: convert filtername to str if it's None

2019-03-01 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I have not called pycompat.bytestr() and rather converted the value there because I am starting to get concerned about the function call overhead of all this byte

Re: [PATCH 2 of 2 "] storage: introduce a `revlog.reuse-external-delta` config

2019-03-01 Thread Yuya Nishihara
On Wed, 27 Feb 2019 13:26:28 +0100, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1551267618 -3600 > # Wed Feb 27 12:40:18 2019 +0100 > # Node ID d1df36a5e877119ca96134b0ee2e886c32f40c38 > # Parent ed7aebbee814840433cf40ce02aecde83d6129c1 > # EXP-Topic d

Re: [PATCH 1 of 7] tests: remove useless line wrapping in a code fragment embedded in test script

2019-03-01 Thread Yuya Nishihara
On Fri, 01 Mar 2019 03:16:11 +0900, FUJIWARA Katsunori wrote: > # HG changeset patch > # User FUJIWARA Katsunori > # Date 1551376312 -32400 > # Fri Mar 01 02:51:52 2019 +0900 > # Node ID c3bccf551e129e0ed8dd7c3c0b5d06cd4314a42a > # Parent 78027e7bc54426e0b7d5a2c9ba3b428f314ccd1a > # Availabl

Re: D6042: py3: convert filtername to str if it's None

2019-03-01 Thread Yuya Nishihara
> +filtername = repo.filtername > +if filtername is None: > +filtername = 'None' > repo.ui.log('branchcache', 'updated %s branch cache in %.4f > seconds\n', > -repo.filtername, duration) > +filtername, duration) Perhaps,

D6042: py3: convert filtername to str if it's None

2019-03-01 Thread yuja (Yuya Nishihara)
yuja added a comment. > +filtername = repo.filtername > +if filtername is None: > +filtername = 'None' > > repo.ui.log('branchcache', 'updated %s branch cache in %.4f seconds\n', > > - repo.filtername, duration) +filtername, dura

D6040: py3: port things from chgserver.py

2019-03-01 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbce2356ece68: py3: port things from chgserver.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6040?vs=14283&id=14287 REVIS

D6039: py3: make sure return value of posix.groupname() is bytes

2019-03-01 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfaa04f45b5fe: py3: make sure return value of posix.groupname() is bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6039?v

D6041: py3: pass a str to getpass.getpass()

2019-03-01 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8e364664a999: py3: pass a str to getpass.getpass() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6041?vs=14284&id=14288 REV

D6037: absorb: run cleanupnodes() within transaction also when not using obsmarkers

2019-03-01 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc6a5009ed04a: absorb: run cleanupnodes() within transaction also when not using obsmarkers (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.me

D5940: uncommit: make experimental.uncommitondirtydir to work on PATH (issue5977)

2019-03-01 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh marked 5 inline comments as done. navaneeth.suresh added a comment. In https://phab.mercurial-scm.org/D5940#88065, @martinvonz wrote: > I don't understand the commit message. `experimental.uncommitondirtydir` already works with PATH, doesn't it? I think you mean something

D6038: push: added clear warning message when pushing a closed branch(issue6080)

2019-03-01 Thread mharbison72 (Matt Harbison)
mharbison72 added inline comments. INLINE COMMENTS > test-push-warn.t:235 >searching for changes > - abort: push creates new remote branches: c! > + abort: push creates new remote branches:c(closed)! >(use 'hg push --new-branch' to create new remote branches) Minor nit, but it looks li

D6038: push: added clear warning message when pushing a closed branch(issue6080)

2019-03-01 Thread taapas1128 (Taapas Agrawal)
taapas1128 updated this revision to Diff 14290. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6038?vs=14276&id=14290 REVISION DETAIL https://phab.mercurial-scm.org/D6038 AFFECTED FILES mercurial/discovery.py tests/test-push-warn.t tests/test-tree

D6038: push: added clear warning message when pushing a closed branch(issue6080)

2019-03-01 Thread taapas1128 (Taapas Agrawal)
taapas1128 added a comment. @mharbison72 done. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6038 To: taapas1128, #hg-reviewers Cc: mharbison72, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercuri