D6335: copies: make "limit" argument to _tracefile() mandatory

2019-05-02 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We always pass a limit. I think the fact that it was optional was also the reason we checked ">=limit" before we used it. So now we can remove that condition

Re: [PATCH] histedit: Show file names in multiple line format

2019-05-02 Thread Jordi Gutiérrez Hermoso
On Thu, 2019-05-02 at 16:51 -0700, Martin von Zweigbergk wrote: > I've queued these mostly bases on Jordi's review. Thanks to both of you! Wait wait, I had stylistic complaints, but I couldn't get to them! Ah, well, I'll submit follow-ups. These patches are definite improvements. _

Re: [PATCH] histedit: Show file names in multiple line format

2019-05-02 Thread Martin von Zweigbergk via Mercurial-devel
I've queued these mostly bases on Jordi's review. Thanks to both of you! On Thu, Apr 25, 2019 at 8:44 PM Yu Feng wrote: > diff --git a/hgext/histedit.py b/hgext/histedit.py > --- a/hgext/histedit.py > +++ b/hgext/histedit.py > @@ -1227,6 +1227,13 @@ def addln(win, y, x, line, color=None): >

Re: [PATCH V4] repoview: introduce a `experimental.extra-filter-revs` config

2019-05-02 Thread Martin von Zweigbergk via Mercurial-devel
Queued. On Tue, Apr 23, 2019 at 11:34 PM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > Gentle ping on that patch. All the feedback from the previous round > should have been applied. > > On 4/17/19 4:37 PM, Pierre-Yves David wrote: > > diff --git a/mercurial/configitems.py b/mercur

Re: [PATCH 2 of 3] hgtagsfnodescache: inherit fnode from parent when possible

2019-05-02 Thread Pierre-Yves David
On 5/2/19 11:55 PM, Martin von Zweigbergk wrote: On Thu, May 2, 2019 at 2:48 PM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 5/2/19 8:24 PM, Martin von Zweigbergk wrote: > > > On Thu, May 2, 2019 at 9:37 AM Pierre-Yves David > mailto:pierre

Re: [PATCH 2 of 3] hgtagsfnodescache: inherit fnode from parent when possible

2019-05-02 Thread Martin von Zweigbergk via Mercurial-devel
On Thu, May 2, 2019 at 3:05 PM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 5/2/19 11:55 PM, Martin von Zweigbergk wrote: > > > > > > On Thu, May 2, 2019 at 2:48 PM Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > > > > > On 5/2/19 8:24

Re: [PATCH 2 of 3] hgtagsfnodescache: inherit fnode from parent when possible

2019-05-02 Thread Martin von Zweigbergk via Mercurial-devel
On Thu, May 2, 2019 at 2:48 PM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 5/2/19 8:24 PM, Martin von Zweigbergk wrote: > > > > > > On Thu, May 2, 2019 at 9:37 AM Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > # HG changeset patch > >

Re: [PATCH 14 of 14 evolve-ext] docs: drop references to the old temporary commit that was created with amend

2019-05-02 Thread Pierre-Yves David
All these but patch 9 have been pushed, many thanks for updating this. (see comment on patch 9) On 4/28/19 6:29 AM, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1556425288 14400 # Sun Apr 28 00:21:28 2019 -0400 # Node ID 5c913f7081b36f71c3678f3686f89d5365e7bdeb #

Re: [PATCH 2 of 3] hgtagsfnodescache: inherit fnode from parent when possible

2019-05-02 Thread Pierre-Yves David
On 5/2/19 8:24 PM, Martin von Zweigbergk wrote: On Thu, May 2, 2019 at 9:37 AM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierre-Yves David mailto:pierre-yves.da...@octobus.net>> # Date 1552263020 -3600 #      Mon Mar 11 01

Re: [PATCH 2 of 3] hgtagsfnodescache: inherit fnode from parent when possible

2019-05-02 Thread Martin von Zweigbergk via Mercurial-devel
On Thu, May 2, 2019 at 9:37 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1552263020 -3600 > # Mon Mar 11 01:10:20 2019 +0100 > # Node ID eac353183daaef0a503da8cd72b8df43f54d7fb8 > # Parent a753bc019c1ad7c5661a050adc

D6334: remotefilelog: move most setup from onetimesetup() to uisetup()

2019-05-02 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY All the wrappers moved in this patch check if remotefilelog is enabled before they change behavior, so it's safe to always wrap. REPOSITORY rHG Mer

D6333: remotefilelog: move most functions in onetimeclientsetup() to top level

2019-05-02 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is how most extensions seem to do it. It makes sure we don't accidentally depend on the captured ui instance. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH 2 of 3] hgtagsfnodescache: inherit fnode from parent when possible

2019-05-02 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1552263020 -3600 # Mon Mar 11 01:10:20 2019 +0100 # Node ID eac353183daaef0a503da8cd72b8df43f54d7fb8 # Parent a753bc019c1ad7c5661a050adce49e4c3cd5a786 # EXP-Topic fnodecache # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 3 of 3] updatecaches: also warm hgtagsfnodescache

2019-05-02 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1552268118 -3600 # Mon Mar 11 02:35:18 2019 +0100 # Node ID 8e2bc8ccf591f453d417fc1bd5c77a18510b954d # Parent eac353183daaef0a503da8cd72b8df43f54d7fb8 # EXP-Topic fnodecache # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 1 of 3] hgtagsfnodescache: handle nullid lookup

2019-05-02 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1552262978 -3600 # Mon Mar 11 01:09:38 2019 +0100 # Node ID a753bc019c1ad7c5661a050adce49e4c3cd5a786 # Parent bed4c308fc56e29181602c5c004483d5a878ed26 # EXP-Topic fnodecache # Available At https://bitbucket.org/octobus/mercurial-devel/ #

Re: Mercurial 5.0 rc + Python 3.7 + Apache 2.4.39

2019-05-02 Thread Pulkit Goyal
On Thu, May 2, 2019 at 7:14 AM Edgar Anjensen Landazuri Sánchez < edgar.landazuri.sanc...@gmail.com> wrote: > Hello, > I've been trying to setup a mercurial repository for a couple of days now. > After struggling with the different versions that are needed I ended up > going after the state of the

Re: Mercurial 5.0 rc + Python 3.7 + Apache 2.4.39

2019-05-02 Thread Pierre-Yves David
Mercurial does not have official python 3 support yet. (version 5.0 is the first one with "beta" support). If you are trying to setup this for production use python 2.7. If you are indeed trying to test the python3 beta, please file bug at https://bz.mercurial-scm.org/ Thanks! On 5/1/19 2:1

D6332: releasenotes: add a file in which to record release notes

2019-05-02 Thread marmoute (Pierre-Yves David)
marmoute added a comment. +1 on the idea of an explcit editable file instead of immutable static entry in the changelog. I would use it. The main issue emerging from this kind of approach are the conflict in that file. There are multiple way to smooth that out. REPOSITORY rHG Mercuri

Re: [PATCH 09 of 14 evolve-ext] docs: change `evolution` references to `stabilization`

2019-05-02 Thread Pierre-Yves David
On 5/2/19 2:47 AM, Matt Harbison wrote: On Sun, 28 Apr 2019 00:28:56 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1556417010 14400 #  Sat Apr 27 22:03:30 2019 -0400 # Node ID 65670dda8ace58b000da738d3e053197c436bf7a # Parent  8edc865f6a9f625b66092015c2d1c1

D6332: releasenotes: add a file in which to record release notes

2019-05-02 Thread Sietse (Sietse Brouwer)
Sietse added a comment. I think this is a fine idea -- it is more robust, because it does not depend on getting the commit syntax right, but on knowing the right place. It also means commit messages (for developers, one per commit) don't have to do double duty as release notes (for users, on