martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We already handle the ping-pong rename case in the filtering step, so
there's very little point in doing it in the chaining loop (ping-pong
renames are very r
martinvonz updated this revision to Diff 15018.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6306?vs=14900&id=15018
REVISION DETAIL
https://phab.mercurial-scm.org/D6306
AFFECTED FILES
mercurial/changelog.py
mercurial/localrepo.py
tests/test-copi
martinvonz updated this revision to Diff 15017.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6332?vs=14985&id=15017
REVISION DETAIL
https://phab.mercurial-scm.org/D6332
AFFECTED FILES
relnotes/next
CHANGE DETAILS
diff --git a/relnotes/next b/relno
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd811f17090a3: repair: reword comments that I noticed while
working on source formatting (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercuria
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf9cdd732cb58: minirst: support subsubsubsubsections (header
level 5) with marker (authored by Sietse, committed by
).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa42cc325b682: gendoc: nest command headers under category
headers (authored by Sietse, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6329?vs=1500
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG037a97d62625: gendoc: guarantee that all commands were
processed (authored by Sietse, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6327?vs=14999
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0786b791b3b5: gendoc: indent loop to make next patch more
legible (authored by Sietse, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6325?vs=1495
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3816e361e3d8: gendoc: group commands by category in man
page and HTML help (authored by Sietse, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D6326?vs=14998&id=15012#toc
REPOS
martinvonz added inline comments.
INLINE COMMENTS
> gendoc.py:207
> +if not categorycmds:
> +continue # Skip empty categories
> +# Print a section header for the category.
`test-check-code.t` didn't like this ("gratuitous whitespace after Python
keyword"), so I move
martinvonz added a comment.
Queuing this, thanks.
INLINE COMMENTS
> Sietse wrote in gendoc.py:201
> Could somebody confirm the new `hg.1` man page and `hg.1.html` output look
> okay? I've linked them (and the originals) in the comment at the top of this
> page above. They are extremely user
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I recently learned of a Firefox/Chrome feature that allows
wiresharking otherwise-TLS'd network connections. Gloriously, there's
a pypi module that enables this
durin42 created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This applied black to the 20 smallest files in mercurial/:
ls -S1 mercurial/*.py | tail -n20 | xargs black
Note that a few files failed to form
durin42 added a comment.
PTAL
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6339
To: durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://ww
durin42 updated this revision to Diff 15008.
durin42 marked an inline comment as done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6339?vs=15002&id=15008
REVISION DETAIL
https://phab.mercurial-scm.org/D6339
AFFECTED FILES
mercurial/repair.py
CHANG
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe10b8058da84: repair: reword comment about bookmarks logic
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6340?vs=15003&id=1
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG970aaf38c3fc: contrib: have byteify-strings explode if run
in Python 2 (authored by durin42, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D6341?vs=15004&id=15007#toc
REPOSITO
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd26bfbf419f9: monotone: fix a bogus _() wrapper that was
caught when formatting code (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-s
> On May 4, 2019, at 16:35, Pierre-Yves David
> wrote:
>
>
>
> On 5/4/19 6:29 PM, Martin von Zweigbergk via Mercurial-devel wrote:
>> I feel like this feature goes against the idea of orthogonal commands and
>> that it could easily be achieved with a hook. Is it a common enough request
>>
On 5/4/19 6:29 PM, Martin von Zweigbergk via Mercurial-devel wrote:
I feel like this feature goes against the idea of orthogonal commands
and that it could easily be achieved with a hook. Is it a common enough
request to have it in core? OTOH, it's a very simple feature, so I'm not
too concer
I feel like this feature goes against the idea of orthogonal commands and
that it could easily be achieved with a hook. Is it a common enough request
to have it in core? OTOH, it's a very simple feature, so I'm not too
concerned with having it in core.
*From: *Augie Fackler
*Date: *Sat, May 4, 20
martinvonz added inline comments.
INLINE COMMENTS
> Sietse wrote in gendoc.py:200
> It doesn't error out, I checked before uploading. Debug commands have
> CATEGORY_NONE; see also below.
>
> The purpose of this patch is to give confidence that no commands got 'lost'
> as we moved from 'process
Sietse added inline comments.
INLINE COMMENTS
> gendoc.py:201
> + subsectionfunc: minirst function to format command headers
> +"""
> h = {}
Could somebody confirm the new `hg.1` man page and `hg.1.html` output look
okay? I've linked them (and the originals) in the comment at the
martinvonz added inline comments.
INLINE COMMENTS
> repair.py:421
> +if 'treemanifest' in repo.requirements:
> +# otherwise This logic is safe if treemanifest isn't in
> +# use, but it's also not required so we skip it if it's
Nit: use same message as above
REPOS
Sietse marked 2 inline comments as done.
Sietse added inline comments.
INLINE COMMENTS
> martinvonz wrote in gendoc.py:200
> I think a previous version of this patch ignored uncategorized debug
> commands. Will this version error out?
It doesn't error out, I checked before uploading. Debug comm
Sietse marked 2 inline comments as done.
Sietse added inline comments.
INLINE COMMENTS
> martinvonz wrote in gendoc.py:188
> Interesting examples.
>
> I found the `commithook()` quite confusing. I've sent
> https://phab.mercurial-scm.org/D6336 to remove the arguments from it.
>
> As you said,
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6341
AFFECTED FILES
contrib/byteify-strings.py
CHANGE DETAILS
diff --git a/contrib/byteify-strings.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Again, this will help auto-formatting shortly.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6340
AFFECTED FILES
mercurial/repair
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I think this is clearer, and one will also keep us from upsetting
check-code when other formatting cleanups happen.
REPOSITORY
rHG Mercurial
REVISION DETAIL
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There was a spurious space after `debug`, which hid the _() inside
ui.debug() from check-code. Sigh.
While here, wrap things more concisely.
REPOSITORY
rHG
Sietse updated this revision to Diff 15000.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6329?vs=14991&id=15000
REVISION DETAIL
https://phab.mercurial-scm.org/D6329
AFFECTED FILES
doc/gendoc.py
CHANGE DETAILS
diff --git a/doc/gendoc.py b/doc/gendo
Sietse updated this revision to Diff 14999.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6327?vs=14990&id=14999
REVISION DETAIL
https://phab.mercurial-scm.org/D6327
AFFECTED FILES
doc/gendoc.py
CHANGE DETAILS
diff --git a/doc/gendoc.py b/doc/gendo
Sietse updated this revision to Diff 14998.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6326?vs=14989&id=14998
REVISION DETAIL
https://phab.mercurial-scm.org/D6326
AFFECTED FILES
doc/gendoc.py
CHANGE DETAILS
diff --git a/doc/gendoc.py b/doc/gendo
> On May 4, 2019, at 00:46, Anton Shestakov wrote:
>
> # HG changeset patch
> # User Anton Shestakov
> # Date 1556863876 -28800
> # Fri May 03 14:11:16 2019 +0800
> # Node ID f95f3e733b24730f8ad5874150c2eefb9123a482
> # Parent 49d7c0579df397ff05941d09ce97967e6ca9d53e
> # EXP-Topic post-c
> On May 4, 2019, at 01:26, Matt Harbison wrote:
>
> # HG changeset patch
> # User Matt Harbison
> # Date 1556947002 14400
> # Sat May 04 01:16:42 2019 -0400
> # Node ID e83214915906f6929faae4e67eacd698298aec19
> # Parent c74226916c8c86330886c82a68874a581f0ce1b0
> lfs: add a TODO file
q
35 matches
Mail list logo