Re: [PATCH hglib] tests: handle the removal of `obsolete._enabled` in Mercurial

2019-05-21 Thread Matt Harbison
On Mon, 20 May 2019 11:42:49 -0400, Augie Fackler wrote: On Tue, May 07, 2019 at 10:21:28PM -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1557281819 14400 # Tue May 07 22:16:59 2019 -0400 # Node ID 1febca34c800a64cc2c886d24920b936674cbd1c # Parent

[PATCH hglib V2] tests: handle the removal of `obsolete._enabled` in Mercurial

2019-05-21 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1557281819 14400 # Tue May 07 22:16:59 2019 -0400 # Node ID 19b12f3e7cc79566c4bb7d1c8df4a6d50d88133d # Parent 33b512aa8dba0cbe523188fbb62d30ae2125a236 tests: handle the removal of `obsolete._enabled` in Mercurial I'm not sure why we can't

D6416: changelog: optionally store added and removed files in changeset extras

2019-05-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As mentioned in an earlier patch, copies._chain() is used a lot in the changeset-centric version of pathcopies(). It is expensive because it needs to look at

D6422: copies: avoid calling matcher if matcher.always()

2019-05-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When storing copy information in the changesets, this patch speeds up hg debugpathcopies FENNEC_58_0_2_BUILD1 FIREFOX_59_0b8_BUILD2 from 5.9s to

D6420: copies: don't filter out copy targets created on other side of merge commit

2019-05-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If file X is copied to Y on one side of merge and the other side creates Y (no copy), we would not mark that as copy. In the changeset-centric pathcopies()

D6421: copies: avoid unnecessary copying of copy dict

2019-05-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When storing copy information in the changesets, this patch speeds up hg debugpathcopies FENNEC_58_0_2_BUILD1 FIREFOX_59_0b8_BUILD2 from 11s to 5.9s.

D6417: context: get filesadded() and filesremoved() from changeset if configured

2019-05-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This adds the read side for getting the sets of added and removed files from the changeset extras. I timed this command on the hg repo: hg log -T

D6419: copies: do full filtering at end of _changesetforwardcopies()

2019-05-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As mentioned earlier, pathcopies() is very slow when copies are stored in the changeset. Most of the cost comes from calling _chain() for every changeset,

D6418: copies: split up _chain() in naive chaining and filtering steps

2019-05-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The function now has two clearly defined steps. The first step is the actual chaining. This step is very cheap. The second step is filtering out invalid

D6415: rust-python3: useless python2 specific import

2019-05-21 Thread gracinet (Georges Racinet)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5b795108dd17: rust-python3: useless python2 specific import (authored by gracinet, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6397: rust-python3: compatibility fix for incoming PyLong

2019-05-21 Thread gracinet (Georges Racinet)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG48df8a06c8bb: rust-python3: compatibility fix for incoming PyLong (authored by gracinet, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6412: py3: add one new passing test found by buildbot

2019-05-21 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9166935da31f: py3: add one new passing test found by buildbot (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH] discovery: slowly increase sampling size

2019-05-21 Thread Pierre-Yves David
On 5/21/19 10:40 PM, Martin von Zweigbergk wrote: On Tue, May 21, 2019 at 1:24 PM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 5/21/19 10:00 PM, Martin von Zweigbergk wrote: > > > On Tue, May 21, 2019 at 11:10 AM Martin von Zweigbergk >

D2647: setdiscovery: make progress on most connected groups each roundtrip

2019-05-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 15210. martinvonz edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2647?vs=15208=15210 REVISION DETAIL https://phab.mercurial-scm.org/D2647 AFFECTED FILES

D2647: setdiscovery: make progress on most connected groups each roundtrip

2019-05-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2647#93256, @marmoute wrote: > I feel like I am missing something. Your commit message seems to be talking using at least as many item in the sameple than there is independant connected set. However your code seems to use

[Bug 6144] New: lots of test timeouts reported as errors

2019-05-21 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6144 Bug ID: 6144 Summary: lots of test timeouts reported as errors Product: Mercurial Version: 5.0 Hardware: All OS: NetBSD Status: UNCONFIRMED Severity: bug

[Bug 6143] New: test-logtoprocess failure

2019-05-21 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6143 Bug ID: 6143 Summary: test-logtoprocess failure Product: Mercurial Version: 5.0 Hardware: All OS: NetBSD Status: UNCONFIRMED Severity: bug

Re: [PATCH] discovery: slowly increase sampling size

2019-05-21 Thread Martin von Zweigbergk via Mercurial-devel
On Tue, May 21, 2019 at 1:24 PM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 5/21/19 10:00 PM, Martin von Zweigbergk wrote: > > > > > > On Tue, May 21, 2019 at 11:10 AM Martin von Zweigbergk > > mailto:martinv...@google.com>> wrote: > > > > > > > > On Tue, May 21, 2019

Re: [PATCH] discovery: slowly increase sampling size

2019-05-21 Thread Pierre-Yves David
On 5/21/19 10:00 PM, Martin von Zweigbergk wrote: On Tue, May 21, 2019 at 11:10 AM Martin von Zweigbergk mailto:martinv...@google.com>> wrote: On Tue, May 21, 2019 at 10:09 AM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: On 5/21/19 6:05 PM, Martin

D2647: setdiscovery: make progress on most connected groups each roundtrip

2019-05-21 Thread marmoute (Pierre-Yves David)
marmoute added a comment. I feel like I am missing something. Your commit message seems to be talking using at least as many item in the sameple than there is independant connected set. However your code seems to use "heads(undecided)" that is a quite different. Using independant connected

Re: [PATCH] discovery: slowly increase sampling size

2019-05-21 Thread Martin von Zweigbergk via Mercurial-devel
On Tue, May 21, 2019 at 11:10 AM Martin von Zweigbergk < martinv...@google.com> wrote: > > > On Tue, May 21, 2019 at 10:09 AM Pierre-Yves David < > pierre-yves.da...@ens-lyon.org> wrote: > >> >> >> On 5/21/19 6:05 PM, Martin von Zweigbergk wrote: >> > >> > >> > On Tue, May 21, 2019 at 4:22 AM

Re: [PATCH] discovery: slowly increase sampling size

2019-05-21 Thread Martin von Zweigbergk via Mercurial-devel
On Tue, May 21, 2019 at 10:09 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > > > On 5/21/19 6:05 PM, Martin von Zweigbergk wrote: > > > > > > On Tue, May 21, 2019 at 4:22 AM Pierre-Yves David > > mailto:pierre-yves.da...@ens-lyon.org>> > > > wrote: > > > > # HG changeset

D6397: rust-python3: compatibility fix for incoming PyLong

2019-05-21 Thread gracinet (Georges Racinet)
gracinet added a comment. https://phab.mercurial-scm.org/D6415 is also necessary to actually build with python3 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6397 To: gracinet, #hg-reviewers Cc: yuja, durin42, kevincox, mercurial-devel

D2647: setdiscovery: make progress on each connected group each roundtrip

2019-05-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 15208. martinvonz edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2647?vs=14801=15208 REVISION DETAIL https://phab.mercurial-scm.org/D2647 AFFECTED FILES

D6415: rust-python3: useless python2 specific import

2019-05-21 Thread gracinet (Georges Racinet)
gracinet created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This python27_sys import prevents building with python3, it had been previously removed in

D6397: rust-python3: compatibility fix for incoming PyLong

2019-05-21 Thread gracinet (Georges Racinet)
gracinet added a comment. @yuja yes indeed, just resubmitted with `as_object()`, thanks Actually the first variant I tried was with it but I must have botched it, because it didn't compile. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6397 To: gracinet,

D6397: rust-python3: compatibility fix for incoming PyLong

2019-05-21 Thread gracinet (Georges Racinet)
gracinet updated this revision to Diff 15207. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6397?vs=15164=15207 REVISION DETAIL https://phab.mercurial-scm.org/D6397 AFFECTED FILES rust/hg-cpython/src/dirstate.rs CHANGE DETAILS diff --git

Re: [PATCH] discovery: slowly increase sampling size

2019-05-21 Thread Pierre-Yves David
On 5/21/19 6:05 PM, Martin von Zweigbergk wrote: On Tue, May 21, 2019 at 4:22 AM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierre-Yves David mailto:pierre-yves.da...@octobus.net>> # Date 1558436902 -7200 #      Tue May 21

Re: [PATCH] discovery: slowly increase sampling size

2019-05-21 Thread Martin von Zweigbergk via Mercurial-devel
On Tue, May 21, 2019 at 4:22 AM Pierre-Yves David < pierre-yves.da...@ens-lyon.org> wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1558436902 -7200 > # Tue May 21 13:08:22 2019 +0200 > # Node ID 123267b121ea268b3bc488c6dde68a8d93ee4f4c > # Parent

[PATCH] discovery: slowly increase sampling size

2019-05-21 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1558436902 -7200 # Tue May 21 13:08:22 2019 +0200 # Node ID 123267b121ea268b3bc488c6dde68a8d93ee4f4c # Parent 86f17fc31aa8a0c26c11db6a532293463ee6428a # EXP-Topic discovery # Available At https://bitbucket.org/octobus/mercurial-devel/ #