D6658: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines

2019-07-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > test-setdiscovery.t:988 > + query 5; still undecided: 185, sample size is: 185 (no-py3 !) > + query 5; still undecided: 187, sample size is: 185 (py3 !) >5 total queries in *.s (glob) Fixing this in flight to be 187 in both places :)

mercurial@42628: 3 new changesets

2019-07-21 Thread Mercurial Commits
3 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/944604118c0f changeset: 42626:944604118c0f user:Matt Harbison date:Sat Jul 20 22:18:22 2019 -0400 summary: tests: glob over some timing numbers in test-shelve.t https://www.mercurial-scm.org/repo/hg/re

D6665: continue: added support for graft

2019-07-21 Thread taapas1128 (Taapas Agrawal)
taapas1128 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch creates `cmdutil.continuegraft()` function which contains the logic to resume graft when called directly. This function is then registered as `cont

D6659: graft: split graft code into seperate functions

2019-07-21 Thread taapas1128 (Taapas Agrawal)
taapas1128 edited the summary of this revision. taapas1128 retitled this revision from "graft: split graft code to avoid duplication" to "graft: split graft code into seperate functions". taapas1128 updated this revision to Diff 15987. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https

mercurial@42625: 2 new changesets

2019-07-21 Thread Mercurial Commits
2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/811e502d646d changeset: 42624:811e502d646d user:Augie Fackler date:Thu Jul 18 14:19:41 2019 -0400 summary: cleanup: remove redundant import https://www.mercurial-scm.org/repo/hg/rev/01a503aacc51 change

D6664: transaction: leave unfinished without crashing when not properly released

2019-07-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think the transaction.__del__ is there just as a last resort in case we (or an extension) forgot to release the transaction. When that happens, the repo can

D6660: commands: removed part of description from abort and continue

2019-07-21 Thread taapas1128 (Taapas Agrawal)
Closed by commit rHG55d8329ba509: commands: removed part of description from abort and continue (authored by taapas1128). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6660?vs=15974

D6658: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines

2019-07-21 Thread durin42 (Augie Fackler)
Closed by commit rHGeb27d9eee2cc: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6658?vs

D6663: tests: glob over some timing numbers in test-shelve.t

2019-07-21 Thread mharbison72 (Matt Harbison)
Closed by commit rHG944604118c0f: tests: glob over some timing numbers in test-shelve.t (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6663?vs=15980&id=159

D6658: py3: fix test-setdiscovery.t on Python 3 by conditionalizing two lines

2019-07-21 Thread martinvonz (Martin von Zweigbergk)
This revision is now accepted and ready to land. martinvonz added a comment. martinvonz accepted this revision. Heh, I wrote a patch for this before I saw yours. The problem is that `random.sample()` (and other integer-based functions) changed, see https://bugs.python.org/issue27742. REPOSIT

D6655: continue: added support for graft

2019-07-21 Thread taapas1128 (Taapas Agrawal)
taapas1128 added a comment. @martinvonz No problem, I will update patch D6659 . REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6655/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6655 To: taapas1128, #hg-

D6655: continue: added support for graft

2019-07-21 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Sorry, but since both Yuya and I are uncomfortable with this patch, I'll de-queue it so it doesn't block other patches from getting queued. I think it would be good if you can fold D6659 into this one and then split it up so

[PATCH 6 of 6] rust-filepatterns: unescape comment character property

2019-07-21 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1563687721 -32400 # Sun Jul 21 14:42:01 2019 +0900 # Node ID 6b975c15fd687cfcb60c314ab7f3232d48313775 # Parent aa50f3ab3c8b106c16ac1d60772cd5a1eedb6d0a rust-filepatterns: unescape comment character property There were multiple issues in the

[PATCH 5 of 6] rust-filepatterns: use literal b'#' instead of cast

2019-07-21 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1563681654 -32400 # Sun Jul 21 13:00:54 2019 +0900 # Node ID aa50f3ab3c8b106c16ac1d60772cd5a1eedb6d0a # Parent adb7bc2932816deff985967f42837391c0977b06 rust-filepatterns: use literal b'#' instead of cast diff --git a/rust/hg-core/src/filepat

[PATCH 3 of 6] hgignore: add escape syntax test for glob patterns

2019-07-21 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1563684509 -32400 # Sun Jul 21 13:48:29 2019 +0900 # Node ID aa1e9070fdec903532d9e41e944dedca48cac548 # Parent ffd98e7af307aed4765a0fefd59d5a1a8f49850a hgignore: add escape syntax test for glob patterns The last example, [\#], is what the ru

[PATCH 4 of 6] rust-filepatterns: fix type of warnings tuple to (bytes, bytes)

2019-07-21 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1563680817 -32400 # Sun Jul 21 12:46:57 2019 +0900 # Node ID adb7bc2932816deff985967f42837391c0977b06 # Parent aa1e9070fdec903532d9e41e944dedca48cac548 rust-filepatterns: fix type of warnings tuple to (bytes, bytes) Otherwise warn() in match

[PATCH 1 of 6] hgignore: update \-escape test to reflect actual behavior

2019-07-21 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1563683447 -32400 # Sun Jul 21 13:30:47 2019 +0900 # Node ID 3b48980437122079907807800b5cdc5adfa8a6a6 # Parent 513a97303bbcea4ecc1628486f700d89e6714a48 hgignore: update \-escape test to reflect actual behavior "\\" is not an escape character

[PATCH 2 of 6] hgignore: add a few more weird patterns to test case

2019-07-21 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1563683844 -32400 # Sun Jul 21 13:37:24 2019 +0900 # Node ID ffd98e7af307aed4765a0fefd59d5a1a8f49850a # Parent 3b48980437122079907807800b5cdc5adfa8a6a6 hgignore: add a few more weird patterns to test case diff --git a/tests/test-hgignore.t b