D6726: fix: correctly parse the :metadata subconfig

2019-08-14 Thread hooper (Danny Hooper)
Closed by commit rHGd82e9f7e7440: fix: correctly parse the :metadata subconfig (authored by hooper). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6723: fix: allow tools to use :linerange, but also run if a file is unchanged

2019-08-14 Thread hooper (Danny Hooper)
Closed by commit rHG69b37b7227f2: fix: allow tools to use :linerange, but also run if a file is unchanged (authored by hooper). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6634: rust-dirstate: call rust dirstatemap from Python

2019-08-14 Thread Raphaël Gomès
Closed by commit rHG39674659b3f4: rust-dirstate: call rust dirstatemap from Python (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6633: rust-dirstate: rust-cpython bridge for dirstatemap

2019-08-14 Thread Raphaël Gomès
Closed by commit rHGe0f7ee53107e: rust-dirstate: rust-cpython bridge for dirstatemap (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6632: rust-dirstate: rust implementation of dirstatemap

2019-08-14 Thread Raphaël Gomès
Closed by commit rHG565c143f4377: rust-dirstate: rust implementation of dirstatemap (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6631: rust-cpython: add macro for sharing references

2019-08-14 Thread Raphaël Gomès
Closed by commit rHG826407e1ecba: rust-cpython: add macro for sharing references (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6628: rust-parsers: switch to parse/pack_dirstate to mutate-on-loop

2019-08-14 Thread Raphaël Gomès
Closed by commit rHGc36bdb4e884d: rust-parsers: switch to parse/pack_dirstate to mutate-on-loop (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6629: rust-dirstate: use EntryState enum instead of literals

2019-08-14 Thread Raphaël Gomès
Closed by commit rHG7102ef7dfa31: rust-dirstate: use EntryState enum instead of literals (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6630: rust-docstrings: add missing module docstrings

2019-08-14 Thread Raphaël Gomès
Closed by commit rHG0def0fcbb2fc: rust-docstrings: add missing module docstrings (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6627: rust-parsers: move parser bindings to their own file and Python module

2019-08-14 Thread Raphaël Gomès
Closed by commit rHG83c836e8efcc: rust-parsers: move parser bindings to their own file and Python module (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY

D6690: rust-dirstate: improve API of `DirsMultiset`

2019-08-14 Thread Raphaël Gomès
Closed by commit rHG4f9dff6f4d7e: rust-dirstate: improve API of `DirsMultiset` (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6626: rust-dirstate: create dirstate submodule in hg-cpython

2019-08-14 Thread Raphaël Gomès
Closed by commit rHG85cb54e76d48: rust-dirstate: create dirstate submodule in hg-cpython (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6727: fix: pass line ranges as value instead of callback

2019-08-14 Thread hooper (Danny Hooper)
hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The callback no longer takes any arguments from the inner function, so we might as well call it sooner and pass the value instead. Note the value still needs to

D6726: fix: correctly parse the :metadata subconfig

2019-08-14 Thread hooper (Danny Hooper)
hooper created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's being handled as a string instead of a bool, though the thruthiness of the string makes the feature still essentially work. Added a regression test.

D6427: discovery: new devel.discovery.randomize option

2019-08-14 Thread gracinet (Georges Racinet)
Herald added a subscriber: mjpieters. Closed by commit rHG334c1ea57136: discovery: new devel.discovery.randomize option (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs

D6430: rust-discovery: using from Python code

2019-08-14 Thread gracinet (Georges Racinet)
Closed by commit rHG4d20b1fe8a72: rust-discovery: using from Python code (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D6429: rust-discovery: optimization of add commons/missings for empty arguments

2019-08-14 Thread Phabricator
Closed by commit rHGc5748c6969b9: rust-discovery: optimization of add commons/missings for empty arguments (authored by Georges Racinet on percheron.racinet.fr geor...@racinet.fr). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it

D6426: rust-discovery: optionally don't randomize at all, for tests

2019-08-14 Thread gracinet (Georges Racinet)
Closed by commit rHG4e7bd6180b53: rust-discovery: optionally dont randomize at all, for tests (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6428: rust-discovery: using the children cache in add_missing

2019-08-14 Thread gracinet (Georges Racinet)
Closed by commit rHG8c9a6adec67a: rust-discovery: using the children cache in add_missing (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6424: rust-discovery: takefullsample() core implementation

2019-08-14 Thread gracinet (Georges Racinet)
Closed by commit rHG8041a1b45163: rust-discovery: takefullsample() core implementation (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6423: rust-discovery: core implementation for take_quick_sample()

2019-08-14 Thread gracinet (Georges Racinet)
Closed by commit rHG388622cbc911: rust-discovery: core implementation for take_quick_sample() (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6425: rust-discovery: exposing sampling to python

2019-08-14 Thread gracinet (Georges Racinet)
Closed by commit rHG1c4b5689bef5: rust-discovery: exposing sampling to python (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D6517: rust-discovery: read the index from a repo passed at init

2019-08-14 Thread gracinet (Georges Racinet)
Closed by commit rHGb6f3f704a561: rust-discovery: read the index from a repo passed at init (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6516: rust-discovery: accept the new 'respectsize' init arg

2019-08-14 Thread gracinet (Georges Racinet)
Closed by commit rHG5154701a5413: rust-discovery: accept the new respectsize init arg (authored by gracinet). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D6725: tests: split joint repo/changelog fake into one for each type

2019-08-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm just not comfortable with fakes that get overloaded for multiple types: too often it gets out of hand and becomes difficult to trace. REPOSITORY rHG

D6430: rust-discovery: using from Python code

2019-08-14 Thread durin42 (Augie Fackler)
durin42 added a comment. I'm not thrilled with this - it's a lot of code, and I think there are some simpler options that haven't been explored. For example, clients could use the logexchange infrastructure to prime the sampling process and do a lot better. That said, it seems "fine"

D6517: rust-discovery: read the index from a repo passed at init

2019-08-14 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > test-rust-discovery.py:34 > > +class fakerepo(object): > +def __init__(self, idx): I'd rather we not have this one object that mocks both a repo and a changelog - it _will_ become confusing in the future. Make it two objects. REPOSITORY

D6718: repository: suppress typing errors on functions without arguments

2019-08-14 Thread durin42 (Augie Fackler)
durin42 added a comment. durin42 accepted this revision as: durin42. Seems fine, but probably file a bug against mypy on this. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6718/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6718 To:

D6717: mypy: add a mypy.ini config file

2019-08-14 Thread durin42 (Augie Fackler)
durin42 added a comment. Did you run tests on this patch? IIRC there's a test that'll fail ;) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6717/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6717 To: indygreg, #hg-reviewers Cc: durin42,