indygreg added a comment.
Question: should this checking be performed in `exchange.push` or at the
command layer?
(I'm not sure of the answer.)
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6989/new/
REVISION DETAIL
https://phab.mercurial-scm.
durin42 added inline comments.
INLINE COMMENTS
> navaneeth.suresh wrote in commands.py:5646
> i see. do i need to replace `strip` by `debugstrip` on every occurrence in
> tests? otherwise, i would have to revert the changes in the tests and keep
> the extension as it is.
One or two is fine, yo
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6989
AFFECTED FILES
mercurial/commands.py
mercurial/configitems.py
mercurial/help/config.txt
tes
durin42 updated this revision to Diff 16858.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6734?vs=16714&id=16858
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6734/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6734
AFFECTED FILES
navaneeth.suresh added inline comments.
INLINE COMMENTS
> durin42 wrote in commands.py:5646
> debugstrip please (and put it in debugcommands)
>
> and Gregory points out we need a strip extension that preserves the old
> `strip` name for users that are used to that
i see. do i need to replace `
This revision now requires changes to proceed.
durin42 added inline comments.
durin42 requested changes to this revision.
INLINE COMMENTS
> commands.py:5646
>
> +@command("strip",
> +[
debugstrip please (and put it in debugcommands)
and Gregory points out we need a strip extension that pr
navaneeth.suresh created this revision.
Herald added a reviewer: durin42.
Herald added a reviewer: durin42.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Until now, `strip` was bootstrapped as an extension. This patch adds
`strip`
This revision now requires changes to proceed.
indygreg added a comment.
indygreg requested changes to this revision.
I think this is a useful feature. I've wanted this in automated environment
so the last state from the progress bar is preserved, for example.
But I agree with Augie that
indygreg updated this revision to Diff 16854.
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6922?vs=16853&id=16854
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6922/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6922
AFFECTED FILES
contrib/ci/README.rst
indygreg added inline comments.
INLINE COMMENTS
> durin42 wrote in __init__.py:1
> I'm not sold, honestly: we've already substantially diverged from upstream on
> this, so I think we should just act like we own it for now.
We need to take some upstream Python 3 changes soon. Can we defer this
This revision now requires changes to proceed.
indygreg added a comment.
indygreg requested changes to this revision.
This still needs to not modify `mercurial/__init__.py`.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6972/new/
REVISION DETAIL
htt
indygreg updated this revision to Diff 16853.
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6922?vs=16717&id=16853
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6922/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6922
AFFECTED FILES
contrib/ci/README.rst
Closed by commit rHG808a57a08470: fix: add :enabled sub-config for fixer tools
(authored by hooper).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
REPOSITORY
rHG Mercurial
CHANGES SIN
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-devel.
Closed by commit rHGc5c502bd1f70: automation: add a command to submit to a Try
server (authored by indygreg).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-devel.
Closed by commit rHGf71b3c561b93: automation: improve documentation for
credentials management (authored by indygreg).
This revision was automatically updated to reflect the committed changes.
This revision was not
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-devel.
Closed by commit rHGeddae0ed485d: automation: upgrade various packages
(authored by indygreg).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed;
Herald added a reviewer: hg-reviewers.
Herald added a subscriber: mercurial-devel.
Closed by commit rHGb8df6a470bbb: automation: switch to us-west-2 by default
(authored by indygreg).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it l
7 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/f9d35f01b8b3
changeset: 43044:f9d35f01b8b3
user:Gregory Szorc
date:Mon Sep 30 17:26:41 2019 -0700
summary: setup: build extensions in parallel by default
https://www.mercurial-scm.org/repo/hg/rev/8c4f3
Closed by commit rHG9a3be115fb78: statprof: drop python #! and exec bit we
don't use (authored by durin42).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6985?vs=16841&id=16847
CHA
Closed by commit rHG3b8a4587a456: cvsps: switch a file open to a with statement
(authored by durin42).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6984?vs=16840&id=16846
CHANGES
durin42 updated this revision to Diff 16845.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6972?vs=16843&id=16845
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6972/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6972
AFFECTED FILES
durin42 updated this revision to Diff 16844.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6971?vs=16842&id=16844
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6971/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6971
AFFECTED FILES
durin42 added inline comments.
INLINE COMMENTS
> indygreg wrote in __init__.py:1
> This is 3rd party code and shouldn't be formatted.
I'm not sold, honestly: we've already substantially diverged from upstream on
this, so I think we should just act like we own it for now.
REPOSITORY
rHG Mercu
durin42 added a comment.
Now down to these failures:
+ doc/check-seclevel.py:50:
+ > ui.note('checking "%s"\n' % name)
+ missing _() in ui message (use () to hide false-positives)
+ doc/check-seclevel.py:73:
+ > ui.warn('gap of section level at "%s
durin42 updated this revision to Diff 16843.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6972?vs=16832&id=16843
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6972/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6972
AFFECTED FILES
durin42 updated this revision to Diff 16842.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6971?vs=16831&id=16842
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6971/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6971
AFFECTED FILES
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
For some reason this wasn't flagged until I ran a reformatter on this file.
I'm deeply confused by this, but since we don't execute this drop the support
for it.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
For some reason this only showed up in check-code after running
black. Puzzling.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D698
This revision is now accepted and ready to land.
indygreg added a comment.
indygreg accepted this revision.
I'm going to split this on land so `pyproject.toml` appears in its own
changeset.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6342/new/
REVI
durin42 added a comment.
Current test failures:
--- /usr/local/google/home/augie/hgtest/tests/test-check-code.t
+++ /usr/local/google/home/augie/hgtest/tests/test-check-code.t.err
@@ -27,9 +27,40 @@
Skipping contrib/packaging/hgpackaging/wix.py it has no-che?k-code (glob)
durin42 updated this revision to Diff 16834.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6974?vs=16821&id=16834
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6974/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6974
AFFECTED FILES
durin42 updated this revision to Diff 16833.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6973?vs=16820&id=16833
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6973/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6973
AFFECTED FILES
durin42 edited the summary of this revision.
durin42 updated this revision to Diff 16832.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6972?vs=16819&id=16832
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6972/new/
REVISION DETAIL
https:/
durin42 edited the summary of this revision.
durin42 updated this revision to Diff 16831.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6971?vs=16830&id=16831
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6971/new/
REVISION DETAIL
https:/
On Sat, 05 Oct 2019 12:58:24 +0200, Denis Laxalde wrote:
> # HG changeset patch
> # User Denis Laxalde
> # Date 1570269799 -7200
> # Sat Oct 05 12:03:19 2019 +0200
> # Node ID 819f8fffbdf90119836d867937302def34c71a8a
> # Parent e370f9e4bfad03977309feb121906d6768907701
> templatefuncs: accoun
Poisoning is the way to go in the long run. I haven't really thought
about how much of a pain this could be.
On 10/5/19 5:03 PM, Yuya Nishihara wrote:
On Sun, 22 Sep 2019 15:41:40 +0900, Yuya Nishihara wrote:
# HG changeset patch
# User Yuya Nishihara
# Date 1568674765 -32400
# Tue Sep 1
On Sun, 22 Sep 2019 15:41:39 +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1568470639 -32400
> # Sat Sep 14 23:17:19 2019 +0900
> # Node ID 34a355c69f643f15ff46f4524c75137c08a8de3b
> # Parent e7f643679476b013e86b9a2b75f704d64eec4293
> rust-cpython: move
On Sun, 22 Sep 2019 15:41:40 +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1568674765 -32400
> # Tue Sep 17 07:59:25 2019 +0900
> # Node ID fcaf01804ac8198d52d141d642d5ef7c935360cc
> # Parent 34a355c69f643f15ff46f4524c75137c08a8de3b
> rust-cpython: mark
# HG changeset patch
# User Yuya Nishihara
# Date 1570283901 14400
# Sat Oct 05 09:58:21 2019 -0400
# Node ID d0703e81d88e3e28f39d1f6bc36846be14c593cf
# Parent c348d829d23a0bb240e4a7904b74a88da9f4e71a
rust-cpython: change license of ref_sharing.rs to MIT
Since we plan to upstream this featu
durin42 added a comment.
durin42 planned changes to this revision.
This still causes check-code problems, but it's getting close.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6971/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6971
To: durin
durin42 edited the summary of this revision.
durin42 updated this revision to Diff 16830.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6971?vs=16818&id=16830
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6971/new/
REVISION DETAIL
https:/
durin42 edited the summary of this revision.
durin42 updated this revision to Diff 16829.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6342?vs=16812&id=16829
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6342/new/
REVISION DETAIL
https:/
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was conflicting with black, so dump it.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6979
AFFECTED FILES
contrib/check-code
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6978
AFFECTED FILES
contrib/check-code.py
CHANGE DETAILS
diff --git a/contrib/check-code.py b/contrib
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
black manages this for us, so we don't need to worry about this anymore.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6977
AFFECTE
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Both Python and C code are managed by formatters now, so relax this.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6976
AFFECTED FI
hooper created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This allows distributing opt-in fixer tool configurations in .hgrc
files. This may be useful for adding default configs in core, or for
orgranizations that want t
This revision now requires changes to proceed.
indygreg added a comment.
indygreg requested changes to this revision.
This needs `hgext/fsmonitor/pywatchman` added to the list.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6974/new/
REVISION DETAIL
This revision now requires changes to proceed.
indygreg added a comment.
indygreg requested changes to this revision.
This is good. But it will need rebased once `b""` are removed.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6973/new/
REVISION DETAI
This revision now requires changes to proceed.
indygreg added a comment.
indygreg requested changes to this revision.
Please add `# skip-blame` to the commit message.
INLINE COMMENTS
> __init__.py:1
> # Copyright 2014-present Facebook, Inc.
> # All rights reserved.
Files in this directory
indygreg added a comment.
Please also add `# skip-blame` to the commit message.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6971/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6971
To: durin42, indygreg, martinvonz, #hg-reviewers
Cc: mjpiet
This revision now requires changes to proceed.
indygreg added inline comments.
indygreg requested changes to this revision.
INLINE COMMENTS
> __init__.py:1
> # Copyright 2014-present Facebook, Inc.
> # All rights reserved.
This is 3rd party code and shouldn't be formatted.
REPOSITORY
rHG Me
This revision now requires changes to proceed.
indygreg added a comment.
indygreg requested changes to this revision.
Please add `# skip-blame` to the commit message. And split the addition of
`pyproject.toml` into its own commit so we have annotate info.
REPOSITORY
rHG Mercurial
CHANGES S
Closed by commit rHGa614f26d4897: transaction: re-wrap line to avoid a black
bug (authored by durin42).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6970?vs=16817&id=16823
CHANGES
Closed by commit rHG6e8582ccf76d: discovery: re-wrap expression to avoid a
black bug (authored by durin42).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6969?vs=16816&id=16822
CHA
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It's commented out for now since my patch hasn't landed, but we can
uncomment it when that lands.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercu
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We've rewritten everything, so we no longer require this step.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6973
AFFECTED FILES
durin42 created this revision.
Herald added a reviewer: indygreg.
Herald added subscribers: mercurial-devel, Kwan, mjpieters.
Herald added a reviewer: martinvonz.
Herald added a reviewer: martinvonz.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Done with
python3 contrib/byteify
durin42 created this revision.
Herald added a reviewer: indygreg.
Herald added subscribers: mercurial-devel, Kwan, mjpieters.
Herald added a reviewer: martinvonz.
Herald added a reviewer: martinvonz.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is using my patch to black
(https
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6970
AFFECTED FILES
mercurial/transaction.py
CHANGE DETAILS
diff --git a/mercurial/transaction.py b/m
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6969
AFFECTED FILES
mercurial/discovery.py
CHANGE DETAILS
diff --git a/mercurial/discovery.py b/mercu
navaneeth.suresh updated this revision to Diff 16815.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6738?vs=16808&id=16815
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6738/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6738
AFFEC
navaneeth.suresh updated this revision to Diff 16814.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6737?vs=16807&id=16814
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6737/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6737
AFFEC
navaneeth.suresh edited the summary of this revision.
navaneeth.suresh updated this revision to Diff 16813.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6966?vs=16806&id=16813
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6966/new/
REVISIO
durin42 updated this revision to Diff 16812.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6342?vs=15040&id=16812
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6342/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6342
AFFECTED FILES
pulkit added a comment.
pulkit added subscribers: sheehan, pulkit.
@sheehan this might be of interest to you.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6876/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6876
To: mharbison72, #hg-reviewer
# HG changeset patch
# User Denis Laxalde
# Date 1570269799 -7200
# Sat Oct 05 12:03:19 2019 +0200
# Node ID 819f8fffbdf90119836d867937302def34c71a8a
# Parent e370f9e4bfad03977309feb121906d6768907701
templatefuncs: account for user's diffopts in diff()
diff --git a/mercurial/templatefuncs.p
Thanks for the explanation and merging the fix!
On Thu, 3 Oct 2019, 00:09 Yuya Nishihara, wrote:
> On Wed, 02 Oct 2019 21:35:52 +0200, Floris Bruynooghe wrote:
> > On Tue 01 Oct 2019 at 08:15 +0900, Yuya Nishihara wrote:
> > > On Mon, 30 Sep 2019 21:22:17 +0200, Floris Bruynooghe wrote:
> > >> #
68 matches
Mail list logo
