[Bug 6199] New: i have problem when use hg update

2019-10-08 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6199 Bug ID: 6199 Summary: i have problem when use hg update Product: Mercurial Version: unspecified Hardware: PC OS: Windows Status: UNCONFIRMED Severity: feat

Re: D7026: treemanifest: move out of experimental

2019-10-08 Thread Pierre-Yves David
the storage session is more about small configuration of the storage system without impact on the repository. The `format` section is more appropriate for things that deeply impact the repository format. So this should probably at least lives in the `format` as `format.use-tree-manifest`. Ho

[Bug 6198] New: pyproject.toml breaks test-install.t

2019-10-08 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6198 Bug ID: 6198 Summary: pyproject.toml breaks test-install.t Product: Mercurial Version: default branch Hardware: PC OS: Linux Status: UNCONFIRMED Severity:

Python 3 Transition Plan / Calendar Versioning

2019-10-08 Thread Gregory Szorc
At the Mercurial 5.2 Sprint last weekend, we made a number of decisions regarding Python 3 and version numbers. Our plan is to make Mercurial 5.2 (the next release planned for November 1) stable on Python 3 on all major platforms. This entails Mercurial passing as many tests as a Python 2.7 based

D7028: cleanup: join string literals that are already on one line

2019-10-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7028#103123 , @durin42 wrote: > nit: add a `# skip-blame: ` annotation to help us in the future (maybe check history to look for how it's been annotated in the past) Done. REPOSITORY rHG Mercurial CHANGE

D7028: cleanup: join string literals that are already on one line

2019-10-08 Thread durin42 (Augie Fackler)
durin42 added a comment. nit: add a `# skip-blame: ` annotation to help us in the future (maybe check history to look for how it's been annotated in the past) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7028/new/ REVISION DETAIL https://phab.merc

D7028: cleanup: join string literals that are already on one line

2019-10-08 Thread spectral (Kyle Lippincott)
spectral added a comment. spectral accepted this revision. Some slightly disappointing loss of clarity where we had originally had something like: foo(b'abc\n' b'def') and this became `foo('abc\n' b'def')`, which is now `foo('abc\ndef')`: I liked the newlines ending the st

D7029: py3: delete b'' prefix from safehasattr arguments

2019-10-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7029 AFFECTED FILES hgext/absorb.py hgext/bugzilla.py

D7027: debugcommands: add a few more writenoi18n()

2019-10-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7027 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git a/mercurial/debugcommands

D6943: upgrade: allow for `sidedata` removal

2019-10-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > test-sidedata.t:74-75 > > -Check that we cannot upgrade to sidedata > - > +Check that we can upgrade to sidedata > +- > Looks like this change should be in the pare

D7024: destutil: provide hint on rebase+merge for how to specify destination/rev

2019-10-08 Thread spectral (Kyle Lippincott)
Closed by commit rHGbff942299ca9: destutil: provide hint on rebase+merge for how to specify destination/rev (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D702

D7026: treemanifest: move out of experimental

2019-10-08 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In recent sprint, we discussed that treemanifest should be moved out of experimental. The feature has been used inside Google, Fac

D7024: destutil: provide hint on rebase+merge for how to specify destination/rev

2019-10-08 Thread spectral (Kyle Lippincott)
spectral added a comment. In D7024#103055 , @pulkit wrote: > IIUC, you mean `unambiguous` instead of `ambiguous` in the commit message? Re-reading I am confused. Updated the message, see if this works better? REPOSITORY rHG Mercurial C

mercurial@43110: 25 new changesets

2019-10-08 Thread Mercurial Commits
25 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/bbcbb82e3589 changeset: 43086:bbcbb82e3589 user:Gregory Szorc date:Sun Oct 06 14:51:45 2019 -0400 summary: py3: stop implicitly importing unicode https://www.mercurial-scm.org/repo/hg/rev/66f2cc210a29

D7023: hghave: document format for version feature checks as , no dots

2019-10-08 Thread spectral (Kyle Lippincott)
Closed by commit rHG37af48031d6f: hghave: document format for version feature checks as , no dots (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7

D7023: hghave: document format for version feature checks as , no dots

2019-10-08 Thread spectral (Kyle Lippincott)
spectral edited the summary of this revision. spectral retitled this revision from "tests: fix test-archive to specify feature as py38, not py-38" to "hghave: document format for version feature checks as , no dots". spectral updated this revision to Diff 16974. REPOSITORY rHG Mercurial CHANG

Re: [PATCH 5 of 5] log: populate keywords if specified in custom -Tjson(...) or -Tcbor(...)

2019-10-08 Thread Rodrigo Damazio via Mercurial-devel
Thanks for doing this, it'll be very useful :) On Tue, Oct 8, 2019 at 10:33 AM Augie Fackler wrote: > (+rdamazio because I believe this is of interest) > > > On Oct 6, 2019, at 16:00, Yuya Nishihara wrote: > > > > # HG changeset patch > > # User Yuya Nishihara > > # Date 1570388321 <(15)%20703

D2010: check-commit: allow foo_bar naming in functions

2019-10-08 Thread indygreg (Gregory Szorc)
Closed by commit rHG24a07347aa60: check-commit: allow foo_bar naming in functions (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGE

D7022: infinitepush: mark extension as likely to be deleted

2019-10-08 Thread durin42 (Augie Fackler)
Closed by commit rHGe5d535621ee1: infinitepush: mark extension as likely to be deleted (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7022?vs=16960&id=16972 C

D7000: grep: enable all-files by default (BC)

2019-10-08 Thread khanchi97 (Sushil khanchi)
khanchi97 added a comment. Sure :) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7000/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7000 To: khanchi97, #hg-reviewers Cc: JordiGH, mercurial-devel __

D7023: tests: fix test-archive to specify feature as py38, not py-38

2019-10-08 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Looks like D7016 fixed it. +1 to the docs you have added, if you rebase and resend with the commit message updated, I will be happy to push it. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.or

D6989: push: support config option to require revs be specified when running push

2019-10-08 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Hm, looks like this needs to be rebased on tip of hg-committed because of recent blackening of codebase. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6989/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6989 To: spect

D6989: push: support config option to require revs be specified when running push

2019-10-08 Thread pulkit (Pulkit Goyal)
This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. The current place for the check looks good. Can you follow-up by adding it to `ui.tweakdefaults`? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D698

D7024: destutil: add mechanism to specify ambiguous destination on rebase and merge

2019-10-08 Thread pulkit (Pulkit Goyal)
pulkit added a comment. IIUC, you mean `unambiguous` instead of `ambiguous` in the commit message? Re-reading I am confused. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7024/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7024 To: spectral,

D7025: rewriteutil: add configurable check to disallow obsoleting someone else cset

2019-10-08 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One of the things about obsolete markers (especially prune markers) is that sharing them can lead to cases where you loose your data. The best example is that som

mercurial@43085: 3 new changesets

2019-10-08 Thread Mercurial Commits
3 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/7054fd370430 changeset: 43083:7054fd370430 user:Augie Fackler date:Sun Oct 06 14:13:03 2019 -0700 summary: contrib: add a fork of black (as "grey") that includes my changes https://www.mercurial-scm.or

D7015: py3: finish porting iteritems() to pycompat and remove source transformer

2019-10-08 Thread indygreg (Gregory Szorc)
Closed by commit rHGd783f945a701: py3: finish porting iteritems() to pycompat and remove source transformer (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED

D7014: py3: define and use pycompat.iteritems() for hgext/

2019-10-08 Thread indygreg (Gregory Szorc)
Closed by commit rHG649d3ac37a12: py3: define and use pycompat.iteritems() for hgext/ (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT http

D7013: py3: define and use pycompat.itervalues()

2019-10-08 Thread indygreg (Gregory Szorc)
Closed by commit rHG74802979dd9d: py3: define and use pycompat.itervalues() (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT https://phab.m

D7019: tests: use range() in generate-churning-module.py

2019-10-08 Thread indygreg (Gregory Szorc)
Closed by commit rHG1fcf79e9943a: tests: use range() in generate-churning-module.py (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHAN

D7018: tests: allow warning about file

2019-10-08 Thread indygreg (Gregory Szorc)
Closed by commit rHGf244da1fc4c6: tests: allow warning about file (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPD

D7017: lsprof: remove __main__ functionality

2019-10-08 Thread indygreg (Gregory Szorc)
Closed by commit rHGdc6d866b8cb8: lsprof: remove __main__ functionality (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LA

D7016: tests: use proper Python 3.8 feature

2019-10-08 Thread indygreg (Gregory Szorc)
Closed by commit rHG5e9188f054d9: tests: use proper Python 3.8 feature (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAS

D7012: py3: stop normalizing 2nd argument of *attr() to unicode

2019-10-08 Thread indygreg (Gregory Szorc)
Closed by commit rHGc95b2f40db7c: py3: stop normalizing 2nd argument of *attr() to unicode (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercuria

D7024: destutil: add mechanism to specify ambiguous destination on rebase and merge

2019-10-08 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We've seen some confusion where users specify -t, thinking it means target, and are confused when it says to explicitly specify a revision/destination: they fe

D7023: tests: fix test-archive to specify feature as py38, not py-38

2019-10-08 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7023 AFFECTED FILES tests/hghave.py tests/test-archive.t CHANGE DETAILS diff --git a/tes

Re: [PATCH 5 of 5] log: populate keywords if specified in custom -Tjson(...) or -Tcbor(...)

2019-10-08 Thread Augie Fackler
(+rdamazio because I believe this is of interest) > On Oct 6, 2019, at 16:00, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1570388321 14400 > # Sun Oct 06 14:58:41 2019 -0400 > # Node ID debe9628570ddfd9728f2097eb67ea0febaffd22 > # Parent 7260fcfed7308f1

Re: [PATCH 3 of 5] formatter: parse name of built-in formatter templates in standard way

2019-10-08 Thread Augie Fackler
> On Oct 6, 2019, at 16:00, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1570332035 14400 > # Sat Oct 05 23:20:35 2019 -0400 > # Node ID efda5c5a4fe1a783ad40da15d4e52ccfb09554da > # Parent 79c73a7a10457e10fa370fe43b028ce54ca98bb7 > formatter: parse name

Re: [PATCH 10 of 10] rust-cpython: add safe way to map PyLeakedRef<&T> to PyLeakedRef

2019-10-08 Thread Yuya Nishihara
On Sun, 22 Sep 2019 15:41:47 +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1568553550 -32400 > # Sun Sep 15 22:19:10 2019 +0900 > # Node ID 0d0d926ccd7f34a2125071d6e7e0f86e04026ba6 > # Parent 77d76b966a64f83fb7be893f7fc4090f24d7e83c > rust-cpython: add

Re: [PATCH 2 of 2] import: read X-Mercurial-Node email header to determine nodeid

2019-10-08 Thread Augie Fackler
sure, queued > On Oct 6, 2019, at 07:14, Denis Laxalde wrote: > > # HG changeset patch > # User Denis Laxalde > # Date 1570359979 -7200 > # Sun Oct 06 13:06:19 2019 +0200 > # Node ID bbfd3358c4169aef9837dcd6d72648a16acd56aa > # Parent d0e3c6accb3c176527c8b85e739cf1d30343d96d > import: rea

D7000: grep: enable all-files by default (BC)

2019-10-08 Thread Jordi Gutiérrez Hermoso
JordiGH added a comment. The docstring needs a significant update too. Would you like me to suggest something? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7000/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7000 To: khanchi97, #hg-reviewer

D7000: grep: enable all-files by default (BC)

2019-10-08 Thread Jordi Gutiérrez Hermoso
JordiGH added a comment. The docstring needs an update too. INLINE COMMENTS > commands.py:2742 > > By default, grep prints the most recent revision number for each > file in which it finds a match. To get it to print every revision No longer by default! Or perhaps at all. REPOSI

D7022: infinitepush: mark extension as likely to be deleted

2019-10-08 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY .. bc:: The infinitepush extension is believed to be unused, and will be deleted at the end of 2020 unless users contact mercurial-devel@mercurial-scm

D2010: check-commit: allow foo_bar naming in functions

2019-10-08 Thread marmoute (Pierre-Yves David)
This revision now requires review to proceed. marmoute added a comment. marmoute accepted this revision. Apparently, I was not looking at the right view… REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D2010/new/ REVISION DETAIL https://phab.mercurial-

[PATCH 13 of 13] perf: introduce a `perfdirstatecontains` command

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570523303 14400 # Tue Oct 08 04:28:23 2019 -0400 # Node ID c048894d3616efa28ee45979be12780260a7fed3 # Parent 397c7843d0261382d642b2e02b2685ab9367d6bb # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 12 of 13] perf: introduce a perfdirstateiter command

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570522984 14400 # Tue Oct 08 04:23:04 2019 -0400 # Node ID 397c7843d0261382d642b2e02b2685ab9367d6bb # Parent 3c1b646e3acdf5386b01a010e66bd102dbbb90e4 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 11 of 13] perf: use `setup` function in `perfdirstatewrite`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570515544 14400 # Tue Oct 08 02:19:04 2019 -0400 # Node ID 3c1b646e3acdf5386b01a010e66bd102dbbb90e4 # Parent 1c51d61bbe6899cc5baeb20de5539f922710e5a1 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 07 of 13] perf: use `setup` function in `perfdirstatefoldmap`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570515375 14400 # Tue Oct 08 02:16:15 2019 -0400 # Node ID 701f359a9899d1a8b2cafea2aadc1f667dacd385 # Parent 877921fc4a78077e3f45d08253464930fbfa5ae0 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 10 of 13] perf: document `perfdirstatewrite`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570513774 14400 # Tue Oct 08 01:49:34 2019 -0400 # Node ID 1c51d61bbe6899cc5baeb20de5539f922710e5a1 # Parent c33255b2f828e29c1fb1914f7d5cdd74008a26c5 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 08 of 13] perf: document `perfdirfoldmap`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570513758 14400 # Tue Oct 08 01:49:18 2019 -0400 # Node ID 8a6ad5abbf29c925d1b2610714f9e68df1bbc8e1 # Parent 701f359a9899d1a8b2cafea2aadc1f667dacd385 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 09 of 13] perf: use `setup` function in `perfdirfoldmap`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570515135 14400 # Tue Oct 08 02:12:15 2019 -0400 # Node ID c33255b2f828e29c1fb1914f7d5cdd74008a26c5 # Parent 8a6ad5abbf29c925d1b2610714f9e68df1bbc8e1 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 06 of 13] perf: document `perfdirstatefoldmap`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570513690 14400 # Tue Oct 08 01:48:10 2019 -0400 # Node ID 877921fc4a78077e3f45d08253464930fbfa5ae0 # Parent 13417ac3f81259be90354e190b1e0ff8d6f86314 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 05 of 13] perf: use `setup` function in `perfdirstatedirs`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570514921 14400 # Tue Oct 08 02:08:41 2019 -0400 # Node ID 13417ac3f81259be90354e190b1e0ff8d6f86314 # Parent 902c06177e20872773fb8bab6ca3569412143b08 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 02 of 13] perf: document `perfdirstate`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570513617 14400 # Tue Oct 08 01:46:57 2019 -0400 # Node ID ec08340eaebb19b13d9544616ac232cba7cd4e12 # Parent 8d066f6d8a5716e88812487d7d1c7db2808bb9bb # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 03 of 13] perf: use `setup` function in `perfdirstate`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570514230 14400 # Tue Oct 08 01:57:10 2019 -0400 # Node ID 574a82b6c9e77c1ffd3e69d0649b720945b182c6 # Parent ec08340eaebb19b13d9544616ac232cba7cd4e12 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 04 of 13] perf: document `perfdirstatedirs`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570513655 14400 # Tue Oct 08 01:47:35 2019 -0400 # Node ID 902c06177e20872773fb8bab6ca3569412143b08 # Parent 574a82b6c9e77c1ffd3e69d0649b720945b182c6 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 01 of 13] perf: document `perfstatus`

2019-10-08 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1570511728 14400 # Tue Oct 08 01:15:28 2019 -0400 # Node ID 8d066f6d8a5716e88812487d7d1c7db2808bb9bb # Parent 9002f4a3dde63518d1467f3934a1fe226f3b2297 # EXP-Topic perf-doc # Available At https://bitbucket.org/octobus/mercurial-devel/ #

Re: [PATCH] patchbomb: use procutil.shellquote() instead of shlex to escape email address

2019-10-08 Thread Augie Fackler
> On Oct 1, 2019, at 19:21, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1569969322 -32400 > # Wed Oct 02 07:35:22 2019 +0900 > # Node ID 7caa35ed514b937c9c4dd0b76cdee562f6746d73 > # Parent 03e769278ef31f648ba5c49be719da5b73587607 > patchbomb: use procu

Re: [PATCH 2 of 2 BLACKGNAROCK-V2] formatting: introduce a `test-check-format-black.t` that enforce formatting

2019-10-08 Thread Augie Fackler
queued, thanks for the cleanups. > On Oct 7, 2019, at 14:14, Pierre-Yves David > wrote: > > # HG changeset patch > # User Pierre-Yves David > # Date 1570463578 14400 > # Mon Oct 07 11:52:58 2019 -0400 > # Node ID c5294d305666f3b5de9a001c9327ec8eab97eee5 > # Parent 3c5fc04c5cbc3b146105b0e

D7020: pycompat: implement a shlexquote that properly handles bytes

2019-10-08 Thread yuja (Yuya Nishihara)
yuja added a comment. See https://www.mercurial-scm.org/pipermail/mercurial-devel/2019-October/134352.html REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7020/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7020 To: indygreg, #hg-reviewers Cc:

Re: D7020: pycompat: implement a shlexquote that properly handles bytes

2019-10-08 Thread Yuya Nishihara
See https://www.mercurial-scm.org/pipermail/mercurial-devel/2019-October/134352.html ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D7020: pycompat: implement a shlexquote that properly handles bytes

2019-10-08 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > marmoute wrote in pycompat.py:343 > It might be a silly questions, but why are we going through `latin-1` instead > of `utf-8` or any other crazy encoding ? Because the underlying string is likely raw bytes and `latin-1` will preserve those cod

D6876: phabricator: support automatically obsoleting old revisions of pulled commits

2019-10-08 Thread mharbison72 (Matt Harbison)
mharbison72 added inline comments. INLINE COMMENTS > marmoute wrote in phabricator.py:187 > User A phasend a patch > > - User A phasend a changeset `A` as D1337 > > - User B phabimport D1337 , rebase (as > `A'`) and

D7020: pycompat: implement a shlexquote that properly handles bytes

2019-10-08 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > pycompat.py:343 > +s = shlex.quote(s) > +return s.encode('latin-1') > + It might be a silly questions, but why are we going through `latin-1` instead of `utf-8` or any other crazy encoding ? REPOSITORY rHG Mercurial CHANGES S

D7021: notify: cast hash to bytes

2019-10-08 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute accepted this revision. This looks good to me. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7021/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7021 To: indygreg, #hg-reviewers, marmoute Cc: marmoute, mercu

D2010: check-commit: allow foo_bar naming in functions

2019-10-08 Thread marmoute (Pierre-Yves David)
This revision now requires changes to proceed. marmoute added a comment. marmoute requested changes to this revision. +1 on the idea. A bunch of formatting changes seems to have sneaked in this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D

D6876: phabricator: support automatically obsoleting old revisions of pulled commits

2019-10-08 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > mharbison72 wrote in phabricator.py:187 > It looks like, based on the loop where it's used, it will obsolete //all// > (non public) commits that match. The only way I can think of where that > happens is if I `phabimport` someone else's patches