Re: [PATCH 1 of 5] rust-cpython: put leaked reference in PyLeakedRef

On Sun, Oct 13, 2019 at 8:52 PM Yuya Nishihara wrote: > On Sun, 13 Oct 2019 07:46:14 -0700, Martin von Zweigbergk wrote: > > On Sat, Oct 12, 2019, 01:06 Yuya Nishihara wrote: > > > # HG changeset patch > > > # User Yuya Nishihara > > > # Date 1568552779 -32400 > > > # Sun Sep 15 22:06:19

Re: [PATCH 1 of 8] eol: test-eol-update.t coverage around update --clean using filters ... badly

On Mon, 14 Oct 2019 02:13:35 +0200, Mads Kiilerich wrote: > # HG changeset patch > # User Mads Kiilerich > # Date 1571004565 -7200 > # Mon Oct 14 00:09:25 2019 +0200 > # Node ID 57f88532f7005eeb13cb06418ae3a3b156085adf > # Parent 52781d57313d512efb7150603104bea3ca11d0eb > eol:

Re: [PATCH 2 of 8] localrepo: debug log of filter name when filtering through a function

On Mon, 14 Oct 2019 02:13:36 +0200, Mads Kiilerich wrote: > # HG changeset patch > # User Mads Kiilerich > # Date 1570970400 -7200 > # Sun Oct 13 14:40:00 2019 +0200 > # Node ID 2b91375a812ce3c694efa35a98a109387962 > # Parent 57f88532f7005eeb13cb06418ae3a3b156085adf > localrepo: debug

Re: [PATCH 1 of 2] patchcopies: give up any optimization based on `introrev`

On Sun, 13 Oct 2019 23:02:25 +0200, Pierre-Yves David wrote: > On 10/13/19 12:08 PM, Yuya Nishihara wrote: > > On Fri, 11 Oct 2019 20:00:58 +0200, Pierre-Yves David wrote: > >> On 10/11/19 2:02 PM, Yuya Nishihara wrote: > >>> On Fri, 11 Oct 2019 01:04:12 +0200, Pierre-Yves David wrote: > # HG

[PATCH V2] dirs: remove mutable string optimization at all

# HG changeset patch # User Yuya Nishihara # Date 1570964769 -32400 # Sun Oct 13 20:06:09 2019 +0900 # Node ID dd9f93e8af83be1bfd7082026d28f774917f0593 # Parent feaea7fe888383bcb1d28e69df325e41ef68ece9 dirs: remove mutable string optimization at all As far as I can see, the optimization

Re: [PATCH 1 of 5] rust-cpython: put leaked reference in PyLeakedRef

On Sun, 13 Oct 2019 07:46:14 -0700, Martin von Zweigbergk wrote: > On Sat, Oct 12, 2019, 01:06 Yuya Nishihara wrote: > > # HG changeset patch > > # User Yuya Nishihara > > # Date 1568552779 -32400 > > # Sun Sep 15 22:06:19 2019 +0900 > > # Node ID 458c6598a13caee640294d88af4e93783fc36476 >

Re: [PATCH] dirs: remove mutable string optimization at all

On Sun, 13 Oct 2019 15:33:28 -0400, Matt Harbison wrote: > On Sun, 13 Oct 2019 07:27:32 -0400, Yuya Nishihara wrote: > > > # HG changeset patch > > # User Yuya Nishihara > > # Date 1570964769 -32400 > > # Sun Oct 13 20:06:09 2019 +0900 > > # Node ID 87dfcdb8394e377049b5a337585309ae4c652c7d

[PATCH 8 of 8] eol: don't fallback to use .hgeol from tip (BC)

# HG changeset patch # User Mads Kiilerich # Date 1570925426 -7200 # Sun Oct 13 02:10:26 2019 +0200 # Node ID 74c8ac8124723f06a612ff560403d4bd288ec5f4 # Parent 68dde01bb05c782d484d96e424512b89e0673bec eol: don't fallback to use .hgeol from tip (BC) If no .hgeol were found in the current

[PATCH 7 of 8] eol: tweak test-eol-clone.t with better descriptions and logging

# HG changeset patch # User Mads Kiilerich # Date 1571010144 -7200 # Mon Oct 14 01:42:24 2019 +0200 # Node ID 68dde01bb05c782d484d96e424512b89e0673bec # Parent 950c89a71e9837dc81da80ed34eee9b602a808d9 eol: tweak test-eol-clone.t with better descriptions and logging Expose impact of changes

[PATCH 6 of 8] eol: fix update - don't use and apply removed .hgeol patterns

# HG changeset patch # User Mads Kiilerich # Date 1570925707 -7200 # Sun Oct 13 02:15:07 2019 +0200 # Node ID 950c89a71e9837dc81da80ed34eee9b602a808d9 # Parent 844fa54a1ffbc052fbcd76f103b3db6b02a84690 eol: fix update - don't use and apply removed .hgeol patterns 'hg up -C' to revisions

[PATCH 4 of 8] eol: update isbinary filter to work without compat wrapper

# HG changeset patch # User Mads Kiilerich # Date 1571009598 -7200 # Mon Oct 14 01:33:18 2019 +0200 # Node ID 5670699747c92d725927e25754817d5aa498d728 # Parent 1e663f4a658dbf6669c9bfd53918bf1daa734dc6 eol: update isbinary filter to work without compat wrapper diff --git a/hgext/eol.py

[PATCH 3 of 8] localrepo: fix variable binding in handling of old filters

# HG changeset patch # User Mads Kiilerich # Date 1570925119 -7200 # Sun Oct 13 02:05:19 2019 +0200 # Node ID 1e663f4a658dbf6669c9bfd53918bf1daa734dc6 # Parent 2b91375a812ce3c694efa35a98a109387962 localrepo: fix variable binding in handling of old filters The lambda was referencing

[PATCH 5 of 8] eol: cache needs update, also if it has same timestamp as the source

# HG changeset patch # User Mads Kiilerich # Date 1570925493 -7200 # Sun Oct 13 02:11:33 2019 +0200 # Node ID 844fa54a1ffbc052fbcd76f103b3db6b02a84690 # Parent 5670699747c92d725927e25754817d5aa498d728 eol: cache needs update, also if it has same timestamp as the source Ignoring same

[PATCH 2 of 8] localrepo: debug log of filter name when filtering through a function

# HG changeset patch # User Mads Kiilerich # Date 1570970400 -7200 # Sun Oct 13 14:40:00 2019 +0200 # Node ID 2b91375a812ce3c694efa35a98a109387962 # Parent 57f88532f7005eeb13cb06418ae3a3b156085adf localrepo: debug log of filter name when filtering through a function diff --git

[PATCH 1 of 8] eol: test-eol-update.t coverage around update --clean using filters ... badly

# HG changeset patch # User Mads Kiilerich # Date 1571004565 -7200 # Mon Oct 14 00:09:25 2019 +0200 # Node ID 57f88532f7005eeb13cb06418ae3a3b156085adf # Parent 52781d57313d512efb7150603104bea3ca11d0eb eol: test-eol-update.t coverage around update --clean using filters ... badly This will

Re: [PATCH 1 of 2] patchcopies: give up any optimization based on `introrev`

On 10/13/19 12:08 PM, Yuya Nishihara wrote: On Fri, 11 Oct 2019 20:00:58 +0200, Pierre-Yves David wrote: On 10/11/19 2:02 PM, Yuya Nishihara wrote: On Fri, 11 Oct 2019 01:04:12 +0200, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1570672173 -7200 # Thu

Re: [PATCH 1 of 5] rust-cpython: put leaked reference in PyLeakedRef

On Sat, Oct 12, 2019, 01:06 Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1568552779 -32400 > # Sun Sep 15 22:06:19 2019 +0900 > # Node ID 458c6598a13caee640294d88af4e93783fc36476 > # Parent ce20b870041fc4d6ba6989acbb9373797ce9b3d6 > rust-cpython: put

Re: [PATCH 1 of 7] rust-cpython: add wrapper around decapsule_make_dirstate_tuple()

On Sun, 13 Oct 2019 22:41:37 +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1570953317 -32400 > # Sun Oct 13 16:55:17 2019 +0900 > # Node ID 083f70b7b5899755bb28ce16d6fc45eee46e84e4 > # Parent dbe969ca04b9711aa3b244b2dcea9b9925bab960 > rust-cpython: add

[PATCH 7 of 7] rust-cpython: drop direct dependency on python(27|3)_sys

# HG changeset patch # User Yuya Nishihara # Date 1570970825 -32400 # Sun Oct 13 21:47:05 2019 +0900 # Node ID f04203256726d2172b0aa42311263f56dd12d3ac # Parent 7ac435844d990e027d8b589909ca42d17a89b6b4 rust-cpython: drop direct dependency on python(27|3)_sys We no longer use it. diff

[PATCH 6 of 7] rust-cpython: leverage upstreamed py_capsule_fn!() macro

# HG changeset patch # User Yuya Nishihara # Date 1570954064 -32400 # Sun Oct 13 17:07:44 2019 +0900 # Node ID 7ac435844d990e027d8b589909ca42d17a89b6b4 # Parent 7073183d7ec824b6b3686b41b6c0a98d089a6447 rust-cpython: leverage upstreamed py_capsule_fn!() macro diff --git

[PATCH 5 of 7] rust-cpython: bump cpython crates to 0.3

# HG changeset patch # User Yuya Nishihara # Date 1570953909 -32400 # Sun Oct 13 17:05:09 2019 +0900 # Node ID 7073183d7ec824b6b3686b41b6c0a98d089a6447 # Parent d7823e47559d0b0aec701c9f6cc8f66ae59ecaa1 rust-cpython: bump cpython crates to 0.3 Unblocks py_capsule_fn!(). diff --git

[PATCH 4 of 7] rust-cpython: turn inline comments into non-doc comments

# HG changeset patch # User Yuya Nishihara # Date 1570953746 -32400 # Sun Oct 13 17:02:26 2019 +0900 # Node ID d7823e47559d0b0aec701c9f6cc8f66ae59ecaa1 # Parent 1c18f9652cda28e7d8d0ffc2e7a01d16622bc98f rust-cpython: turn inline comments into non-doc comments diff --git

[PATCH 3 of 7] rust-cpython: fix signature of make_dirstate_tuple()

# HG changeset patch # User Yuya Nishihara # Date 1570953670 -32400 # Sun Oct 13 17:01:10 2019 +0900 # Node ID 1c18f9652cda28e7d8d0ffc2e7a01d16622bc98f # Parent 46a5d47e23a43c12115de6707fe727e52a8a5f74 rust-cpython: fix signature of make_dirstate_tuple() Fortunately, the layout of PyObject

[PATCH 2 of 7] rust-cpython: mark capsule function as unsafe

# HG changeset patch # User Yuya Nishihara # Date 1570953495 -32400 # Sun Oct 13 16:58:15 2019 +0900 # Node ID 46a5d47e23a43c12115de6707fe727e52a8a5f74 # Parent 083f70b7b5899755bb28ce16d6fc45eee46e84e4 rust-cpython: mark capsule function as unsafe diff --git

[PATCH 1 of 7] rust-cpython: add wrapper around decapsule_make_dirstate_tuple()

# HG changeset patch # User Yuya Nishihara # Date 1570953317 -32400 # Sun Oct 13 16:55:17 2019 +0900 # Node ID 083f70b7b5899755bb28ce16d6fc45eee46e84e4 # Parent dbe969ca04b9711aa3b244b2dcea9b9925bab960 rust-cpython: add wrapper around decapsule_make_dirstate_tuple() There are a couple of

Re: [PATCH 7 of 7] rust-cpython: leverage upstreamed py_capsule_fn!() macro

On 10/13/19 2:37 PM, Yuya Nishihara wrote: > On Sun, 13 Oct 2019 14:08:24 +0200, Georges Racinet wrote: >>> +py_capsule_fn!( >>> +from mercurial.cext.parsers import index_get_parents_CAPI >>> +as get_parents_capi >>> +signature ( >>> +index: *mut

Re: [PATCH 7 of 7] rust-cpython: leverage upstreamed py_capsule_fn!() macro

On Sun, 13 Oct 2019 14:08:24 +0200, Georges Racinet wrote: > > +py_capsule_fn!( > > +from mercurial.cext.parsers import index_get_parents_CAPI > > +as get_parents_capi > > +signature ( > > +index: *mut python_sys::PyObject, > > Here you can directly use

Re: [PATCH 7 of 7] rust-cpython: leverage upstreamed py_capsule_fn!() macro

Hi, I don't have time for a formal review right now, but I did skim over the series, and I think it can be simplified and pushed further, removing the whole sys_python dependency (see the inline comment below) Actually I have a series of my own in the works to the same effect, i.e., leveraging

[PATCH] dirs: remove mutable string optimization at all

# HG changeset patch # User Yuya Nishihara # Date 1570964769 -32400 # Sun Oct 13 20:06:09 2019 +0900 # Node ID 87dfcdb8394e377049b5a337585309ae4c652c7d # Parent ce20b870041fc4d6ba6989acbb9373797ce9b3d6 dirs: remove mutable string optimization at all As far as I can see, the optimization

Re: [PATCH 1 of 2] perf: introduce a `--iteration` to `perfdirstate`

On Sat, 12 Oct 2019 04:20:42 +0200, Pierre-Yves David wrote: > # HG changeset patch > # User Pierre-Yves David > # Date 1570522984 14400 > # Tue Oct 08 04:23:04 2019 -0400 > # Node ID 992c09636ae9d0543ea621305a71d6f9f77dc7dc > # Parent c88075eb28e3281a4470fde929fbf5a13bda5f8a > # EXP-Topic

Re: [PATCH 1 of 2] patchcopies: give up any optimization based on `introrev`

On Fri, 11 Oct 2019 20:00:58 +0200, Pierre-Yves David wrote: > On 10/11/19 2:02 PM, Yuya Nishihara wrote: > > On Fri, 11 Oct 2019 01:04:12 +0200, Pierre-Yves David wrote: > >> # HG changeset patch > >> # User Pierre-Yves David > >> # Date 1570672173 -7200 > >> # Thu Oct 10 03:49:33 2019

[PATCH 7 of 7] rust-cpython: leverage upstreamed py_capsule_fn!() macro

# HG changeset patch # User Yuya Nishihara # Date 1570954064 -32400 # Sun Oct 13 17:07:44 2019 +0900 # Node ID 6c8410bd4ce786ceca53986514a1fbda5f097f2d # Parent 2d7671cc1d717f3ed3890e47324e4ed479529466 rust-cpython: leverage upstreamed py_capsule_fn!() macro diff --git

[PATCH 6 of 7] rust-cpython: bump cpython crates to 0.3

# HG changeset patch # User Yuya Nishihara # Date 1570953909 -32400 # Sun Oct 13 17:05:09 2019 +0900 # Node ID 2d7671cc1d717f3ed3890e47324e4ed479529466 # Parent 88cde8b3df606c060c32de2002a2008f030a10c5 rust-cpython: bump cpython crates to 0.3 Unblocks py_capsule_fn!(). diff --git

[PATCH 5 of 7] rust-cpython: turn inline comments into non-doc comments

# HG changeset patch # User Yuya Nishihara # Date 1570953746 -32400 # Sun Oct 13 17:02:26 2019 +0900 # Node ID 88cde8b3df606c060c32de2002a2008f030a10c5 # Parent 8ba14080af7216e711666457c2c068661ae3a97e rust-cpython: turn inline comments into non-doc comments diff --git

[PATCH 4 of 7] rust-cpython: fix signature of make_dirstate_tuple()

# HG changeset patch # User Yuya Nishihara # Date 1570953670 -32400 # Sun Oct 13 17:01:10 2019 +0900 # Node ID 8ba14080af7216e711666457c2c068661ae3a97e # Parent 63a1df3aac72e67667eb7210f364f4b2d892b06f rust-cpython: fix signature of make_dirstate_tuple() Fortunately, the layout of PyObject

[PATCH 3 of 7] rust-cpython: mark capsule function as unsafe

# HG changeset patch # User Yuya Nishihara # Date 1570953495 -32400 # Sun Oct 13 16:58:15 2019 +0900 # Node ID 63a1df3aac72e67667eb7210f364f4b2d892b06f # Parent 00cd8123f876e03a3af2660c6cf4ba1a77b2bee3 rust-cpython: mark capsule function as unsafe diff --git

[PATCH 2 of 7] rust-cpython: add wrapper around decapsule_make_dirstate_tuple()

# HG changeset patch # User Yuya Nishihara # Date 1570953317 -32400 # Sun Oct 13 16:55:17 2019 +0900 # Node ID 00cd8123f876e03a3af2660c6cf4ba1a77b2bee3 # Parent 6ecc771edbad738c634b50846de1943ea7d34d9e rust-cpython: add wrapper around decapsule_make_dirstate_tuple() There are a couple of

[PATCH 1 of 7] rust-cpython: alias python(27|3)_sys globally

# HG changeset patch # User Yuya Nishihara # Date 1570952770 -32400 # Sun Oct 13 16:46:10 2019 +0900 # Node ID 6ecc771edbad738c634b50846de1943ea7d34d9e # Parent dbe969ca04b9711aa3b244b2dcea9b9925bab960 rust-cpython: alias python(27|3)_sys globally diff --git a/rust/hg-cpython/src/cindex.rs

D7081: tests: open file in binary mode in test-upgrade-repo.t

Closed by commit rHG86b26f20146d: tests: open file in binary mode in test-upgrade-repo.t (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7080: hghave: use a native string to invoke the `black` command

Closed by commit rHG138ac8cbce60: hghave: use a native string to invoke the `black` command (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7079: py3: convert cwd to native string when running `fix`

Closed by commit rHG2d1f9880af1b: py3: convert cwd to native string when running `fix` (authored by mharbison72). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7079?vs=17121=17124