Re: [PATCH 1 of 5] rust-cpython: put leaked reference in PyLeakedRef

I think Georges reviewed the other patch series. I'll be taking a closer look at this one as soon as I finish mine. On 10/14/19 7:41 AM, Martin von Zweigbergk via Mercurial-devel wrote: I'll queue this mostly based on Georges' review, thanks. ___ M

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare added a comment. Alphare marked 3 inline comments as done. @martinvonz First of all, thanks a lot for starting the Rust reviews, your feedback is very helpful. For most of your comments, I tried cutting out the parts of the implementation that were not needed yet but did not go f

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17132. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17065&id=17132 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17133. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17132&id=17133 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

Re: [PATCH 1 of 5] rust-cpython: put leaked reference in PyLeakedRef

Le 14 octobre 2019 10:10:34 GMT+02:00, "Raphaël Gomès" a écrit : >I think Georges reviewed the other patch series. I think you're right I'll be taking a >closer >look at this one as soon as I finish mine. > >On 10/14/19 7:41 AM, Martin von Zweigbergk via Mercurial-devel wrote: > >> >> I'll q

Re: [PATCH 1 of 7] rust-cpython: add wrapper around decapsule_make_dirstate_tuple()

On 10/13/19 3:46 PM, Yuya Nishihara wrote: > On Sun, 13 Oct 2019 22:41:37 +0900, Yuya Nishihara wrote: >> # HG changeset patch >> # User Yuya Nishihara >> # Date 1570953317 -32400 >> # Sun Oct 13 16:55:17 2019 +0900 >> # Node ID 083f70b7b5899755bb28ce16d6fc45eee46e84e4 >> # Parent dbe969ca0

Re: [PATCH 1 of 5] rust-cpython: put leaked reference in PyLeakedRef

On Mon, 14 Oct 2019 10:10:34 +0200, Raphaël Gomès wrote: > I think Georges reviewed the other patch series. I'll be taking a closer > look at this one as soon as I finish mine. Perhaps Martin queued the other rust-cpython series which is/was reviewed by Georges. Maybe I shouldn't send two series i

D6993: black: add a pyproject.toml that contains our black settings

durin42 added a comment. Ugh, weird. I think this is an issue around setuptools versions, but I'll try and ask dstufft this week. :( REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6993/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6993 To: d

Re: [PATCH 1 of 5] rust-cpython: put leaked reference in PyLeakedRef

Heh, I have no idea which one I queued. I know you said you forgot --flag V2, so I assumed the two series I saw on patchwork were the same. On Mon, Oct 14, 2019, 07:17 Yuya Nishihara wrote: > On Mon, 14 Oct 2019 10:10:34 +0200, Raphaël Gomès wrote: > > I think Georges reviewed the other patch se

mercurial@43214: 73 new changesets

73 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/beed7ce61681 changeset: 43142:beed7ce61681 user:Pierre-Yves David date:Sun Oct 06 23:36:51 2019 -0400 summary: sidedatacopies: write copies information in sidedata when applicable https://www.mercuri

Re: D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Just quickly scanned. Not reviewed the core logic. > +/// Get name in the case stored in the filesystem > +/// The name should be relative to root, and be normcase-ed for efficiency. > +/// > +/// Note that this function is unnecessary, and should not be > +// called, for case-sensitive filesyste

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

yuja added a comment. Just quickly scanned. Not reviewed the core logic. > +/// Get name in the case stored in the filesystem > +/// The name should be relative to root, and be normcase-ed for efficiency. > +/// > +/// Note that this function is unnecessary, and should not be > +//

D6993: black: add a pyproject.toml that contains our black settings

indygreg added a comment. We're seeing this with the latest version of pip/setuptools: https://ci.hg.gregoryszorc.com/job-info/hg-committed-649a9601b9e2642fa0ef12e6ad51ac85ab6e860c-debian10-cpython-2.7-0#failed-tests. But it only happens when we're using the self-installed Python/pip/set

Re: [PATCH RFC] changegroup: leave out all parent file revisions when creating bundles

On 10/11/19 7:57 PM, Mads Kiilerich wrote: # HG changeset patch # User Mads Kiilerich # Date 1570804632 -7200 # Fri Oct 11 16:37:12 2019 +0200 # Node ID 72d12ee773795edc163f73b9160e5d29022878dd # Parent 52781d57313d512efb7150603104bea3ca11d0eb changegroup: leave out all parent file revisio

Mercurial 5.2 release as stable release for Python 3.

Hey everyone, I hope you are doing well. We released 5.0 as beta release for Python 3 support and much has improved since than. Evolve extension recently started supporting Python 3. There are still few tests failing which are minor. We are planning to mark the upcoming release i.e. 5.2 as stabl

D7086: fix: remove a never-true check for unset pattern in Fixer.affects()

hooper added a comment. Looks good. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7086/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7086 To: martinvonz, #hg-reviewers Cc: hooper, mercurial-devel _

D7069: copies: simplify the handling of merges

This revision is now accepted and ready to land. martinvonz added inline comments. martinvonz accepted this revision. INLINE COMMENTS > copies.py:285 > roots = set(children) - set(missingrevs) > -# 'work' contains 3-tuples of a (revision number, parent number, copies). > -# The paren

[Bug 6204] New: hgweb fails when reading config file for Python 3

https://bz.mercurial-scm.org/show_bug.cgi?id=6204 Bug ID: 6204 Summary: hgweb fails when reading config file for Python 3 Product: Mercurial Version: default branch Hardware: All OS: Linux Status: UNCONFIRMED

D7087: black: rename pyproject.toml to black.toml

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Black won't read this automatically (you'll have to specify --config), but having a pyproject.toml *at all* puts pip in PEP 517/518 mode which breaks us for obsc

D7089: black: use multiline exclude definition

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Our excludes list is pretty complicated, so let's give ourselves some readability. Black treats multiline exclude definitions as verbse regular express

D7088: black: move remaining config knobs into toml file

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7088 AFFECTED FILES black.toml contrib/examples/fix.hgrc CHANGE DETAILS diff --git a/contrib/exampl

D7090: black: also ignore grey.py

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7090 AFFECTED FILES black.toml contrib/examples/fix.hgrc CHANGE DETAILS diff --git a/cont

D7077: contrib: update to latest Windows package versions

Closed by commit rHGc157356c03f7: contrib: update to latest Windows package versions (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7077?vs=17118&id=17138 CH

D7078: automation: capture additional exception when formatting

Closed by commit rHG6a350194de7f: automation: capture additional exception when formatting (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7078?vs=17119&id=171

D7082: fix: fix registration of config item defaults

Closed by commit rHG5cb3e6f4e069: fix: fix registration of config item defaults (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7082?vs=17127&id=17140 CHANG

D7083: fix: don't pass in default value when looking up config

Closed by commit rHGf4c1fd6addd5: fix: don't pass in default value when looking up config (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7083?vs=17128&id=17

D7084: fix: make Fixer initialization more explicit for clarity

Closed by commit rHG2e3aa8ed5bdf: fix: make Fixer initialization more explicit for clarity (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7084?vs=17129&id=1

D7086: fix: remove a never-true check for unset pattern in Fixer.affects()

Closed by commit rHG96c4c6f37d52: fix: remove a never-true check for unset pattern in Fixer.affects() (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7086?vs

D7085: fix: warn when a fixer doesn't have a configured command

Closed by commit rHG99f2d939f03c: fix: warn when a fixer doesn't have a configured command (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7085?vs=17130&id=1

Re: Mercurial 5.2 release as stable release for Python 3.

I support marking the code base as stable with Python 3 in the upcoming few weeks - at least for non-Windows. If we're serious about this, we all need to be running Mercurial with Python 3 locally and fixing bugs. I tried installing a Python 3 Mercurial a few days ago and I encountered enough trac

D7091: tests: show graph log before and after widening in more cases

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm about to make some changes to which revisions get sent during widening. Some more tests will make it clearer what changes.

D7092: widening: duplicate generateellipsesbundle2() for widening

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The widening and the non-widening code are quite different. It will be clearer to have them as sepearate functions. To start w

D7093: narrow: drop server support for widening using the getbundle command (BC)

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The client still supports widening using the getbundle, which we (Google) still depend on a for a little while more (we've sta

D7094: widening: remove always-true condition in widening code

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The function is now specifically about widening, so we don't need to check if we're widening. REPOSITORY rHG Mercurial REV

D7095: widening: remove pointless code for second changegroup

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The caller passes in common==heads, so we will never find any nodes to visit in this code and there will therefore never be a

D7096: widening: remove unused "heads" argument

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7096 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/n

D7098: widening: trust user to give full "known" set

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The new narrow_widen wire protocol command is supposed to return data for exactly the revisions that the client requested (in

D7097: widening: remove "depth" argument since it's always None

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7097 AFFECTED FILES hgext/narrow/narrowbundle2.py hgext/narrow/n

D7099: widening: pass in matchers instead of patterns

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This matches how it's done for the non-ellipsis case. The oldmatch is not used yet, but it should be used eventually when wide

D7070: copies: extract data extraction into a `revinfo` function

martinvonz added a comment. The extracted function slows down `hg perfpathcopies FIREFOX_BETA_59_END FIREFOX_BETA_60_BASE` (not merge-heavy) from 3.55s to 3.87s, but since you also changed `ctx.p[12]copies()` to `ctx._copies` it ended up being a net speed improvement (3.24s including for the

Re: Mercurial 5.2 release as stable release for Python 3.

On 10/14/19 7:08 PM, Gregory Szorc wrote: I support marking the code base as stable with Python 3 in the upcoming few weeks - at least for non-Windows. If we're serious about this, we all need to be running Mercurial with Python 3 locally and fixing bugs. I tried installing a Python 3 Mercur

Re: Mercurial 5.2 release as stable release for Python 3.

On Mon, Oct 14, 2019 at 11:21 AM Raphaël Gomès wrote: > > On 10/14/19 7:08 PM, Gregory Szorc wrote: > > I support marking the code base as stable with Python 3 in the upcoming > few weeks - at least for non-Windows. > > If we're serious about this, we all need to be running Mercurial with > Pytho

D6843: ui: option to preserve the progress bar

joerg.sonnenberger updated this revision to Diff 17154. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6843?vs=16520&id=17154 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6843/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6843 AFF

D7100: tests: add test showing that fixer patterns are currently relative to $PWD

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7100 AFFECTED FILES tests/test-fix.t CHANGE DETAILS diff --git a/tests/test-fix.t b/tests/test-fix

D7101: fix: match patterns relative to root

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I was surprised fixer patterns (used to determine which fixers to run) are applies to the parent directory, not the repo root directory. Danny Hooper (the aut

D7065: examples: allow the fix configuration to work from any directory

martinvonz added a comment. martinvonz added a subscriber: hooper. In D7065#103835 , @mharbison72 wrote: > In D7065#103834 , @martinvonz wrote: > >> It's unfortunate that this is necessary. I'll

Re: Mercurial 5.2 release as stable release for Python 3.

On Mon, 14 Oct 2019 10:08:09 -0700, Gregory Szorc wrote: > Python 3 on Windows has a ton of test failures. ~120 I believe. I suspect a > lot of them are the same underlying issues. Note that many encoding issues wouldn't be covered by our test suite. I suspect there are at least two encoding-relat

mercurial@43216: 2 new changesets

2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/c157356c03f7 changeset: 43215:c157356c03f7 user:Gregory Szorc date:Sat Oct 12 11:36:26 2019 -0700 summary: contrib: update to latest Windows package versions https://www.mercurial-scm.org/repo/hg/rev/6

D7101: fix: match patterns relative to root

This revision now requires changes to proceed. mharbison72 added a comment. mharbison72 requested changes to this revision. The part of the help text that documents `:pattern` and points to `hg help patterns` should probably explicitly state that they are all relative to repo root, regardless

D7065: examples: allow the fix configuration to work from any directory

mharbison72 added a comment. mharbison72 abandoned this revision. In D7065#104119 , @martinvonz wrote: > I talked to @hooper about this and they agreed that using repo-relative paths is almost always what the user wants. I've sent D7101

D7087: black: rename pyproject.toml to black.toml

Closed by commit rHG8f89899a5446: black: rename pyproject.toml to black.toml (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7087?vs=17134&id=17160 CHANGES SIN

D7088: black: move remaining config knobs into toml file

Closed by commit rHG15c05732d177: black: move remaining config knobs into toml file (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7088?vs=17135&id=17161 CHAN

D7089: black: use multiline exclude definition

Closed by commit rHG2a201b366d5b: black: use multiline exclude definition (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7089?vs=17136&id=17162 CHANGES SINCE

D7090: black: also ignore grey.py

Closed by commit rHG8343070ed758: black: also ignore grey.py (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7090?vs=17137&id=17163 CHANGES SINCE LAST ACTION

D7101: fix: match patterns relative to root

martinvonz updated this revision to Diff 17164. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7101?vs=17156&id=17164 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7101/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7101 AFFECTED FI

D7101: fix: match patterns relative to root

martinvonz added a comment. In D7101#104125 , @mharbison72 wrote: > The part of the help text that documents `:pattern` and points to `hg help patterns` should probably explicitly state that they are all relative to repo root, regardless of w

D7101: fix: match patterns relative to root

mharbison72 added a comment. mharbison72 accepted this revision. In D7101#104151 , @martinvonz wrote: >> I can’t tell from my phone, but should the matcher in `getworkqueue` and the status call in `pathstofix` also be adjusted? (Not sure if t

D7071: copies: use unchecked parentrevs function to access parent

martinvonz added inline comments. INLINE COMMENTS > copies.py:293 > > repo = a.repo() > children = {} Why not just add `.unfiltered()` here? That should be even faster (3.16s -> 2.90s compared to this patch for the case I tested). REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTI

D7075: copies: add an explicit test using multiple roots

martinvonz added inline comments. INLINE COMMENTS > test-copies-unrelated.t:398 > + > +Copies involving multiple roots. > + nit: maybe "involving *merge* of multiple roots" to clarify how it's different from the case above > test-copies-unrelated.t:403-406 > + $ echo a >> a > + $ hg ci -Aqm