D7114: automation: install Python 3.8.0

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3.8 has been released. Let's install it instead of the RC / development version. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.merc

D7113: automation: schedule an EC2Launch run on next boot

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Without this, launching EC2 instances constructed from the AMI won't go through the normal EC2 instance launch machinery. This missing machinery does important

D7106: fuzz: restrict dirs fuzzer to only 40k of input

durin42 added a comment. The concern is basically that the fuzzer will figure out something dumb, like `'a/' * 4 + 'b'` which consumes around a gig of memory. I don't think this is a serious OOM vector, since any such manifest would also be inordinately large? Maybe I'm being an opt

D7105: dirs: reject consecutive slashes in paths

Closed by commit rHG1f04c51d52ea: dirs: reject consecutive slashes in paths (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7105?vs=17173&id=17192 CHANGES SINC

D7104: dirs: give formatting oversight to clang-format

Closed by commit rHGea62d7b06c12: dirs: give formatting oversight to clang-format (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7104?vs=17172&id=17191 CHANGE

D7103: dirs: tag a struct as not being formattable

Closed by commit rHGbe178b5d91c8: dirs: tag a struct as not being formattable (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7103?vs=17171&id=17190 CHANGES SI

D7112: tests: stabilize test-eol-update on Windows

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These appeared in the recent eol fix series. I'm not sure about the identity mismatch warning- it seems like a general timing issue, because it happened on

D7111: tests: opt into python3 when testing virtualenv installation

mharbison72 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise it complains that Mercurial requires '~=2.7'. Since the existing linux py3 test doesn't flag this, I'm assuming that virtualenv simply isn

D7106: fuzz: restrict dirs fuzzer to only 40k of input

indygreg added a comment. If we blow stupid amounts of memory in the `dirs` internals, perhaps we should be enforcing a length limit in the implementation instead of burying our head in the sand by not triggering it via fuzzing. If we need to teach the fuzzer to only send small input so

D7105: dirs: reject consecutive slashes in paths

This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. This seems strictly correct, since the `dirs` type should be internal and should be well-formed. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D

D7026: treemanifest: move out of experimental

durin42 added a comment. That sounds fine REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7026/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7026 To: pulkit, durin42, #hg-reviewers Cc: marmoute, mercurial-devel

D7068: sidedatacopies: only store an entry if it has values

Closed by commit rHG30570a056fa8: sidedatacopies: only store an entry if it has values (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial C

D7067: sidedatacopies: only read from copies when in this mode

Closed by commit rHGe51f5d06a99c: sidedatacopies: only read from copies when in this mode (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17184. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17181&id=17184 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7059: rust-dirstate-status: rust-cpython bindings for `dirstate.status`

Alphare updated this revision to Diff 17185. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7059?vs=17183&id=17185 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7059/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7059 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare added inline comments. INLINE COMMENTS > martinvonz wrote in status.rs:24 > Do we need to borrow it mutably? We don't anymore, thanks. I'll be reworking the overly complicated match expression within the next hour. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.me

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17181. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17176&id=17181 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7059: rust-dirstate-status: rust-cpython bindings for `dirstate.status`

Alphare updated this revision to Diff 17183. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7059?vs=17177&id=17183 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7059/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7059 AFFECTED FILES

D7110: rust-status: add missing lifetime parameter in ref_sharing

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7110 AFFECTED FILES rust/hg-cpython/src/ref_sharing.rs CHANGE DETAILS diff --git a/

Re: Python 3 Transition Plan / Calendar Versioning

Le mer. 9 oct. 2019 à 03:30, Gregory Szorc a écrit : > > Our new versioning scheme will be .[M]M.N. e.g. 2020.5.0 or 2020.10.1. > This scheme consists of the 4 digit year, a 1-2 digit month, and a > monotonically increasing point release, starting at 0. This scheme is > compatible with our

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

martinvonz added inline comments. INLINE COMMENTS > status.rs:24 > +files: Vec, > +dmap: &mut DirstateMap, > +root_dir: P, Do we need to borrow it mutably? > status.rs:49 > +(normalized, Ok(stat)) => { > +if stat.is_file() { > +results

D7108: cleanup: hgdemandimport.tracing accepts strings, not bytes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This does mean that the resulting traces will have some b'' goo in them on Python 3, but I think that's a worthwile price to pay since it doesn't break any tests

D6550: tracing: add a couple of trace points on obsolete and repoview

durin42 updated this revision to Diff 17180. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6550?vs=15609&id=17180 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6550/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6550 AFFECTED FILES

D7109: dirstate: add some traces on listdir calls

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm starting to spend some time trying to make `hg status` do less work, and knowing what's happening in here and what's expensive is an important start. REPOSITO

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

kevincox added a comment. kevincox accepted this revision. Thanks, looks good. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 To: Alphare, #hg-reviewers, kevincox Cc: yuja, martinvonz, d

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17176. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17167&id=17176 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7059: rust-dirstate-status: rust-cpython bindings for `dirstate.status`

Alphare updated this revision to Diff 17177. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7059?vs=17166&id=17177 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7059/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7059 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare added inline comments. Alphare marked an inline comment as done. INLINE COMMENTS > kevincox wrote in status.rs:23 > This doesn't appear to be consumed by the function so you should take a > `&[HgPathBuf]`. Or since I don't think you use the path either probably a > `&[HgPath]`. Done wi

D7107: rust-cross-platform: remove `unimplemented!` to get compile-time errors instead

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We should get a compile-time error that there is missing functionality for the targeted platform instead of the program breaking at runtime. REP

Re: Mercurial 5.2 release as stable release for Python 3.

On Mon, Oct 14, 2019 at 8:08 PM Gregory Szorc wrote: > > I support marking the code base as stable with Python 3 in the upcoming few > weeks - at least for non-Windows. > > If we're serious about this, we all need to be running Mercurial with Python > 3 locally and fixing bugs. I tried installin

D7106: fuzz: restrict dirs fuzzer to only 40k of input

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Experimentally one very long path of this size shouldn't blow the RAM budget in the fuzzer environment, and it's not really exciting to discover that building th

D7105: dirs: reject consecutive slashes in paths

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We shouldn't ever see those, and the fuzzer go really excited that if it gives us a 65k string with 55k slashes in it we use a lot of RAM. REPOSITORY rHG Mercur

D7104: dirs: give formatting oversight to clang-format

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7104 AFFECTED FILES contrib/clang-format-ignorelist mercurial/cext/dirs.c CHANGE DETAILS diff --git

D7103: dirs: tag a struct as not being formattable

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7103 AFFECTED FILES mercurial/cext/dirs.c CHANGE DETAILS diff --git a/mercurial/cext/dirs.c b/mercuri

D7102: tests: fix formatting test after move of black config

durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7102 AFFECTED FILES tests/test-check-format.t CHANGE DETAILS diff --git a/tests/test-check-

D6956: unfinishedstate: suggested `hg update .` (including `.`) to complete update

martinvonz added inline comments. INLINE COMMENTS > spectral wrote in state.py:204 > I wonder if it would be possible to portably quote the `.` so that users > don't think it's just sitting on the end there. Something like `hg update > '.'` If not, then we should surround the entire thing in q

Re: [PATCH V2] dirs: remove mutable string optimization at all

queued this, many thanks > On Oct 13, 2019, at 23:54, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1570964769 -32400 > # Sun Oct 13 20:06:09 2019 +0900 > # Node ID dd9f93e8af83be1bfd7082026d28f774917f0593 > # Parent feaea7fe888383bcb1d28e69df325e41ef68ec

Re: [PATCH] py3: prevent comparison with None in curses histedit (issue6196)

On Tue, 15 Oct 2019 12:14:59 +0200, Denis Laxalde wrote: > # HG changeset patch > # User Denis Laxalde > # Date 1571134484 -7200 > # Tue Oct 15 12:14:44 2019 +0200 > # Node ID ecfb39f6d22d9fb58b5b6981e346afc478e91ef5 > # Parent 6a350194de7f29d4f9dda183ab6df1d210bd58ff > py3: prevent comparis

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

This revision now requires changes to proceed. kevincox added inline comments. kevincox requested changes to this revision. INLINE COMMENTS > Alphare wrote in status.rs:83 > Collecting into a `Result` prevents us from doing a `filter_map` during > `collect`. Implementing a `ParallelIterator` ada

D7101: fix: match patterns relative to root

Closed by commit rHGf02d3c0eed18: fix: match patterns relative to root (authored by martinvonz). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7101?vs=17164&id=17169#toc REPOSITORY rHG Mercurial CHANGES SINC

D7100: tests: add test showing that fixer patterns are currently relative to $PWD

Closed by commit rHG5272bd7e7517: tests: add test showing that fixer patterns are currently relative to $PWD (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D7070: copies: extract data extraction into a `revinfo` function

martinvonz added a comment. In D7070#104170 , @martinvonz wrote: > In D7070#104159 , @marmoute wrote: > >> In D7070#104100 , @martinvonz wrote: >>

D7101: fix: match patterns relative to root

pulkit added a comment. Amended the following in flight: diff --git a/tests/test-fix.t b/tests/test-fix.t --- a/tests/test-fix.t +++ b/tests/test-fix.t @@ -157,8 +157,10 @@ Help text for fix. :skipclean suboption to false. The :pattern suboption determin

D7070: copies: extract data extraction into a `revinfo` function

martinvonz added a comment. In D7070#104159 , @marmoute wrote: > In D7070#104100 , @martinvonz wrote: > >> The extracted function slows down `hg perfpathcopies FIREFOX_BETA_59_END FIREFOX_BETA_

D7084: fix: make Fixer initialization more explicit for clarity

martinvonz added a comment. In D7084#104166 , @pulkit wrote: > Hm, IIUC this was edited in flight, not sure why. I noticed that test-check-format.t was failing last night so I fixed it up in flight. It wanted to put the procutil import on

D7084: fix: make Fixer initialization more explicit for clarity

pulkit added a comment. Hm, IIUC this was edited in flight, not sure why. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7084/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7084 To: martinvonz, #hg-reviewers, pulkit Cc: mercurial-devel ___

[PATCH] py3: prevent comparison with None in curses histedit (issue6196)

# HG changeset patch # User Denis Laxalde # Date 1571134484 -7200 # Tue Oct 15 12:14:44 2019 +0200 # Node ID ecfb39f6d22d9fb58b5b6981e346afc478e91ef5 # Parent 6a350194de7f29d4f9dda183ab6df1d210bd58ff py3: prevent comparison with None in curses histedit (issue6196) diff --git a/hgext/histedi

[PATCH evolve-ext] py3: fix setup.py --version

# HG changeset patch # User Denis Laxalde # Date 1570805473 -7200 # Fri Oct 11 16:51:13 2019 +0200 # Branch stable # Node ID cdb5b5e5a88e55eddf78985a56e8da0e905e75d4 # Parent 597a90b8910cb8fe67307e538c72440e367d9c25 py3: fix setup.py --version Before: $ python3 setup.py --version b

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17167. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17165&id=17167 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare updated this revision to Diff 17165. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7058?vs=17133&id=17165 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7058/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7058 AFFECTED FILES

D7059: rust-dirstate-status: rust-cpython bindings for `dirstate.status`

Alphare updated this revision to Diff 17166. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7059?vs=17066&id=17166 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7059/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7059 AFFECTED FILES

D7058: rust-dirstate-status: add first Rust implementation of `dirstate.status`

Alphare added a comment. In D7058#103954 , @yuja wrote: > Just quickly scanned. Not reviewed the core logic. > >> +/// Get name in the case stored in the filesystem >> +/// The name should be relative to root, and be normcase-ed for effic

D7070: copies: extract data extraction into a `revinfo` function

marmoute added a comment. In D7070#104100 , @martinvonz wrote: > The extracted function slows down `hg perfpathcopies FIREFOX_BETA_59_END FIREFOX_BETA_60_BASE` (not merge-heavy) from 3.55s to 3.87s, but since you also changed `ctx.p[12]copies